zendesk_apps_support 4.44.0.alpha.1 → 4.44.0.alpha.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b611098add00d4e6f1c03e6604521db85f49bd6beea30a43695a286c0d474122
-  data.tar.gz: 40e1ade02e50ac1980eeda60def6501368499e48f46c6180f5e5e7f0053564e2
+  metadata.gz: fe37253e337a257e36a42c6006453c38496c17ef5841602349414a56cb7a1033
+  data.tar.gz: 79810be6dda1ddd34c9d5f1071f9daf27d19f827291f564fc36fc340f7d86f26
 SHA512:
-  metadata.gz: 7052e5b47f7b72d52073f25e39291ef32b0373d850b4912d1f82b05a7463188e328452823471bde20ffa537d1bb47ffb53a5ad50713343114423352d3a0861d8
-  data.tar.gz: 8010184c5735b90149c78a3f75ba4d29a08e90f5d4ed0eebda6f94f16763ceeb08328671ef273355492f53a9b931802a253b0be0879fa4969f00c6beddc36ec6
+  metadata.gz: 9da2e41badbb91b7f25eb7967bf1ef34148494a1f28f36992ea7c5fd793586490db4c3d967d7f2c5d758764150c5ed5eced1e9f589838133fa58e39aca9c0d66
+  data.tar.gz: bbc500a4a44f9fcb4a95245719d24de6bfa25227e33c12b6fbae5dac072bc2d0217cfe55d7ceb027bd006266217bb76690dd0f19d5feb4b2424139137d5d57fe

data/config/locales/en.yml

@@ -49,6 +49,89 @@ en:
             excessive_custom_objects_requirements: The requirements.json file contains
               too many custom objects requirements. The current limit is %{max} requirements.
               This app has %{count} requirements.
+            excessive_custom_objects_v2_requirements: The requirements.json file contains
+              too many custom objects v2 requirements. The current limit is %{max}
+              custom objects per account. This app has %{count} custom objects per
+              account.
+            excessive_custom_objects_v2_fields: The requirements.json file contains
+              too many custom object fields. The current limit is %{max} fields per
+              custom object. This app has %{count} fields for object %{object_key}.
+            excessive_custom_objects_v2_triggers: The requirements.json file contains
+              too many custom object triggers. The current limit is %{max} triggers
+              per custom object. This app has %{count} triggers for object %{object_key}.
+            excessive_custom_objects_v2_trigger_conditions: The requirements.json
+              file contains too many custom object trigger conditions. The current
+              limit is %{max} conditions per trigger. This app has %{count} conditions
+              for trigger %{trigger_title}.
+            excessive_custom_objects_v2_trigger_actions: The requirements.json file
+              contains too many custom object trigger actions. The current limit is
+              %{max} actions per trigger. This app has %{count} actions for trigger
+              %{trigger_title}.
+            excessive_cov2_dropdown_fields_per_object: The requirements.json file
+              contains too many custom object fields of type dropdown. The current
+              limit is %{max} fields per object. This app has %{count} fields of type
+              dropdown for object %{object_key}.
+            excessive_cov2_multiselect_fields_per_object: The requirements.json file
+              contains too many custom object fields of type multiselect. The current
+              limit is %{max} fields per object. This app has %{count} fields of type
+              multiselect for object %{object_key}.
+            excessive_cov2_field_options: The requirements.json file contains too
+              many options for custom object field %{field_key}. The current limit
+              is %{max} options per field. This app has %{count} options for field
+              %{field_key} in object %{object_key}.
+            excessive_cov2_relationship_filter_conditions: The requirements.json file
+              contains too many conditions in relationship filter for custom object
+              field %{field_key}. The current limit is %{max} conditions per field.
+              This app has %{count} conditions for field %{field_key} in object %{object_key}.
+            missing_cov2_object_schema_key: 'The requirements.json file is missing
+              custom object schema key for object %{object_key}. The following key
+              is required: %{missing_key}.'
+            missing_cov2_field_schema_key: 'The requirements.json file is missing
+              custom object field schema key for field %{field_key} in object %{object_key}.
+              The following key is required: %{missing_key}.'
+            missing_cov2_trigger_schema_key: 'The requirements.json file is missing
+              custom object trigger schema key for trigger %{trigger_title} in object
+              %{object_key}. The following key is required: %{missing_key}.'
+            empty_cov2_trigger_conditions: The requirements.json file contains an
+              empty conditions array for custom object trigger %{trigger_title} in
+              object %{object_key}.
+            invalid_cov2_requirements_structure: The requirements.json file contains
+              an invalid custom_objects_v2 structure. \"custom_objects_v2\" requirements
+              must be an object.
+            excessive_cov2_payload_size: The requirements.json file contains a custom
+              objects v2 payload that is too large. The maximum allowed size is 1
+              MB.
+            invalid_cov2_trigger_conditions_structure: The requirements.json file
+              contains an invalid custom object trigger conditions structure. Conditions
+              must be a hash with "all" and "any" arrays for trigger %{trigger_title}.
+            invalid_cov2_trigger_actions_structure: The requirements.json file contains
+              an invalid custom object trigger actions structure. \"actions\" must
+              be an array for trigger %{trigger_title}.
+            empty_cov2_trigger_actions: The requirements.json file contains empty
+              custom object trigger actions. At least one action must be specified
+              for trigger %{trigger_title}.
+            excessive_cov2_selection_fields_per_object: The requirements.json file
+              contains too many custom object fields of type %{field_type}. The current
+              limit is %{max} fields per object. This app has %{count} fields of type
+              %{field_type} for object %{object_key}.
+            invalid_objects_structure_in_cov2_requirements: The requirements.json
+              file contains an invalid objects structure. \"objects\" must be an array.
+            invalid_object_fields_structure_in_cov2_requirements: The requirements.json
+              file contains an invalid object_fields structure. \"object_fields\"
+              must be an array.
+            invalid_object_triggers_structure_in_cov2_requirements: The requirements.json
+              file contains an invalid object_triggers structure. \"object_triggers\"
+              must be an array.
+            empty_cov2_requirements: The requirements.json file contains empty custom
+              objects v2 requirements. You must define valid requirements.
+            invalid_cov2_object_reference_in_fields: The requirements.json file contains
+              an invalid object reference in object_fields. Field \"%{item_identifier}\"
+              references object \"%{object_key}\" which does not exist in the objects
+              array.
+            invalid_cov2_object_reference_in_triggers: The requirements.json file
+              contains an invalid object reference in object_triggers. Trigger \"%{item_identifier}\"
+              references object \"%{object_key}\" which does not exist in the objects
+              array.
             missing_required_fields: 'Missing required fields in requirements.json:
               "%{field}" is required in "%{identifier}"'
             duplicate_requirements:

data/lib/zendesk_apps_support/package.rb

@@ -31,7 +31,8 @@ module ZendeskAppsSupport
       @warnings = []
     end
 
-    def validate(marketplace: true, skip_marketplace_translations: false, error_on_password_parameter: false)
+    def validate(marketplace: true, skip_marketplace_translations: false, error_on_password_parameter: false,
+                 validate_custom_objects_v2: false)
       errors = []
       errors << Validations::Manifest.call(self, error_on_password_parameter: error_on_password_parameter)
 
@@ -39,7 +40,7 @@ module ZendeskAppsSupport
         errors << Validations::Marketplace.call(self) if marketplace
         errors << Validations::Source.call(self)
         errors << Validations::Translations.call(self, skip_marketplace_translations: skip_marketplace_translations)
-        errors << Validations::Requirements.call(self)
+        errors << Validations::Requirements.call(self, validate_custom_objects_v2:)
 
         # only adds warnings
         Validations::SecureSettings.call(self)
@@ -61,9 +62,14 @@ module ZendeskAppsSupport
       errors.flatten.compact
     end
 
-    def validate!(marketplace: true, skip_marketplace_translations: false, error_on_password_parameter: false)
-      errors = validate(marketplace: marketplace, skip_marketplace_translations: skip_marketplace_translations, error_on_password_parameter: error_on_password_parameter)
+    def validate!(marketplace: true, skip_marketplace_translations: false, error_on_password_parameter: false,
+                  validate_custom_objects_v2: false)
+      errors = validate(marketplace: marketplace,
+                        skip_marketplace_translations: skip_marketplace_translations,
+                        error_on_password_parameter: error_on_password_parameter,
+                        validate_custom_objects_v2:)
       raise errors.first if errors.any?
+
       true
     end
 

data/lib/zendesk_apps_support/validations/custom_objects_v2/constants.rb

@@ -47,6 +47,11 @@ module ZendeskAppsSupport
         UNDEFINED_VALUE = '(undefined)'
         CONDITION_KEYS = [ALL, ANY].freeze
         MAX_PAYLOAD_SIZE_BYTES = 1_048_576 # 1 MB in bytes
+
+        REFERENCE_VALIDATION_CONFIG = {
+          SCHEMA_KEYS[:object_fields] => { identifier: KEY, error: :invalid_cov2_object_reference_in_fields },
+          SCHEMA_KEYS[:object_triggers] => { identifier: TITLE, error: :invalid_cov2_object_reference_in_triggers }
+        }.freeze
       end
     end
   end

data/lib/zendesk_apps_support/validations/custom_objects_v2/custom_objects_v2.rb

@@ -10,18 +10,23 @@ module ZendeskAppsSupport
     module CustomObjectsV2
       class << self
         include Constants
+        include ValidationHelpers
 
         def call(requirements)
-          errors = validate_overall_requirements_structure(requirements)
-          return errors if errors.any?
+          structural_errors = validate_overall_requirements_structure(requirements)
+          return structural_errors if structural_errors.any?
 
           payload_size_errors = validate_payload_size(requirements)
           return payload_size_errors if payload_size_errors.any?
 
-          [
+          limits_and_schema_errors = [
             validate_limits(requirements),
             validate_schema(requirements)
           ].flatten
+
+          return limits_and_schema_errors if limits_and_schema_errors.any?
+
+          validate_object_references(requirements)
         end
 
         private
@@ -67,6 +72,27 @@ module ZendeskAppsSupport
           SchemaValidator.validate(requirements)
         end
 
+        def validate_object_references(requirements)
+          valid_object_keys = extract_valid_object_keys(requirements[SCHEMA_KEYS[:objects]])
+
+          REFERENCE_VALIDATION_CONFIG.flat_map do |collection_type, config|
+            collection = requirements[collection_type]
+            validate_collection_references(collection, valid_object_keys, config[:error], config[:identifier])
+          end
+        end
+
+        def validate_collection_references(collection, valid_object_keys, error, identifier)
+          valid_collection = extract_hash_entries(collection)
+          valid_collection.filter_map do |item|
+            object_key = item[OBJECT_KEY]
+            next if valid_object_keys.include?(object_key)
+
+            ValidationError.new(error,
+                                item_identifier: safe_value(item[identifier]),
+                                object_key: object_key)
+          end
+        end
+
         def validate_collection_is_array(collection, error_type)
           return [] if collection.nil? || collection.is_a?(Array)
 
@@ -78,6 +104,14 @@ module ZendeskAppsSupport
             collection.is_a?(Array) && collection.empty?
           end
         end
+
+        def extract_valid_object_keys(objects)
+          valid_objects = extract_hash_entries(objects)
+          valid_objects.filter_map do |obj|
+            key = obj[KEY]
+            key if key.is_a?(String) && !key.strip.empty?
+          end.uniq
+        end
       end
     end
   end

data/lib/zendesk_apps_support/validations/custom_objects_v2/schema_validator.rb

@@ -60,7 +60,7 @@ module ZendeskAppsSupport
           end
 
           def validate_trigger_schema(trigger)
-            required_keys = %w[object_key title actions conditions]
+            required_keys = %w[key object_key title actions conditions]
             missing_keys = required_keys - trigger.keys
             trigger_title = safe_value(trigger[TITLE])
             object_key = safe_value(trigger[OBJECT_KEY])
@@ -103,10 +103,6 @@ module ZendeskAppsSupport
             [ValidationError.new(:empty_cov2_trigger_actions, **error_data)]
           end
 
-          def safe_value(value)
-            value || UNDEFINED_VALUE
-          end
-
           def valid_conditions_structure?(conditions)
             return false unless conditions.is_a?(Hash) && conditions.any?
             return false if (conditions.keys - CONDITION_KEYS).any?

data/lib/zendesk_apps_support/validations/custom_objects_v2/validation_helpers.rb

@@ -4,6 +4,8 @@ module ZendeskAppsSupport
   module Validations
     module CustomObjectsV2
       module ValidationHelpers
+        include Constants
+
         private
 
         def extract_hash_entries(collection)
@@ -17,6 +19,10 @@ module ZendeskAppsSupport
 
           Constants::CONDITION_KEYS.sum { |key| conditions[key]&.size || 0 }
         end
+
+        def safe_value(value)
+          value || UNDEFINED_VALUE
+        end
       end
     end
   end

data/lib/zendesk_apps_support/validations/requirements.rb

@@ -7,7 +7,7 @@ module ZendeskAppsSupport
       MAX_CUSTOM_OBJECTS_REQUIREMENTS = 50
 
       class << self
-        def call(package)
+        def call(package, validate_custom_objects_v2: false)
           if package.manifest.requirements_only? && !package.has_requirements?
             return [ValidationError.new(:missing_requirements)]
           elsif !supports_requirements(package) && package.has_requirements?
@@ -31,7 +31,7 @@ module ZendeskAppsSupport
             errors << invalid_custom_objects(requirements)
             errors << invalid_webhooks(requirements)
             errors << invalid_target_types(requirements)
-            errors << validate_custom_objects_v2_requirements(requirements)
+            errors << validate_custom_objects_v2_requirements(requirements, validate_custom_objects_v2:)
             errors << missing_required_fields(requirements)
             errors.flatten!
             errors.compact!
@@ -80,8 +80,8 @@ module ZendeskAppsSupport
           end
         end
 
-        def validate_custom_objects_v2_requirements(requirements)
-          return unless requirements.key?(AppRequirement::CUSTOM_OBJECTS_V2_KEY)
+        def validate_custom_objects_v2_requirements(requirements, validate_custom_objects_v2: false)
+          return unless validate_custom_objects_v2 && requirements.key?(AppRequirement::CUSTOM_OBJECTS_V2_KEY)
 
           cov2_requirements = requirements[AppRequirement::CUSTOM_OBJECTS_V2_KEY]
           CustomObjectsV2.call(cov2_requirements)

data/lib/zendesk_apps_support/version.rb

@@ -1,3 +1,3 @@
 module ZendeskAppsSupport
-  VERSION = "4.44.0.alpha.1"
+  VERSION = '4.44.0.alpha.3'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: zendesk_apps_support
 version: !ruby/object:Gem::Version
-  version: 4.44.0.alpha.1
+  version: 4.44.0.alpha.3
 platform: ruby
 authors:
 - James A. Rosen
@@ -11,7 +11,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-09-19 00:00:00.000000000 Z
+date: 2025-10-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: i18n