zendesk_apps_support 4.44.0.alpha.1 → 4.44.0.alpha.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b611098add00d4e6f1c03e6604521db85f49bd6beea30a43695a286c0d474122
-  data.tar.gz: 40e1ade02e50ac1980eeda60def6501368499e48f46c6180f5e5e7f0053564e2
+  metadata.gz: a2d6e7a936e79ffd9af267e73b5a4013415b4b5c1db85ce326758913a20d5ef2
+  data.tar.gz: 2e4204dcd26518cff3ea848aaa52b5897f074366a073becfba928ee5ee5a696e
 SHA512:
-  metadata.gz: 7052e5b47f7b72d52073f25e39291ef32b0373d850b4912d1f82b05a7463188e328452823471bde20ffa537d1bb47ffb53a5ad50713343114423352d3a0861d8
-  data.tar.gz: 8010184c5735b90149c78a3f75ba4d29a08e90f5d4ed0eebda6f94f16763ceeb08328671ef273355492f53a9b931802a253b0be0879fa4969f00c6beddc36ec6
+  metadata.gz: e107a2a670cd16d81056520bdf7907962748ca232234a6fbad84e5b5e454b26b9658c867b952068271b464294bef2918d4cd4eb8c0a5b5770b146da6315dc937
+  data.tar.gz: 830b07edfba8c165e437e9ace71c797905cf169ebe53c2fd034b2af98aa88cde5be420e44585f21d33826c02160563bc79dd6a610b0c1e4ec333cd884d9ef066

data/lib/zendesk_apps_support/app_requirement.rb

@@ -7,6 +7,9 @@ module ZendeskAppsSupport
     CUSTOM_OBJECTS_TYPE_KEY = 'custom_object_types'
     CUSTOM_OBJECTS_RELATIONSHIP_TYPE_KEY = 'custom_object_relationship_types'
     CUSTOM_OBJECTS_V2_KEY = 'custom_objects_v2'
+    CUSTOM_OBJECTS_V2_OBJECTS_KEY = 'objects'
+    CUSTOM_OBJECTS_V2_OBJECT_FIELDS_KEY = 'object_fields'
+    CUSTOM_OBJECT_V2_OBJECT_TRIGGERS_KEY = 'object_triggers'
     TYPES = %w[automations channel_integrations custom_objects macros targets views ticket_fields
                triggers user_fields organization_fields webhooks custom_objects_v2].freeze
   end

data/lib/zendesk_apps_support/package.rb

@@ -31,7 +31,8 @@ module ZendeskAppsSupport
       @warnings = []
     end
 
-    def validate(marketplace: true, skip_marketplace_translations: false, error_on_password_parameter: false)
+    def validate(marketplace: true, skip_marketplace_translations: false, error_on_password_parameter: false,
+                 validate_custom_objects_v2: false)
       errors = []
       errors << Validations::Manifest.call(self, error_on_password_parameter: error_on_password_parameter)
 
@@ -39,7 +40,7 @@ module ZendeskAppsSupport
         errors << Validations::Marketplace.call(self) if marketplace
         errors << Validations::Source.call(self)
         errors << Validations::Translations.call(self, skip_marketplace_translations: skip_marketplace_translations)
-        errors << Validations::Requirements.call(self)
+        errors << Validations::Requirements.call(self, validate_custom_objects_v2:)
 
         # only adds warnings
         Validations::SecureSettings.call(self)
@@ -61,9 +62,14 @@ module ZendeskAppsSupport
       errors.flatten.compact
     end
 
-    def validate!(marketplace: true, skip_marketplace_translations: false, error_on_password_parameter: false)
-      errors = validate(marketplace: marketplace, skip_marketplace_translations: skip_marketplace_translations, error_on_password_parameter: error_on_password_parameter)
+    def validate!(marketplace: true, skip_marketplace_translations: false, error_on_password_parameter: false,
+                  validate_custom_objects_v2: false)
+      errors = validate(marketplace: marketplace,
+                        skip_marketplace_translations: skip_marketplace_translations,
+                        error_on_password_parameter: error_on_password_parameter,
+                        validate_custom_objects_v2:)
       raise errors.first if errors.any?
+
       true
     end
 

data/lib/zendesk_apps_support/validations/custom_objects_v2/constants.rb

@@ -47,6 +47,11 @@ module ZendeskAppsSupport
         UNDEFINED_VALUE = '(undefined)'
         CONDITION_KEYS = [ALL, ANY].freeze
         MAX_PAYLOAD_SIZE_BYTES = 1_048_576 # 1 MB in bytes
+
+        REFERENCE_VALIDATION_CONFIG = {
+          SCHEMA_KEYS[:object_fields] => { identifier: KEY, error: :invalid_cov2_object_reference_in_fields },
+          SCHEMA_KEYS[:object_triggers] => { identifier: TITLE, error: :invalid_cov2_object_reference_in_triggers }
+        }.freeze
       end
     end
   end

data/lib/zendesk_apps_support/validations/custom_objects_v2/custom_objects_v2.rb

@@ -10,18 +10,23 @@ module ZendeskAppsSupport
     module CustomObjectsV2
       class << self
         include Constants
+        include ValidationHelpers
 
         def call(requirements)
-          errors = validate_overall_requirements_structure(requirements)
-          return errors if errors.any?
+          structural_errors = validate_overall_requirements_structure(requirements)
+          return structural_errors if structural_errors.any?
 
           payload_size_errors = validate_payload_size(requirements)
           return payload_size_errors if payload_size_errors.any?
 
-          [
+          limits_and_schema_errors = [
             validate_limits(requirements),
             validate_schema(requirements)
           ].flatten
+
+          return limits_and_schema_errors if limits_and_schema_errors.any?
+
+          validate_object_references(requirements)
         end
 
         private
@@ -67,6 +72,27 @@ module ZendeskAppsSupport
           SchemaValidator.validate(requirements)
         end
 
+        def validate_object_references(requirements)
+          valid_object_keys = extract_valid_object_keys(requirements[SCHEMA_KEYS[:objects]])
+
+          REFERENCE_VALIDATION_CONFIG.flat_map do |collection_type, config|
+            collection = requirements[collection_type]
+            validate_collection_references(collection, valid_object_keys, config[:error], config[:identifier])
+          end
+        end
+
+        def validate_collection_references(collection, valid_object_keys, error, identifier)
+          valid_collection = extract_hash_entries(collection)
+          valid_collection.filter_map do |item|
+            object_key = item[OBJECT_KEY]
+            next if valid_object_keys.include?(object_key)
+
+            ValidationError.new(error,
+                                item_identifier: safe_value(item[identifier]),
+                                object_key: object_key)
+          end
+        end
+
         def validate_collection_is_array(collection, error_type)
           return [] if collection.nil? || collection.is_a?(Array)
 
@@ -78,6 +104,14 @@ module ZendeskAppsSupport
             collection.is_a?(Array) && collection.empty?
           end
         end
+
+        def extract_valid_object_keys(objects)
+          valid_objects = extract_hash_entries(objects)
+          valid_objects.filter_map do |obj|
+            key = obj[KEY]
+            key if key.is_a?(String) && !key.strip.empty?
+          end.uniq
+        end
       end
     end
   end

data/lib/zendesk_apps_support/validations/custom_objects_v2/schema_validator.rb

@@ -60,7 +60,7 @@ module ZendeskAppsSupport
           end
 
           def validate_trigger_schema(trigger)
-            required_keys = %w[object_key title actions conditions]
+            required_keys = %w[key object_key title actions conditions]
             missing_keys = required_keys - trigger.keys
             trigger_title = safe_value(trigger[TITLE])
             object_key = safe_value(trigger[OBJECT_KEY])
@@ -103,10 +103,6 @@ module ZendeskAppsSupport
             [ValidationError.new(:empty_cov2_trigger_actions, **error_data)]
           end
 
-          def safe_value(value)
-            value || UNDEFINED_VALUE
-          end
-
           def valid_conditions_structure?(conditions)
             return false unless conditions.is_a?(Hash) && conditions.any?
             return false if (conditions.keys - CONDITION_KEYS).any?

data/lib/zendesk_apps_support/validations/custom_objects_v2/validation_helpers.rb

@@ -4,6 +4,8 @@ module ZendeskAppsSupport
   module Validations
     module CustomObjectsV2
       module ValidationHelpers
+        include Constants
+
         private
 
         def extract_hash_entries(collection)
@@ -17,6 +19,10 @@ module ZendeskAppsSupport
 
           Constants::CONDITION_KEYS.sum { |key| conditions[key]&.size || 0 }
         end
+
+        def safe_value(value)
+          value || UNDEFINED_VALUE
+        end
       end
     end
   end

data/lib/zendesk_apps_support/validations/requirements.rb

@@ -7,7 +7,7 @@ module ZendeskAppsSupport
       MAX_CUSTOM_OBJECTS_REQUIREMENTS = 50
 
       class << self
-        def call(package)
+        def call(package, validate_custom_objects_v2: false)
           if package.manifest.requirements_only? && !package.has_requirements?
             return [ValidationError.new(:missing_requirements)]
           elsif !supports_requirements(package) && package.has_requirements?
@@ -31,7 +31,7 @@ module ZendeskAppsSupport
             errors << invalid_custom_objects(requirements)
             errors << invalid_webhooks(requirements)
             errors << invalid_target_types(requirements)
-            errors << validate_custom_objects_v2_requirements(requirements)
+            errors << validate_custom_objects_v2_requirements(requirements, validate_custom_objects_v2:)
             errors << missing_required_fields(requirements)
             errors.flatten!
             errors.compact!
@@ -80,8 +80,8 @@ module ZendeskAppsSupport
           end
         end
 
-        def validate_custom_objects_v2_requirements(requirements)
-          return unless requirements.key?(AppRequirement::CUSTOM_OBJECTS_V2_KEY)
+        def validate_custom_objects_v2_requirements(requirements, validate_custom_objects_v2: false)
+          return unless validate_custom_objects_v2 && requirements.key?(AppRequirement::CUSTOM_OBJECTS_V2_KEY)
 
           cov2_requirements = requirements[AppRequirement::CUSTOM_OBJECTS_V2_KEY]
           CustomObjectsV2.call(cov2_requirements)

data/lib/zendesk_apps_support/version.rb

@@ -1,3 +1,3 @@
 module ZendeskAppsSupport
-  VERSION = "4.44.0.alpha.1"
+  VERSION = '4.44.0.alpha.2'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: zendesk_apps_support
 version: !ruby/object:Gem::Version
-  version: 4.44.0.alpha.1
+  version: 4.44.0.alpha.2
 platform: ruby
 authors:
 - James A. Rosen
@@ -11,7 +11,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-09-19 00:00:00.000000000 Z
+date: 2025-10-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: i18n