zendesk_apps_support 4.32.0 → 4.34.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 10d6271886136ebf1422ffac35331cf0a6f0ee416fc45c122126cfab170c6d1a
-  data.tar.gz: ee79d3867a3e6f959d6a692a6eb9bd39c8b15663cf89cb35887ef5aa92ad2106
+  metadata.gz: a3eedd03346c484f6bd2e08a72948df6b7b4a6cf3c373ae6eecb98273028fbb2
+  data.tar.gz: 90d093c8b977a52b390268210b40edbde9b4c0cc88c2119562a3abe57d8044b2
 SHA512:
-  metadata.gz: 24b854a106b6d9d29bac321e7b76fe685db0b800fc1da73f95da40ad12c45f5d6a548c10418b048f89d45af1dfdc31ca6f40199088217453873dc2450d7cf3ee
-  data.tar.gz: 020f26d213b85c16ea3a9154320a7c11c176f17fe6c33e7eeb4c182eea1441e09e633169cb072c768e22d5ba133ca1f1d232d194f7fd336dbf38775e31366310
+  metadata.gz: f81472245fdd81c038b434670e0294d15d808898f8594554ae3ddb8cac4d71f7c0c6603e0bc1295de3d2863dc2f08fce645ea7816a88fc42ffd101286cbeacd0
+  data.tar.gz: cdd24acb548cdbefa089084e547a2b58e1f41c7a74b32266ef8b025572bff2e8250261d0642c7fcf47d352433349147dd8fb231e937c7f148a231e175a35ad30

data/config/locales/en.yml

@@ -148,6 +148,7 @@ en:
               other: "%{invalid_locations} are invalid locations in framework v1."
             oauth_parameter_cannot_be_secure: oauth parameter cannot be set to be
               secure.
+            invalid_url: '%{field} must be a valid URL, got "%{value}".'
         warning:
           app_build:
             deprecated_version: You are targeting a deprecated version of the framework.

data/config/locales/translations/zendesk_apps_support.yml

@@ -412,3 +412,7 @@ parts:
       key: "txt.apps.admin.error.app_build.oauth_parameter_cannot_be_secure"
       title: "oauth parameter cannot be set to be secure."
       value: "oauth parameter cannot be set to be secure."
+  - translation:
+      key: "txt.apps.admin.error.app_build.invalid_url"
+      title: "App builder job: this value needs to be a valid URL, but something else was passed in. placeholder value is taken from user input. You can translate as: The value %{field} must be a valid URL... to avoid any gender issues."
+      value: "%{field} must be a valid URL, got \"%{value}\"."

data/lib/zendesk_apps_support/manifest/location_options.rb

@@ -9,7 +9,8 @@ module ZendeskAppsSupport
         auto_hide: 'autoHide',
         flexible: 'flexible',
         signed: 'signed',
-        url: 'url'
+        url: 'url',
+        size: 'size'
       }.freeze
 
       attr_reader :location

data/lib/zendesk_apps_support/validations/manifest.rb

@@ -39,6 +39,7 @@ module ZendeskAppsSupport
             type_checks(manifest),
             oauth_error(manifest),
             default_locale_error(manifest, package),
+            validate_urls(manifest),
             validate_parameters(manifest),
             if manifest.requirements_only? || manifest.marketing_only?
               [ ban_location(manifest),
@@ -63,6 +64,20 @@ module ZendeskAppsSupport
           ]
         end
 
+        def validate_urls(manifest)
+          errors = []
+
+          if manifest.terms_conditions_url && !valid_url?(manifest.terms_conditions_url)
+            errors << ValidationError.new(:invalid_url, field: 'terms_conditions_url', value: manifest.terms_conditions_url)
+          end
+
+          author = manifest.author
+          if author && author["url"] && !valid_url?(author["url"])
+            errors << ValidationError.new(:invalid_url, field: 'author url', value: author["url"])
+          end
+          errors
+        end
+
         def validate_parameters(manifest)
           if manifest.marketing_only?
             marketing_only_errors(manifest)
@@ -416,6 +431,13 @@ module ZendeskAppsSupport
             ValidationError.new(:invalid_no_template)
           end
         end
+
+        def valid_url?(value)
+          uri = URI.parse(value)
+          uri.is_a?(URI::HTTP) && !uri.host.nil?
+        rescue URI::InvalidURIError
+          false
+        end
       end
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: zendesk_apps_support
 version: !ruby/object:Gem::Version
-  version: 4.32.0
+  version: 4.34.1
 platform: ruby
 authors:
 - James A. Rosen
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-05-16 00:00:00.000000000 Z
+date: 2022-06-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: i18n
@@ -347,7 +347,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: 1.3.6
 requirements: []
-rubygems_version: 3.0.3.1
+rubygems_version: 3.0.1
 signing_key: 
 specification_version: 4
 summary: Support to help you develop Zendesk Apps.