zendesk_apps_support 4.31.1 → 4.34.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: '01083332c185deb236fcc2f4fb3e66b65a695085790b448c8451f4c8c1b21aac'
-  data.tar.gz: 1580841170ebef45a0d9a9c27a65e567683e353d6c4ba6293be06a60d2da64de
+  metadata.gz: daadfd24b104643d1232b9d0806cccfd9019e73f3e124eb25eea78215deadebf
+  data.tar.gz: 101976ef21c36e7c07249ed91aac765861a57b7fa87fb02a57d00aaf353a57dd
 SHA512:
-  metadata.gz: f06ed79968e27181e17530785e21e678aaf45a2ff1e3776f29d0f8de3ecde20b125f01b5698196292e57e5ee431a1ac5e2359da6dddec417c8323308d97ee746
-  data.tar.gz: a63fb2623abbe41fb40475358793c2ec47c75562e3fd0ede58ea4e6630e4e2d48adacd498a77c3c4dfc8add50a41f83ab26309f5ee69daeb7fbe69b5e65edc43
+  metadata.gz: d3535f5a0f2da21a3865a5891d4d2ad35d38876dd54ff6ece6c41933935f133681e7b45d95a8efe1abd5acc93421a37cac2150586e90d95c563f01894011d579
+  data.tar.gz: 9d15fa32361ce1979f4dccbd1eba7e630d337b929c85e54eafbddf4651d741babaa5f99bff06d657e3b6cd28dabafb1aea74e2dcd21acf95809785ad9d98bcea

data/config/locales/en.yml

@@ -148,6 +148,7 @@ en:
               other: "%{invalid_locations} are invalid locations in framework v1."
             oauth_parameter_cannot_be_secure: oauth parameter cannot be set to be
               secure.
+            invalid_url: '%{field} must be a valid URL, got "%{value}".'
         warning:
           app_build:
             deprecated_version: You are targeting a deprecated version of the framework.

data/config/locales/translations/zendesk_apps_support.yml

@@ -412,3 +412,7 @@ parts:
       key: "txt.apps.admin.error.app_build.oauth_parameter_cannot_be_secure"
       title: "oauth parameter cannot be set to be secure."
       value: "oauth parameter cannot be set to be secure."
+  - translation:
+      key: "txt.apps.admin.error.app_build.invalid_url"
+      title: "App builder job: this value needs to be a valid URL, but something else was passed in. placeholder value is taken from user input. You can translate as: The value %{field} must be a valid URL... to avoid any gender issues."
+      value: "%{field} must be a valid URL, got \"%{value}\"."

data/lib/zendesk_apps_support/manifest/location_options.rb

@@ -9,7 +9,8 @@ module ZendeskAppsSupport
         auto_hide: 'autoHide',
         flexible: 'flexible',
         signed: 'signed',
-        url: 'url'
+        url: 'url',
+        size: 'size'
       }.freeze
 
       attr_reader :location

data/lib/zendesk_apps_support/validations/manifest.rb

@@ -39,6 +39,7 @@ module ZendeskAppsSupport
             type_checks(manifest),
             oauth_error(manifest),
             default_locale_error(manifest, package),
+            validate_urls(manifest),
             validate_parameters(manifest),
             if manifest.requirements_only? || manifest.marketing_only?
               [ ban_location(manifest),
@@ -63,6 +64,20 @@ module ZendeskAppsSupport
           ]
         end
 
+        def validate_urls(manifest)
+          errors = []
+
+          if manifest.terms_conditions_url && !valid_url?(manifest.terms_conditions_url)
+            errors << ValidationError.new(:invalid_url, field: 'terms_conditions_url', value: manifest.terms_conditions_url)
+          end
+
+          author = manifest.author
+          if author && author["url"] && !valid_url?(author["url"])
+            errors << ValidationError.new(:invalid_url, field: 'author url', value: author["url"])
+          end
+          errors
+        end
+
         def validate_parameters(manifest)
           if manifest.marketing_only?
             marketing_only_errors(manifest)
@@ -416,6 +431,13 @@ module ZendeskAppsSupport
             ValidationError.new(:invalid_no_template)
           end
         end
+
+        def valid_url?(value)
+          uri = URI.parse(value)
+          uri.is_a?(URI::HTTP) && !uri.host.nil?
+        rescue URI::InvalidURIError
+          false
+        end
       end
     end
   end

data/lib/zendesk_apps_support/validations/requirements.rb

@@ -30,6 +30,7 @@ module ZendeskAppsSupport
             errors << invalid_custom_fields(requirements)
             errors << invalid_custom_objects(requirements)
             errors << invalid_webhooks(requirements)
+            errors << invalid_target_types(requirements)
             errors << missing_required_fields(requirements)
             errors.flatten!
             errors.compact!
@@ -171,6 +172,18 @@ module ZendeskAppsSupport
                                           identifier: identifier)
           end
         end
+
+        def invalid_target_types(requirements)
+          invalid_target_types = %w[http_target]
+
+          requirements['targets']&.map do |_identifier, requirement|
+            if invalid_target_types.include?(requirement['type'])
+              ValidationError.new(:invalid_requirements_types,
+                                  invalid_types: "targets -> #{requirement['type']}",
+                                  count: 1)
+            end
+          end
+        end
       end
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: zendesk_apps_support
 version: !ruby/object:Gem::Version
-  version: 4.31.1
+  version: 4.34.0
 platform: ruby
 authors:
 - James A. Rosen
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-02-09 00:00:00.000000000 Z
+date: 2022-05-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: i18n