zendesk_apps_support 4.31.0 → 4.33.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: cbc9fd13362aa145c08d79257d11b41d61df1ae6e40ad4ce9dd849343d79b43d
-  data.tar.gz: 351f8e6f2e5da95f28a950581c744149e4d445de1a5e1054ff6a652bdef326f8
+  metadata.gz: '0358535696ec34c00e8eb9b6d2aa3c0575ddca2dec7df2f516e15099788f96c2'
+  data.tar.gz: 178611fb26e2bd7552c8e6b82c520854f40455ef71b3fa685690f2666df8e1a9
 SHA512:
-  metadata.gz: bf545fb8709e9183891d82c4eeb3bafbc4aab436f658c956591e205390abe5119670c647b848c9a2d25c770571d1f136daa0b9c9ae4fd9cea864bc3e6b41f30d
-  data.tar.gz: 5f2724bf3b60e2de9affb773176de16effa2617d5876f7afa798b8c2aa0bcbfceafa81f9db959a3d004dd5577107e204d12ab7f568aae14cf306748be723c283
+  metadata.gz: 6a2cfbba4f1726d72874e64d4e59612b43cfc429a0d2944896824e8751ea8445953bb52576b885967b4601a0faa5a6c727667b8768b13d0bf06b8fdee5a1e104
+  data.tar.gz: dc364377373e42668dce9f13cb30abf30e64d360c18f2c0d7bd3401c4005c2b22c3774fdf56c77d26ab0e077416d2853562e7daed87e2f396faa74950b82e205

data/lib/zendesk_apps_support/manifest/location_options.rb

@@ -9,7 +9,8 @@ module ZendeskAppsSupport
         auto_hide: 'autoHide',
         flexible: 'flexible',
         signed: 'signed',
-        url: 'url'
+        url: 'url',
+        size: 'size'
       }.freeze
 
       attr_reader :location

data/lib/zendesk_apps_support/validations/requirements.rb

@@ -30,6 +30,7 @@ module ZendeskAppsSupport
             errors << invalid_custom_fields(requirements)
             errors << invalid_custom_objects(requirements)
             errors << invalid_webhooks(requirements)
+            errors << invalid_target_types(requirements)
             errors << missing_required_fields(requirements)
             errors.flatten!
             errors.compact!
@@ -113,18 +114,20 @@ module ZendeskAppsSupport
 
           return if webhook_requirements.nil?
 
-          validate_webhook_keys(webhook_requirements)
+          webhook_requirements.map do |identifier, requirement|
+            validate_webhook_keys(identifier, requirement)
+          end.flatten
         end
 
-        def validate_webhook_keys(webhook_requirements)
+        def validate_webhook_keys(identifier, requirement)
           required_keys = %w[name status endpoint http_method request_format]
 
-          missing_keys = required_keys - webhook_requirements.keys
+          missing_keys = required_keys - requirement.keys
 
           missing_keys.map do |key|
             ValidationError.new(:missing_required_fields,
                                 field: key,
-                                identifier: AppRequirement::WEBHOOKS_KEY)
+                                identifier: identifier)
           end
         end
 
@@ -169,6 +172,18 @@ module ZendeskAppsSupport
                                           identifier: identifier)
           end
         end
+
+        def invalid_target_types(requirements)
+          invalid_target_types = %w[http_target]
+
+          requirements['targets']&.map do |_identifier, requirement|
+            if invalid_target_types.include?(requirement['type'])
+              ValidationError.new(:invalid_requirements_types,
+                                  invalid_types: "targets -> #{requirement['type']}",
+                                  count: 1)
+            end
+          end
+        end
       end
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: zendesk_apps_support
 version: !ruby/object:Gem::Version
-  version: 4.31.0
+  version: 4.33.0
 platform: ruby
 authors:
 - James A. Rosen
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-02-03 00:00:00.000000000 Z
+date: 2022-05-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: i18n