zendesk_apps_support 4.29.5 → 4.29.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a106bcae90806c793735bbc559eb47fec0daaf4b
-  data.tar.gz: 54de16ed4176064fdf01ed8b11efcdf1a91901be
+  metadata.gz: f7aff48dd5eff958501e5e21f78713b7e2906f9e
+  data.tar.gz: d267db414baabe7ced86ec3e1b196c08fb0346e2
 SHA512:
-  metadata.gz: a591b02c1fb89fcac0ef7817a51697a186cc68643820c8e3ba68dc9284638190f8f51e7631cc00938605e06ae7fc8d78c7c8919f11bc3018a5745085b881c1de
-  data.tar.gz: a4ddc50586ad3c6a523581b9fc23b736aa670b3ee15802d911fec5e0a3b5fc2aac1050bb0d37b9e0aea2398016561c7e0fc13c4daeb8c4b05a4a46e8a4082d01
+  metadata.gz: a87b22e67e6489bb6d619b24d5ba7ac670e9322a500b06aaf32014328917bdf496d779ae554c83a39258979a6583dfa5a57f2ec3ffd0c432d024d4c14430ab4b
+  data.tar.gz: 19b7439b1574327c9b53cac0448db136cc1d2f3be29da878d75d597d5cba7f038c8204bf270295ec6e6ba32c0980ffcd4e20737d3121ca269fa58522d4ffd908

data/config/locales/en.yml

@@ -96,6 +96,8 @@ en:
             blank_location_uri: "%{location} location does not specify a URI."
             invalid_location_uri: "%{uri} is either an invalid location URI, refers
               to a missing asset, or does not use HTTPS."
+            invalid_location_flexible_type: "%{flexible} is an invalid type for the
+              flexible location parameter."
             name_as_parameter_name: Can't call a parameter 'name'
             invalid_hidden_parameter:
               one: "%{invalid_params} is set to hidden and cannot be required."
@@ -123,6 +125,9 @@ en:
                 do not match products in translations (%{translation_products})
               insecure_token_parameter_in_manifest: 'Make sure to set secure to true
                 when using keys in Settings. Learn more: %{link}'
+              default_secure_or_hidden_parameter_in_manifest: Default values for secure
+                or hidden parameters are not stored securely. Be sure to review them
+                and confirm they do not contain sensitive data
             stylesheet_error: 'Sass error: %{sass_error}'
             invalid_type_parameter:
               one: "%{invalid_types} is an invalid parameter type."

data/config/locales/translations/zendesk_apps_support.yml

@@ -234,6 +234,10 @@ parts:
       key: "txt.apps.admin.error.app_build.invalid_location_uri"
       title: "App builder job: invalid URI for an iframe in the manifest"
       value: "%{uri} is either an invalid location URI, refers to a missing asset, or does not use HTTPS."
+  - translation:
+      key: "txt.apps.admin.error.app_build.invalid_location_flexible_type"
+      title: "App builder job: invalid flexible type for an iframe in the manifest"
+      value: "%{flexible} is an invalid type for the flexible location parameter."
   - translation:
       key: "txt.apps.admin.error.app_build.name_as_parameter_name"
       title: "App builder job: error message when developer names a parameter 'name'"
@@ -351,6 +355,11 @@ parts:
       title: "Validation message to indicate missing secure(true) field in manifest's token parameter. Do not translate 'secure' and 'true'. Secure(true) in manifest refers to https://developer.zendesk.com/apps/docs/developer-guide/using_sdk#using-secure-settings"
       value: "Make sure to set secure to true when using keys in Settings. Learn more: %{link}"
       screenshot: "https://drive.google.com/open?id=1ss3nNN2RG29R7StjCtiH8qjuwFBlRApJ"
+  - translation:
+      key: "txt.apps.admin.error.app_build.translation.default_secure_or_hidden_parameter_in_manifest"
+      title: "Validation message to indicate that a hidden or secure manifest parameter has a default value. Do not translate 'secure' and 'hidden'. Secure(true) in manifest refers to https://developer.zendesk.com/apps/docs/developer-guide/using_sdk#using-secure-settings"
+      value: "Default values for secure or hidden parameters are not stored securely. Be sure to review them and confirm they do not contain sensitive data"
+      screenshot: "https://drive.google.com/file/d/1MI6ci6Jz6xtwOXjcbHFCfNi1FjXKOuv9/view?usp=sharing"
   - translation:
       key: "txt.apps.admin.error.app_build.stylesheet_error"
       title: "App builder job: invalid stylesheet syntax"

data/lib/zendesk_apps_support/manifest/location_options.rb

@@ -7,6 +7,7 @@ module ZendeskAppsSupport
         legacy: 'legacy',
         auto_load: 'autoLoad',
         auto_hide: 'autoHide',
+        flexible: 'flexible',
         signed: 'signed',
         url: 'url'
       }.freeze

data/lib/zendesk_apps_support/sass_functions.rb

@@ -26,9 +26,9 @@ require 'sassc'
 module SassC::Script::Functions
   module AppAssetUrl
     def app_asset_url(name)
-      raise ArgumentError, "Expected #{name} to be a string" unless name.is_a? Sass::Script::Value::String
+      raise ArgumentError, "Expected #{name} to be a string" unless name.is_a? SassC::Script::Value::String
       result = %{url("#{app_asset_url_helper(name)}")}
-      SassC::Script::String.new(result)
+      SassC::Script::Value::String.new(result)
     end
 
     private

data/lib/zendesk_apps_support/validations/manifest.rb

@@ -271,6 +271,10 @@ module ZendeskAppsSupport
             elsif location_options.auto_load?
               errors << ValidationError.new(:blank_location_uri, location: location_options.location.name)
             end
+
+            if !([true, false].include? location_options.flexible) && !location_options.flexible.nil?
+              errors << invalid_location_flexible_error(location_options)
+            end
           end
 
           Product::PRODUCTS_AVAILABLE.each do |product|
@@ -319,6 +323,12 @@ module ZendeskAppsSupport
           validation_error
         end
 
+        def invalid_location_flexible_error(location_options)
+          flexible_flag = location_options.flexible
+          validation_error = ValidationError.new(:invalid_location_flexible_type, flexible: flexible_flag)
+          validation_error
+        end
+
         def valid_absolute_uri?(uri)
           uri.scheme == 'https' || uri.host == 'localhost'
         end

data/lib/zendesk_apps_support/validations/mime.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require 'mimemagic'
+require 'marcel'
 
 module ZendeskAppsSupport
   module Validations
@@ -20,9 +20,8 @@ module ZendeskAppsSupport
         private
 
         def block_listed?(app_file)
-          mime_type = MimeMagic.by_magic(app_file.read)
-
-          content_subtype = mime_type.subtype if mime_type
+          mime_type = Marcel::MimeType.for(StringIO.new(app_file.read))
+          content_subtype = mime_type.split('/', 2).last if mime_type
           extension_name = app_file.extension.delete('.')
 
           ([content_subtype, extension_name] & UNSUPPORTED_MIME_TYPES).any?

data/lib/zendesk_apps_support/validations/secure_settings.rb

@@ -11,12 +11,18 @@ module ZendeskAppsSupport
           manifest_params = package.manifest.parameters
 
           insecure_params_found = manifest_params.any? { |param| insecure_param?(param) }
-
           package.warnings << secure_settings_warning if insecure_params_found
+
+          secure_or_hidden_default_param_found = manifest_params.any? { |param| secure_or_hidden_default_param?(param) }
+          package.warnings << hidden_default_parameter_warning if secure_or_hidden_default_param_found
         end
 
         private
 
+        def secure_or_hidden_default_param?(parameter)
+          parameter.default? && (parameter.secure || parameter.type == 'hidden')
+        end
+
         def insecure_param?(parameter)
           parameter.name =~ SECURABLE_KEYWORDS_REGEXP && type_password_or_text?(parameter.type) && !parameter.secure
         end
@@ -25,6 +31,12 @@ module ZendeskAppsSupport
           parameter_type == 'text' || parameter_type == 'password'
         end
 
+        def hidden_default_parameter_warning
+          I18n.t(
+            'txt.apps.admin.error.app_build.translation.default_secure_or_hidden_parameter_in_manifest'
+          )
+        end
+
         def secure_settings_warning
           I18n.t(
             'txt.apps.admin.error.app_build.translation.insecure_token_parameter_in_manifest',

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: zendesk_apps_support
 version: !ruby/object:Gem::Version
-  version: 4.29.5
+  version: 4.29.9
 platform: ruby
 authors:
 - James A. Rosen
@@ -11,7 +11,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-08-19 00:00:00.000000000 Z
+date: 2021-08-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: i18n
@@ -31,16 +31,16 @@ dependencies:
   name: sassc
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 1.11.2
+        version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 1.11.2
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: sass
   requirement: !ruby/object:Gem::Requirement
@@ -103,14 +103,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.2.3
+        version: 2.3.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.2.3
+        version: 2.3.1
 - !ruby/object:Gem::Dependency
   name: nokogiri
   requirement: !ruby/object:Gem::Requirement
@@ -146,19 +146,19 @@ dependencies:
       - !ruby/object:Gem::Version
         version: 0.9.10
 - !ruby/object:Gem::Dependency
-  name: mimemagic
+  name: marcel
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 0.3.3
+        version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 0.3.3
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: ipaddress_2
   requirement: !ruby/object:Gem::Requirement
@@ -249,14 +249,28 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.17.3
+        version: 2.2.26
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 2.2.26
+- !ruby/object:Gem::Dependency
+  name: parallel
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 1.12.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.17.3
+        version: 1.12.1
 description: Support to help you develop Zendesk Apps.
 email:
 - dev@zendesk.com