zendesk_apps_support 4.28.0 → 4.29.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 18a2219c066ccf5b47f80f660a62cd4b292810f7
-  data.tar.gz: 32c93abb832fbf273644fcc5e223f9f72b7c178f
+SHA256:
+  metadata.gz: e0ede6523497ff0fbf8d8768ea7a00b90ad1011c3eeb5ed0db26c9b7f22e49fc
+  data.tar.gz: 9a5577cdb2dfac58db29921c5b1b76291a33de58376d7b4c3a9d2ade650c0b91
 SHA512:
-  metadata.gz: c258716b5eb2ca613b9fb9ae98a13fcaa4aa2aa72c07604ed8d5f965764596a55c6e0cdfbe5964279336b2726923b07744582cead4b64359c5849075a23369dc
-  data.tar.gz: ac7944c1a7b828e567cc2850cea3a013d825c47ef879fcd6494151a8932cc2d82d7951e0e5b2111a4f0eb6629a2d33bf440bfdf4403dd906dc2d0569eb4a1fbb
+  metadata.gz: 6b256559f9f1fc4948e3921bd711b9cdedff8b98a3d1bc8573d3e83fc961023acfbec1994e713a72edff82970c13f1266cbf2aea933f1ee2cb8b65a384b52e97
+  data.tar.gz: 35555b53118ea3d124778b5f129fbcc3dc9ef891f3eefadb89c7cb619c8ead585262f61f58594c3001f438c1ae9106abbaf6b5ad01cff61153cf4e3426103cd1

data/lib/zendesk_apps_support/package.rb

@@ -40,10 +40,10 @@ module ZendeskAppsSupport
         errors << Validations::Source.call(self)
         errors << Validations::Translations.call(self, skip_marketplace_translations: skip_marketplace_translations)
         errors << Validations::Requirements.call(self)
-        errors << Validations::Requests.call(self)
 
         # only adds warnings
         Validations::SecureSettings.call(self)
+        Validations::Requests.call(self)
 
         unless manifest.requirements_only? || manifest.marketing_only? || manifest.iframe_only?
           errors << Validations::Templates.call(self)

data/lib/zendesk_apps_support/validations/requests.rb

@@ -7,62 +7,25 @@ module ZendeskAppsSupport
   module Validations
     module Requests
       class << self
-        IP_ADDRESS = /\d{1,3}\.\d{1,3}\.\d{1,3}\.\d{1,3}/
-
         def call(package)
-          errors = []
           files = package.js_files + package.html_files
-          private_app = package.manifest.private?
 
           files.each do |file|
             file_content = file.read
 
             http_protocol_urls = find_address_containing_http(file_content)
-            if http_protocol_urls.any?
-              package.warnings << insecure_http_requests_warning(
-                http_protocol_urls,
-                file.relative_path
-              )
-            end
-
-            ip_addresses = file_content.scan(IP_ADDRESS)
-            next unless ip_addresses.any?
-
-            ip_validation_messages = ip_validation_messages(
-              file.relative_path,
-              ip_addresses,
-              private_app
+            next unless http_protocol_urls.any?
+            package.warnings << insecure_http_requests_warning(
+              http_protocol_urls,
+              file.relative_path
             )
-
-            validation_group = private_app ? package.warnings : errors
-            validation_group << ip_validation_messages
           end
 
           package.warnings.flatten!
-          errors
         end
 
         private
 
-        def ip_validation_messages(file_path, ip_addresses, private_app)
-          ip_addresses.each_with_object([]) do |ip_address, messages|
-            ip_type_string = ip_type_string(ip_address)
-            next unless ip_type_string
-
-            string_params = {
-              type: ip_type_string, uri: ip_address, file: file_path
-            }
-            validation_message =
-              if private_app
-                I18n.t('txt.apps.admin.error.app_build.blocked_request', string_params)
-              else
-                ValidationError.new(:blocked_request, string_params)
-              end
-
-            messages << validation_message
-          end
-        end
-
         def insecure_http_requests_warning(http_protocol_urls, relative_path)
           http_protocol_urls = http_protocol_urls.join(
             I18n.t('txt.apps.admin.error.app_build.listing_comma')
@@ -75,19 +38,6 @@ module ZendeskAppsSupport
           )
         end
 
-        def ip_type_string(ip_address)
-          block_type =
-            case IPAddress.parse(ip_address)
-            when proc(&:private?) then 'private'
-            when proc(&:loopback?) then 'loopback'
-            when proc(&:link_local?) then 'link_local'
-            end
-
-          block_type && I18n.t("txt.apps.admin.error.app_build.blocked_request_#{block_type}")
-        rescue ArgumentError
-          nil # Ignore numbers which are not an IP address
-        end
-
         def find_address_containing_http(file_content)
           file_content.scan(URI.regexp(['http'])).map(&:compact).map(&:last)
         end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: zendesk_apps_support
 version: !ruby/object:Gem::Version
-  version: 4.28.0
+  version: 4.29.0
 platform: ruby
 authors:
 - James A. Rosen
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-01-29 00:00:00.000000000 Z
+date: 2020-02-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: i18n
@@ -319,8 +319,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: 1.3.6
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.6.8
+rubygems_version: 3.0.6
 signing_key: 
 specification_version: 4
 summary: Support to help you develop Zendesk Apps.