zendesk_apps_support 4.27.0 → 4.28.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA256:
-  metadata.gz: 98c46bd59f486032480d291ecd0daa4fb479665e9a9e114b2c1966223eeb9f11
-  data.tar.gz: 74f5b5e00169a98c185a919648905917438c41e3c7126804b70a1651b139a253
+SHA1:
+  metadata.gz: 18a2219c066ccf5b47f80f660a62cd4b292810f7
+  data.tar.gz: 32c93abb832fbf273644fcc5e223f9f72b7c178f
 SHA512:
-  metadata.gz: ad1e834cfee32a905ad10ec1bc0164cffa567a3b40e7f1b1a2a17b3c0b5d88b145aef6eeae86da08b1f97e50212678afd21043ae18e7d72a1aaece71eb8fda66
-  data.tar.gz: fc2a957936239bbc3ff72adb5ef40ab98a120090e1f2b0f0a926433e456aea07d965433319b07de91854998ec8a6066417252d9a12d8b59e29f4af5e8663ba69
+  metadata.gz: c258716b5eb2ca613b9fb9ae98a13fcaa4aa2aa72c07604ed8d5f965764596a55c6e0cdfbe5964279336b2726923b07744582cead4b64359c5849075a23369dc
+  data.tar.gz: ac7944c1a7b828e567cc2850cea3a013d825c47ef879fcd6494151a8932cc2d82d7951e0e5b2111a4f0eb6629a2d33bf440bfdf4403dd906dc2d0569eb4a1fbb

data/lib/zendesk_apps_support/location.rb

@@ -63,7 +63,8 @@ module ZendeskAppsSupport
       Location.new(id: 21, name: 'dashboard', product_code: Product::SELL.code, visible: true),
       Location.new(id: 22, name: 'note_editor', product_code: Product::SELL.code, visible: true),
       Location.new(id: 23, name: 'call_log_editor', product_code: Product::SELL.code, visible: true),
-      Location.new(id: 24, name: 'email_editor', product_code: Product::SELL.code, visible: true)
+      Location.new(id: 24, name: 'email_editor', product_code: Product::SELL.code, visible: true),
+      Location.new(id: 25, name: 'top_bar', product_code: Product::SELL.code, visible: true)
     ].freeze
   end
 end

data/lib/zendesk_apps_support/package.rb

@@ -16,7 +16,10 @@ module ZendeskAppsSupport
     DEFAULT_SCSS   = File.read(File.expand_path('../assets/default_styles.scss', __FILE__))
     SRC_TEMPLATE   = Erubis::Eruby.new(File.read(File.expand_path('../assets/src.js.erb', __FILE__)))
 
-    LOCATIONS_WITH_ICONS = %w[top_bar nav_bar system_top_bar ticket_editor].freeze
+    LOCATIONS_WITH_ICONS_PER_PRODUCT = {
+      Product::SUPPORT => %w[top_bar nav_bar system_top_bar ticket_editor].freeze,
+      Product::SELL => %w[top_bar].freeze
+    }.freeze
 
     attr_reader :lib_root, :root, :warnings
 
@@ -321,14 +324,17 @@ module ZendeskAppsSupport
     def location_icons
       Hash.new { |h, k| h[k] = {} }.tap do |location_icons|
         manifest.location_options.each do |location_options|
-          next unless location_options.location &&
-                      LOCATIONS_WITH_ICONS.include?(location_options.location.name) &&
-                      location_options.location.product == Product::SUPPORT
+          # no location information in the manifest
+          next unless location_options.location
+
+          product = location_options.location.product
+          location_name = location_options.location.name
+          # the location on the product does not support icons
+          next unless LOCATIONS_WITH_ICONS_PER_PRODUCT.fetch(product, []).include?(location_name)
 
           host = location_options.location.product.name
-          location = location_options.location.name
           product_directory = manifest.products.count > 1 ? "#{host}/" : ''
-          location_icons[host][location] = build_location_icons_hash(location, product_directory)
+          location_icons[host][location_name] = build_location_icons_hash(location_name, product_directory)
         end
       end
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: zendesk_apps_support
 version: !ruby/object:Gem::Version
-  version: 4.27.0
+  version: 4.28.0
 platform: ruby
 authors:
 - James A. Rosen
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-12-09 00:00:00.000000000 Z
+date: 2020-01-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: i18n
@@ -320,7 +320,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: 1.3.6
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.7.10
+rubygems_version: 2.6.8
 signing_key: 
 specification_version: 4
 summary: Support to help you develop Zendesk Apps.