zendesk_apps_support 4.10.0 → 4.11.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA256:
-  metadata.gz: d10ac2adce861c9b73ab9101e7606305d34b1741db038c458e22cc574e37a5d3
-  data.tar.gz: d41cc50438b65b960d20baaa26a5ab14f522cd935e3aa84cabf51a63835ea806
+SHA1:
+  metadata.gz: 651dbb4885312a3344235f1fc67430b4292378d8
+  data.tar.gz: 872abbf352ba3f02cae8a6902e0a09e203c9a303
 SHA512:
-  metadata.gz: 698940e0eb1029f3181251dba53d537333c029ca1bed06831045b1c26b1508035ab0b7f3b15b83d428c796d151ed9531a9d6f90e599507cf44c5e4b5f692c295
-  data.tar.gz: bd61dc59a6b09dff757172bd03eef673df6138257a00d3d36df12b1867036e93f2c13839c6f440015e74a0bc94cf6407a2fccbd63386f3d88d283900b12822d2
+  metadata.gz: 3648f0308aa79e2b962de36da307d8c8ca178b148d30ca2b81bbcd2f58d4cb9b2b740059da7353873d04c4082b6b3f70341af561d6efe86db7d36404c68e34bb
+  data.tar.gz: 14475794f8d8578fa05355ac485beb08cb463284b85868cd20dd688c3ba16369b39672dfd22864c0f960f480e30b244ceaf6783a75917d8c1e2f56c6be73b5e0

data/config/locales/translations/zendesk_apps_support.yml

@@ -35,11 +35,6 @@ parts:
       key: "txt.apps.admin.error.app_build.no_framework_version_required"
       title: "App builder job: ban framework version while requirements only"
       value: "Framework versions can't be set when you specify requirements only"
-  - translation:
-      key: "txt.apps.admin.error.app_build.no_app_js_required"
-      title: "App builder job: ban app.js while requirements only"
-      value: "Do not set your app to requirements only if you need app.js"
-      obsolete: "2016-02-28"
   - translation:
       key: "txt.apps.admin.error.app_build.manifest_not_json"
       title: "App builder job: manifest is invalid JSON error"
@@ -187,18 +182,8 @@ parts:
   - translation:
       key: "txt.apps.admin.error.app_build.signed_setting_uri"
       title: "App builder job: invalid URI for an iframe in the manifest. The `manifest` is a setting file, the `signed url` is https://cloud.google.com/storage/docs/access-control/signed-urls"
-      value: "the url (%{uri}) cannot use a setting because it is a signed url"
+      value: "The url (%{uri}) cannot use a setting because it is a signed url."
       screenshot: "https://drive.google.com/open?id=1oQmBeGfNT5EDaEH3oEQoNjaCzBw5XAvL"
-  - translation:
-      key: "txt.apps.admin.error.app_build.duplicate_location.one"
-      title: "App builder job: duplicate locations"
-      value: "%{duplicate_locations} is a duplicate location."
-      obsolete: "2016-12-31"
-  - translation:
-      key: "txt.apps.admin.error.app_build.duplicate_location.other"
-      title: "App builder job: duplicate locations"
-      value: "%{duplicate_locations} are duplicate locations."
-      obsolete: "2016-12-31"
   - translation:
       key: "txt.apps.admin.error.app_build.name_as_parameter_name"
       title: "App builder job: error message when developer names a parameter 'name'"

data/lib/zendesk_apps_support.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module ZendeskAppsSupport
   require 'zendesk_apps_support/engine'
 

data/lib/zendesk_apps_support/app_file.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module ZendeskAppsSupport
   class AppFile
     attr_reader :relative_path

data/lib/zendesk_apps_support/app_requirement.rb

@@ -1,8 +1,9 @@
 # frozen_string_literal: true
+
 module ZendeskAppsSupport
   class AppRequirement
-    TYPES = %w(automations channel_integrations
+    TYPES = %w[automations channel_integrations
                macros targets views ticket_fields triggers
-               user_fields organization_fields).freeze
+               user_fields organization_fields].freeze
   end
 end

data/lib/zendesk_apps_support/app_version.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module ZendeskAppsSupport
   # At any point in time, we support up to four versions:
   #  * deprecated -- we will still serve apps targeting the deprecated version,

data/lib/zendesk_apps_support/build_translation.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module ZendeskAppsSupport
   module BuildTranslation
     I18N_TITLE_KEY = 'title'

data/lib/zendesk_apps_support/engine.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 if Object.const_defined?(:Rails) && Rails.const_defined?(:Engine)
 
   module ZendeskAppsSupport

data/lib/zendesk_apps_support/finders.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module ZendeskAppsSupport
   module Finders
     class RecordNotFound < StandardError

data/lib/zendesk_apps_support/i18n.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module ZendeskAppsSupport
   module I18n
     class << self

data/lib/zendesk_apps_support/installation.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module ZendeskAppsSupport
   class Installation
     attr_accessor :id, :app_id, :app_name, :requirements, :settings, :enabled, :collapsible, :updated_at, :created_at

data/lib/zendesk_apps_support/installed.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'erubis'
 
 module ZendeskAppsSupport

data/lib/zendesk_apps_support/location.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module ZendeskAppsSupport
   class Location
     extend ZendeskAppsSupport::Finders

data/lib/zendesk_apps_support/manifest.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module ZendeskAppsSupport
   class Manifest
     LEGACY_URI_STUB = '_legacy'
@@ -82,7 +83,7 @@ module ZendeskAppsSupport
         noTemplate: no_template_locations,
         singleInstall: single_install?,
         signedUrls: signed_urls?
-      }.select { |_k, v| !v.nil? }
+      }.reject { |_k, v| v.nil? }
     end
 
     def unknown_locations(host)

data/lib/zendesk_apps_support/manifest/location_options.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module ZendeskAppsSupport
   class Manifest
     class LocationOptions

data/lib/zendesk_apps_support/manifest/no_override_hash.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module ZendeskAppsSupport
   class Manifest
     class OverrideError < StandardError

data/lib/zendesk_apps_support/manifest/parameter.rb

@@ -1,9 +1,10 @@
 # frozen_string_literal: true
+
 module ZendeskAppsSupport
   class Manifest
     class Parameter
-      TYPES = %w(text password checkbox url number multiline hidden).freeze
-      ATTRIBUTES = %i(name type required secure default).freeze
+      TYPES = %w[text password checkbox url number multiline hidden].freeze
+      ATTRIBUTES = %i[name type required secure default].freeze
       attr_reader(*ATTRIBUTES)
       def default?
         @has_default

data/lib/zendesk_apps_support/package.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'pathname'
 require 'erubis'
 require 'json'
@@ -15,7 +16,7 @@ module ZendeskAppsSupport
     DEFAULT_SCSS   = File.read(File.expand_path('../assets/default_styles.scss', __FILE__))
     SRC_TEMPLATE   = Erubis::Eruby.new(File.read(File.expand_path('../assets/src.js.erb', __FILE__)))
 
-    LOCATIONS_WITH_ICONS = %w(top_bar nav_bar system_top_bar ticket_editor).freeze
+    LOCATIONS_WITH_ICONS = %w[top_bar nav_bar system_top_bar ticket_editor].freeze
 
     attr_reader :lib_root, :root, :warnings
 
@@ -326,7 +327,7 @@ module ZendeskAppsSupport
       {
         'inactive' => inactive_png
       }.tap do |icon_state_hash|
-        %w(active hover).each do |state|
+        %w[active hover].each do |state|
           specific_png = "#{product_directory}icon_#{location}_#{state}.png"
           selected_png = has_file?("assets/#{specific_png}") ? specific_png : inactive_png
           icon_state_hash[state] = selected_png

data/lib/zendesk_apps_support/product.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module ZendeskAppsSupport
   class Product
     extend ZendeskAppsSupport::Finders

data/lib/zendesk_apps_support/sass_functions.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'sass'
 
 module Sass::Script::Functions

data/lib/zendesk_apps_support/stylesheet_compiler.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'sass'
 require 'sassc'
 require 'zendesk_apps_support/sass_functions'

data/lib/zendesk_apps_support/validations/banner.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'image_size'
 
 module ZendeskAppsSupport

data/lib/zendesk_apps_support/validations/manifest.rb

@@ -1,13 +1,14 @@
 # rubocop:disable ModuleLength
 # frozen_string_literal: true
+
 require 'uri'
 
 module ZendeskAppsSupport
   module Validations
     module Manifest
       RUBY_TO_JSON = ZendeskAppsSupport::Manifest::RUBY_TO_JSON
-      REQUIRED_MANIFEST_FIELDS = RUBY_TO_JSON.select { |k| %i(author default_locale).include? k }.freeze
-      OAUTH_REQUIRED_FIELDS = %w(client_id client_secret authorize_uri access_token_uri).freeze
+      REQUIRED_MANIFEST_FIELDS = RUBY_TO_JSON.select { |k| %i[author default_locale].include? k }.freeze
+      OAUTH_REQUIRED_FIELDS = %w[client_id client_secret authorize_uri access_token_uri].freeze
       PARAMETER_TYPES = ZendeskAppsSupport::Manifest::Parameter::TYPES
 
       class << self
@@ -21,7 +22,6 @@ module ZendeskAppsSupport
           end
 
           collate_manifest_errors(package)
-
         rescue JSON::ParserError => e
           return [ValidationError.new(:manifest_not_json, errors: e)]
         rescue ZendeskAppsSupport::Manifest::OverrideError => e
@@ -94,20 +94,20 @@ module ZendeskAppsSupport
         end
 
         def string_error(manifest)
-          manifest_strings = %i(
+          manifest_strings = %i[
             default_locale
             version
             framework_version
             remote_installation_url
             terms_conditions_url
             google_analytics_code
-          )
+          ]
           errors = manifest_strings.map do |field|
             validate_string(manifest.public_send(field), field)
           end
 
           if manifest.author
-            author_strings = %w(name email url)
+            author_strings = %w[name email url]
             errors << (author_strings.map do |field|
               validate_string(manifest.author[field], "author #{field}")
             end)
@@ -116,7 +116,7 @@ module ZendeskAppsSupport
         end
 
         def boolean_error(manifest)
-          booleans = %i(requirements_only marketing_only single_install signed_urls private)
+          booleans = %i[requirements_only marketing_only single_install signed_urls private]
           errors = []
           RUBY_TO_JSON.each do |ruby, json|
             if booleans.include? ruby

data/lib/zendesk_apps_support/validations/marketplace.rb

@@ -1,8 +1,9 @@
 # frozen_string_literal: true
+
 module ZendeskAppsSupport
   module Validations
     module Marketplace
-      WHITELISTED_EXPERIMENTS = %w(hashParams newCssCompiler).freeze
+      WHITELISTED_EXPERIMENTS = %w[hashParams newCssCompiler].freeze
 
       class << self
         def call(package)

data/lib/zendesk_apps_support/validations/requirements.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module ZendeskAppsSupport
   module Validations
     module Requirements

data/lib/zendesk_apps_support/validations/source.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'jshintrb'
 
 module ZendeskAppsSupport
@@ -15,8 +16,8 @@ module ZendeskAppsSupport
         sub: true,
 
         # predefined globals:
-        predef: %w(_ console services helpers alert confirm self
-                   JSON Base64 require module exports moment),
+        predef: %w[_ console services helpers alert confirm self
+                   JSON Base64 require module exports moment],
 
         browser: true
       }.freeze

data/lib/zendesk_apps_support/validations/stylesheets.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'zendesk_apps_support/stylesheet_compiler'
 
 module ZendeskAppsSupport

data/lib/zendesk_apps_support/validations/svg.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'loofah'
 
 module ZendeskAppsSupport

data/lib/zendesk_apps_support/validations/templates.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module ZendeskAppsSupport
   module Validations
     module Templates

data/lib/zendesk_apps_support/validations/translations.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'jshintrb'
 require 'json'
 
@@ -135,7 +136,7 @@ module ZendeskAppsSupport
         end
 
         def get_missing_keys(package, keys)
-          public_app_keys = %w(name short_description installation_instructions long_description)
+          public_app_keys = %w[name short_description installation_instructions long_description]
           mandatory_keys = package.manifest.private? ? ['name'] : public_app_keys
 
           # since we support description as well as short_description for backwards compatibility,

data/lib/zendesk_apps_support/validations/validation_error.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'json'
 
 module ZendeskAppsSupport

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: zendesk_apps_support
 version: !ruby/object:Gem::Version
-  version: 4.10.0
+  version: 4.11.0
 platform: ruby
 authors:
 - James A. Rosen
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-03-14 00:00:00.000000000 Z
+date: 2018-04-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: i18n
@@ -115,30 +115,30 @@ dependencies:
   name: loofah
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 2.2.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 2.2.1
 - !ruby/object:Gem::Dependency
   name: nokogiri
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.6.8
+        version: 1.8.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.6.8
+        version: 1.8.1
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -187,14 +187,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.46.0
+        version: 0.49.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.46.0
+        version: 0.49.0
 - !ruby/object:Gem::Dependency
   name: byebug
   requirement: !ruby/object:Gem::Requirement
@@ -274,7 +274,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: 1.3.6
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.7.6
+rubygems_version: 2.6.8
 signing_key: 
 specification_version: 4
 summary: Support to help you develop Zendesk Apps.