zendesk_apps_support 3.1.3 → 3.1.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0109ce4105d60dea50f5b3a1fd4ef1be8f846f97
-  data.tar.gz: ed2fbeaef6580326d51ffe0168f509962b3a3353
+  metadata.gz: 0135f4e989070c7aed5d46bfeea4b70d6b8db5cd
+  data.tar.gz: 9f0f660725a7a3d29e0c55472276c23e8767505d
 SHA512:
-  metadata.gz: 8c9adc260e3f74ae811b728a05988a42c81542c96bbb1c004f524b61d99f9cac393bb3ce1bf9660b167e0042e79fdc3e0c7648587cc5b84adbc1d1ea754736b4
-  data.tar.gz: 69aa0c73c61277e9d2816cd39884fbf0f5435c3736b49f92d67c19f877a44487c83b60f6b13bc45b3b5bfab0a987396cb5da1dd0b77bc54e5aeb257ba181634f
+  metadata.gz: c82edf95d8a62192e522af3dd43dc33ba2c1ac5fdc78d38b3256166b58d0dbc51772bb3321c7b98664c740fb64a0b90037b00af4d8cf859c1f40f1eab1af923e
+  data.tar.gz: 83b3fc838adeb1c6203405c6fd41fd76777d764b3ee7d40603bc0edc75a22b9e8732d4f07dff6629d38694ed702b9ed1cdaeb266e29b4488aec8e515f8cb1039

data/config/locales/translations/zendesk_apps_support.yml

@@ -46,7 +46,7 @@ parts:
       value: "Symlinks are not allowed in the zip file"
   - translation:
       key: "txt.apps.admin.error.app_build.invalid_experiment"
-      title: "App builder job: experiment has been specifed that is not publically available or otherwise invalid"
+      title: "App builder job: an experiment has been specifed that is not publically available or otherwise invalid. https://en.wikipedia.org/wiki/Manifest_file"
       value: "Manifest specifies unknown or unavailable experiment: %{experiment}"
   - translation:
       key: "txt.apps.admin.error.app_build.missing_requirements"

data/lib/zendesk_apps_support/assets/src.js.erb

@@ -19,6 +19,7 @@ var app = ZendeskApps.defineApp(<%= iframe_only ? 'null' : 'source' %>)
   .reopen({
     appName: <%= name.to_json %>,
     appVersion: <%= version.to_json %>,
+    locationIcons: <%= location_icons.to_json %>,
     assetUrlPrefix: <%= asset_url_prefix.to_json %>,
     appClassName: <%= app_class_name.to_json %>,
     author: {

data/lib/zendesk_apps_support/location.rb

@@ -3,8 +3,14 @@ module ZendeskAppsSupport
     extend ZendeskAppsSupport::Finders
     attr_reader :id, :name, :orderable, :product_code
 
+    def self.unique_ids
+      @ids ||= Set.new
+    end
+
     def initialize(attrs)
       @id = attrs.fetch(:id)
+      raise 'Duplicate id' if Location.unique_ids.include? @id
+      Location.unique_ids.add @id
       @name = attrs.fetch(:name)
       @orderable = attrs.fetch(:orderable)
       @product_code = attrs.fetch(:product_code)
@@ -27,7 +33,8 @@ module ZendeskAppsSupport
       Location.new(id: 5, orderable: true, name: 'user_sidebar', product_code: Product::SUPPORT.code),
       Location.new(id: 6, orderable: true, name: 'organization_sidebar', product_code: Product::SUPPORT.code),
       Location.new(id: 7, orderable: false, name: 'background', product_code: Product::SUPPORT.code),
-      Location.new(id: 8, orderable: true, name: 'chat_sidebar', product_code: Product::CHAT.code)
+      Location.new(id: 8, orderable: true, name: 'chat_sidebar', product_code: Product::CHAT.code),
+      Location.new(id: 9, orderable: false, name: 'modal', product_code: Product::SUPPORT.code)
     ].freeze
   end
 end

data/lib/zendesk_apps_support/manifest.rb

@@ -68,7 +68,7 @@ module ZendeskAppsSupport
     end
 
     def enabled_experiments
-      (experiments || {}).select { |k, v| v }.keys
+      (experiments || {}).select { |_k, v| v }.keys
     end
 
     def initialize(manifest_text)

data/lib/zendesk_apps_support/package.rb

@@ -15,6 +15,8 @@ module ZendeskAppsSupport
     DEFAULT_SCSS   = File.read(File.expand_path('../assets/default_styles.scss', __FILE__))
     SRC_TEMPLATE   = Erubis::Eruby.new(File.read(File.expand_path('../assets/src.js.erb', __FILE__)))
 
+    LOCATIONS_WITH_ICONS = ['top_bar', 'nav_bar']
+
     attr_reader :lib_root, :root, :warnings
 
     def initialize(dir, is_cached = true)
@@ -131,6 +133,7 @@ module ZendeskAppsSupport
         source: source,
         app_settings: app_settings,
         asset_url_prefix: asset_url_prefix,
+        location_icons: location_icons,
         app_class_name: app_class_name,
         author: manifest.author,
         translations: runtime_translations(translations_for(locale)),
@@ -278,6 +281,30 @@ module ZendeskAppsSupport
       read_file('app.js')
     end
 
+    def location_icons
+      {}.tap do |location_icons|
+        manifest.locations.each do |host, locations_for_host|
+          next unless [Product::SUPPORT.name].include?(host)
+
+          locations_for_host.keys.each do |location|
+            next unless LOCATIONS_WITH_ICONS.include?(location)
+            location_icons[host] ||= {}
+            location_icons[host][location] = if (has_file?("assets/icon_#{location}.svg"))
+              { 'svg' => "icon_#{location}.svg" }
+            elsif (has_file?("assets/icon_#{location}_inactive.png"))
+              {
+                'inactive' => "icon_#{location}_inactive.png",
+                'active' => has_file?("assets/icon_#{location}_active.png") ? "icon_#{location}_active.png" : "icon_#{location}_inactive.png",
+                'hover' => has_file?("assets/icon_#{location}_hover.png") ? "icon_#{location}_hover.png" : "icon_#{location}_inactive.png"
+              }
+            else
+              {}
+            end
+          end
+        end
+      end
+    end
+
     def commonjs_modules
       return {} unless has_lib_js?
 

data/lib/zendesk_apps_support/validations/marketplace.rb

@@ -1,7 +1,8 @@
+# frozen_string_literal: true
 module ZendeskAppsSupport
   module Validations
     module Marketplace
-      WHITELISTED_EXPERIMENTS = [].freeze
+      WHITELISTED_EXPERIMENTS = ['hashParams'].freeze
 
       class << self
         def call(package)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: zendesk_apps_support
 version: !ruby/object:Gem::Version
-  version: 3.1.3
+  version: 3.1.4
 platform: ruby
 authors:
 - James A. Rosen
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-10-19 00:00:00.000000000 Z
+date: 2016-10-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: i18n