zendesk_apps_support 3.1.2 → 3.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 17e0397eb9e955f39c20172e468c5c802c16e6b9
-  data.tar.gz: 729794611cb19c2ad235ef74edcdb57b8d10cea3
+  metadata.gz: 0109ce4105d60dea50f5b3a1fd4ef1be8f846f97
+  data.tar.gz: ed2fbeaef6580326d51ffe0168f509962b3a3353
 SHA512:
-  metadata.gz: 31db6f1d415c359436fda55684f6040bc5187b6700814f63398bcfa6f6f912dc329f63cb2b5628eb186b7a1abea085d11b4e7e28cc68d55381608c6b1be2e55e
-  data.tar.gz: 855a7bd5ae36894856819ebed680ce64d5628b54da9ec6fae5873eae20a7537fdea6851e5e22ca254e470604e75fb06e74c29d4a34a9326661198d2b1c59cb86
+  metadata.gz: 8c9adc260e3f74ae811b728a05988a42c81542c96bbb1c004f524b61d99f9cac393bb3ce1bf9660b167e0042e79fdc3e0c7648587cc5b84adbc1d1ea754736b4
+  data.tar.gz: 69aa0c73c61277e9d2816cd39884fbf0f5435c3736b49f92d67c19f877a44487c83b60f6b13bc45b3b5bfab0a987396cb5da1dd0b77bc54e5aeb257ba181634f

data/config/locales/en.yml

@@ -20,6 +20,8 @@ en:
             manifest_not_json: manifest is not proper JSON. %{errors}
             missing_manifest: Could not find manifest.json
             symlink_in_zip: Symlinks are not allowed in the zip file
+            invalid_experiment: 'Manifest specifies unknown or unavailable experiment:
+              %{experiment}'
             missing_requirements: Could not find requirements.json
             requirements_not_supported: App requirements are not supported for marketing-only
               apps
@@ -53,7 +55,7 @@ en:
               not allowed when an iframe URI or noTemplate is specified
             invalid_default_locale: "%{default_locale} is not a valid default locale."
             missing_translation_file: 'Missing translation file for locale ''%{default_locale}''.
-              Please read: http://developer.zendesk.com/documentation/apps/i18n.html'
+              Learn more: http://developer.zendesk.com/documentation/apps/i18n.html'
             invalid_host: "%{host_name} is an invalid host for apps."
             invalid_location:
               one: "%{invalid_locations} is an invalid location in %{host_name}."
@@ -81,7 +83,7 @@ en:
             invalid_type_parameter:
               one: "%{invalid_types} is an invalid parameter type."
               other: "%{invalid_types} are invalid parameter types."
-            unacceptable_boolean: '%{field} must be a Boolean value, got "%{value}"'
+            unacceptable_boolean: '%{field} must be a boolean value, got "%{value}".'
             invalid_no_template: noTemplate must be set to true, false, or an array
               of valid locations.
             duplicate_reference: 'Duplicate reference in manifest: "%{key}".'

data/config/locales/translations/zendesk_apps_support.yml

@@ -44,6 +44,10 @@ parts:
       key: "txt.apps.admin.error.app_build.symlink_in_zip"
       title: "App builder job: symlinks not allowed. https://en.wikipedia.org/wiki/Symbolic_link"
       value: "Symlinks are not allowed in the zip file"
+  - translation:
+      key: "txt.apps.admin.error.app_build.invalid_experiment"
+      title: "App builder job: experiment has been specifed that is not publically available or otherwise invalid"
+      value: "Manifest specifies unknown or unavailable experiment: %{experiment}"
   - translation:
       key: "txt.apps.admin.error.app_build.missing_requirements"
       title: "App builder job: missing requirements error"
@@ -127,7 +131,7 @@ parts:
   - translation:
       key: "txt.apps.admin.error.app_build.missing_translation_file"
       title: "App builder job: missing translation file"
-      value: "Missing translation file for locale '%{default_locale}'. Please read: http://developer.zendesk.com/documentation/apps/i18n.html"
+      value: "Missing translation file for locale '%{default_locale}'. Learn more: http://developer.zendesk.com/documentation/apps/i18n.html"
   - translation:
       key: "txt.apps.admin.error.app_build.invalid_host"
       title: "App builder job: invalid host application for apps"
@@ -214,8 +218,8 @@ parts:
       value: "%{invalid_types} are invalid parameter types."
   - translation:
       key: "txt.apps.admin.error.app_build.unacceptable_boolean"
-      title: "App builder job: this value needs to be either true or false, but something else was passed in"
-      value: "%{field} must be a Boolean value, got \"%{value}\""
+      title: "App builder job: this value needs to be either true or false, but something else was passed in. placeholder value is taken from user input. You can translate as: The value %{field} must be a Boolean... to avoid any gender issues."
+      value: "%{field} must be a boolean value, got \"%{value}\"."
   - translation:
       key: "txt.apps.admin.error.app_build.invalid_no_template"
       title: "App builder job: `noTemplate` needs to be true, false or a valid array, but something else was passed in. noTemplate, true, and false should not be translated."

data/lib/zendesk_apps_support/manifest.rb

@@ -8,6 +8,7 @@ module ZendeskAppsSupport
       marketing_only: 'marketingOnly',
       version: 'version',
       author: 'author',
+      experiments: 'experiments',
       framework_version: 'frameworkVersion',
       single_install: 'singleInstall',
       signed_urls: 'signedUrls',
@@ -66,6 +67,10 @@ module ZendeskAppsSupport
       end
     end
 
+    def enabled_experiments
+      (experiments || {}).select { |k, v| v }.keys
+    end
+
     def initialize(manifest_text)
       m = parse_json(manifest_text)
       RUBY_TO_JSON.each do |ruby, json|
@@ -77,6 +82,7 @@ module ZendeskAppsSupport
       @private = m.fetch('private', true)
       @signed_urls ||= false
       @no_template ||= false
+      @experiments ||= {}
       set_locations_and_hosts
     end
 

data/lib/zendesk_apps_support/package.rb

@@ -27,10 +27,9 @@ module ZendeskAppsSupport
 
     def validate(marketplace: true)
       [].tap do |errors|
-        errors << Validations::Marketplace.call(self) if marketplace
-
         errors << Validations::Manifest.call(self)
         if has_manifest?
+          errors << Validations::Marketplace.call(self) if marketplace
           errors << Validations::Source.call(self)
           errors << Validations::Translations.call(self)
           errors << Validations::Requirements.call(self)
@@ -119,6 +118,7 @@ module ZendeskAppsSupport
       templates = manifest.no_template == true ? {} : compiled_templates(app_id, asset_url_prefix)
 
       app_settings = {
+        experiments: manifest.experiments,
         location: manifest.locations,
         noTemplate: manifest.no_template_locations,
         singleInstall: manifest.single_install?,

data/lib/zendesk_apps_support/validations/marketplace.rb

@@ -1,9 +1,11 @@
 module ZendeskAppsSupport
   module Validations
     module Marketplace
+      WHITELISTED_EXPERIMENTS = [].freeze
+
       class << self
         def call(package)
-          [no_symlinks(package.root)].compact
+          [no_symlinks(package.root), *no_experiments(package.manifest)].compact
         end
 
         private
@@ -14,6 +16,13 @@ module ZendeskAppsSupport
           end
           nil
         end
+
+        def no_experiments(manifest)
+          invalid_experiments = manifest.enabled_experiments - WHITELISTED_EXPERIMENTS
+          invalid_experiments.map do |experiment|
+            ValidationError.new(:invalid_experiment, experiment: experiment)
+          end
+        end
       end
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: zendesk_apps_support
 version: !ruby/object:Gem::Version
-  version: 3.1.2
+  version: 3.1.3
 platform: ruby
 authors:
 - James A. Rosen
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-09-05 00:00:00.000000000 Z
+date: 2016-10-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: i18n
@@ -201,7 +201,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: 1.3.6
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.6.4
 signing_key: 
 specification_version: 4
 summary: Support to help you develop Zendesk Apps.