zendesk_apps_support 1.21.1 → 1.22.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 91d3d7ff3563b2673d0ac16aeb4d8f94d1696d65
-  data.tar.gz: 3c7cd223b4acc89de257981cd90dc91a157e1c1e
+  metadata.gz: 4a06daa0f4459f305a6b215168a11d06d304cf8d
+  data.tar.gz: a35c8073b293511472db0053f8475961277cf45b
 SHA512:
-  metadata.gz: 6abcdd6d959a301a4059b0b1886caa09ffad15fb1b6ba5cad499e0f0ef247a40ff183818dc96da71f1f938f6d0f37c8bd0e05d386fa752b6bed9e3f9b94b4c56
-  data.tar.gz: 40489d6183b4209fd4a80993afd844a43351f658c8ef8c7cc63c6e958862c0c927533d8614e723830a2ae9d0d9fd2d93e0f13604c01db830087c8fb4fb1ac5c4
+  metadata.gz: bc8ec88d0bd509aeab9e4d6a66e4a85a510a28fb8bf45db7826a50c34a554ed5f63c76f1c07ae64c36a1441191ada7b98a1f87a044ae5c002d1d30e0ab80b1e8
+  data.tar.gz: 7aeaa373044becb9409257a27016c4af59107893975f6ed8a14200894607fc6f03747cba5c10fceaea05ba54f3800fbecec8a5c5727b6073c70b877eb72699f4

data/lib/zendesk_apps_support.rb

@@ -5,6 +5,7 @@ module ZendeskAppsSupport
   autoload :AppFile,                'zendesk_apps_support/app_file'
   autoload :BuildTranslation,       'zendesk_apps_support/build_translation'
   autoload :I18n,                   'zendesk_apps_support/i18n'
+  autoload :Location,               'zendesk_apps_support/location'
   autoload :Package,                'zendesk_apps_support/package'
   autoload :Installed,              'zendesk_apps_support/installed'
   autoload :Installation,           'zendesk_apps_support/installation'

data/lib/zendesk_apps_support/location.rb

@@ -0,0 +1,29 @@
+module ZendeskAppsSupport
+  module Location
+    # the numbers below match the enum values on the database, do not change them!
+    LOCATIONS_AVAILABLE = {
+      "zendesk" => {
+        "top_bar" => 1,
+        "nav_bar" => 2,
+        "ticket_sidebar" => 3,
+        "new_ticket_sidebar" => 4,
+        "user_sidebar" => 5,
+        "organization_sidebar" => 6,
+        "background" => 7
+      },
+      "zopim" => {
+        "chat_sidebar" => 8
+      }
+    }.freeze
+
+    class << self
+      def hosts
+        LOCATIONS_AVAILABLE.keys
+      end
+
+      def names_for(host: host)
+        LOCATIONS_AVAILABLE[host.to_s].keys
+      end
+    end
+  end
+end

data/lib/zendesk_apps_support/validations/manifest.rb

@@ -6,10 +6,6 @@ module ZendeskAppsSupport
       REQUIRED_MANIFEST_FIELDS = %w( author defaultLocale ).freeze
       OAUTH_REQUIRED_FIELDS    = %w( client_id client_secret authorize_uri access_token_uri ).freeze
       TYPES_AVAILABLE          = %w( text password checkbox url number multiline hidden ).freeze
-      LOCATIONS_AVAILABLE      = {
-        'zendesk' => %w( top_bar nav_bar ticket_sidebar new_ticket_sidebar user_sidebar organization_sidebar background ),
-        'zopim' => %w( chat_sidebar )
-      }.freeze
 
       class <<self
         def call(package)
@@ -107,9 +103,9 @@ module ZendeskAppsSupport
         def invalid_location_error(manifest)
           manifest_location = manifest['location'].is_a?(Hash) ? manifest['location'] : { 'zendesk' => [*manifest['location']] }
           manifest_location.find do |host, locations|
-            error = if !LOCATIONS_AVAILABLE.keys.include?(host)
+            error = if !Location.hosts.include?(host)
               ValidationError.new(:invalid_host, host_name: host)
-            elsif (invalid_locations = locations - LOCATIONS_AVAILABLE[host]).any?
+            elsif (invalid_locations = locations - Location.names_for(host: host)).any?
               ValidationError.new(:invalid_location, invalid_locations: invalid_locations.join(', '), host_name: host, count: invalid_locations.length)
             end
             break error if error

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: zendesk_apps_support
 version: !ruby/object:Gem::Version
-  version: 1.21.1
+  version: 1.22.0
 platform: ruby
 authors:
 - James A. Rosen
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-01-07 00:00:00.000000000 Z
+date: 2016-01-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: i18n
@@ -163,6 +163,7 @@ files:
 - lib/zendesk_apps_support/i18n.rb
 - lib/zendesk_apps_support/installation.rb
 - lib/zendesk_apps_support/installed.rb
+- lib/zendesk_apps_support/location.rb
 - lib/zendesk_apps_support/package.rb
 - lib/zendesk_apps_support/sass_functions.rb
 - lib/zendesk_apps_support/stylesheet_compiler.rb
@@ -200,3 +201,4 @@ signing_key:
 specification_version: 4
 summary: Support to help you develop Zendesk Apps.
 test_files: []
+has_rdoc: