zendesk_apps_support 1.20.0 → 1.21.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 21a2a6da05c4d89d23d1322dfd5f279c3191381b
-  data.tar.gz: 3f48e22275d82ea5b2c4ecd444e4a362d81f4943
+  metadata.gz: 009359f73088ae44d54a08f53abd893b3a04ef91
+  data.tar.gz: 2e92ee8a0f9553c70176fcf9b456e0eb4043d982
 SHA512:
-  metadata.gz: 7fd547a41b3f5210d912bab54c0564747552fd0d03b787e7482c97257534199fb34367166edfc6e58e7000be07f65bc18b54bcef47c0f8a36b8add12f4916041
-  data.tar.gz: ac53d9ddc31416ed8f7381554c1efe5f50e10032c73c0ab7f91f6add6cf982232ac17802be5bac1175c48230e4a3cf7b670794ee2ac3ca3a3508ccb8fc891afe
+  metadata.gz: 8d68dd79073e10cb6924c7c857d63b839c19b75a2d5bc58b8f70c0afa3129ef366de1ee8cfebcd9fdc603165d76a82c41f92b3b5128e56f30ed339020b24e6d3
+  data.tar.gz: f010c99af6e8f772088e0488f73e2e80fcac0034882a8d0ac64a81765aa3d996dc4d3e7be19c4f3b13863af188613ebbe36db80885a3f457b02d294b3d28b71f

data/config/locales/translations/zendesk_apps_support.yml

@@ -37,7 +37,7 @@ parts:
       value: "Could not find manifest.json"
   - translation:
       key: "txt.apps.admin.error.app_build.symlink_in_zip"
-      title: "App builder job: symlinks not allowed"
+      title: "App builder job: symlinks not allowed. https://en.wikipedia.org/wiki/Symbolic_link"
       value: "Symlinks are not allowed in the zip file"
   - translation:
       key: "txt.apps.admin.error.app_build.missing_requirements"

data/lib/zendesk_apps_support/package.rb

@@ -77,11 +77,22 @@ module ZendeskAppsSupport
     end
 
     def files
-      non_tmp_files
+      files = []
+      Dir[root.join('**/**')].each do |f|
+        next unless File.file?(f)
+        relative_file_name = f.sub(/#{root}\/?/, '')
+        next if relative_file_name =~ /^tmp\//
+        files << AppFile.new(self, relative_file_name)
+      end
+      files
+    end
+
+    def js_files
+      @js_files ||= files.select { |f| f =~ /\.js$/ }
     end
 
     def lib_files
-      @lib_files ||= non_tmp_files.select { |f| f =~ /^lib\/.*\.js$/ }
+      @lib_files ||= js_files.select { |f| f =~ /^lib\// }
     end
 
     def template_files
@@ -89,7 +100,7 @@ module ZendeskAppsSupport
     end
 
     def translation_files
-      non_tmp_files.select { |f| f =~ /^translations\// }
+      files.select { |f| f =~ /^translations\// }
     end
 
     def compile_js(options)
@@ -259,17 +270,6 @@ module ZendeskAppsSupport
       read_file('app.js')
     end
 
-    def non_tmp_files
-      files = []
-      Dir[root.join('**/**')].each do |f|
-        next unless File.file?(f)
-        relative_file_name = f.sub(/#{root}\/?/, '')
-        next if relative_file_name =~ /^tmp\//
-        files << AppFile.new(self, relative_file_name)
-      end
-      files
-    end
-
     def commonjs_modules
       return {} unless has_lib_js?
 

data/lib/zendesk_apps_support/validations/manifest.rb

@@ -7,7 +7,7 @@ module ZendeskAppsSupport
       OAUTH_REQUIRED_FIELDS    = %w( client_id client_secret authorize_uri access_token_uri ).freeze
       TYPES_AVAILABLE          = %w( text password checkbox url number multiline hidden ).freeze
       LOCATIONS_AVAILABLE      = {
-        'zendesk' => %w( top_bar nav_bar ticket_sidebar new_ticket_sidebar user_sidebar organization_sidebar ),
+        'zendesk' => %w( top_bar nav_bar ticket_sidebar new_ticket_sidebar user_sidebar organization_sidebar background ),
         'zopim' => %w( chat_sidebar )
       }.freeze
 

data/lib/zendesk_apps_support/validations/source.rb

@@ -16,13 +16,15 @@ module ZendeskAppsSupport
         # predefined globals:
         predef: %w(_ console services helpers alert confirm window document self
                    JSON Base64 clearInterval clearTimeout setInterval setTimeout
-                   require module exports top frames parent moment)
+                   require module exports top frames parent moment),
+
+        browser: true
       }.freeze
 
       class <<self
         def call(package)
-          app   = package.files.find { |file| file.relative_path == 'app.js' }
-          files = package.lib_files << app
+          files = package.js_files
+          app   = files.find { |file| file.relative_path == 'app.js' }
 
           if package.manifest_json['requirementsOnly']
             return app ? [ValidationError.new(:no_app_js_required)] : []

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: zendesk_apps_support
 version: !ruby/object:Gem::Version
-  version: 1.20.0
+  version: 1.21.0
 platform: ruby
 authors:
 - James A. Rosen
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-11-27 00:00:00.000000000 Z
+date: 2015-12-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: i18n
@@ -195,7 +195,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: 1.3.6
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.4.5.1
 signing_key: 
 specification_version: 4
 summary: Support to help you develop Zendesk Apps.