zendesk_apps_support 1.13.3 → 1.14.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 58ceec0aaae39626d6beea11fec546292b8bc189
-  data.tar.gz: ab381ae71f046c859a30f4d69ab4a7461dfbdb9b
+  metadata.gz: 679199783462b55a07e745d2426f36f2e7aac214
+  data.tar.gz: 1430e6af569e94e4cb825ccd06ad73b628866b50
 SHA512:
-  metadata.gz: c17c0fc787ef6e3031f6b5328b1604ce5e1fd564ad175add7289e099560bde444516d3283bb87e58be3fe67cbb3795873d3de2998b565b5facc17e931e98ecf1
-  data.tar.gz: 493cd4ff0ed9a17cfd625d905e77fff4a86baa98772fc70f0baaabc9a5930d539f1ecd2911d69b3648f26937038af94aeb8a274533653b146e2017330772a289
+  metadata.gz: ad83e9e61ceff49f753f4d4977fd7a4d827306a5da652940c4a437b1215bfadc3b11a47848a53d5c3bf8b4a6ea47a22731147d091cc31ef0fdf474b2b584cd81
+  data.tar.gz: 44ea8771a24edf318259e22b4c5af7313ef134cbfb52a1220ebe1e852db5ec8b1c2c0ee5d118fa1b48148896f55343e91c0e3a4ea601d66509ee25a134672fff

data/config/locales/en.yml

@@ -10,6 +10,11 @@ en:
               one: 'JSHint error in %{file}: %{errors}'
               other: 'JSHint errors in %{file}: %{errors}'
             missing_location_and_requirements: Missing app location or requirements
+            no_location_required: Having location defined while requirements only
+              is true
+            no_framework_version_required: Having framework version defined while
+              requirements only is true
+            no_app_js_required: Having app.js present while requirements only is true
             manifest_not_json: manifest is not proper JSON. %{errors}
             missing_manifest: Could not find manifest.json
             missing_requirements: Could not find requirements.json

data/config/locales/translations/zendesk_apps_support.yml

@@ -20,6 +20,18 @@ parts:
       key: "txt.apps.admin.error.app_build.missing_location_and_requirements"
       title: "App builder job: missing location and requirements error"
       value: "Missing app location or requirements"
+  - translation:
+      key: "txt.apps.admin.error.app_build.no_location_required"
+      title: "App builder job: ban location while requirements only"
+      value: "Having location defined while requirements only is true"
+  - translation:
+      key: "txt.apps.admin.error.app_build.no_framework_version_required"
+      title: "App builder job: ban framework version while requirements only"
+      value: "Having framework version defined while requirements only is true"
+  - translation:
+      key: "txt.apps.admin.error.app_build.no_app_js_required"
+      title: "App builder job: ban app.js while requirements only"
+      value: "Having app.js present while requirements only is true"
   - translation:
       key: "txt.apps.admin.error.app_build.manifest_not_json"
       title: "App builder job: manifest is invalid JSON error"

data/lib/zendesk_apps_support/package.rb

@@ -11,10 +11,12 @@ module ZendeskAppsSupport
     SRC_TEMPLATE   = Erubis::Eruby.new( File.read(File.expand_path('../assets/src.js.erb', __FILE__)) )
 
     attr_reader :root, :warnings
+    attr_accessor :requirements_only
 
     def initialize(dir)
       @root = Pathname.new(File.expand_path(dir))
       @warnings = []
+      @requirements_only = false
     end
 
     def validate
@@ -26,8 +28,9 @@ module ZendeskAppsSupport
           errors << Validations::Package.call(self)
           errors << Validations::Translations.call(self)
 
-          if has_js?
-            errors << Validations::Source.call(self)
+          errors << Validations::Source.call(self)
+
+          unless @requirements_only
             errors << Validations::Templates.call(self)
             errors << Validations::Stylesheets.call(self)
           end
@@ -117,10 +120,6 @@ module ZendeskAppsSupport
       file_exists?("requirements.json")
     end
 
-    def is_requirements_only?
-      has_requirements? && !has_location?
-    end
-
     private
 
     def compiled_templates(app_id, asset_url_prefix)

data/lib/zendesk_apps_support/validations/manifest.rb

@@ -16,6 +16,7 @@ module ZendeskAppsSupport
           return [ValidationError.new(:missing_manifest)] unless manifest
 
           manifest = MultiJson.load(manifest.read)
+
           [].tap do |errors|
             errors << missing_keys_error(manifest)
             errors << default_locale_error(manifest, package)
@@ -25,13 +26,19 @@ module ZendeskAppsSupport
             errors << invalid_type_error(manifest)
             errors << name_as_parameter_name_error(manifest)
 
-            if package.has_js?
+            if manifest['requirementsOnly']
+              package.requirements_only = true
+
+              errors << ban_location(manifest)
+              errors << ban_framework_version(manifest)
+            else
               errors << missing_location_error(package)
               errors << invalid_location_error(manifest)
               errors << duplicate_location_error(manifest)
               errors << missing_framework_version(manifest)
               errors << invalid_version_error(manifest, package)
             end
+
             errors.compact!
           end
         rescue MultiJson::DecodeError => e
@@ -40,6 +47,14 @@ module ZendeskAppsSupport
 
         private
 
+        def ban_location(manifest)
+          ValidationError.new(:no_location_required) unless manifest['location'].nil?
+        end
+
+        def ban_framework_version(manifest)
+          ValidationError.new(:no_framework_version_required) unless manifest['frameworkVersion'].nil?
+        end
+
         def oauth_error(manifest)
           return unless manifest['oauth']
 
@@ -159,8 +174,6 @@ module ZendeskAppsSupport
           end
         end
 
-        private
-
         def missing_keys_validation_error(missing_keys)
           ValidationError.new('manifest_keys.missing', :missing_keys => missing_keys.join(', '), :count => missing_keys.length)
         end

data/lib/zendesk_apps_support/validations/source.rb

@@ -21,6 +21,7 @@ module ZendeskAppsSupport
         def call(package)
           source = package.files.find { |f| f.relative_path == 'app.js' }
 
+          return [ ValidationError.new(:no_app_js_required) ] if package.requirements_only && source
           return [ ValidationError.new(:missing_source) ] unless source
 
           jshint_errors = linter.lint(source.read)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: zendesk_apps_support
 version: !ruby/object:Gem::Version
-  version: 1.13.3
+  version: 1.14.0
 platform: ruby
 authors:
 - James A. Rosen
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-02-17 00:00:00.000000000 Z
+date: 2014-02-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: i18n
@@ -190,8 +190,9 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: 1.3.6
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.2.0
 signing_key: 
 specification_version: 4
 summary: Support to help you develop Zendesk Apps.
 test_files: []
+has_rdoc: