zendesk_apps_support 1.1.1 → 1.1.2

data/config/locales/en.yml

@@ -19,6 +19,8 @@ en:
             style_in_template: <style> tag in %{template}. Use an app.css file instead.
             invalid_default_locale: ! '%{defaultLocale} is not a valid default locale.
               Only two- and three-letter ISO 639 language codes are allowed.'
+            missing_translation_file: ! 'Missing translation file for locale ''%{defaultLocale}''.
+              Please read: http://developer.zendesk.com/documentation/apps/i18n.html'
             invalid_location:
               one: ! '%{invalid_locations} in an invalid location.'
               other: ! '%{invalid_locations} are invalid locations.'

data/config/locales/translations/zendesk_apps_support.yml

@@ -43,6 +43,10 @@ parts:
       key: "txt.apps.admin.error.app_build.invalid_default_locale"
       title: "App builder job: invalid default locale"
       value: "%{defaultLocale} is not a valid default locale. Only two- and three-letter ISO 639 language codes are allowed."
+  - translation:
+      key: "txt.apps.admin.error.app_build.missing_translation_file"
+      title: "App builder job: missing translation file"
+      value: "Missing translation file for locale '%{defaultLocale}'. Please read: http://developer.zendesk.com/documentation/apps/i18n.html"
   - translation:
       key: "txt.apps.admin.error.app_build.invalid_location.one"
       title: "App builder job: invalid locations"

data/lib/zendesk_apps_support/validations/manifest.rb

@@ -5,25 +5,25 @@ module ZendeskAppsSupport
     module Manifest
 
       REQUIRED_MANIFEST_FIELDS = %w( author defaultLocale location frameworkVersion).freeze
-      LOCATIONS_AVAILABLE = %w( nav_bar ticket_sidebar new_ticket_sidebar ).freeze
+      LOCATIONS_AVAILABLE      = %w( nav_bar ticket_sidebar new_ticket_sidebar ).freeze
 
       class <<self
         def call(package)
           manifest = package.files.find { |f| f.relative_path == 'manifest.json' }
 
-          return [ ValidationError.new(:missing_manifest) ] unless manifest
+          return [ValidationError.new(:missing_manifest)] unless manifest
 
           manifest = MultiJson.load(manifest.read)
 
           [].tap do |errors|
             errors << missing_keys_error(manifest)
-            errors << default_locale_error(manifest)
+            errors << default_locale_error(manifest, package)
             errors << invalid_location_error(manifest)
             errors << invalid_hidden_parameter_error(manifest)
             errors.compact!
           end
         rescue MultiJson::DecodeError => e
-          return [ ValidationError.new(:manifest_not_json, :errors => e) ]
+          return [ValidationError.new(:manifest_not_json, :errors => e)]
         end
 
         private
@@ -38,10 +38,14 @@ module ZendeskAppsSupport
           end
         end
 
-        def default_locale_error(manifest)
+        def default_locale_error(manifest, package)
           default_locale = manifest['defaultLocale']
-          if !default_locale.nil? && default_locale !~ /^[a-z]{2,3}$/
-            ValidationError.new(:invalid_default_locale, :defaultLocale => default_locale)
+          if !default_locale.nil?
+            if default_locale !~ /^[a-z]{2,3}$/
+              ValidationError.new(:invalid_default_locale, :defaultLocale => default_locale)
+            elsif package.translation_files.detect { |file| file.relative_path == "translations/#{default_locale}.json" }.nil?
+              ValidationError.new(:missing_translation_file, :defaultLocale => default_locale)
+            end
           end
         end
 

data/spec/validations/manifest_spec.rb

@@ -29,6 +29,17 @@ describe ZendeskAppsSupport::Validations::Manifest do
     locale_error.should_not be_nil
   end
 
+  it 'should have an error when the translation file is missing for the defaultLocale' do
+    manifest = { 'defaultLocale' => 'pt' }
+    manifest_file = mock('AppFile', :relative_path => 'manifest.json', :read => JSON.dump(manifest))
+    translation_files = mock('AppFile', :relative_path => 'translations/en.json')
+    package = mock('Package', :files => [manifest_file], :translation_files => [translation_files])
+    errors = ZendeskAppsSupport::Validations::Manifest.call(package)
+
+    locale_error = errors.find { |e| e.to_s =~ /Missing translation file/ }
+    locale_error.should_not be_nil
+  end
+
   it 'should have an error when the location is invalid' do
     manifest = { 'location' => ['ticket_sidebar', 'a_invalid_location'] }
     manifest_file = mock('AppFile', :relative_path => 'manifest.json', :read => JSON.dump(manifest))

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: zendesk_apps_support
 version: !ruby/object:Gem::Version
-  version: 1.1.1
+  version: 1.1.2
   prerelease: 
 platform: ruby
 authors:
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-04-11 00:00:00.000000000 Z
+date: 2013-04-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: i18n