zendesk2 1.3.2 → 1.3.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ed5cd2b9f54357316f66656d811ef3e6718eba22
-  data.tar.gz: ea10043b0c18a118eb7a93de954c56059076e0a2
+  metadata.gz: aeacdd1baed3d95569ba4f094e5019e896802326
+  data.tar.gz: 1fa4b658c4a044099e3662b675d032825d784d87
 SHA512:
-  metadata.gz: fbfa268c8848d68edc143372334c332f96b5cd4daee18cec251404f563abb52564a4974fa0edeabab99e5e347573cb9d1c9468a213d44e1dee395268740494de
-  data.tar.gz: 7633461afdc6c38b878aa9893baf69bbad65e23ad21f37721c3b87126cf7df91839e73c222402a61fb89a75619cb26ac92c1ec0badc2217d91942b415c120be1
+  metadata.gz: bfc438e64a48e5909ab3567cb0c11ebef385955de7393b67840a870213f643e3949098dd1abbc41536b75335fb161bb0edbfa89017a9dc65436d9741a783d62d
+  data.tar.gz: 4946663f0020af266949b279c73243a16387909a89f67f4dd32049fa6c1cd81ddfe80454bf125504f4c10b3e041475f6bf3c37a63276a7ada49dbb186f03f058

data/lib/zendesk2/client/requests/create_ticket.rb

@@ -75,13 +75,14 @@ class Zendesk2::Client
       }.merge(params)
 
       record["requester_id"] ||= (requester_id && requester_id.to_s) || current_user["id"].to_s
-      requester = self.find!(:users, record["requester_id"])
-
       record["submitter_id"] = current_user["id"].to_s
 
-      if record["organization_id"] = params.delete('organization_id') || requester["organization_id"]
-        self.find!(:organizations, record["organization_id"])
-      end
+      # @note invalid requester id does NOT cause a 404 or 422
+      record["organization_id"] = if requester = self.data[:users][record["requester_id"]]
+                                    requester["organization_id"]
+                                  else
+                                    nil
+                                  end
 
       self.data[:tickets][identity] = record
 

data/lib/zendesk2/version.rb

@@ -1,3 +1,3 @@
 module Zendesk2
-  VERSION = "1.3.2"
+  VERSION = "1.3.3"
 end

data/spec/tickets_spec.rb

@@ -35,10 +35,12 @@ describe "Zendesk2::Client" do
       end
     end
 
-    it "should require a valid organization if not blank" do
-      expect {
-        client.tickets.create!(subject: mock_uuid, description: mock_uuid, organization_id: -1)
-      }.to raise_exception(Zendesk2::Error, /RecordNotFound/)
+    context 'valid requester exists' do
+      it 'sets organization id' do
+        ticket = client.tickets.create!(subject: mock_uuid, description: mock_uuid, requester_id: 11111111111199)
+
+        expect(ticket.organization_id).to be_nil
+      end
     end
 
     it "should default to the requesters primary organization if organization is not specified" do
@@ -101,7 +103,7 @@ describe "Zendesk2::Client" do
       target_comments = 2.times.map { ticket.comment(mock_uuid) }
       2.times.map { another_ticket.comment(mock_uuid) }
 
-      expect(ticket.comments.all).to match_array(target_comments)
+      expect(ticket.comments.all).to include(*target_comments) # @fixme model (subject + description) || (comment) on create_ticket as a comment
     end
   end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: zendesk2
 version: !ruby/object:Gem::Version
-  version: 1.3.2
+  version: 1.3.3
 platform: ruby
 authors:
 - Josh Lane
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-11-06 00:00:00.000000000 Z
+date: 2014-11-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: addressable