zapata 0.1.6 → 1.0.0

data/spec/hash_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+# frozen_string_literal: true
 
 describe Zapata::Revolutionist do
   before(:all) do
@@ -6,38 +6,38 @@ describe Zapata::Revolutionist do
   end
 
   it '#test_in_arg' do
-    has_block('#test_in_arg', %Q{
+    has_block('#test_in_arg', %{
       expect(test_hash.test_in_arg({ 1 => :one, TestHash => 2.718 })).to eq({ 1 => :one, TestHash => 2.718 })
     })
   end
 
   it '#test_nested_one_level' do
-    has_block('#test_nested_one_level', %Q{
+    has_block('#test_nested_one_level', %{
       expect(test_hash.test_nested_one_level({ first_level: { 1 => :one, TestHash => 2.718 } })).to eq({ first_level: { 1 => :one, TestHash => 2.718 } })
     })
   end
 
   it '#test_nested_two_levels' do
-    has_block('#test_nested_two_levels', %Q{
+    has_block('#test_nested_two_levels', %{
       expect(test_hash.test_nested_two_levels({ second_level: { first_level: { 1 => :one, TestHash => 2.718 } } })).to eq({ second_level: { first_level: { 1 => :one, TestHash => 2.718 } } })
     })
   end
 
   it '#test_nested_three_levels' do
-    has_block('#test_nested_three_levels', %Q{
+    has_block('#test_nested_three_levels', %{
       expect(test_hash.test_nested_three_levels({ third_level: { second_level: { first_level: { 1 => :one, TestHash => 2.718 } } } })).to eq({ third_level: { second_level: { first_level: { 1 => :one, TestHash => 2.718 } } } })
     })
   end
 
   it '#test_key_as_another_hash' do
-    has_block('#test_key_as_another_hash', %Q{
+    has_block('#test_key_as_another_hash', %{
       expect(test_hash.test_key_as_another_hash({ { 1 => :one, TestHash => 2.718 } => :ratm })).to eq({ { 1 => :one, TestHash => 2.718 } => :ratm })
     })
   end
 
   it '#test_keys_are_symbols' do
-    has_block('#test_keys_are_symbols', %Q{
-      expect(test_hash.test_keys_are_symbols({ this: 'should', be: 'pretty' })).to eq({ this: 'should', be: 'pretty' })
+    has_block('#test_keys_are_symbols', %{
+      expect(test_hash.test_keys_are_symbols({ this: 'should', be: 'pretty' })).to eq({ be: 'pretty', this: 'should' })
     })
   end
 end

data/spec/klass_types_spec.rb

@@ -1,10 +1,10 @@
-require 'spec_helper'
+# frozen_string_literal: true
 
 describe Zapata::Revolutionist do
   context 'it should work with' do
     it 'bare module' do
       generated = exec_generation('app/models/testing_module/bare.rb')
-      expected = expected(%Q{require 'rails_helper'
+      expected = expected(%{require 'rails_helper'
 
       describe TestingModule::Bare do
         let(:bare) do
@@ -17,7 +17,7 @@ describe Zapata::Revolutionist do
 
     it 'nested module' do
       generated = exec_generation('app/models/testing_module/nested/inside.rb')
-      expected = expected(%Q{require 'rails_helper'
+      expected = expected(%{require 'rails_helper'
 
       describe TestingModule::Nested::Inside do
         let(:inside) do
@@ -34,19 +34,19 @@ describe Zapata::Revolutionist do
       end
 
       it '#defined_with_self' do
-        has_block('#defined_with_self', %Q{
+        has_block('#defined_with_self', %{
           expect(TestingModule::KlassMethods.defined_with_self(5)).to eq(5)
         })
       end
 
       it '#defined_with_back_back_self' do
-        has_block('#defined_with_back_back_self', %Q{
+        has_block('#defined_with_back_back_self', %{
           expect(TestingModule::KlassMethods.defined_with_back_back_self(5)).to eq(5)
         })
       end
 
       it '#back_to_public_defined_with_self' do
-        has_block('#back_to_public_defined_with_self', %Q{
+        has_block('#back_to_public_defined_with_self', %{
           expect(TestingModule::KlassMethods.back_to_public_defined_with_self(5)).to eq(5)
         })
       end

data/spec/send_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+# frozen_string_literal: true
 
 describe Zapata::Revolutionist do
   before(:all) do
@@ -6,7 +6,7 @@ describe Zapata::Revolutionist do
   end
 
   it '#another_method_as_arg' do
-    has_block('#another_method_as_arg', %Q{
+    has_block('#another_method_as_arg', %{
       expect(test_send.another_method_as_arg('Help method')).to eq('Help method')
     })
   end
@@ -30,25 +30,25 @@ describe Zapata::Revolutionist do
   # end
 
   it '#to_another_object' do
-    has_block('#to_another_object', %Q{
+    has_block('#to_another_object', %{
       expect(test_send.to_another_object(AnotherObject.my_name)).to eq('Domas')
     })
   end
 
   it '#to_another_object_with_params' do
-    has_block('#to_another_object_with_params', %Q{
+    has_block('#to_another_object_with_params', %{
       expect(test_send.to_another_object_with_params(AnotherObject.send_with_params(12))).to eq('Id was 12')
     })
   end
 
   it '#not_explicit_with_params' do
-    has_block('#not_explicit_with_params', %Q{
+    has_block('#not_explicit_with_params', %{
       expect(test_send.not_explicit_with_params('Could you find it?')).to eq('Could you find it?')
     })
   end
 
   it '#fail_to_understand' do
-    has_block('#fail_to_understand', %Q{
+    has_block('#fail_to_understand', %{
       expect(test_send.fail_to_understand('Missing "failure"')).to eq('Missing "failure"')
     })
   end

data/spec/simple_types_spec.rb

@@ -1,10 +1,10 @@
-require 'spec_helper'
+# frozen_string_literal: true
 
 describe Zapata::Revolutionist do
   context 'it should work with' do
     it 'ints' do
       generated = exec_generation('app/models/test_int.rb')
-      expected = expected(%Q{require 'rails_helper'
+      expected = expected(%{require 'rails_helper'
 
       describe TestInt do
         let(:test_int) do
@@ -21,7 +21,7 @@ describe Zapata::Revolutionist do
 
     it 'symbols' do
       generated = exec_generation('app/models/test_sym.rb')
-      expected = expected(%Q{require 'rails_helper'
+      expected = expected(%{require 'rails_helper'
 
       describe TestSym do
         let(:test_sym) do
@@ -38,7 +38,7 @@ describe Zapata::Revolutionist do
 
     it 'strings' do
       generated = exec_generation('app/models/test_str.rb')
-      expected = expected(%Q{require 'rails_helper'
+      expected = expected(%{require 'rails_helper'
 
       describe TestStr do
         let(:test_str) do
@@ -55,7 +55,7 @@ describe Zapata::Revolutionist do
 
     it 'floats' do
       generated = exec_generation('app/models/test_float.rb')
-      expected = expected(%Q{require 'rails_helper'
+      expected = expected(%{require 'rails_helper'
 
       describe TestFloat do
         let(:test_float) do
@@ -72,7 +72,7 @@ describe Zapata::Revolutionist do
 
     it 'consts' do
       generated = exec_generation('app/models/test_const.rb')
-      expected = expected(%Q{require 'rails_helper'
+      expected = expected(%{require 'rails_helper'
 
       describe TestConst do
         let(:test_const) do

data/spec/spec_helper.rb

@@ -1,90 +1,32 @@
+# frozen_string_literal: true
+
 require 'coveralls'
+
 Coveralls.wear!
 
 require 'zapata'
 
-# This file was generated by the `rspec --init` command. Conventionally, all
-# specs live under a `spec` directory, which RSpec adds to the `$LOAD_PATH`.
-# The generated `.rspec` file contains `--require spec_helper` which will cause this
-# file to always be loaded, without a need to explicitly require it in any files.
-#
-# Given that it is always loaded, you are encouraged to keep this file as
-# light-weight as possible. Requiring heavyweight dependencies from this file
-# will add to the boot time of your test suite on EVERY test run, even for an
-# individual file that may not need all of that loaded. Instead, make a
-# separate helper file that requires this one and then use it only in the specs
-# that actually need it.
-#
-# The `.rspec` file also contains a few flags that are not defaults but that
-# users commonly want.
-#
-# See http://rubydoc.info/gems/rspec-core/RSpec/Core/Configuration
 RSpec.configure do |config|
-  # The settings below are suggested to provide a good initial experience
-  # with RSpec, but feel free to customize to your heart's content.
-=begin
-  # These two settings work together to allow you to limit a spec run
-  # to individual examples or groups you care about by tagging them with
-  # `:focus` metadata. When nothing is tagged with `:focus`, all examples
-  # get run.
-  config.filter_run :focus
-  config.run_all_when_everything_filtered = true
-
-  # Many RSpec users commonly either run the entire suite or an individual
-  # file, and it's useful to allow more verbose output when running an
-  # individual spec file.
-  if config.files_to_run.one?
-    # Use the documentation formatter for detailed output,
-    # unless a formatter has already been configured
-    # (e.g. via a command-line flag).
-    config.default_formatter = 'doc'
-  end
-
-  # Print the 10 slowest examples and example groups at the
-  # end of the spec run, to help surface which specs are running
-  # particularly slow.
-  config.profile_examples = 10
-
-  # Run specs in random order to surface order dependencies. If you find an
-  # order dependency and want to debug it, you can fix the order by providing
-  # the seed, which is printed after each run.
-  #     --seed 1234
-  config.order = :random
-
-  # Seed global randomization in this process using the `--seed` CLI option.
-  # Setting this allows you to use `--seed` to deterministically reproduce
-  # test failures related to randomization by passing the same `--seed` value
-  # as the one that triggered the failure.
-  Kernel.srand config.seed
+  # Enable flags like --only-failures and --next-failure
+  config.example_status_persistence_file_path = '.rspec_status'
 
-  # rspec-expectations config goes here. You can use an alternate
-  # assertion/expectation library such as wrong or the stdlib/minitest
-  # assertions if you prefer.
-  config.expect_with :rspec do |expectations|
-    # Enable only the newer, non-monkey-patching expect syntax.
-    # For more details, see:
-    #   - http://myronmars.to/n/dev-blog/2012/06/rspecs-new-expectation-syntax
-    expectations.syntax = :expect
+  config.expect_with :rspec do |c|
+    c.syntax = :expect
   end
-
-  # rspec-mocks config goes here. You can use an alternate test double
-  # library (such as bogus or mocha) by changing the `mock_with` option here.
-  config.mock_with :rspec do |mocks|
-    # Enable only the newer, non-monkey-patching expect syntax.
-    # For more details, see:
-    #   - http://teaisaweso.me/blog/2013/05/27/rspecs-new-message-expectation-syntax/
-    mocks.syntax = :expect
-
-    # Prevents you from mocking or stubbing a method that does not exist on
-    # a real object. This is generally recommended.
-    mocks.verify_partial_doubles = true
-  end
-=end
 end
 
 # Helper methods
 RAILS_TEST_APP_DIR = "#{Dir.pwd}/spec/support/rails_test_app"
 
+def execution_output(command)
+  stdout = Bundler.with_clean_env do
+    Open3.pipeline_r(
+      command
+    )
+  end
+  stdout.first.readlines
+end
+
 def clean(string)
   string.split(/\n/).map(&:strip).join("\n")
 end
@@ -98,7 +40,7 @@ def expected(code)
 end
 
 def exec_generation(generate_for)
-  stdin, stdout, stderr = Bundler.with_clean_env do
+  _, stdout, stderr = Bundler.with_clean_env do
     Open3.popen3(
       "cd #{RAILS_TEST_APP_DIR} && bundle exec zapata generate #{generate_for} -s"
     )
@@ -107,7 +49,7 @@ def exec_generation(generate_for)
   output = stdout.readlines
   begin
     generated_filename = output.last.match(/File\ (.+)\ was/)[1]
-  rescue
+  rescue StandardError
     raise "Did not get the message that file was generated. Got this instead:
       STDOUT: #{output}
       STDERR: #{stderr.readlines}"

data/spec/support/rails_test_app/app/assets/config/manifest.js

@@ -0,0 +1,3 @@
+//= link_tree ../images
+//= link_directory ../javascripts .js
+//= link_directory ../stylesheets .css

data/spec/support/rails_test_app/app/models/robot_to_test.rb

@@ -1,5 +1,5 @@
 class RobotToTest
-  def initialize(human_name, cv)
+  def initialize(human_name, _cv)
     @name = robot_name(human_name)
   end
 
@@ -11,7 +11,7 @@ class RobotToTest
     { planets: planets }
   end
 
-  def nested_fun_objects(fun_objects)
+  def nested_fun_objects(_fun_objects)
     'It was fun'
   end
 
@@ -26,7 +26,7 @@ class RobotToTest
   end
 
   def fun_objects
-    [%i(array in array), { hash: nested_hash }]
+    [%i[array in array], { hash: nested_hash }]
   end
 
   def nested_hash
@@ -34,7 +34,7 @@ class RobotToTest
   end
 
   def array
-    %w(array)
+    %w[array]
   end
 end
 

data/spec/support/rails_test_app/app/models/test_send.rb

@@ -49,7 +49,7 @@ class TestSend
     1 + 3
   end
 
-  def not_explicit(name)
+  def not_explicit(_name)
     'Could you find it?'
   end
 

data/spec/support/rails_test_app/config.ru

@@ -1,4 +1,4 @@
 # This file is used by Rack-based servers to start the application.
 
-require ::File.expand_path('../config/environment',  __FILE__)
+require ::File.expand_path('../config/environment', __FILE__)
 run Rails.application

data/spec/support/rails_test_app/config/initializers/cookies_serializer.rb

@@ -1,3 +1,3 @@
 # Be sure to restart your server when you modify this file.
 
-Rails.application.config.action_dispatch.cookies_serializer = :json
+Rails.application.config.action_dispatch.cookies_serializer = :json

data/spec/support/rails_test_app/spec/models/robot_to_test_spec.rb

@@ -2,7 +2,7 @@ require 'rails_helper'
 
 describe RobotToTest do
   let(:robot_to_test) do
-    RobotToTest.new('Emiliano', { planets: ['Mars', Human.home] })
+    RobotToTest.new('Emiliano', planets: ['Mars', Human.home])
   end
 
   it '#robot_name' do
@@ -10,7 +10,7 @@ describe RobotToTest do
   end
 
   it '#cv' do
-    expect(robot_to_test.cv).to eq({ planets: ['Mars', 'Earth'] })
+    expect(robot_to_test.cv).to eq(planets: %w(Mars Earth))
   end
 
   it '#nested_fun_objects' do

data/spec/support/rails_test_app/spec/models/test_hash_spec.rb

@@ -26,6 +26,6 @@ describe TestHash do
   end
 
   it '#test_keys_are_symbols' do
-    expect(test_hash.test_keys_are_symbols({ this: 'should', be: 'pretty' })).to eq({ this: 'should', be: 'pretty' })
+    expect(test_hash.test_keys_are_symbols({ this: 'should', be: 'pretty' })).to eq({ be: 'pretty', this: 'should' })
   end
 end

data/spec/support/rails_test_app/spec/rails_helper.rb

@@ -1,7 +1,7 @@
 # This file is copied to spec/ when you run 'rails generate rspec:install'
-ENV["RAILS_ENV"] ||= 'test'
+ENV['RAILS_ENV'] ||= 'test'
 require 'spec_helper'
-require File.expand_path("../../config/environment", __FILE__)
+require File.expand_path('../../config/environment', __FILE__)
 require 'rspec/rails'
 
 # Requires supporting ruby files with custom matchers and macros, etc, in
@@ -11,7 +11,7 @@ require 'rspec/rails'
 # run twice. It is recommended that you do not name files matching this glob to
 # end with _spec.rb. You can configure this pattern with the --pattern
 # option on the command line or in ~/.rspec, .rspec or `.rspec-local`.
-Dir[Rails.root.join("spec/support/**/*.rb")].each { |f| require f }
+Dir[Rails.root.join('spec/support/**/*.rb')].each { |f| require f }
 
 # Checks for pending migrations before tests are run.
 # If you are not using ActiveRecord, you can remove this line.

data/spec/support/rails_test_app/spec/spec_helper.rb

@@ -15,64 +15,62 @@
 #
 # See http://rubydoc.info/gems/rspec-core/RSpec/Core/Configuration
 RSpec.configure do |config|
-# The settings below are suggested to provide a good initial experience
-# with RSpec, but feel free to customize to your heart's content.
-=begin
-  # These two settings work together to allow you to limit a spec run
-  # to individual examples or groups you care about by tagging them with
-  # `:focus` metadata. When nothing is tagged with `:focus`, all examples
-  # get run.
-  config.filter_run :focus
-  config.run_all_when_everything_filtered = true
-
-  # Many RSpec users commonly either run the entire suite or an individual
-  # file, and it's useful to allow more verbose output when running an
-  # individual spec file.
-  if config.files_to_run.one?
-    # Use the documentation formatter for detailed output,
-    # unless a formatter has already been configured
-    # (e.g. via a command-line flag).
-    config.default_formatter = 'doc'
-  end
-
-  # Print the 10 slowest examples and example groups at the
-  # end of the spec run, to help surface which specs are running
-  # particularly slow.
-  config.profile_examples = 10
-
-  # Run specs in random order to surface order dependencies. If you find an
-  # order dependency and want to debug it, you can fix the order by providing
-  # the seed, which is printed after each run.
-  #     --seed 1234
-  config.order = :random
-
-  # Seed global randomization in this process using the `--seed` CLI option.
-  # Setting this allows you to use `--seed` to deterministically reproduce
-  # test failures related to randomization by passing the same `--seed` value
-  # as the one that triggered the failure.
-  Kernel.srand config.seed
-
-  # rspec-expectations config goes here. You can use an alternate
-  # assertion/expectation library such as wrong or the stdlib/minitest
-  # assertions if you prefer.
-  config.expect_with :rspec do |expectations|
-    # Enable only the newer, non-monkey-patching expect syntax.
-    # For more details, see:
-    #   - http://myronmars.to/n/dev-blog/2012/06/rspecs-new-expectation-syntax
-    expectations.syntax = :expect
-  end
-
-  # rspec-mocks config goes here. You can use an alternate test double
-  # library (such as bogus or mocha) by changing the `mock_with` option here.
-  config.mock_with :rspec do |mocks|
-    # Enable only the newer, non-monkey-patching expect syntax.
-    # For more details, see:
-    #   - http://teaisaweso.me/blog/2013/05/27/rspecs-new-message-expectation-syntax/
-    mocks.syntax = :expect
-
-    # Prevents you from mocking or stubbing a method that does not exist on
-    # a real object. This is generally recommended.
-    mocks.verify_partial_doubles = true
-  end
-=end
+  # The settings below are suggested to provide a good initial experience
+  # with RSpec, but feel free to customize to your heart's content.
+  #   # These two settings work together to allow you to limit a spec run
+  #   # to individual examples or groups you care about by tagging them with
+  #   # `:focus` metadata. When nothing is tagged with `:focus`, all examples
+  #   # get run.
+  #   config.filter_run :focus
+  #   config.run_all_when_everything_filtered = true
+  #
+  #   # Many RSpec users commonly either run the entire suite or an individual
+  #   # file, and it's useful to allow more verbose output when running an
+  #   # individual spec file.
+  #   if config.files_to_run.one?
+  #     # Use the documentation formatter for detailed output,
+  #     # unless a formatter has already been configured
+  #     # (e.g. via a command-line flag).
+  #     config.default_formatter = 'doc'
+  #   end
+  #
+  #   # Print the 10 slowest examples and example groups at the
+  #   # end of the spec run, to help surface which specs are running
+  #   # particularly slow.
+  #   config.profile_examples = 10
+  #
+  #   # Run specs in random order to surface order dependencies. If you find an
+  #   # order dependency and want to debug it, you can fix the order by providing
+  #   # the seed, which is printed after each run.
+  #   #     --seed 1234
+  #   config.order = :random
+  #
+  #   # Seed global randomization in this process using the `--seed` CLI option.
+  #   # Setting this allows you to use `--seed` to deterministically reproduce
+  #   # test failures related to randomization by passing the same `--seed` value
+  #   # as the one that triggered the failure.
+  #   Kernel.srand config.seed
+  #
+  #   # rspec-expectations config goes here. You can use an alternate
+  #   # assertion/expectation library such as wrong or the stdlib/minitest
+  #   # assertions if you prefer.
+  #   config.expect_with :rspec do |expectations|
+  #     # Enable only the newer, non-monkey-patching expect syntax.
+  #     # For more details, see:
+  #     #   - http://myronmars.to/n/dev-blog/2012/06/rspecs-new-expectation-syntax
+  #     expectations.syntax = :expect
+  #   end
+  #
+  #   # rspec-mocks config goes here. You can use an alternate test double
+  #   # library (such as bogus or mocha) by changing the `mock_with` option here.
+  #   config.mock_with :rspec do |mocks|
+  #     # Enable only the newer, non-monkey-patching expect syntax.
+  #     # For more details, see:
+  #     #   - http://teaisaweso.me/blog/2013/05/27/rspecs-new-message-expectation-syntax/
+  #     mocks.syntax = :expect
+  #
+  #     # Prevents you from mocking or stubbing a method that does not exist on
+  #     # a real object. This is generally recommended.
+  #     mocks.verify_partial_doubles = true
+  #   end
 end