zakuro 0.7.2 → 0.8.0

data/lib/zakuro/era/japan/gengou/alignment/aligner.rb

@@ -41,7 +41,7 @@ module Zakuro
           def initialize(resources: [])
             @lines = []
             (1..LINE_SIZE).each do |_index|
-              @lines.push(Line.new)
+              lines.push(Line.new)
             end
 
             save(resources: resources)
@@ -73,7 +73,7 @@ module Zakuro
           def get(line:, start_date:, last_date:)
             raise ArgumentError.new, 'invalid line number' unless LINE_INDEXES.include?(line)
 
-            @lines[line].get(start_date: start_date, last_date: last_date)
+            lines[line].get(start_date: start_date, last_date: last_date)
           end
 
           #
@@ -89,7 +89,7 @@ module Zakuro
           def get_by_name(line:, name:)
             raise ArgumentError.new, 'invalid line number' unless LINE_INDEXES.include?(line)
 
-            @lines[line].get_by_name(name: name)
+            lines[line].get_by_name(name: name)
           end
 
           private
@@ -114,7 +114,7 @@ module Zakuro
             rest = [
               LinearGengou.new(gengou: gengou)
             ]
-            @lines.each do |line|
+            lines.each do |line|
               rest = line.push(list: rest)
             end
           end

data/lib/zakuro/era/japan/gengou/alignment/division.rb

@@ -14,153 +14,152 @@ module Zakuro
         # Division 元号区分
         #
         module Division
-          #
-          # 重複した範囲を返す
-          #
-          # @param [LinearGengou] this 残り元号
-          # @param [LinearGengou] other 比較元号
-          #
-          # @return [Array<LinearGengou>] 重複分
-          #
-          def self.match(this:, other:)
-            result = []
-            if other.in?(start_date: this.start_date, last_date: this.last_date)
-              result.push(this)
-              return result
-            end
-
-            if other.out?(start_date: this.start_date, last_date: this.last_date)
-              # 該当なし
-              return result
-            end
+          class << self
+            #
+            # 重複した範囲を返す
+            #
+            # @param [LinearGengou] this 残り元号
+            # @param [LinearGengou] other 比較元号
+            #
+            # @return [Array<LinearGengou>] 重複分
+            #
+            def match(this:, other:)
+              result = []
+              if other.in?(start_date: this.start_date, last_date: this.last_date)
+                result.push(this)
+                return result
+              end
 
-            if other.covered?(start_date: this.start_date, last_date: this.last_date)
-              # 範囲内のみ返す
-              result.push(trim_gengou(this: this, other: other))
-              return result
-            end
+              if other.out?(start_date: this.start_date, last_date: this.last_date)
+                # 該当なし
+                return result
+              end
 
-            result.push(narrow_gengou(this: this, other: other))
+              if other.covered?(start_date: this.start_date, last_date: this.last_date)
+                # 範囲内のみ返す
+                result.push(trim_gengou(this: this, other: other))
+                return result
+              end
 
-            result
-          end
+              result.push(narrow_gengou(this: this, other: other))
 
-          #
-          # 範囲が重複しない差分を返す
-          #
-          # @param [LinearGengou] this 積元号
-          # @param [LinearGengou] other 比較元号
-          #
-          # @return [Array<LinearGengou>] 差分
-          #
-          def self.mismatch(this:, other:)
-            result = []
-            if other.in?(start_date: this.start_date, last_date: this.last_date)
-              # 該当なし
-              return result
+              result
             end
 
-            if other.out?(start_date: this.start_date, last_date: this.last_date)
-              result.push(this)
-              return result
-            end
-
-            if other.covered?(start_date: this.start_date, last_date: this.last_date)
-              result |= split_gengou(this: this, other: other)
-              return result
-            end
+            #
+            # 範囲が重複しない差分を返す
+            #
+            # @param [LinearGengou] this 積元号
+            # @param [LinearGengou] other 比較元号
+            #
+            # @return [Array<LinearGengou>] 差分
+            #
+            def mismatch(this:, other:)
+              result = []
+              if other.in?(start_date: this.start_date, last_date: this.last_date)
+                # 該当なし
+                return result
+              end
 
-            result.push(shave_gengou(this: this, other: other))
-            result
-          end
+              if other.out?(start_date: this.start_date, last_date: this.last_date)
+                result.push(this)
+                return result
+              end
 
-          #
-          # 比較により分離した元号をつなげる
-          #
-          # @param [Array<LinearGengou>] list 元号
-          #
-          # @return [Array<LinearGengou>] 同一元号がつながった元号
-          #
-          def self.connect(list: []) # rubocop:disable Metrics/MethodLength
-            result = []
-            list.each do |linear_gengou|
-              if result.size.zero?
-                result.push(linear_gengou)
-                next
+              if other.covered?(start_date: this.start_date, last_date: this.last_date)
+                result |= split_gengou(this: this, other: other)
+                return result
               end
 
-              before = result[-1]
+              result.push(shave_gengou(this: this, other: other))
+              result
+            end
 
-              if unconnectable?(current: linear_gengou, before: before)
-                result.push(linear_gengou)
-                next
+            #
+            # 比較により分離した元号をつなげる
+            #
+            # @param [Array<LinearGengou>] list 元号
+            #
+            # @return [Array<LinearGengou>] 同一元号がつながった元号
+            #
+            def connect(list: []) # rubocop:disable Metrics/MethodLength
+              result = []
+              list.each do |linear_gengou|
+                if result.size.zero?
+                  result.push(linear_gengou)
+                  next
+                end
+
+                before = result[-1]
+
+                if unconnectable?(current: linear_gengou, before: before)
+                  result.push(linear_gengou)
+                  next
+                end
+
+                result[-1] = LinearGengou.new(
+                  start_date: before.start_date, last_date: linear_gengou.last_date,
+                  gengou: linear_gengou.gengou
+                )
               end
 
-              result[-1] = LinearGengou.new(
-                start_date: before.start_date, last_date: linear_gengou.last_date,
-                gengou: linear_gengou.gengou
-              )
+              result
             end
 
-            result
-          end
+            private
 
-          def self.unconnectable?(current:, before:)
-            return true unless current.gengou.name == before.gengou.name
+            def unconnectable?(current:, before:)
+              return true unless current.gengou.name == before.gengou.name
 
-            return true unless (before.last_date.clone + 1) == current.start_date
+              return true unless (before.last_date.clone + 1) == current.start_date
 
-            false
-          end
-          private_class_method :unconnectable?
+              false
+            end
 
-          def self.split_gengou(this:, other:)
-            [
-              LinearGengou.new(
-                start_date: this.start_date.clone, last_date: other.start_date.clone - 1,
-                gengou: this.gengou
-              ),
+            def split_gengou(this:, other:)
+              [
+                LinearGengou.new(
+                  start_date: this.start_date.clone, last_date: other.start_date.clone - 1,
+                  gengou: this.gengou
+                ),
+                LinearGengou.new(
+                  start_date: other.last_date.clone + 1, last_date: this.last_date.clone,
+                  gengou: this.gengou
+                )
+              ]
+            end
+
+            def trim_gengou(this:, other:)
               LinearGengou.new(
-                start_date: other.last_date.clone + 1, last_date: this.last_date.clone,
+                start_date: other.start_date, last_date: other.last_date,
                 gengou: this.gengou
               )
-            ]
-          end
-          private_class_method :split_gengou
-
-          def self.trim_gengou(this:, other:)
-            LinearGengou.new(
-              start_date: other.start_date, last_date: other.last_date,
-              gengou: this.gengou
-            )
-          end
-          private_class_method :trim_gengou
+            end
 
-          def self.narrow_gengou(this:, other:)
-            start = this.start_date > other.start_date ? this.start_date : other.start_date
-            last = this.last_date < other.last_date ? this.last_date : other.last_date
+            def narrow_gengou(this:, other:)
+              start = this.start_date > other.start_date ? this.start_date : other.start_date
+              last = this.last_date < other.last_date ? this.last_date : other.last_date
 
-            LinearGengou.new(
-              start_date: start.clone, last_date: last.clone, gengou: this.gengou
-            )
-          end
-          private_class_method :narrow_gengou
+              LinearGengou.new(
+                start_date: start.clone, last_date: last.clone, gengou: this.gengou
+              )
+            end
 
-          def self.shave_gengou(this:, other:) # rubocop:disable Metrics/AbcSize
-            start = this.start_date
-            last = this.last_date
+            def shave_gengou(this:, other:) # rubocop:disable Metrics/AbcSize
+              start = this.start_date
+              last = this.last_date
 
-            # 開始日が比較元号の開始日より前の範囲
-            last = other.start_date.clone - 1 if this.start_date < other.start_date
+              # 開始日が比較元号の開始日より前の範囲
+              last = other.start_date.clone - 1 if this.start_date < other.start_date
 
-            # 終了日が比較元号の開始日より後の範囲
-            start = other.last_date.clone + 1 if this.last_date > other.last_date
+              # 終了日が比較元号の開始日より後の範囲
+              start = other.last_date.clone + 1 if this.last_date > other.last_date
 
-            LinearGengou.new(
-              start_date: start.clone, last_date: last.clone, gengou: this.gengou
-            )
+              LinearGengou.new(
+                start_date: start.clone, last_date: last.clone, gengou: this.gengou
+              )
+            end
           end
-          private_class_method :shave_gengou
         end
       end
     end

data/lib/zakuro/era/japan/gengou/alignment/line.rb

@@ -72,7 +72,7 @@ module Zakuro
           #
           def get(start_date:, last_date:)
             result = []
-            @list.each do |gengou|
+            list.each do |gengou|
               next if gengou.out?(start_date: start_date, last_date: last_date)
 
               # 1日でも範囲内であれば対象とみなす
@@ -91,7 +91,7 @@ module Zakuro
           #
           def get_by_name(name:)
             result = []
-            @list.each do |gengou|
+            list.each do |gengou|
               result.push(gengou) if gengou.name == name
             end
 
@@ -110,7 +110,8 @@ module Zakuro
           def rest(list: [])
             result = []
 
-            @list.each do |gengou|
+            inner_list = @list
+            inner_list.each do |gengou|
               result |= and!(rest: list, other: gengou)
             end
 
@@ -123,15 +124,16 @@ module Zakuro
           # @param [Array<LinearGengou>] list 元号
           #
           def insert(list: [])
+            inner_list = @list
             surplus_result = list.clone
-            @list.each do |gengou|
+            inner_list.each do |gengou|
               surplus_result = not!(surplus: surplus_result, other: gengou)
             end
 
             surplus_result = Division.connect(list: surplus_result)
 
             surplus_result.each do |gengou|
-              @list.push(gengou)
+              inner_list.push(gengou)
             end
           end
 

data/lib/zakuro/era/japan/gengou/alignment/linear_gengou.rb

@@ -45,7 +45,7 @@ module Zakuro
           # @return [String] 元号名
           #
           def name
-            @gengou.name
+            gengou.name
           end
 
           #
@@ -55,7 +55,7 @@ module Zakuro
           # @return [False] 不正なし
           #
           def invalid?
-            @gengou.invalid?
+            gengou.invalid?
           end
 
           #
@@ -69,13 +69,13 @@ module Zakuro
           def include?(date: Western::Calendar.new)
             return false if invalid?
 
-            return false if @start_date.invalid?
+            return false if start_date.invalid?
 
-            return false if @last_date.invalid?
+            return false if last_date.invalid?
 
-            return false if date < @start_date
+            return false if date < start_date
 
-            return false if date > @last_date
+            return false if date > last_date
 
             true
           end
@@ -90,7 +90,9 @@ module Zakuro
           # @return [False] 範囲外あり
           #
           def in?(start_date:, last_date:)
-            @start_date <= start_date && last_date <= @last_date
+            inner_start_date = @start_date
+            inner_last_date = @last_date
+            inner_start_date <= start_date && last_date <= inner_last_date
           end
 
           #
@@ -103,11 +105,13 @@ module Zakuro
           # @return [False] 範囲内あり
           #
           def out?(start_date:, last_date:)
+            inner_start_date = @start_date
+            inner_last_date = @last_date
             # 範囲より前
-            return true if start_date < @start_date && last_date < @start_date
+            return true if start_date < inner_start_date && last_date < inner_start_date
 
             # 範囲より後
-            return true if @last_date < start_date && @last_date < last_date
+            return true if inner_last_date < start_date && inner_last_date < last_date
 
             false
           end
@@ -122,7 +126,9 @@ module Zakuro
           # @return [True] 完全超過せず
           #
           def covered?(start_date:, last_date:)
-            start_date < @start_date && @last_date < last_date
+            inner_start_date = @start_date
+            inner_last_date = @last_date
+            start_date < inner_start_date && inner_last_date < last_date
           end
 
           #
@@ -148,7 +154,7 @@ module Zakuro
           def change_start_date?
             return false if invalid?
 
-            @start_date != native_start_date
+            start_date != native_start_date
           end
 
           #
@@ -160,7 +166,7 @@ module Zakuro
           def change_last_date?
             return false if invalid?
 
-            @last_date != native_last_date
+            last_date != native_last_date
           end
 
           #
@@ -169,7 +175,7 @@ module Zakuro
           # @return [Western::Calendar]設定された元号の開始日
           #
           def native_start_date
-            @gengou.both_start_date.western
+            gengou.both_start_date.western
           end
 
           #
@@ -178,7 +184,7 @@ module Zakuro
           # @return [Western::Calendar] 設定された元号の終了日
           #
           def native_last_date
-            @gengou.last_date
+            gengou.last_date
           end
         end
       end

data/lib/zakuro/era/japan/gengou/alignment.rb

@@ -23,31 +23,33 @@ module Zakuro
         # @return [Aligner] 整列結果
         SUMMARY = Aligner.new(resources: Resource::LIST)
 
-        #
-        # 指定した範囲内の元号を取得する
-        #
-        # @param [Integer] line 行
-        # @param [Western::Calendar] start_date 開始日
-        # @param [Western::Calendar] last_date 終了日
-        #
-        # @return [Array<LinearGengou>] 元号
-        #
-        def self.get(line: FIRST_LINE,
-                     start_date: Western::Calendar.new, last_date: Western::Calendar.new)
-
-          SUMMARY.get(line: line, start_date: start_date, last_date: last_date)
-        end
-
-        #
-        # 指定した範囲内の元号を取得する（元号名）
-        #
-        # @param [Integer] line 行
-        # @param [String] name 元号名
-        #
-        # @return [Array<LinearGengou>] 元号
-        #
-        def self.get_by_name(line: FIRST_LINE, name:)
-          SUMMARY.get_by_name(line: line, name: name)
+        class << self
+          #
+          # 指定した範囲内の元号を取得する
+          #
+          # @param [Integer] line 行
+          # @param [Western::Calendar] start_date 開始日
+          # @param [Western::Calendar] last_date 終了日
+          #
+          # @return [Array<LinearGengou>] 元号
+          #
+          def get(line: FIRST_LINE,
+                  start_date: Western::Calendar.new, last_date: Western::Calendar.new)
+
+            SUMMARY.get(line: line, start_date: start_date, last_date: last_date)
+          end
+
+          #
+          # 指定した範囲内の元号を取得する（元号名）
+          #
+          # @param [Integer] line 行
+          # @param [String] name 元号名
+          #
+          # @return [Array<LinearGengou>] 元号
+          #
+          def get_by_name(line: FIRST_LINE, name:)
+            SUMMARY.get_by_name(line: line, name: name)
+          end
         end
       end
     end

data/lib/zakuro/era/japan/gengou/resource/parser.rb

@@ -53,11 +53,11 @@ module Zakuro
             # @return [Gengou] 元号情報
             #
             def create
-              both_start_year = Both::YearParser.new(hash: @both_start_year).create
-              both_start_date = Both::DateParser.new(hash: @both_start_date).create
+              start_year = Both::YearParser.new(hash: both_start_year).create
+              start_date = Both::DateParser.new(hash: both_start_date).create
 
-              Gengou.new(name: @name, both_start_year: both_start_year,
-                         both_start_date: both_start_date)
+              Gengou.new(name: name, both_start_year: start_year,
+                         both_start_date: start_date)
             end
           end
 
@@ -95,10 +95,10 @@ module Zakuro
             # @return [Set] 元号セット情報
             #
             def create
-              both_last_date = Both::DateParser.new(hash: @both_last_date).create
+              last_date = Both::DateParser.new(hash: both_last_date).create
               list = create_list
               Set.new(
-                id: @id, name: @name, both_last_date: both_last_date, list: list
+                id: id, name: name, both_last_date: last_date, list: list
               )
             end
 
@@ -111,7 +111,7 @@ module Zakuro
             #
             def create_list
               result = []
-              @list.each_with_index do |li, index|
+              list.each_with_index do |li, index|
                 gengou = GengouParser.new(hash: li, index: index).create
                 next_index = index + 1
                 gengou = calc_last_date_on_gengou_data(next_index: next_index,
@@ -122,24 +122,20 @@ module Zakuro
               result
             end
 
-            # :reek:TooManyStatements { max_statements: 6 }
-
             #
             # 次の元号の開始日から、元号の終了日に変換する
             #
             # @param [Integer] next_index 次の元号の要素位置
-            # @param [String] gengou 次回開始日
+            # @param [GengouParser] gengou 元号
             #
             # @return [Gengou] 元号情報
             #
             def calc_last_date_on_gengou_data(next_index:, gengou:)
-              if next_index >= @list.size
-                gengou.write_last_year(last_year: @both_last_year['western'])
-                last_date = Western::Calendar.parse(text: @both_last_date['western'])
-                gengou.write_last_date(last_date: last_date)
+              if next_index >= list.size
+                last_gengou_data(gengou: gengou)
                 return gengou
               end
-              next_item = @list[next_index]
+              next_item = list[next_index]
               gengou.convert_next_start_year_to_last_year(
                 next_start_year: next_item['start_year']['western']
               )
@@ -148,6 +144,19 @@ module Zakuro
               )
               gengou
             end
+
+            private
+
+            #
+            # 最後の元号の終了日を設定する
+            #
+            # @param [GengouParser] gengou 元号
+            #
+            def last_gengou_data(gengou:)
+              gengou.write_last_year(last_year: both_last_year['western'])
+              last_date = Western::Calendar.parse(text: both_last_date['western'])
+              gengou.write_last_date(last_date: last_date)
+            end
           end
 
           #
@@ -179,10 +188,12 @@ module Zakuro
               # @return [Both::Year] 年情報
               #
               def create
-                japan = @japan.to_i
-                western = @western.to_i
+                japan_year = japan.to_i
+                western_year = western.to_i
 
-                Japan::Gengou::Resource::Both::Year.new(japan: japan, western: western)
+                Japan::Gengou::Resource::Both::Year.new(
+                  japan: japan_year, western: western_year
+                )
               end
             end
 
@@ -211,32 +222,36 @@ module Zakuro
               # @return [Both::Date] 日情報
               #
               def create
-                japan = Japan::Calendar.parse(text: @japan)
-                western = Western::Calendar.parse(text: @western)
+                japan_date = Japan::Calendar.parse(text: japan)
+                western_date = Western::Calendar.parse(text: western)
 
-                Japan::Gengou::Resource::Both::Date.new(japan: japan, western: western)
+                Japan::Gengou::Resource::Both::Date.new(
+                  japan: japan_date, western: western_date
+                )
               end
             end
           end
 
-          #
-          # 解析/展開する
-          #
-          # @param [String] filepath 元号セットファイルパス
-          #
-          # @return [Set] 元号セット情報
-          #
-          # @raise [ArgumentError] 引数エラー
-          #
-          def self.run(filepath: '')
-            yaml = YAML.load_file(filepath)
+          class << self
+            #
+            # 解析/展開する
+            #
+            # @param [String] filepath 元号セットファイルパス
+            #
+            # @return [Set] 元号セット情報
+            #
+            # @raise [ArgumentError] 引数エラー
+            #
+            def run(filepath: '')
+              yaml = YAML.load_file(filepath)
 
-            failed = Validator.run(yaml_hash: yaml)
+              failed = Validator.run(yaml_hash: yaml)
 
-            raise ArgumentError, failed.join("\n") unless failed.empty?
+              raise ArgumentError, failed.join("\n") unless failed.empty?
 
-            parser = SetParser.new(hash: yaml)
-            parser.create
+              parser = SetParser.new(hash: yaml)
+              parser.create
+            end
           end
         end
       end