zai_payment 2.3.1 → 2.3.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: bd2bc88b008ee18d342d81dfbe7ee3680e2564b266d2fadd0f6d6f65140098b2
-  data.tar.gz: 59158c3d8919b6ae9df07ddefc6f21162b51218bf47b7c3267e81a52b25172b4
+  metadata.gz: bd5b738eff97b239ed278c2a96ce7b6e10383ca9401089648a9d390e2d29495f
+  data.tar.gz: 74831747ccf4bd3c901474d5ba082cac2297f801249fd5d02e8b923821d8c3b2
 SHA512:
-  metadata.gz: 19e4a3f16c002720a058dbd172a63f14231f99cb9d70735080ad400267e3490813062a5cdfb3ea3c538df71a48008d10bf47efa2284503a9beb2ecd1ee4f7e35
-  data.tar.gz: c3efe64996d506e89b364a9867c7b349111061ff58ad222b9a8814479b1842985ebf0f8bb72c89cf469327ac3e24985c25f84ebb7aee9ae1cbc05d08bf46a070
+  metadata.gz: 5a66826701b65f29051a6b1244201bc3201b5b333e9253f184c46fb0494110dafd15fe53a4b02081c6e7f58f3e373a30ad82b17b9deacf4d25c43d9373499de7
+  data.tar.gz: '096136afbb0dbe39d25960c73f9d1c16649614dd657b74d24fb9dc54ad5f025683640fbe283fa890e2d48d33e152ad3e55bea7426e7bb07361eee1742d4c13f7'

data/badges/coverage.json

@@ -1 +1 @@
-{"schemaVersion": 1, "label": "coverage", "message": "96.15%", "color": "brightgreen"}
+{"schemaVersion": 1, "label": "coverage", "message": "96.2%", "color": "brightgreen"}

data/changelog.md

@@ -1,4 +1,26 @@
 ## [Released]
+## [2.3.2] - 2025-10-29
+### Fixed
+- **Timeout Error Handling**: Improved handling of timeout errors to prevent crashes
+  - Added explicit rescue for `Net::ReadTimeout` and `Net::OpenTimeout` errors
+  - Previously, these errors could sometimes bypass Faraday's error handling and crash the application
+  - Now properly converts all timeout errors to `Errors::TimeoutError` with descriptive messages
+  - Fixes issue: "Request timed out: Net::ReadTimeout with #<TCPSocket:(closed)>"
+  
+### Changed
+- **Increased Default Timeouts**: Adjusted default timeout values for better reliability
+  - Default `timeout` increased from 10 to 30 seconds (general request timeout)
+  - Added separate `read_timeout` configuration (default: 30 seconds)
+  - `open_timeout` remains at 10 seconds (connection establishment)
+  - Users can still customize timeouts via configuration:
+    ```ruby
+    ZaiPayment.configure do |config|
+      config.timeout = 60        # Custom general timeout
+      config.read_timeout = 60   # Custom read timeout
+      config.open_timeout = 15   # Custom open timeout
+    end
+    ```
+
 ## [2.3.1] - 2025-10-28
 ### Fixed
 - **Token Refresh Bug**: Fixed authentication token not being refreshed after expiration

data/lib/zai_payment/client.rb

@@ -61,6 +61,8 @@ module ZaiPayment
       Response.new(response)
     rescue Faraday::Error => e
       handle_faraday_error(e)
+    rescue Net::ReadTimeout, Net::OpenTimeout => e
+      handle_net_timeout_error(e)
     end
 
     def connection
@@ -93,8 +95,13 @@ module ZaiPayment
     end
 
     def apply_timeouts(faraday)
-      faraday.options.timeout = config.timeout if config.timeout
-      faraday.options.open_timeout = config.open_timeout if config.open_timeout
+      set_timeout_option(faraday, :timeout, config.timeout)
+      set_timeout_option(faraday, :open_timeout, config.open_timeout)
+      set_timeout_option(faraday, :read_timeout, config.read_timeout)
+    end
+
+    def set_timeout_option(faraday, option, value)
+      faraday.options.public_send("#{option}=", value) if value
     end
 
     def base_url
@@ -120,5 +127,9 @@ module ZaiPayment
         raise Errors::ApiError, "Request failed: #{error.message}"
       end
     end
+
+    def handle_net_timeout_error(error)
+      raise Errors::TimeoutError, "Request timed out: #{error.class.name} with #{error.message}"
+    end
   end
 end

data/lib/zai_payment/config.rb

@@ -3,15 +3,16 @@
 module ZaiPayment
   class Config
     attr_accessor :environment, :client_id, :client_secret, :scope,
-                  :timeout, :open_timeout
+                  :timeout, :open_timeout, :read_timeout
 
     def initialize
       @environment  = :prelive # or :production
       @client_id    = nil
       @client_secret = nil
       @scope = nil
-      @timeout = 10
-      @open_timeout = 10
+      @timeout = 30      # General timeout - increased from 10 to 30 seconds
+      @open_timeout = 10 # Connection open timeout
+      @read_timeout = 30 # Read timeout - new separate configuration
     end
 
     def validate!

data/lib/zai_payment/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ZaiPayment
-  VERSION = '2.3.1'
+  VERSION = '2.3.2'
 end

data/readme.md

@@ -53,6 +53,11 @@ ZaiPayment.configure do |c|
   c.client_id     = ENV.fetch("ZAI_CLIENT_ID")
   c.client_secret = ENV.fetch("ZAI_CLIENT_SECRET")
   c.scope         = ENV.fetch("ZAI_OAUTH_SCOPE")
+  
+  # Optional: Configure timeout settings (defaults shown)
+  c.timeout       = 30  # General request timeout in seconds
+  c.open_timeout  = 10  # Connection open timeout in seconds
+  c.read_timeout  = 30  # Read timeout in seconds
 end
 ```
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: zai_payment
 version: !ruby/object:Gem::Version
-  version: 2.3.1
+  version: 2.3.2
 platform: ruby
 authors:
 - Eddy Jaga