yunpian_sms 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0011d0dee558f4d2ae2722d8cbafddc79f82a0f8
-  data.tar.gz: '04129d8f55e5672778d39c1feb7420b10a7afad6'
+  metadata.gz: a34e72affc14403a0c3618e90e754f4ce4e7c6b4
+  data.tar.gz: 7434efcaef5f9fc729d8f5f02f23dcf7166bde5b
 SHA512:
-  metadata.gz: 7baf052d77bd4bc93dd164bcadb1d17a8fe0b68b8d42b172d71b65d8ef18215d28ed091e50059770358058c997535e1e9a0b1441b67e3cb3461f03a8867ef019
-  data.tar.gz: 7a3a7a740dc544c849b1d2ec64faead68bc151aaacf01dbef0fc83a6ff423f01433b6930eca0c3cc73946da2be4ad86bd342017a7d5520d83c557543c79d7b35
+  metadata.gz: 34bfeaa8a83180d56f68298ae24145b65b509bc1ebb6a8abdff7bf7e8de4b570a4717bfae0fae4902fa655ca225620b88c963685caa9db8e2ebc4f585af5a011
+  data.tar.gz: b483585943c34c5b3f8b0fc12b05d1c2e6ebe107f4caf99c6565738be94fcc1a4832829166aa560b25480ce3a91bdb5d990e7a3e81c7b0c467719d939392296d

data/README.md

@@ -33,11 +33,15 @@ require 'yunpian_sms'
 YunPianSMS.api_key = 'your api key'
 
 # template examples
-all_templates = YunPianSMS::Template.all
-all_templates.each do |element|
+result = YunPianSMS::Template.all
+if result.successful
+  result.body.each do |element|
     template_id = element["tpl_id"]
-    template = YunPianSMS::Template.find template_id
-end 
+    template = YunPianSMS::Template.find(template_id).body
+  end  
+else
+  # raise error
+end
 ~~~
 
 

data/lib/yunpian_sms/result.rb

@@ -0,0 +1,10 @@
+class YunPianSMS::Result
+
+  attr_reader :successful, :body
+
+  def initialize(successful, body)
+    @successful = successful
+    @body = body
+  end
+
+end

data/lib/yunpian_sms/template.rb

@@ -1,5 +1,6 @@
 require 'net/http'
 require 'json'
+require 'yunpian_sms/result'
 
 class YunPianSMS::Template
 
@@ -24,9 +25,9 @@ class YunPianSMS::Template
       http.request req
     end
     if YunPianSMS.debug_mode && YunPianSMS.logger
-      YunPianSMS.logger.debug "Get Templates response #{res.body}"
+      YunPianSMS.logger.debug "Get Templates response status: #{res.code}, body: #{res.body}"
     end
-    JSON.parse res.body
+    YunPianSMS::Result.new(res.kind_of?(Net::HTTPSuccess), JSON.parse(res.body))
   end
 
 end

data/lib/yunpian_sms/version.rb

@@ -1,3 +1,3 @@
 module YunPianSMS 
-  VERSION = '0.1.0'.freeze
+  VERSION = '0.1.1'.freeze
 end

data/spec/yunpian_sms_spec.rb

@@ -7,23 +7,31 @@ require 'logger'
 describe YunPianSMS do            
   
   subject(:logger) { Logger.new STDOUT  }
+  subject(:api_key) { YAML.load_file('./spec/fixtures/configuration.yml')['api_key']  }
 
   before do
-    configuration = YAML.load_file('./spec/fixtures/configuration.yml')
     YunPianSMS.debug_mode = true                     
     YunPianSMS.logger = logger
-    YunPianSMS.api_key = configuration['api_key']
   end
 
   context 'templates' do
 
-    it 'should get all templates' do
-      all_templates = YunPianSMS::Template.all
-      logger.debug "all templtes #{all_templates}"
-      all_templates.each do |element|
+    it 'should get error response when api key missing' do
+      result = YunPianSMS::Template.all
+      expect(result.successful).to be false
+    end
+
+    it 'should get all templates successfully' do
+      YunPianSMS.api_key = api_key
+      result = YunPianSMS::Template.all
+      expect(result.successful).to be true
+      logger.debug "all templtes #{result.body}"
+      expect(YunPianSMS::Template.find(12324235345435).successful).to be false
+      result.body.each do |element|
         template_id = element["tpl_id"]
-        template = YunPianSMS::Template.find template_id
-        logger.debug "template #{template}"
+        template_result = YunPianSMS::Template.find template_id
+        expect(template_result.successful).to be true
+        logger.debug "template #{template_result.body}"
       end
     end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: yunpian_sms
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - LCola
@@ -33,6 +33,7 @@ files:
 - LICENSE.md
 - README.md
 - lib/yunpian_sms.rb
+- lib/yunpian_sms/result.rb
 - lib/yunpian_sms/template.rb
 - lib/yunpian_sms/version.rb
 - spec/yunpian_sms_spec.rb