yummy-guide-generic-administrate 0.8.9 → 0.8.10

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1ed6d8460a0a0e1b9a84b4b69a0e0dfd01195b505b2d9efa984cddf182efea28
-  data.tar.gz: d1d8de5996db5b20c7bbf8d5f822d9f62f900b59c1c6818a9104ac2a876961f1
+  metadata.gz: 8c30d8690fff8a7358f89a9e8e56a651b9b7630e3d1e69237325a215e0e7a3f0
+  data.tar.gz: 488e2ad28e15eec00b0e8387734c1cdf5bd56426ba9f916fe611c03a700203aa
 SHA512:
-  metadata.gz: 0b4f2c4caeb356f6758c40a5dbbcd7278d1303cc46970273d3ff3549c410bfba1b16ec163a2debb87649fb0e29c930401847aa73d7db866373c35125bc4e2f95
-  data.tar.gz: 077c2bf515cd0f2b0f46dbf16917eb5dbc781add60f5502b7c027fcfc97867c94ee215eaf5cd54049f4f0d597a1c5f68a7855a11280e54e92106b37a7c3cea84
+  metadata.gz: d95722f019bf3930435bd7602d9d937cf744bfa3b261fa771412f17f6b0ca047959bd3212af6cdd9b0c81992872f019ced8d79671e6fdbe38cb093084f227b78
+  data.tar.gz: a0afec4d0c4f2c8615664eea22ca12ef10e5332a70062cde6f535e4a4b251df567c0950e5056a5ea209cd3d3393e73f8b7f2f834056a78b1177ce38744f220a5

data/app/assets/javascripts/yummy_guide_administrate/column_resizer.js

@@ -394,14 +394,6 @@
     return tables;
   }
 
-  function shouldInitializeForAddedNode(node) {
-    if (!node.matches) return false;
-    if (node.matches(TABLE_SELECTOR) || (node.querySelector && node.querySelector(TABLE_SELECTOR))) return true;
-    if (!node.closest || !node.closest(TABLE_SELECTOR)) return false;
-
-    return !!node.closest('thead') || node.matches('colgroup, col');
-  }
-
   function allTrackedTables() {
     return Array.from(document.querySelectorAll(TABLE_SELECTOR));
   }
@@ -1040,29 +1032,6 @@
   document.addEventListener('turbo:load', initializeFromDocument);
   window.addEventListener('resize', initializeFromDocument);
 
-  if (window.MutationObserver) {
-    var mutationObserver = new MutationObserver(function(mutations) {
-      mutations.forEach(function(mutation) {
-        mutation.addedNodes.forEach(function(node) {
-          if (node.nodeType !== Node.ELEMENT_NODE) return;
-          if (!shouldInitializeForAddedNode(node)) return;
-
-          initializeColumnResizer(node);
-          refreshStickyHeaderLayout(node);
-        });
-
-        if (mutation.target && mutation.target.nodeType === Node.ELEMENT_NODE) {
-          refreshStickyHeaderLayout(mutation.target);
-        }
-      });
-    });
-
-    mutationObserver.observe(document.documentElement, {
-      childList: true,
-      subtree: true
-    });
-  }
-
   window.YummyGuideAdministrateColumnResizer = {
     refreshStickyHeaderLayout: refreshStickyHeaderLayout
   };

data/lib/yummy_guide/administrate/version.rb

@@ -2,6 +2,6 @@
 
 module YummyGuide
   module Administrate
-    VERSION = "0.8.9"
+    VERSION = "0.8.10"
   end
 end

data/spec/yummy_guide/administrate/column_resizer_asset_spec.rb

@@ -230,6 +230,14 @@ RSpec.describe "column resizer assets" do
     expect(components_source).not_to include("table-with-fixed-header")
   end
 
+  # document全体のDOM変更監視と一時切り分け用パラメータが残っていないことを静的に確認する
+  it "does not observe document mutations during table initialization" do
+    expect(javascript_source).not_to include("new MutationObserver")
+    expect(javascript_source).not_to include("mutationObserver.observe(document.documentElement")
+    expect(javascript_source).not_to include("admin_column_resizer_disable")
+    expect(javascript_source).not_to include("probeFeatureDisabled")
+  end
+
   # 幅リセット時も固定列のCSS変数を再計算することを静的に確認する
   it "recalculates CSS sticky-left offsets after clearing a column width" do
     expect(javascript_source).to include("clearColumnWidth(columnId, key)")

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: yummy-guide-generic-administrate
 version: !ruby/object:Gem::Version
-  version: 0.8.9
+  version: 0.8.10
 platform: ruby
 authors:
 - akatsuki-kk