yt 0.4.9 → 0.4.10

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f25c54b1f1004f4f077834c4363e122ddc0fe605
-  data.tar.gz: dac600c6f7846186cd83993a857de02c750946ad
+  metadata.gz: b768b3bf2f8df33d6464c3e5576d216eb56a40b6
+  data.tar.gz: 5d9157b38126cdae31aed2bd15192978a1656339
 SHA512:
-  metadata.gz: f2d6a9d99f716a34d3ec647ccb1ef117fa7cfdabbea3aa4fe28c379c72a1f607bbf12f230ebd07ea85abec14a54554ad0ef13b80b49572a66b262f53a6748de6
-  data.tar.gz: c9cdf87a2f003dca6d3b99e66d57bff636ce64aec589a27263ddd7d8838118462083b0e45af8291bf2601c9b504d82877c9e367e333034b032cc20097f70ac50
+  metadata.gz: 536cbae00ed870974c980366668f9a87f0bc7c8e0f8d1cf506fe077b307a5fb1fcb1d49486e7d444f40af1fff1d86c30719c22934a338cc8fb45891c213193ba
+  data.tar.gz: f8df59e9464f5f771266136789fa73bd2faa6649422a183aaba54e4987b1ca12b1fe5fa79daaeb5b8af3bbb360691292269c90814caaddb09afd3a52db665a53

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    yt (0.4.9)
+    yt (0.4.10)
       activesupport
 
 GEM

data/HISTORY.md

@@ -8,6 +8,7 @@ v0.4 - 2014/05/09
 * Fix delegating tags from resources to snippets
 * Two options to add videos to a playlist: fail or not if a video is missing or its account terminated
 * Allow to configure Yt credentials through environment variables
+* When updating a playlist, only changes the specified attributes
 
 v0.3.0 - 2014/04/16
 --------------------

data/README.md

@@ -302,7 +302,7 @@ To install on your system, run
 
 To use inside a bundled Ruby project, add this line to the Gemfile:
 
-    gem 'yt', '~> 0.4.9'
+    gem 'yt', '~> 0.4.10'
 
 Since the gem follows [Semantic Versioning](http://semver.org),
 indicating the full version in your Gemfile (~> *major*.*minor*.*patch*)

data/lib/yt/actions/list.rb

@@ -53,9 +53,12 @@ module Yt
       end
 
       def list_params
+        path = "/youtube/v3/#{self.class.to_s.demodulize.camelize :lower}"
+
         Request.default_params.tap do |params|
           params[:method] = :get
           params[:auth] = @auth
+          params[:path] = path
         end
       end
     end

data/lib/yt/collections/annotations.rb

@@ -1,9 +1,9 @@
-require 'yt/collections/resources'
+require 'yt/collections/base'
 require 'yt/models/annotation'
 
 module Yt
   module Collections
-    class Annotations < Resources
+    class Annotations < Base
 
     private
 

data/lib/yt/collections/base.rb

@@ -8,6 +8,15 @@ module Yt
       include Actions::DeleteAll
       include Actions::Insert
       include Actions::List
+
+      def initialize(options = {})
+        @parent = options[:parent]
+        @auth = options[:auth]
+      end
+
+      def self.of(parent)
+        new parent: parent, auth: parent.auth
+      end
     end
   end
 end

data/lib/yt/collections/channels.rb

@@ -1,9 +1,9 @@
-require 'yt/collections/resources'
+require 'yt/collections/base'
 require 'yt/models/channel'
 
 module Yt
   module Collections
-    class Channels < Resources
+    class Channels < Base
 
     private
 
@@ -14,8 +14,6 @@ module Yt
       def list_params
         super.tap do |params|
           params[:params] = {maxResults: 50, part: 'snippet', mine: true}
-          params[:scope] = 'https://www.googleapis.com/auth/youtube'
-          params[:path] = '/youtube/v3/channels'
         end
       end
     end

data/lib/yt/collections/details_sets.rb

@@ -1,9 +1,9 @@
-require 'yt/collections/resources'
+require 'yt/collections/base'
 require 'yt/models/details_set'
 
 module Yt
   module Collections
-    class DetailsSets < Resources
+    class DetailsSets < Base
 
     private
 

data/lib/yt/collections/playlist_items.rb

@@ -1,9 +1,9 @@
-require 'yt/collections/resources'
+require 'yt/collections/base'
 require 'yt/models/playlist_item'
 
 module Yt
   module Collections
-    class PlaylistItems < Resources
+    class PlaylistItems < Base
 
       # attrs are id and kind
       def insert(attrs = {}, options = {}) #
@@ -29,7 +29,6 @@ module Yt
         super.tap do |params|
           params[:params] = {maxResults: 50, part: 'snippet,status', playlistId: @parent.id}
           params[:scope] = 'https://www.googleapis.com/auth/youtube.readonly'
-          params[:path] = '/youtube/v3/playlistItems'
         end
       end
 

data/lib/yt/collections/playlists.rb

@@ -1,9 +1,9 @@
-require 'yt/collections/resources'
+require 'yt/collections/base'
 require 'yt/models/playlist'
 
 module Yt
   module Collections
-    class Playlists < Resources
+    class Playlists < Base
 
       # Valid body (no defaults) are: title (string), description (string), privacy_status (string),
       # tags (array of strings)
@@ -33,7 +33,6 @@ module Yt
         super.tap do |params|
           params[:params] = {maxResults: 50, part: 'snippet,status', channelId: @parent.id}
           params[:scope] = 'https://www.googleapis.com/auth/youtube.readonly'
-          params[:path] = '/youtube/v3/playlists'
         end
       end
 

data/lib/yt/collections/ratings.rb

@@ -1,9 +1,9 @@
-require 'yt/collections/resources'
+require 'yt/collections/base'
 require 'yt/models/rating'
 
 module Yt
   module Collections
-    class Ratings < Resources
+    class Ratings < Base
 
     private
 
@@ -15,7 +15,6 @@ module Yt
         super.tap do |params|
           params[:path] = '/youtube/v3/videos/getRating'
           params[:params] = {id: @parent.id}
-          params[:scope] = 'https://www.googleapis.com/auth/youtube'
         end
       end
     end

data/lib/yt/collections/snippets.rb

@@ -1,9 +1,9 @@
-require 'yt/collections/resources'
+require 'yt/collections/base'
 require 'yt/models/snippet'
 
 module Yt
   module Collections
-    class Snippets < Resources
+    class Snippets < Base
 
     private
 

data/lib/yt/collections/subscriptions.rb

@@ -3,7 +3,7 @@ require 'yt/models/subscription'
 
 module Yt
   module Collections
-    class Subscriptions < Resources
+    class Subscriptions < Base
 
       def insert(options = {})
         throttle
@@ -43,8 +43,6 @@ module Yt
       def list_params
         super.tap do |params|
           params[:params] = {maxResults: 50, forChannelId: @parent.id, mine: true, part: 'snippet'}
-          params[:scope] = 'https://www.googleapis.com/auth/youtube'
-          params[:path] = '/youtube/v3/subscriptions'
         end
       end
 

data/lib/yt/collections/user_infos.rb

@@ -1,9 +1,9 @@
-require 'yt/collections/resources'
+require 'yt/collections/base'
 require 'yt/models/user_info'
 
 module Yt
   module Collections
-    class UserInfos < Resources
+    class UserInfos < Base
 
     private
 

data/lib/yt/collections/videos.rb

@@ -1,9 +1,9 @@
-require 'yt/collections/resources'
+require 'yt/collections/base'
 require 'yt/models/video'
 
 module Yt
   module Collections
-    class Videos < Resources
+    class Videos < Base
 
     private
 

data/lib/yt/models/playlist.rb

@@ -9,21 +9,17 @@ module Yt
       !exists?
     end
 
-    # Valid body (no defaults) are: title (string), description (string), privacy_status (string),
-    # tags (array of strings) - since title is required, we set it again if it's not passed
     def update(options = {})
-      parts, body = [], {id: @id}
-
       options[:title] ||= title
-      parts << :snippet
-      body[:snippet] = options.slice :title, :description, :tags
+      options[:description] ||= description
+      options[:tags] ||= tags
+      options[:privacy_status] ||= privacy_status
 
-      if status = options[:privacy_status]
-        parts << :status
-        body[:status] = {privacyStatus: status}
-      end
+      snippet = options.slice :title, :description, :tags
+      status = {privacyStatus: privacy_status}
+      body = {id: @id, snippet: snippet, status: status}
+      params = {params: {part: 'snippet,status'}, body: body}
 
-      params = {params: {part: parts.join(',')}, body: body}
       do_update(params, expect: Net::HTTPOK) do |data|
         @id = data['id']
         @snippet = Snippet.new data: data['snippet'] if data['snippet']

data/lib/yt/models/rating.rb

@@ -21,7 +21,6 @@ module Yt
         params[:method] = :post
         params[:path] = '/youtube/v3/videos/rate'
         params[:params] = {id: @video_id}
-        params[:scope] = 'https://www.googleapis.com/auth/youtube'
       end
     end
   end

data/lib/yt/version.rb

@@ -1,3 +1,3 @@
 module Yt
-  VERSION = '0.4.9'
+  VERSION = '0.4.10'
 end

data/spec/associations/device_auth/playlists_spec.rb

@@ -3,9 +3,13 @@ require 'yt/associations/playlists'
 
 describe Yt::Associations::Playlists, scenario: :device_app do
   let(:account) { Yt.configuration.account }
+  let(:title) { 'Yt Test title' }
+  let(:description) { 'Yt Test description' }
+  let(:tags) { ['Yt Test Tag 1', 'Yt Test Tag 2'] }
+  let(:privacy_status) { 'unlisted' }
+  let(:params) { {title: title, description: description, tags: tags, privacy_status: privacy_status} }
 
-  describe '#playlists' do
-    let(:params) { {title: "Yt Test Playlists" } }
+  describe 'playlists' do
     before { account.create_playlist params }
     after { account.delete_playlists params }
 
@@ -13,16 +17,22 @@ describe Yt::Associations::Playlists, scenario: :device_app do
     it { expect(account.playlists.first).to be_a Yt::Playlist }
   end
 
-  describe '#create_playlist' do
-    let(:params) { {title: "Yt Test Create Playlist" } }
+  describe 'create a playlist' do
     after { account.delete_playlists params }
 
     it { expect(account.create_playlist params).to be_a Yt::Playlist }
     it { expect{account.create_playlist params}.to change{account.playlists.count}.by(1) }
   end
 
-  describe '#delete_playlists' do
-    let(:params) { {title: "Yt Test Delete Playlist #{rand}" } }
+  describe 'delete a playlist' do
+    let(:title) { "Yt Test Delete Playlist #{rand}" }
+    before { @playlist = account.create_playlist params }
+
+    it { expect(@playlist.delete).to be true }
+  end
+
+  describe 'delete a set of playlists' do
+    let(:title) { "Yt Test Delete All Playlists #{rand}" }
     before { account.create_playlist params }
 
     it { expect(account.delete_playlists title: %r{#{params[:title]}}).to eq [true] }
@@ -31,13 +41,22 @@ describe Yt::Associations::Playlists, scenario: :device_app do
   end
 
   describe 'update a playlist' do
-    let(:old_title) { "Yt Test Before Update Playlist" }
-    let(:new_title) { "Yt Test After Update Playlist" }
-    before { @playlist = account.create_playlist title: old_title }
+    before { @playlist = account.create_playlist params }
     after { @playlist.delete }
 
-    it { expect(@playlist.update title: new_title).to eq true }
-    it { expect{@playlist.update title: new_title}.to change{@playlist.title} }
-    it { expect{@playlist.update privacy_status: 'unlisted'}.to change{@playlist.privacy_status} }
+    context 'changes the attributes that are specified to be updated' do
+      let(:new_attrs) { {title: "Yt Test Update Playlist #{rand}"} }
+      it { expect(@playlist.update new_attrs).to eq true }
+      it { expect{@playlist.update new_attrs}.to change{@playlist.title} }
+    end
+
+    context 'does not changes the attributes that are not specified to be updated' do
+      let(:new_attrs) { {} }
+      it { expect(@playlist.update new_attrs).to eq true }
+      it { expect{@playlist.update new_attrs}.not_to change{@playlist.title} }
+      it { expect{@playlist.update new_attrs}.not_to change{@playlist.description} }
+      it { expect{@playlist.update new_attrs}.not_to change{@playlist.tags} }
+      it { expect{@playlist.update new_attrs}.not_to change{@playlist.privacy_status} }
+    end
   end
-end
+end

data/spec/models/configuration_spec.rb

@@ -4,7 +4,8 @@ describe Yt::Configuration do
   subject(:config) { Yt::Configuration.new }
 
   describe '#scenario' do
-    context 'by default' do
+    context 'without an environment variable YT_CLIENT_SCENARIO' do
+      before { ENV['YT_CLIENT_SCENARIO'] = nil }
       it {expect(config.scenario).to be :web_app }
     end
 
@@ -20,7 +21,8 @@ describe Yt::Configuration do
   end
 
   describe '#client_id' do
-    context 'by default' do
+    context 'without an environment variable YT_CLIENT_ID' do
+      before { ENV['YT_CLIENT_ID'] = nil }
       it {expect(config.client_id).to be_nil }
     end
 
@@ -32,7 +34,8 @@ describe Yt::Configuration do
   end
 
   describe '#client_secret' do
-    context 'by default' do
+    context 'without an environment variable YT_CLIENT_SECRET' do
+      before { ENV['YT_CLIENT_SECRET'] = nil }
       it {expect(config.client_secret).to be_nil }
     end
 
@@ -44,7 +47,8 @@ describe Yt::Configuration do
   end
 
   describe '#api_key' do
-    context 'by default' do
+    context 'without an environment variable YT_API_KEY' do
+      before { ENV['YT_API_KEY'] = nil }
       it {expect(config.api_key).to be_nil }
     end
 

data/spec/models/playlist_spec.rb

@@ -31,8 +31,7 @@ describe Yt::Playlist do
   end
 
   describe '#update' do
-    # TODO: separate stubs to show options translate into do_insert params
-    let(:attrs) { {id: 'PLSWYkYzOr', snippet: {'title'=>'old'}} }
+    let(:attrs) { {id: 'PLSWYkYzOr', snippet: {'title'=>'old'}, status: {"privacyStatus"=>"public"}} }
     before { playlist.stub(:do_update).and_yield 'snippet'=>{'title'=>'new'} }
 
     it { expect(playlist.update title: 'new').to be_true }

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: yt
 version: !ruby/object:Gem::Version
-  version: 0.4.9
+  version: 0.4.10
 platform: ruby
 authors:
 - Claudio Baccigalupo
@@ -143,7 +143,6 @@ files:
 - lib/yt/collections/playlist_items.rb
 - lib/yt/collections/playlists.rb
 - lib/yt/collections/ratings.rb
-- lib/yt/collections/resources.rb
 - lib/yt/collections/snippets.rb
 - lib/yt/collections/subscriptions.rb
 - lib/yt/collections/user_infos.rb

data/lib/yt/collections/resources.rb

@@ -1,16 +0,0 @@
-require 'yt/collections/base'
-
-module Yt
-  module Collections
-    class Resources < Base
-      def initialize(options = {})
-        @parent = options[:parent]
-        @auth = options[:auth]
-      end
-
-      def self.of(parent)
-        new parent: parent, auth: parent.auth
-      end
-    end
-  end
-end