yt 0.4.10 → 0.5.3

data/spec/associations/device_auth/user_infos_spec.rb

@@ -2,9 +2,14 @@ require 'spec_helper'
 require 'yt/associations/user_infos'
 
 describe Yt::Associations::UserInfos, scenario: :device_app do
-  let(:account) { Yt.configuration.account }
+  subject(:account) { Yt::Account.new attrs }
 
   describe '#user_info' do
-    it { expect(account.user_info).to be_a Yt::UserInfo }
+    context 'given an existing account' do
+      let(:account) { Yt.configuration.account }
+      it { expect(account.user_info).to be_a Yt::UserInfo }
+    end
+
+    # Note: testing with an unknown account would fail before getting user info
   end
 end

data/spec/associations/server_auth/details_sets_spec.rb

@@ -2,17 +2,17 @@ require 'spec_helper'
 require 'yt/associations/details_sets'
 
 describe Yt::Associations::DetailsSets, scenario: :server_app do
-  let(:video) { Yt::Video.new id: 'fsdfsfsdMESycYJytkU' }
+  subject(:video) { Yt::Video.new id: video_id }
 
   describe '#details_set' do
     context 'given an existing video' do
-      let(:video) { Yt::Video.new id: 'MESycYJytkU' }
+      let(:video_id) { 'MESycYJytkU' }
       it { expect(video.details_set).to be_a Yt::DetailsSet }
     end
 
     context 'given an unknown video' do
-      let(:video) { Yt::Video.new id: 'not-a-video-id' }
-      it { expect(video.details_set).to be_nil }
+      let(:video_id) { 'not-a-video-id' }
+      it { expect{video.details_set}.to raise_error Yt::Errors::NoItems }
     end
   end
 end

data/spec/associations/server_auth/ids_spec.rb

@@ -0,0 +1,18 @@
+require 'spec_helper'
+require 'yt/associations/ids'
+
+describe Yt::Associations::Ids, scenario: :server_app do
+  subject(:resource) { Yt::Resource.new url: url }
+
+  describe '#id' do
+    context 'given a URL containing an existing username' do
+      let(:url) { 'youtube.com/fullscreen' }
+      it { expect(resource.id).to eq 'UCxO1tY8h1AhOz0T4ENwmpow' }
+    end
+
+    context 'given a URL containing an unknown username' do
+      let(:url) { 'youtube.com/--not--a--valid--username' }
+      it { expect{resource.id}.to raise_error Yt::Errors::NoItems }
+    end
+  end
+end

data/spec/associations/server_auth/snippets_spec.rb

@@ -12,7 +12,7 @@ describe Yt::Associations::Snippets, scenario: :server_app do
 
     context 'given an unknown video resource' do
       let(:video) { Yt::Video.new id: 'not-a-video-id' }
-      it { expect(video.snippet).to be_nil }
+      it { expect{video.snippet}.to raise_error Yt::Errors::NoItems }
     end
 
     context 'given an existing channel resource' do
@@ -22,7 +22,7 @@ describe Yt::Associations::Snippets, scenario: :server_app do
 
     context 'given an unknown channel resource' do
       let(:channel) { Yt::Channel.new id: 'not-a-channel-id' }
-      it { expect(channel.snippet).to be_nil }
+      it { expect{channel.snippet}.to raise_error Yt::Errors::NoItems }
     end
   end
 end

data/spec/collections/playlist_items_spec.rb

@@ -4,16 +4,36 @@ require 'yt/collections/playlist_items'
 
 describe Yt::Collections::PlaylistItems do
   subject(:collection) { Yt::Collections::PlaylistItems.new parent: playlist }
-  let(:playlist) { Yt::Playlist.new }
+  let(:playlist) { Yt::Playlist.new id: 'LLxO1tY8h1AhOz0T4ENwmpow' }
+  let(:attrs) { {id: 'MESycYJytkU', kind: :video} }
+  let(:response_body) { %Q{{"error":{"errors":[{"reason":"#{reason}"}]}}} }
+  let(:msg) { {response: {body: response_body}}.to_json }
 
   describe '#insert' do
     let(:playlist_item) { Yt::PlaylistItem.new }
-    # TODO: separate stubs to show options translate into do_insert params
-    before { collection.stub(:do_insert).and_return playlist_item }
 
-    it { expect(collection.insert).to eq playlist_item }
-  end
+    context 'given an existing video' do
+      before { collection.stub(:do_insert).and_return playlist_item }
+
+      it { expect(collection.insert attrs).to eq playlist_item }
+    end
+
+    context 'given an unknown video' do
+      let(:reason) { 'videoNotFound' }
+      before { collection.stub(:do_insert).and_raise Yt::Errors::Failed, msg }
 
+      it { expect{collection.insert attrs}.to fail.with 'videoNotFound' }
+      it { expect{collection.insert attrs, ignore_errors: true}.not_to fail }
+    end
+
+    context 'given a forbidden video' do
+      let(:reason) { 'forbidden' }
+      before { collection.stub(:do_insert).and_raise Yt::Errors::Failed, msg }
+
+      it { expect{collection.insert attrs}.to fail.with 'forbidden' }
+      it { expect{collection.insert attrs, ignore_errors: true}.not_to fail }
+    end
+  end
 
   describe '#delete_all' do
     before { collection.stub(:do_delete_all).and_return [true] }

data/spec/collections/subscriptions_spec.rb

@@ -4,6 +4,8 @@ require 'yt/collections/subscriptions'
 describe Yt::Collections::Subscriptions do
   subject(:collection) { Yt::Collections::Subscriptions.new }
   before { collection.stub :throttle }
+  let(:response_body) { %Q{{"error":{"errors":[{"reason":"#{reason}"}]}}} }
+  let(:msg) { {response: {body: response_body}}.to_json }
 
   describe '#insert' do
     context 'given a new subscription' do
@@ -14,11 +16,11 @@ describe Yt::Collections::Subscriptions do
     end
 
     context 'given a duplicate subscription' do
-      let(:msg) { '{"error"=>{"errors"=>[{"reason"=>"subscriptionDuplicate"}]}}' }
-      before { collection.stub(:do_insert).and_raise Yt::RequestError, msg }
+      let(:reason) { 'subscriptionDuplicate' }
+      before { collection.stub(:do_insert).and_raise Yt::Errors::Failed, msg }
 
-      it { expect{collection.insert}.to raise_error Yt::RequestError, msg }
-      it { expect{collection.insert ignore_duplicates: true}.not_to raise_error }
+      it { expect{collection.insert}.to fail.with 'subscriptionDuplicate' }
+      it { expect{collection.insert ignore_errors: true}.not_to fail }
     end
   end
 

data/spec/errors/failed_spec.rb

@@ -0,0 +1,9 @@
+require 'spec_helper'
+require 'yt/errors/failed'
+
+describe Yt::Errors::Failed do
+  let(:msg) { %r{request.+?failed} }
+  describe '#exception' do
+    it { expect{raise Yt::Errors::Failed}.to raise_error msg }
+  end
+end

data/spec/errors/no_items_spec.rb

@@ -0,0 +1,9 @@
+require 'spec_helper'
+require 'yt/errors/no_items'
+
+describe Yt::Errors::NoItems do
+  let(:msg) { %r{request.+?returned no items} }
+  describe '#exception' do
+    it { expect{raise Yt::Errors::NoItems}.to raise_error msg }
+  end
+end

data/spec/errors/unauthenticated_spec.rb

@@ -0,0 +1,9 @@
+require 'spec_helper'
+require 'yt/errors/unauthenticated'
+
+describe Yt::Errors::Unauthenticated do
+  let(:msg) { %r{request.+?without the required authentication} }
+  describe '#exception' do
+    it { expect{raise Yt::Errors::Unauthenticated}.to raise_error msg }
+  end
+end

data/spec/models/description_spec.rb

@@ -21,7 +21,7 @@ describe Yt::Description do
     end
 
     context 'with a video long URL' do
-      let(:text) { 'Link to video: youtube.com/watch?v=MESycYJytkU' }
+      let(:text) { 'example.com and Link to video: youtube.com/watch?v=MESycYJytkU' }
       it { expect(description).to have_link_to_video }
     end
 
@@ -33,7 +33,7 @@ describe Yt::Description do
 
   describe '#has_link_to_channel?' do
     context 'without a channel URL' do
-      let(:text) { 'Link to video: youtu.be/MESycYJytkU' }
+      let(:text) { 'youtu.be/MESycYJytkU is a video link' }
       it { expect(description).not_to have_link_to_channel }
     end
 

data/spec/models/request_spec.rb

@@ -0,0 +1,29 @@
+require 'spec_helper'
+require 'yt/models/request'
+
+describe Yt::Request do
+  subject(:request) { Yt::Request.new attrs }
+  let(:attrs) { {} }
+
+  describe '#run' do
+    context 'given a request to YouTube V3 API without authentication' do
+      let(:attrs) { {host: 'www.googleapis.com'} }
+      before{ Yt.configuration.api_key = nil }
+      it { expect{request.run}.to raise_error Yt::Errors::Unauthenticated }
+    end
+
+    context 'given a request that returns a non-2XX code' do
+      let(:not_found) { Net::HTTPNotFound.new nil, nil, nil }
+      before { Net::HTTP.stub(:start).and_return not_found }
+      before { not_found.stub(:body) }
+      it { expect{request.run}.to fail }
+    end
+
+    context 'given a request that returns a 2XX code' do
+      let(:ok) { Net::HTTPOK.new nil, nil, nil }
+      before { Net::HTTP.stub(:start).and_return ok }
+      before { ok.stub(:body) }
+      it { expect{request.run}.not_to fail }
+    end
+  end
+end

data/spec/models/resource_spec.rb

@@ -0,0 +1,21 @@
+require 'spec_helper'
+require 'yt/models/resource'
+
+describe Yt::Resource do
+  subject(:resource) { Yt::Resource.new attrs }
+
+  context 'given a resource initialized with a URL (containing an ID)' do
+    let(:attrs) { {url: 'youtu.be/MESycYJytkU'} }
+
+    it { expect(resource.id).to eq 'MESycYJytkU' }
+    it { expect(resource.kind).to eq 'video' }
+    it { expect(resource.username).to be_nil }
+  end
+
+  context 'given a resource initialized with a URL (containing a username)' do
+    let(:attrs) { {url: 'youtube.com/fullscreen'} }
+
+    it { expect(resource.kind).to eq 'channel' }
+    it { expect(resource.username).to eq 'fullscreen' }
+  end
+end

data/spec/models/subscription_spec.rb

@@ -3,6 +3,8 @@ require 'yt/models/subscription'
 
 describe Yt::Subscription do
   subject(:subscription) { Yt::Subscription.new id: id }
+  let(:response_body) { %Q{{"error":{"errors":[{"reason":"#{reason}"}]}}} }
+  let(:msg) { {response: {body: response_body}}.to_json }
 
   describe '#exists?' do
     context 'given a subscription with an id' do
@@ -27,11 +29,11 @@ describe Yt::Subscription do
     end
 
     context 'given an unknown subscription' do
-      let(:msg) { '{"error"=>{"errors"=>[{"reason"=>"subscriptionNotFound"}]}}' }
-      before { subscription.stub(:do_delete).and_raise Yt::RequestError, msg }
+      let(:reason) { 'subscriptionNotFound' }
+      before { subscription.stub(:do_delete).and_raise Yt::Errors::Failed, msg }
 
-      it { expect{subscription.delete}.to raise_error Yt::RequestError, msg }
-      it { expect{subscription.delete ignore_not_found: true}.not_to raise_error }
+      it { expect{subscription.delete}.to fail.with 'subscriptionNotFound' }
+      it { expect{subscription.delete ignore_errors: true}.not_to fail }
     end
   end
 end

data/spec/models/url_spec.rb

@@ -0,0 +1,72 @@
+# encoding: UTF-8
+
+require 'spec_helper'
+require 'yt/models/url'
+
+describe Yt::URL do
+  subject(:url) { Yt::URL.new text }
+
+  context 'given a long video URL' do
+    let(:text) { 'youtube.com/watch?v=MESycYJytkU' }
+    it {expect(url.kind).to eq :video }
+    it {expect(url.id).to eq 'MESycYJytkU' }
+    it {expect(url.username).to be_nil }
+  end
+
+  context 'given a short video URL' do
+    let(:text) { 'https://youtu.be/MESycYJytkU' }
+    it {expect(url.kind).to eq :video }
+    it {expect(url.id).to eq 'MESycYJytkU' }
+  end
+
+  context 'given a long channel URL' do
+    let(:text) { 'http://youtube.com/channel/UCxO1tY8h1AhOz0T4ENwmpow' }
+    it {expect(url.kind).to eq :channel }
+    it {expect(url.id).to eq 'UCxO1tY8h1AhOz0T4ENwmpow' }
+  end
+
+  context 'given a short channel URL' do
+    let(:text) { 'https://www.youtube.com/Fullscreen' }
+    it {expect(url.kind).to eq :channel }
+    it {expect(url.username).to eq 'Fullscreen' }
+    it {expect(url.id).to be_nil }
+  end
+
+  context 'given a user’s channel URL' do
+    let(:text) { 'https://www.youtube.com/user/Fullscreen' }
+    it {expect(url.kind).to eq :channel }
+    it {expect(url.username).to eq 'Fullscreen' }
+  end
+
+  context 'given a subscription center URL' do
+    let(:text) { 'youtube.com/subscription_center?add_user=Fullscreen' }
+    it {expect(url.kind).to eq :subscription }
+  end
+
+  context 'given a subscription widget URL' do
+    let(:text) { 'youtube.com/subscribe_widget?p=Fullscreen' }
+    it {expect(url.kind).to eq :subscription }
+  end
+
+  context 'given a subscription confirmation URL' do
+    let(:text) { 'youtube.com/channel/UCxO1tY8h1AhOz0T4ENwmpow?sub_confirmation=1' }
+    it {expect(url.kind).to eq :subscription }
+  end
+
+  context 'given a long playlist URL' do
+    let(:text) { 'youtube.com/playlist?list=LLxO1tY8h1AhOz0T4ENwmpow' }
+    it {expect(url.kind).to eq :playlist }
+    it {expect(url.id).to eq 'LLxO1tY8h1AhOz0T4ENwmpow' }
+  end
+
+  context 'given a video-embed playlist URL' do
+    let(:text) { 'youtube.com/watch?v=MESycYJytkU&list=LLxO1tY8h1AhOz0T4ENwmpow' }
+    it {expect(url.kind).to eq :playlist }
+    it {expect(url.id).to eq 'LLxO1tY8h1AhOz0T4ENwmpow' }
+  end
+
+  context 'given a valid URL with a trailing slash' do
+    let(:text) { 'https://www.youtube.com/user/Fullscreen/' }
+    it {expect(url.kind).to eq :channel }
+  end
+end

data/spec/support/fail_matcher.rb

@@ -0,0 +1,14 @@
+RSpec::Matchers.define :fail do
+  match do |block|
+    begin
+      block.call
+      false
+    rescue Yt::Errors::Base => error
+      @reason ? error.reasons.include?(@reason) : true
+    end
+  end
+
+  chain :with do |reason|
+    @reason = reason
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: yt
 version: !ruby/object:Gem::Version
-  version: 0.4.10
+  version: 0.5.3
 platform: ruby
 authors:
 - Claudio Baccigalupo
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-05-15 00:00:00.000000000 Z
+date: 2014-05-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -121,13 +121,12 @@ files:
 - lib/yt/actions/delete_all.rb
 - lib/yt/actions/insert.rb
 - lib/yt/actions/list.rb
-- lib/yt/actions/request.rb
-- lib/yt/actions/request_error.rb
 - lib/yt/actions/update.rb
 - lib/yt/associations.rb
 - lib/yt/associations/annotations.rb
 - lib/yt/associations/channels.rb
 - lib/yt/associations/details_sets.rb
+- lib/yt/associations/ids.rb
 - lib/yt/associations/playlist_items.rb
 - lib/yt/associations/playlists.rb
 - lib/yt/associations/ratings.rb
@@ -140,6 +139,7 @@ files:
 - lib/yt/collections/base.rb
 - lib/yt/collections/channels.rb
 - lib/yt/collections/details_sets.rb
+- lib/yt/collections/ids.rb
 - lib/yt/collections/playlist_items.rb
 - lib/yt/collections/playlists.rb
 - lib/yt/collections/ratings.rb
@@ -148,6 +148,11 @@ files:
 - lib/yt/collections/user_infos.rb
 - lib/yt/collections/videos.rb
 - lib/yt/config.rb
+- lib/yt/errors/base.rb
+- lib/yt/errors/error.rb
+- lib/yt/errors/failed.rb
+- lib/yt/errors/no_items.rb
+- lib/yt/errors/unauthenticated.rb
 - lib/yt/models/account.rb
 - lib/yt/models/annotation.rb
 - lib/yt/models/base.rb
@@ -155,18 +160,22 @@ files:
 - lib/yt/models/configuration.rb
 - lib/yt/models/description.rb
 - lib/yt/models/details_set.rb
+- lib/yt/models/id.rb
 - lib/yt/models/playlist.rb
 - lib/yt/models/playlist_item.rb
 - lib/yt/models/rating.rb
+- lib/yt/models/request.rb
 - lib/yt/models/resource.rb
 - lib/yt/models/snippet.rb
 - lib/yt/models/status.rb
 - lib/yt/models/subscription.rb
+- lib/yt/models/url.rb
 - lib/yt/models/user_info.rb
 - lib/yt/models/video.rb
 - lib/yt/version.rb
 - spec/associations/device_auth/channels_spec.rb
 - spec/associations/device_auth/details_sets_spec.rb
+- spec/associations/device_auth/ids_spec.rb
 - spec/associations/device_auth/playlist_items_spec.rb
 - spec/associations/device_auth/playlists_spec.rb
 - spec/associations/device_auth/ratings_spec.rb
@@ -177,6 +186,7 @@ files:
 - spec/associations/no_auth/annotations_spec.rb
 - spec/associations/server_auth/channels_spec.rb
 - spec/associations/server_auth/details_sets_spec.rb
+- spec/associations/server_auth/ids_spec.rb
 - spec/associations/server_auth/playlist_items_spec.rb
 - spec/associations/server_auth/playlists_spec.rb
 - spec/associations/server_auth/ratings_spec.rb
@@ -194,6 +204,10 @@ files:
 - spec/collections/subscriptions_spec.rb
 - spec/collections/user_infos_spec.rb
 - spec/collections/videos_spec.rb
+- spec/errors/failed_spec.rb
+- spec/errors/no_items_spec.rb
+- spec/errors/unauthenticated_spec.rb
+- spec/models/account_spec.rb
 - spec/models/annotation_spec.rb
 - spec/models/channel_spec.rb
 - spec/models/configuration_spec.rb
@@ -202,13 +216,17 @@ files:
 - spec/models/playlist_item_spec.rb
 - spec/models/playlist_spec.rb
 - spec/models/rating_spec.rb
+- spec/models/request_spec.rb
+- spec/models/resource_spec.rb
 - spec/models/snippet_spec.rb
 - spec/models/status_spec.rb
 - spec/models/subscription_spec.rb
+- spec/models/url_spec.rb
 - spec/models/user_info_spec.rb
 - spec/models/video_spec.rb
 - spec/spec_helper.rb
 - spec/support/device_app.rb
+- spec/support/fail_matcher.rb
 - spec/support/server_app.rb
 - yt.gemspec
 homepage: http://github.com/Fullscreen/yt
@@ -239,6 +257,7 @@ summary: Yt makes it easy to interact with Youtube V3 API by providing a modular
 test_files:
 - spec/associations/device_auth/channels_spec.rb
 - spec/associations/device_auth/details_sets_spec.rb
+- spec/associations/device_auth/ids_spec.rb
 - spec/associations/device_auth/playlist_items_spec.rb
 - spec/associations/device_auth/playlists_spec.rb
 - spec/associations/device_auth/ratings_spec.rb
@@ -249,6 +268,7 @@ test_files:
 - spec/associations/no_auth/annotations_spec.rb
 - spec/associations/server_auth/channels_spec.rb
 - spec/associations/server_auth/details_sets_spec.rb
+- spec/associations/server_auth/ids_spec.rb
 - spec/associations/server_auth/playlist_items_spec.rb
 - spec/associations/server_auth/playlists_spec.rb
 - spec/associations/server_auth/ratings_spec.rb
@@ -266,6 +286,10 @@ test_files:
 - spec/collections/subscriptions_spec.rb
 - spec/collections/user_infos_spec.rb
 - spec/collections/videos_spec.rb
+- spec/errors/failed_spec.rb
+- spec/errors/no_items_spec.rb
+- spec/errors/unauthenticated_spec.rb
+- spec/models/account_spec.rb
 - spec/models/annotation_spec.rb
 - spec/models/channel_spec.rb
 - spec/models/configuration_spec.rb
@@ -274,12 +298,16 @@ test_files:
 - spec/models/playlist_item_spec.rb
 - spec/models/playlist_spec.rb
 - spec/models/rating_spec.rb
+- spec/models/request_spec.rb
+- spec/models/resource_spec.rb
 - spec/models/snippet_spec.rb
 - spec/models/status_spec.rb
 - spec/models/subscription_spec.rb
+- spec/models/url_spec.rb
 - spec/models/user_info_spec.rb
 - spec/models/video_spec.rb
 - spec/spec_helper.rb
 - spec/support/device_app.rb
+- spec/support/fail_matcher.rb
 - spec/support/server_app.rb
 has_rdoc: