yp-ruby 0.1.2 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0caf737e9e7156d763dc679acdd059c8379f76cd
-  data.tar.gz: 1debc4630ecbc1ef807622deff78a10228cc73ae
+  metadata.gz: c0e8f0cb22b7a4f03a355e460984e1ac50da242b
+  data.tar.gz: fa63594396cabc343e2699290b1223c762c903fb
 SHA512:
-  metadata.gz: 244c9f4afec50d95f0bcad7522395d466cb5853d57d1b2e7af2c12f14d0272070ff83c7b772f5e299d9d842082b9bff26714cbdaf676773f319be78ea9061a61
-  data.tar.gz: 941afacc6018c672139fc338cb475f40719f406d1781216f6956e51b8ef2685d12d6599a47217dded3a12d490501fb62845250abc5d4b849da675e658e5b80f0
+  metadata.gz: 9e96e8bfbb983d3336d1b81798087b6d81c64b1631f748488fccaa8206210aa325d1b4c5341523192a141bdb5c80d61882247fad4767a8d1e548a2145c487eff
+  data.tar.gz: 01ec3ed018db1179656697a4ea112b493e04021d3453ff58519f45041abc6d9623b6bd348fe267bb4f1206ee501c32590912cc84fae86fd7af495694740a5ac2

data/lib/base.rb

@@ -1,3 +1,5 @@
+require 'transaction_logger'
+
 module Yp
   class Base
     TYPE = {
@@ -16,7 +18,7 @@ module Yp
     def body
       @params.clone.tap do |params|
         params[:signature] = create_signing_hash
-        Yp.logger.info "[YP] Sending transaction with params #{params.to_s}"
+        TransactionLogger.log_request(params)
       end
     end
 
@@ -69,7 +71,7 @@ module Yp
 
       def parse(response)
         ruby_hash_from_response(CGI::parse(response)).tap do |parsed|
-          Yp.logger.info "[YP] Response received with params #{parsed}"
+          TransactionLogger.log_response(parsed)
         end
       end
 

data/lib/transaction_logger.rb

@@ -0,0 +1,39 @@
+module Yp
+  class TransactionLogger
+    class << self
+
+      FILTERED_KEYS = %w(cardNumber cardCVV cardExpiryMonth cardExpiryYear)
+
+      def log_request(params)
+        info 'Sending transaction', params
+      end
+
+      def log_response(params)
+        info 'Response received', params
+      end
+
+      private
+
+      def info(str, params=nil)
+        Yp.logger.info("#{format_message(str)} #{format_params(params)}")
+      end
+
+      def format_message(str)
+        "[YP] #{str}"
+      end
+
+      def format_params(params)
+        " with params #{filter_card_params(params).to_s}"
+      end
+
+      def filter_card_params(hash)
+        hash.reduce({}) { |memo, param| memo.merge(apply_filter(*param)) }
+      end
+
+      def apply_filter(k, v)
+        { k => FILTERED_KEYS.include?(k.to_s) ? '[FILTERED]' : v }
+      end
+
+    end
+  end
+end

data/lib/version.rb

@@ -1,3 +1,3 @@
 module Yp
-    VERSION = "0.1.2"
+    VERSION = "0.1.3"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: yp-ruby
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - Andrew Hall
@@ -139,6 +139,7 @@ files:
 - lib/nil_logger.rb
 - lib/preauth.rb
 - lib/sale.rb
+- lib/transaction_logger.rb
 - lib/verify.rb
 - lib/version.rb
 - lib/yp.rb