youtube-rb 0.2.0 → 0.3.0

data/spec/integration/ytdlp_integration_spec.rb

@@ -50,17 +50,7 @@ RSpec.describe "YoutubeRb + yt-dlp Integration", :integration do
     end
   end
 
-  describe "backend selection" do
-    it "creates client with yt-dlp backend enabled" do
-      client = YoutubeRb::Client.new(use_ytdlp: true, verbose: false)
-      expect(client.options.use_ytdlp).to be true
-    end
-
-    it "creates client with fallback mode" do
-      client = YoutubeRb::Client.new(ytdlp_fallback: true, verbose: false)
-      expect(client.options.ytdlp_fallback).to be true
-    end
-
+  describe "client configuration" do
     it "creates client with verbose mode" do
       client = YoutubeRb::Client.new(verbose: true)
       expect(client.options.verbose).to be true
@@ -94,7 +84,6 @@ RSpec.describe "YoutubeRb + yt-dlp Integration", :integration do
     it "downloads video segment using yt-dlp backend" do
       client = YoutubeRb::Client.new(
         output_path: output_dir,
-        use_ytdlp: true,
         verbose: false
       )
 

data/spec/real_download_spec.rb

@@ -63,7 +63,6 @@ RSpec.describe "Real video downloads", :real_download do
       
       client = YoutubeRb::Client.new(
         output_path: output_dir,
-        use_ytdlp: true,
         verbose: true
       )
 
@@ -112,7 +111,6 @@ RSpec.describe "Real video downloads", :real_download do
       
       client = YoutubeRb::Client.new(
         output_path: output_dir,
-        use_ytdlp: true,
         verbose: true
       )
 
@@ -128,39 +126,12 @@ RSpec.describe "Real video downloads", :real_download do
     end
   end
 
-  describe "fallback mechanism" do
-    let(:test_url) { 'https://www.youtube.com/watch?v=dQw4w9WgXcQ' }
-
-    it "falls back to yt-dlp when pure Ruby fails", :very_slow do
-      puts "\n  → Testing automatic fallback to yt-dlp"
-      puts "  → This may download ~240MB of video data..."
-      
-      client = YoutubeRb::Client.new(
-        output_path: output_dir,
-        use_ytdlp: false,      # Start with pure Ruby
-        ytdlp_fallback: true,  # Enable fallback
-        verbose: true
-      )
-
-      # This should try pure Ruby first, then fall back to yt-dlp
-      output_file = client.download(test_url)
-      
-      expect(output_file).to be_a(String)
-      expect(File.exist?(output_file)).to be true
-      expect(File.size(output_file)).to be > 10_000_000  # At least 10MB
-      
-      puts "  ✓ Fallback worked, file downloaded"
-      puts "  ✓ File size: #{(File.size(output_file) / 1024.0 / 1024.0).round(2)} MB"
-    end
-  end
-
   describe "error handling" do
     it "raises error for invalid video ID" do
       puts "\n  → Testing error handling for invalid video"
       
       client = YoutubeRb::Client.new(
-        output_path: output_dir,
-        use_ytdlp: true
+        output_path: output_dir
       )
 
       invalid_url = 'https://www.youtube.com/watch?v=invalidvideoid'

data/spec/support/mocking_helper.rb

@@ -1,18 +1,113 @@
+require 'json'
+require 'fileutils'
+
 module MockingHelper
-  # Mock the Extractor to return video info without making HTTP requests
-  def mock_extractor(video_data)
+  # Mock the YtdlpWrapper to return video info without making actual yt-dlp calls
+  def mock_ytdlp(video_data)
     video_info = YoutubeRb::VideoInfo.new(video_data)
     
-    allow_any_instance_of(YoutubeRb::Extractor).to receive(:extract_info).and_return(video_info)
-    allow_any_instance_of(YoutubeRb::Extractor).to receive(:extract_formats).and_return(video_data['formats'] || [])
-    allow_any_instance_of(YoutubeRb::Extractor).to receive(:extract_subtitles).and_return(video_data['subtitles'] || {})
+    # Mock YtdlpWrapper availability
+    allow(YoutubeRb::YtdlpWrapper).to receive(:available?).and_return(true)
+    
+    # Mock extract_info to return video data
+    allow_any_instance_of(YoutubeRb::YtdlpWrapper).to receive(:extract_info).and_return(video_data)
+    
+    # Mock download methods - create actual files
+    allow_any_instance_of(YoutubeRb::YtdlpWrapper).to receive(:download) do |instance, url, output_path|
+      # If output_path is provided, use it; otherwise generate from options
+      if output_path
+        output_file = output_path
+      else
+        options = instance.instance_variable_get(:@options)
+        output_dir = options.output_path || (@test_output_dir || './test_downloads')
+        template = options.output_template || '%(title)s-%(id)s.%(ext)s'
+        
+        # Simple template replacement
+        filename = template
+          .gsub('%(title)s', (video_data['title'] || 'video').gsub(/[\/\\:*?"<>|]/, '_'))
+          .gsub('%(id)s', video_data['id'] || 'unknown')
+          .gsub('%(ext)s', video_data['ext'] || 'mp4')
+        
+        output_file = File.join(output_dir, filename)
+      end
+      
+      # Ensure directory exists
+      FileUtils.mkdir_p(File.dirname(output_file))
+      
+      # Create a fake video file
+      File.write(output_file, "fake video data" * 1000)
+      
+      # Create subtitle files if requested
+      options = instance.instance_variable_get(:@options)
+      if options && (options.write_subtitles || options.write_auto_sub)
+        base_name = File.basename(output_file, File.extname(output_file))
+        subtitle_langs = options.subtitle_langs || ['en']
+        subtitle_format = options.subtitle_format || 'srt'
+        available_subtitles = video_data['subtitles'] || {}
+        
+        subtitle_langs.each do |lang|
+          # Only create subtitle file if language is available in video data
+          next unless available_subtitles.key?(lang)
+          
+          subtitle_file = File.join(File.dirname(output_file), "#{base_name}.#{lang}.#{subtitle_format}")
+          File.write(subtitle_file, "WEBVTT\n\n00:00:00.000 --> 00:00:10.000\nTest subtitle")
+        end
+      end
+      
+      # Create metadata files if requested
+      if options
+        base_name = File.basename(output_file, File.extname(output_file))
+        dir = File.dirname(output_file)
+        
+        if options.write_info_json
+          info_file = File.join(dir, "#{base_name}.info.json")
+          File.write(info_file, JSON.generate(video_data))
+        end
+        
+        if options.write_thumbnail && video_data['thumbnail']
+          ext = File.extname(video_data['thumbnail']).split('?').first || '.jpg'
+          thumbnail_file = File.join(dir, "#{base_name}#{ext}")
+          File.write(thumbnail_file, "fake thumbnail data")
+        end
+        
+        if options.write_description && video_data['description']
+          desc_file = File.join(dir, "#{base_name}.description")
+          File.write(desc_file, video_data['description'])
+        end
+      end
+      
+      output_file
+    end
+    
+    # Mock download_segment
+    allow_any_instance_of(YoutubeRb::YtdlpWrapper).to receive(:download_segment) do |_, url, start_time, end_time, output_path|
+      output_file = output_path || File.join(@test_output_dir || './test_downloads', "segment-#{start_time}-#{end_time}.mp4")
+      
+      # Ensure directory exists
+      FileUtils.mkdir_p(File.dirname(output_file))
+      
+      # Create a fake segment file
+      File.write(output_file, "fake segment data" * 1000)
+      
+      output_file
+    end
     
     video_info
   end
 
-  # Mock extractor to raise error
-  def mock_extractor_error(error_class = YoutubeRb::Extractor::ExtractionError, message = 'Test error')
-    allow_any_instance_of(YoutubeRb::Extractor).to receive(:extract_info).and_raise(error_class, message)
+  # For backward compatibility with tests that use mock_extractor
+  alias_method :mock_extractor, :mock_ytdlp
+
+  # Mock YtdlpWrapper to raise error
+  def mock_ytdlp_error(message = 'Test error')
+    allow(YoutubeRb::YtdlpWrapper).to receive(:available?).and_return(true)
+    allow_any_instance_of(YoutubeRb::YtdlpWrapper).to receive(:extract_info)
+      .and_raise(YoutubeRb::YtdlpWrapper::YtdlpError, message)
+  end
+
+  # For backward compatibility
+  def mock_extractor_error(error_class = nil, message = 'Test error')
+    mock_ytdlp_error(message)
   end
 end
 

data/spec/youtube_rb_spec.rb

@@ -59,8 +59,6 @@ RSpec.describe YoutubeRb do
         expect(options.format).to eq('best')
         expect(options.quality).to eq('best')
         expect(options.output_path).to eq('./downloads')
-        expect(options.use_ytdlp).to eq(false)
-        expect(options.ytdlp_fallback).to eq(true)
         expect(options.verbose).to eq(false)
       end
 
@@ -69,26 +67,22 @@ RSpec.describe YoutubeRb do
           format: '1080p',
           output_path: '/tmp',
           write_subtitles: true,
-          use_ytdlp: true,
           verbose: true
         )
         expect(options.format).to eq('1080p')
         expect(options.output_path).to eq('/tmp')
         expect(options.write_subtitles).to eq(true)
-        expect(options.use_ytdlp).to eq(true)
         expect(options.verbose).to eq(true)
       end
     end
 
     describe "#to_h" do
       it "returns hash representation" do
-        options = YoutubeRb::Options.new(format: 'best', use_ytdlp: true)
+        options = YoutubeRb::Options.new(format: 'best', verbose: true)
         hash = options.to_h
         expect(hash).to be_a(Hash)
         expect(hash[:format]).to eq('best')
-        expect(hash[:use_ytdlp]).to eq(true)
-        expect(hash).to have_key(:ytdlp_fallback)
-        expect(hash).to have_key(:verbose)
+        expect(hash[:verbose]).to eq(true)
       end
     end
 
@@ -169,16 +163,6 @@ RSpec.describe YoutubeRb do
     end
   end
 
-  describe YoutubeRb::Extractor do
-    let(:extractor) { YoutubeRb::Extractor.new('https://www.youtube.com/watch?v=test') }
-
-    describe "#initialize" do
-      it "creates extractor with URL" do
-        expect(extractor.url).to eq('https://www.youtube.com/watch?v=test')
-      end
-    end
-  end
-
   describe YoutubeRb::Downloader do
     let(:url) { 'https://www.youtube.com/watch?v=test' }
     let(:options) { YoutubeRb::Options.new(output_path: './test_downloads') }

data/youtube-rb.gemspec

@@ -12,9 +12,9 @@ Gem::Specification.new do |spec|
   spec.license       = "MIT"
   spec.required_ruby_version = ">= 3.4.0"
 
-  spec.metadata["homepage_uri"] = spec.homepage
   spec.metadata["source_code_uri"] = "https://github.com/Qew7/youtube-rb"
   spec.metadata["changelog_uri"] = "https://github.com/Qew7/youtube-rb/blob/master/CHANGELOG.md"
+  spec.metadata["bug_tracker_uri"] = "https://github.com/Qew7/youtube-rb/issues"
 
   # Specify which files should be added to the gem when it is released.
   spec.files = Dir.glob("{lib,bin,spec}/**/*") + %w[README.md LICENSE Rakefile youtube-rb.gemspec]
@@ -31,7 +31,7 @@ Gem::Specification.new do |spec|
   spec.add_dependency "base64", "~> 0.2"
 
   # Development dependencies
-  spec.add_development_dependency "bundler", ">= 2.7"
+  spec.add_development_dependency "bundler", ">= 2.0"
   spec.add_development_dependency "rake", "~> 13.0"
   spec.add_development_dependency "rspec", "~> 3.13"
   spec.add_development_dependency "webmock", "~> 3.26"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: youtube-rb
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.3.0
 platform: ruby
 authors:
 - Maxim Veysgeym
@@ -99,14 +99,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '2.7'
+        version: '2.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '2.7'
+        version: '2.0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -181,7 +181,6 @@ files:
 - lib/youtube-rb.rb
 - lib/youtube-rb/client.rb
 - lib/youtube-rb/downloader.rb
-- lib/youtube-rb/extractor.rb
 - lib/youtube-rb/options.rb
 - lib/youtube-rb/version.rb
 - lib/youtube-rb/video_info.rb
@@ -206,9 +205,9 @@ homepage: https://github.com/Qew7/youtube-rb
 licenses:
 - MIT
 metadata:
-  homepage_uri: https://github.com/Qew7/youtube-rb
   source_code_uri: https://github.com/Qew7/youtube-rb
   changelog_uri: https://github.com/Qew7/youtube-rb/blob/master/CHANGELOG.md
+  bug_tracker_uri: https://github.com/Qew7/youtube-rb/issues
 rdoc_options: []
 require_paths:
 - lib