youtube-dl.rb 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c8aa4aaf1fec27c155961efff901ade4498033d3
-  data.tar.gz: caf564fb87360422cbfaedacf413aa3dc7929a41
+  metadata.gz: 06e7be65305bac08f73eb43c881dd2527467ba73
+  data.tar.gz: 899718fd19305a6403afdb323962272a104e6a24
 SHA512:
-  metadata.gz: 45a5112701f59e6b028a329000e056c70b3f1575d70cb3517c8c6ca07fc7d23c42e16c002a13df663c07bf6b64dc21b98fae3063fc07bbb7d39541cc281da4c6
-  data.tar.gz: 84321d4274729c199d4c9f893b71205b0c8bb46bba71f2185bdd2c2073f44ac5c464a054ad17ff3fe9d46060dbe2fa1c843d95e98a0dfd485a35027f129fae13
+  metadata.gz: 0c4a12fde5f32a50e5f0088f62c88250f318f3f79d51bc64bc4c98d78316bae84595415968b7a088d007ffb239032c23adf61e5bb83d80a8adcc458ee3e44583
+  data.tar.gz: 963a46ce16a4b1b161b503b486409bea3091268040e83aac1a44cace3d4b4d2c1e4ba4e74fcc7a3b201990d098f98adc320f5c576374bde5983d4bde1aaf004b

data/.travis.yml

@@ -1,7 +1,7 @@
 before_install: 'sudo chmod 755 ./vendor/bin/youtube-dl'
 rvm:
-- 1.9.3
-- 2.0.0
-- 2.1.5
-- jruby-19mode
-- rbx-2
+- 1.9.3 # EOL, but still supporting
+- 2.0.0 # Oldest stable
+- 2.2.2 # Current stable
+# - jruby-19mode # JRuby
+- rbx-2 # Rubinius

data/README.md

@@ -1,7 +1,10 @@
 # youtube-dl.rb
 
 Ruby wrapper for [youtube-dl](http://rg3.github.io/youtube-dl/).
+
 [![Build Status](https://travis-ci.org/layer8x/youtube-dl.rb.svg?branch=master)](https://travis-ci.org/layer8x/youtube-dl.rb)
+[![Code Climate](https://codeclimate.com/github/layer8x/youtube-dl.rb/badges/gpa.svg)](https://codeclimate.com/github/layer8x/youtube-dl.rb)
+[![Test Coverage](https://codeclimate.com/github/layer8x/youtube-dl.rb/badges/coverage.svg)](https://codeclimate.com/github/layer8x/youtube-dl.rb/coverage)
 
 ## Install the gem
 
@@ -52,4 +55,4 @@ YoutubeDL.download "https://www.youtube.com/watch?v=gvdf5n-zI14", options
 5. Push to the branch (`git push origin my-new-feature`)
 6. Create a new Pull Request
 
-Remember: commit now, commit often. 
+Remember: commit now, commit often.

data/lib/youtube-dl/runner.rb

@@ -75,7 +75,7 @@ module YoutubeDL
     def usable_executable_path
       system_path = `which youtube-dl`
       if $?.exitstatus == 0
-        system_path
+        system_path.strip
       else
         vendor_path = File.absolute_path("#{__FILE__}/../../../vendor/bin/youtube-dl")
         File.chmod(775, vendor_path) unless File.executable?(vendor_path) # Make sure vendor binary is executable

data/lib/youtube-dl/version.rb

@@ -1,3 +1,3 @@
 module YoutubeDL
-  VERSION = "0.0.3"
+  VERSION = "0.0.4"
 end

data/test/test_helper.rb

@@ -1,5 +1,10 @@
-require "codeclimate-test-reporter"
-CodeClimate::TestReporter.start
+if RUBY_PLATFORM == "java"
+  require 'simplecov'
+  SimpleCov.start
+else
+  require "codeclimate-test-reporter"
+  CodeClimate::TestReporter.start
+end
 gem 'minitest'
 require 'minitest/autorun'
 require 'minitest/spec'

data/test/youtube-dl/runner_test.rb

@@ -21,6 +21,14 @@ describe YoutubeDL::Runner do
     assert_match 'youtube-dl', @runner.executable_path
   end
 
+  it 'should not have a newline char in the executable_path' do
+    assert_match /youtube-dl\z/, @runner.executable_path
+  end
+
+  it 'should not have newline char in to_command' do
+    assert_match /youtube-dl\s/, @runner.to_command
+  end
+
   it 'should parse key-values from options' do
     @runner.options.some_key = "a value"
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: youtube-dl.rb
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - sapslaj
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-07-20 00:00:00.000000000 Z
+date: 2015-07-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: cocaine