yoshiki 9.0.0.pre.1 → 9.0.0.pre.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: bc0386cead52524a740a6c00fa221f50de4e46ed129fad9762795d487a6a252c
-  data.tar.gz: c8aba054feb43c59cd449d6c3bf08581992365baa07c5685411763d0de664920
+  metadata.gz: 700dac07edfbcd20f2a1aa4e9b9d861c82ae51f5904cfe3a04782f95a7438cce
+  data.tar.gz: c11cda978ac3c1c719c5f8f74a9b438778f2ce381fd2675cae653e5c27d018db
 SHA512:
-  metadata.gz: 26009eb4c0574a765a2bf52d759acd138db916a1e02a5baab7593c83b760b3844c20ac113e104ca2d5d60a5e7c59acb57520877bc5d58d2b80af1769a247a04b
-  data.tar.gz: bf079dd8bde99d32d184a832feaadfcf7b8934d22e591f749c15ac96a2cea0c44b0116679ec344686e9dec12bd4202123608d26e1567c9bf17bfa20ad1ae6d6b
+  metadata.gz: c158e1da50bae9b454bfae823ae68320dea1b11bc8fdfc851a16950aac735b677482943ac1e90ad9b6b94f75aa0cf2a94e85586d34bfb3c29ca94c09897bc9b1
+  data.tar.gz: fc6f07f578af3cfe03262852fa9da0c7c3da6ab96026f0ebbec093c6e087656831c9f33a794dba7ae251cc9489237e0089c69a6ab311bdea773993e7367ed725

data/.gitlab-ci.yml

@@ -7,6 +7,16 @@ before_script:
   - gem update bundler
   - bundle install --clean --jobs $(nproc) --retry=3
 
+ruby 3.3:
+  cache:
+    key: "$CI_BUILD_REF_NAME-3.3"
+    paths:
+      - vendor/bundle
+  image: ruby:3.3-alpine
+  script:
+    - bundle exec rake spec rubocop
+  stage: test
+
 ruby 3.2:
   cache:
     key: "$CI_BUILD_REF_NAME-3.2"

data/.rubocop-defaults.yml

@@ -1,4 +1,7 @@
 require:
+  - rubocop-capybara
+  - rubocop-factory_bot
+  - rubocop-performance
   - rubocop-rake
   - rubocop-rspec
 
@@ -6,6 +9,8 @@ Capybara/MatchStyle: # new in 2.17
   Enabled: true
 Capybara/NegationMatcher: # new in 2.14
   Enabled: true
+Capybara/RedundantWithinFind: # new in 2.20
+  Enabled: true
 Capybara/SpecificActions: # new in 2.14
   Enabled: true
 Capybara/SpecificMatcher: # new in 2.12
@@ -16,6 +21,8 @@ Capybara/RSpec/HaveSelector: # new in 2.19
 
 FactoryBot/AssociationStyle: # new in 2.23
   Enabled: true
+FactoryBot/ExcessiveCreateList: # new in 2.25
+  Enabled: true
 FactoryBot/FactoryAssociationWithStrategy: # new in 2.23
   Enabled: true
 FactoryBot/FactoryClassName: # new in 1.37
@@ -117,6 +124,43 @@ Lint/UselessRuby2Keywords: # new in 1.23
 Metrics/CollectionLiteralLength: # new in 1.47
   Enabled: true
 
+Performance/AncestorsInclude: # new in 1.7
+  Enabled: true
+Performance/BlockGivenWithExplicitBlock: # new in 1.9
+  Enabled: true
+Performance/CollectionLiteralInLoop: # new in 1.8
+  Enabled: true
+Performance/ConcurrentMonotonicTime: # new in 1.12
+  Enabled: true
+Performance/ConstantRegexp: # new in 1.9
+  Enabled: true
+Performance/MapCompact: # new in 1.11
+  Enabled: true
+Performance/MapMethodChain: # new in 1.19
+  Enabled: true
+Performance/MethodObjectAsBlock: # new in 1.9
+  Enabled: true
+Performance/RedundantEqualityComparisonBlock: # new in 1.10
+  Enabled: true
+Performance/RedundantSortBlock: # new in 1.7
+  Enabled: true
+Performance/RedundantSplitRegexpArgument: # new in 1.10
+  Enabled: true
+Performance/RedundantStringChars: # new in 1.7
+  Enabled: true
+Performance/ReverseFirst: # new in 1.7
+  Enabled: true
+Performance/SortReverse: # new in 1.7
+  Enabled: true
+Performance/Squeeze: # new in 1.7
+  Enabled: true
+Performance/StringIdentifierArgument: # new in 1.13
+  Enabled: true
+Performance/StringInclude: # new in 1.7
+  Enabled: true
+Performance/Sum: # new in 1.8
+  Enabled: true
+
 RSpec/BeEmpty: # new in 2.20
   Enabled: true
 RSpec/BeEq: # new in 2.9.0
@@ -151,6 +195,10 @@ RSpec/ReceiveMessages: # new in 2.23
   Enabled: true
 RSpec/RedundantAround: # new in 2.19
   Enabled: true
+RSpec/RedundantPredicateMatcher: # new in 2.26
+  Enabled: true
+RSpec/RemoveConst: # new in 2.26
+  Enabled: true
 RSpec/SkipBlockInsideExample: # new in 2.19
   Enabled: true
 RSpec/SortMetadata: # new in 2.14

data/.rubocop.yml

@@ -1,12 +1,8 @@
 AllCops:
-  TargetRubyVersion: 3.0
+  TargetRubyVersion: 3.3
 
 inherit_from:
-  - .rubocop-defaults.yml
-  - .rubocop-defaults-rails.yml
   - .yoshiki.yml
 
-Naming/FileName:
-  Exclude:
-    - lib/yoshiki.rb
-    - spec/yoshiki_spec.rb
+Gemspec/RequiredRubyVersion:
+  Enabled: false

data/.yoshiki-rails.yml

@@ -8,8 +8,8 @@ AllCops:
     - lib/templates/**/*
     - vendor/**/*
 
-Rails:
-  Enabled: true
+inherit_from:
+  - .rubocop-defaults-rails.yml
 
 Capybara/ClickLinkOrButtonStyle: # new in 2.19
   Enabled: true
@@ -26,6 +26,11 @@ FactoryBot/ConsistentParenthesesStyle: # new in 2.14
   Enabled: true
   EnforcedStyle: omit_parentheses # default is `require_parentheses`
 
+Metrics/BlockLength:
+  Exclude:
+    - config/application.rb
+    - config/environments/**/*.rb
+
 Rails/Inquiry: # new in 2.7
   Enabled: false
 Rails/Output:
@@ -48,9 +53,16 @@ Rails/ToSWithArgument: # new in 2.16
 
 Style/Documentation: # this isn't a rails cop, but this config only makes sense for rails projects
   Exclude: # default config doesn't exclude migrations
+    - app/controllers/application_controller.rb
     - app/helpers/application_helper.rb
+    - app/jobs/application_job.rb
+    - app/mailers/application_mailer.rb
     - app/models/application_record.rb
     - config/application.rb
     - db/migrate/**/*
+    - lib/application_responder.rb
     - spec/**/*
     - test/**/*
+Style/EmptyMethod:
+  Exclude:
+    - app/controllers/**/*_controller.rb

data/.yoshiki-ruby.yml

@@ -11,6 +11,9 @@ AllCops:
     - bin/**/*
     - Gemfile.lock
 
+inherit_from:
+  - .rubocop-defaults.yml
+
 Layout/AccessModifierIndentation:
   EnforcedStyle: outdent # default is `indent`
 Layout/BeginEndAlignment:
@@ -102,6 +105,17 @@ Naming/PredicateName:
   AllowedMethods:
     - is_a?
 
+Performance/ChainArrayAllocation:
+  Enabled: true
+Performance/BigDecimalWithNumericArgument: # new in 1.7
+  Enabled: false # this cop can actually reduce performance: https://github.com/rubocop/rubocop-performance/issues/329#issuecomment-1451511402
+Performance/CaseWhenSplat:
+  Enabled: true
+  AutoCorrect: true
+  SafeAutoCorrect: true
+Performance/SelectMap:
+  Enabled: true
+
 RSpec/ContextWording:
   Prefixes:
     - as a
@@ -115,14 +129,21 @@ RSpec/ImplicitExpect:
   EnforcedStyle: should
 RSpec/ImplicitSubject:
   EnforcedStyle: single_statement_only # default is `single_line_only`
+  Exclude:
+    - spec/system/**/*.rb # allow implicit subject in system specs
 RSpec/LeadingSubject:
   Enabled: false # prefer subject after all let and let!
 RSpec/NestedGroups: # this cop can be configured with `AllowedGroups`
   Enabled: false
 RSpec/PendingWithoutReason: # new in 2.16
   Enabled: false
+RSpec/NoExpectationExample:
+  Exclude:
+    - spec/models/factory_spec.rb
 RSpec/NotToNot:
   EnforcedStyle: to_not # default is not_to; prefer common prefix
+RSpec/MultipleExpectations:
+  Enabled: false # recommend using `aggregate_failures`
 RSpec/SubjectStub: # allow stubbing subject
   Enabled: false   # should only be used for methods *not* under test
 
@@ -139,6 +160,8 @@ Style/DoubleNegation:
 Style/EndlessMethod: # new in 1.8
   Enabled: true
   EnforcedStyle: disallow # default is `allow_single_line`
+Style/FrozenStringLiteralComment:
+  SafeAutoCorrect: true # default is `false`
 Style/HashSyntax:
   EnforcedShorthandSyntax: consistent # default is `always`
 Style/MethodDefParentheses:

data/Gemfile.lock

@@ -1,47 +1,58 @@
 PATH
   remote: .
   specs:
-    yoshiki (9.0.0.pre.1)
-      rubocop (= 1.56.4)
-      rubocop-capybara (= 2.19.0)
-      rubocop-factory_bot (= 2.24.0)
-      rubocop-rails (= 2.22.2)
-      rubocop-rake (= 0.6.0)
-      rubocop-rspec (= 2.25.0)
+    yoshiki (9.0.0.pre.2)
+      rubocop (>= 1.56.4)
+      rubocop-capybara (>= 2.19.0)
+      rubocop-factory_bot (>= 2.24.0)
+      rubocop-performance (>= 1.20.2)
+      rubocop-rails (>= 2.22.2)
+      rubocop-rake (>= 0.6.0)
+      rubocop-rspec (>= 2.25.0)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    activesupport (7.0.8)
+    activesupport (7.1.3)
+      base64
+      bigdecimal
       concurrent-ruby (~> 1.0, >= 1.0.2)
+      connection_pool (>= 2.2.5)
+      drb
       i18n (>= 1.6, < 2)
       minitest (>= 5.1)
+      mutex_m
       tzinfo (~> 2.0)
     ast (2.4.2)
-    base64 (0.1.1)
+    base64 (0.2.0)
+    bigdecimal (3.1.6)
     coderay (1.1.3)
-    concurrent-ruby (1.2.2)
+    concurrent-ruby (1.2.3)
+    connection_pool (2.4.1)
     diff-lcs (1.5.0)
+    drb (2.2.0)
+      ruby2_keywords
     i18n (1.14.1)
       concurrent-ruby (~> 1.0)
-    json (2.6.3)
+    json (2.7.1)
     language_server-protocol (3.17.0.3)
     method_source (1.0.0)
-    minitest (5.20.0)
-    parallel (1.23.0)
-    parser (3.2.2.3)
+    minitest (5.21.2)
+    mutex_m (0.2.0)
+    parallel (1.24.0)
+    parser (3.3.0.5)
       ast (~> 2.4.1)
       racc
     pry (0.14.2)
       coderay (~> 1.1)
       method_source (~> 1.0)
-    psych (5.1.0)
+    psych (5.1.2)
       stringio
-    racc (1.7.1)
+    racc (1.7.3)
     rack (3.0.8)
     rainbow (3.1.1)
-    rake (13.0.6)
-    regexp_parser (2.8.1)
+    rake (13.1.0)
+    regexp_parser (2.9.0)
     rexml (3.2.6)
     rspec (3.12.0)
       rspec-core (~> 3.12.0)
@@ -56,40 +67,43 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.12.0)
     rspec-support (3.12.1)
-    rubocop (1.56.4)
-      base64 (~> 0.1.1)
+    rubocop (1.60.1)
       json (~> 2.3)
       language_server-protocol (>= 3.17.0)
       parallel (~> 1.10)
-      parser (>= 3.2.2.3)
+      parser (>= 3.3.0.2)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 1.8, < 3.0)
       rexml (>= 3.2.5, < 4.0)
-      rubocop-ast (>= 1.28.1, < 2.0)
+      rubocop-ast (>= 1.30.0, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 2.4.0, < 3.0)
     rubocop-ast (1.30.0)
       parser (>= 3.2.1.0)
-    rubocop-capybara (2.19.0)
+    rubocop-capybara (2.20.0)
+      rubocop (~> 1.41)
+    rubocop-factory_bot (2.25.1)
       rubocop (~> 1.41)
-    rubocop-factory_bot (2.24.0)
-      rubocop (~> 1.33)
-    rubocop-rails (2.22.2)
+    rubocop-performance (1.20.2)
+      rubocop (>= 1.48.1, < 2.0)
+      rubocop-ast (>= 1.30.0, < 2.0)
+    rubocop-rails (2.23.1)
       activesupport (>= 4.2.0)
       rack (>= 1.1)
       rubocop (>= 1.33.0, < 2.0)
       rubocop-ast (>= 1.30.0, < 2.0)
     rubocop-rake (0.6.0)
       rubocop (~> 1.0)
-    rubocop-rspec (2.25.0)
+    rubocop-rspec (2.26.1)
       rubocop (~> 1.40)
       rubocop-capybara (~> 2.17)
       rubocop-factory_bot (~> 2.22)
     ruby-progressbar (1.13.0)
-    stringio (3.0.8)
+    ruby2_keywords (0.0.5)
+    stringio (3.1.0)
     tzinfo (2.0.6)
       concurrent-ruby (~> 1.0)
-    unicode-display_width (2.4.2)
+    unicode-display_width (2.5.0)
 
 PLATFORMS
   ruby
@@ -102,4 +116,4 @@ DEPENDENCIES
   yoshiki!
 
 BUNDLED WITH
-   2.4.22
+   2.5.5

data/lib/yoshiki/version.rb

@@ -2,6 +2,6 @@
 
 module Yoshiki
 
-  VERSION = '9.0.0-1'
+  VERSION = '9.0.0-3'
 
 end

data/yoshiki.gemspec

@@ -22,10 +22,11 @@ Gem::Specification.new do |spec|
 
   spec.required_ruby_version = '>= 3.0.0'
 
-  spec.add_dependency 'rubocop',             '1.56.4'
-  spec.add_dependency 'rubocop-capybara',    '2.19.0'
-  spec.add_dependency 'rubocop-factory_bot', '2.24.0'
-  spec.add_dependency 'rubocop-rails',       '2.22.2'
-  spec.add_dependency 'rubocop-rake',        '0.6.0'
-  spec.add_dependency 'rubocop-rspec',       '2.25.0'
+  spec.add_dependency 'rubocop',             '>= 1.56.4'
+  spec.add_dependency 'rubocop-capybara',    '>= 2.19.0'
+  spec.add_dependency 'rubocop-factory_bot', '>= 2.24.0'
+  spec.add_dependency 'rubocop-performance', '>= 1.20.2'
+  spec.add_dependency 'rubocop-rails',       '>= 2.22.2'
+  spec.add_dependency 'rubocop-rake',        '>= 0.6.0'
+  spec.add_dependency 'rubocop-rspec',       '>= 2.25.0'
 end

metadata

@@ -1,97 +1,111 @@
 --- !ruby/object:Gem::Specification
 name: yoshiki
 version: !ruby/object:Gem::Version
-  version: 9.0.0.pre.1
+  version: 9.0.0.pre.3
 platform: ruby
 authors:
 - BM5k
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2023-12-14 00:00:00.000000000 Z
+date: 2024-01-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 1.56.4
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 1.56.4
 - !ruby/object:Gem::Dependency
   name: rubocop-capybara
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 2.19.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 2.19.0
 - !ruby/object:Gem::Dependency
   name: rubocop-factory_bot
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 2.24.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 2.24.0
+- !ruby/object:Gem::Dependency
+  name: rubocop-performance
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.20.2
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.20.2
 - !ruby/object:Gem::Dependency
   name: rubocop-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 2.22.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 2.22.2
 - !ruby/object:Gem::Dependency
   name: rubocop-rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 0.6.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 0.6.0
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 2.25.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 2.25.0
 description: Dev Fu! Style for rubocop.
@@ -138,11 +152,11 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: 3.0.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">"
+  - - ">="
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
 requirements: []
-rubygems_version: 3.4.10
+rubygems_version: 3.5.5
 signing_key:
 specification_version: 4
 summary: Dev Fu! Style