ynab_convert 2.0.0 → 2.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 142532dddc82b58043e383e388306801471835c48004fd55b7804709a545999c
-  data.tar.gz: e7de2e56779760e27e41a3cf3bcbaf265bd66377a80525ad00f7133b57c1b05a
+  metadata.gz: f6fb40d39bcae5a21d257b552d80d5c71b501980001957c669b9e8acb08bfdb2
+  data.tar.gz: b63d021d9863957894ec818bc325c91dce46137c05baf281902ec63e7d7deecb
 SHA512:
-  metadata.gz: a4e37509faa4be4db330876e0c6af4bb2deb0927b4bb4aa8feb9b1943a69690d8765087cfe72ebeb49161b708999253e7443f5b3275f5cfc42bc3f23e93232cf
-  data.tar.gz: 4a0eb0cee6a35847ba39d747f6343c39c5cb0750ca8347f9af0ad70fb3d8382ac5e098bbb6b47c8d931b1d095d4829442fd0315b697d6005003ccc8aa7685638
+  metadata.gz: 785a31e077df3ee9e4e0343144ecc87d185b0cc345272723eced2661d29cce2489560192d6e7efd12fdf361327ea5ad7e876cd5ec10e40025be052b9fed6fa3f
+  data.tar.gz: 0f97b6358e6280e8a40aefdae8a7349e9cf0e512df491cfdb86e5c3eb6c6d384753f6af18d6d2667e5d661025c6e7bd334de63da1d6d4d31738973c04f92d1bf

data/.github/workflows/publish.yml

@@ -0,0 +1,36 @@
+---
+name: ruby
+
+on:
+  push:
+    branches: [master]
+
+permissions:
+  contents: read
+
+jobs:
+  publish:
+    name: Build + Publish
+    runs-on: ubuntu-latest
+    permissions:
+      packages: write
+      contents: read
+
+    steps:
+      - uses: actions/checkout@v3
+      - name: Set up Ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          bundler-cache: true # runs 'bundle install' and caches installed gems automatically
+      - name: Run tests
+        run: bundle exec rake ci
+      - name: Publish to RubyGems
+        run: |
+          mkdir -p $HOME/.gem
+          touch $HOME/.gem/credentials
+          chmod 0600 $HOME/.gem/credentials
+          printf -- "---\n:rubygems_api_key: ${GEM_HOST_API_KEY}\n" > $HOME/.gem/credentials
+          gem build *.gemspec
+          gem push *.gem
+        env:
+          GEM_HOST_API_KEY: "${{secrets.RUBYGEMS_AUTH_TOKEN}}"

data/.github/workflows/test.yml

@@ -0,0 +1,31 @@
+---
+name: ruby
+
+on:
+  push:
+    branches: [master]
+  pull_request:
+    branches: [master]
+
+permissions:
+  contents: read
+
+jobs:
+  test:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        ruby-version: ["2.6", "2.7"]
+
+    steps:
+      - uses: actions/checkout@v3
+      - name: Set up Ruby
+        # To automatically get bug fixes and new Ruby versions for ruby/setup-ruby,
+        # change this to (see https://github.com/ruby/setup-ruby#versioning):
+        # uses: ruby/setup-ruby@v1
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby-version }}
+          bundler-cache: true # runs 'bundle install' and caches installed gems automatically
+      - name: Run tests
+        run: bundle exec rake ci

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    ynab_convert (2.0.0)
+    ynab_convert (2.0.4)
       i18n
       slop
       timecop
@@ -15,7 +15,7 @@ GEM
     backport (1.1.2)
     byebug (11.0.1)
     coderay (1.1.2)
-    concurrent-ruby (1.1.9)
+    concurrent-ruby (1.1.10)
     crack (0.4.5)
       rexml
     diff-lcs (1.3)
@@ -114,7 +114,7 @@ GEM
       json (>= 1.8, < 3)
       simplecov-html (~> 0.10.0)
     simplecov-html (0.10.2)
-    slop (4.9.1)
+    slop (4.9.2)
     solargraph (0.37.2)
       backport (~> 1.1)
       bundler (>= 1.17.2)

data/README.md

@@ -28,7 +28,6 @@ latest one on 2019-12-01.
 ---|---|---|---
 `example` | Example Bank | N/A | Reference processor implementation, not a real institution
 `n26` | N26 | [n26.com](n26.com) | N26 CSV statements, will convert EUR amounts to CHF (hardcoded for now)
-`revolut` | Revolut Ltd | [revolut.com](https://www.revolut.com/) | The processor isn't aware of currencies. Make sure the statements processed with `revolut` are in the same currency that your YNAB is in
 `ubs_chequing` | UBS Switzerland (private banking) | [ubs.ch](https://ubs.ch) | Private chequing and joint accounts
 `ubs_credit` | UBS Switzerland (credit cards) | [ubs.ch](https://ubs.ch) | Both MasterCard and Visa
 `wise` | Wise (Transferwise) cards | [wise.com](https://wise.com) | Performs currency conversion (hardcoded to CHF for now)
@@ -124,9 +123,14 @@ Or add `byebug` or `pry` statements in the code (works with guard and with rspec
 If there is no processor for your financial institution, you can contribute one
 to the project.
 
-There is a commented example processor located at
-`lib/ynab_convert/processors/example_processor.rb`. Looking at the other,
-real-world processors in that directory can also help.
+Looking at the other, real-world processors in `lib/processors` is helpful.
+
+Note that if the processor name's case cannot be camel cased from its lowercase
+string, it will need to be added manually in `lib/ynab_convert.rb` in the
+`processor_class_name` method. For instance, the USB Chequing processor is
+called with `-i ubs_chequing` from the command line. That makes the gem try to
+use `Processors::UbsChequing` as the processor class, but it's actually called
+`Processors::UBSChequing`.
 
 Be sure to add tests to your processor as well before you make a PR.
 

data/lib/ynab_convert/api_clients/currency_api.rb

@@ -8,7 +8,7 @@ module APIClients
   class CurrencyAPI < APIClient
     # The days that are missing from the API's otherwise normally available
     # range
-    MISSING_DAYS = { '2021-09-14' => true }.freeze
+    MISSING_DAYS = { '2021-09-14' => true, '2022-05-01' => true }.freeze
 
     def initialize
       api_base_path = 'https://cdn.jsdelivr.net/gh/fawazahmed0/currency-api@1/'

data/lib/ynab_convert/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module YnabConvert
-  VERSION = '2.0.0'
+  VERSION = '2.0.4'
 end

data/lib/ynab_convert.rb

@@ -6,6 +6,9 @@ require 'ynab_convert/logger'
 require 'core_extensions/string'
 require 'byebug' if ENV['YNAB_CONVERT_DEBUG']
 
+# FIXME: The architecture in here is not the greatest... It should be
+#   redesigned entirely.
+
 # The application
 module YnabConvert
   # Metadata about the gem
@@ -99,7 +102,22 @@ module YnabConvert
     end
 
     def processor_class_name
-      "Processors::#{@options[:institution].camel_case}"
+      # Processor class names don't always match camelcasing the `-i` argument
+      # from the command line. For those classes that don't, a lookup is
+      # performed to find the proper class name.
+      institution = @options[:institution].to_sym
+      institution_to_classname = {
+        ubs_chequing: 'UBSChequing',
+        ubs_credit: 'UBSCredit'
+      }
+
+      classname = institution_to_classname.fetch(institution) do |el|
+        # If the class name is "regular", it will be found by camelcasing the
+        # name passed as the `-i` argument from the command line.
+        el.to_s.camel_case
+      end
+
+      "Processors::#{classname}"
     end
 
     def processor

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ynab_convert
 version: !ruby/object:Gem::Version
-  version: 2.0.0
+  version: 2.0.4
 platform: ruby
 authors:
 - coaxial
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-03-20 00:00:00.000000000 Z
+date: 2022-06-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -261,13 +261,14 @@ executables:
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/workflows/publish.yml"
+- ".github/workflows/test.yml"
 - ".gitignore"
 - ".rspec"
 - ".rubocop.yml"
 - ".ruby-gemset"
 - ".ruby-version"
 - ".solargraph.yml"
-- ".travis.yml"
 - Gemfile
 - Gemfile.lock
 - Guardfile
@@ -342,7 +343,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.8
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: Convert online banking CSV files to YNAB 4 format.

data/.travis.yml

@@ -1,20 +0,0 @@
----
-language: ruby
-cache: bundler
-rvm:
-  - 2.6
-  - 2.7
-before_install: gem install bundler
-
-jobs:
-  include:
-    - stage: test
-      script: echo "Running tests for $(ruby -v)..." && bundle exec rake ci
-    - stage: gem release
-      rvm: 2.6
-      script: echo "Publishing to rubygems.org..."
-      deploy:
-        provider: rubygems
-        gem: ynab_convert
-        api_key: $RUBYGEMS_API_KEY
-        on: master