ynab_convert 1.0.7 → 1.0.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3d04e0b626a2fc75009e2eb5aee5d7693b0c7882bc82a493380ea697df2f0dc1
-  data.tar.gz: e79c99994f87108164b22a75a4a5fb806380bd56af092405a653d40487bdbd71
+  metadata.gz: '01824e596b5db266fa8e21210a6ec3bb6742f2ead99a38a9b3ad94cb05f2c8f2'
+  data.tar.gz: d85fe2a7025389684640282aec1ea75ec7d933aac9c3940b38839bd156c9aa12
 SHA512:
-  metadata.gz: 0f99dbb991b1cb948579e5531e2deb2a6353fca1b16709822122c24a2afe40854e12136a8eec8c0167e807c3ce32e4d4cf659c8380fa1700654d535e3ac8e44e
-  data.tar.gz: 250e64b972b77f55e4805ec8ba53b45bcc348bd3e2e7447dc781d5487979205a4f9d0f157730920e69d08e86f3c06618e6a1921aeb387fb994d6b08bbc642793
+  metadata.gz: 2215ad54cc79274403b940459c50b287789f3c4b7df632187381d97bb99c55ba4f96df372e8bfb2087fd20eef70d0e47d2a8fd1b5d4ecc2d008826230aa74a00
+  data.tar.gz: a1486eb5cfba186a661e8f0458c5b78bf985093812e02f551051047b8fd45ca58266cc4b18622b5d00a3e5e17a44286cd366cf01493aab68f24f8bb9eda031a7

data/.gitignore

@@ -9,3 +9,6 @@
 
 # rspec failure tracking
 .rspec_status
+
+# test artifacts
+*_ynab4.csv

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    ynab_convert (1.0.7)
+    ynab_convert (1.0.8)
       i18n
       slop
 

data/lib/ynab_convert/processor/ubs_chequing.rb

@@ -59,7 +59,29 @@ module Processor
     end
 
     def transaction_payee(row)
+      raw_payee_line = [
+        row[headers[:payee_line_2]],
+        row[headers[:payee_line_3]]
+      ]
+
       # Transaction description is spread over 3 columns.
+      # There are two types of entries:
+      # 1. only the first column contains data
+      # 2. all three columns contain data, most of it junk
+      #
+      # Cleaning them up means dropping the first column if there is anything
+      # in the other columns;
+      # removing the CARD 00000000-0 0000 at the beginning of debit card
+      # payment entries;
+      # removing the rest of the junk appended after the worthwhile data (see
+      # below for details on that)
+      if row[headers[:payee_line_2]].nil?
+        # Make it an Array, for consistency
+        raw_payee_line = [row[headers[:payee_line_1]]]
+      end
+
+      concat_payee_line = raw_payee_line.join(' ')
+
       # Moreover, UBS thought wise to append a bunch of junk information after
       # the transaction details within the third description field. *Most* of
       # this junk starts after the meaningful data and starts with ", OF",
@@ -71,14 +93,14 @@ module Processor
       # See `spec/fixtures/ubs_chequing/statement.csv` L2 and L18--22
 
       # rubocop:disable Metrics/LineLength
-      junk_desc_regex = /,? (O[FN]|ESR|QRR|\d{2} \d{5} \d{5} \d{5} \d{5} \d{5}, TN)/
+      junk_desc_regex = /,? (O[FN]|ESR|QRR|\d{2} \d{5} \d{5} \d{5} \d{5} \d{5}, TN).*/
       # rubocop:enable Metrics/LineLength
 
-      [
-        row[headers[:payee_line_1]],
-        row[headers[:payee_line_2]],
-        row[headers[:payee_line_3]]
-      ].join(' ').split(junk_desc_regex).first
+      # Of course, it wouldn't be complete with more junk information at the
+      # beginning of *some* lines (debit card payments)
+      debit_card_junk_regex = /CARD \d{8}\-\d \d{4} /
+
+      concat_payee_line.sub(junk_desc_regex, '').sub(debit_card_junk_regex, '')
     end
 
     def register_custom_converters

data/lib/ynab_convert/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module YnabConvert
-  VERSION = '1.0.7'
+  VERSION = '1.0.8'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ynab_convert
 version: !ruby/object:Gem::Version
-  version: 1.0.7
+  version: 1.0.8
 platform: ruby
 authors:
 - coaxial
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-03-06 00:00:00.000000000 Z
+date: 2022-03-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler