ynab_convert 1.0.5 → 1.0.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 58ad75b7f1c6b3093257d8ffb95068967324a621be48bc6e08063548d4a9f2bd
-  data.tar.gz: 70bc35076e068aece838b52853f5b7f7656199b67e5b2f3ca78a4aec66037ffb
+  metadata.gz: '01824e596b5db266fa8e21210a6ec3bb6742f2ead99a38a9b3ad94cb05f2c8f2'
+  data.tar.gz: d85fe2a7025389684640282aec1ea75ec7d933aac9c3940b38839bd156c9aa12
 SHA512:
-  metadata.gz: 56621762f02d97515a0f3ce829d5b7bfe9ffb1fe862a6b0e92197ac2b555abe84102900f7eef28f67c7c0570efdf0bc3ea8005c8adb68f9c598a7f0fba94f6e9
-  data.tar.gz: 86a99a7d007c05b7aa3f6e6f3ed211ac009989bd8e31fefbef0db3d9a503dc765ecea825b9e1f6d237d2e26c7c59a455010f975183085037cf8bd2dcb95e8a04
+  metadata.gz: 2215ad54cc79274403b940459c50b287789f3c4b7df632187381d97bb99c55ba4f96df372e8bfb2087fd20eef70d0e47d2a8fd1b5d4ecc2d008826230aa74a00
+  data.tar.gz: a1486eb5cfba186a661e8f0458c5b78bf985093812e02f551051047b8fd45ca58266cc4b18622b5d00a3e5e17a44286cd366cf01493aab68f24f8bb9eda031a7

data/.gitignore

@@ -9,3 +9,6 @@
 
 # rspec failure tracking
 .rspec_status
+
+# test artifacts
+*_ynab4.csv

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    ynab_convert (1.0.5)
+    ynab_convert (1.0.8)
       i18n
       slop
 

data/lib/ynab_convert/processor/ubs_chequing.rb

@@ -59,22 +59,48 @@ module Processor
     end
 
     def transaction_payee(row)
+      raw_payee_line = [
+        row[headers[:payee_line_2]],
+        row[headers[:payee_line_3]]
+      ]
+
       # Transaction description is spread over 3 columns.
+      # There are two types of entries:
+      # 1. only the first column contains data
+      # 2. all three columns contain data, most of it junk
+      #
+      # Cleaning them up means dropping the first column if there is anything
+      # in the other columns;
+      # removing the CARD 00000000-0 0000 at the beginning of debit card
+      # payment entries;
+      # removing the rest of the junk appended after the worthwhile data (see
+      # below for details on that)
+      if row[headers[:payee_line_2]].nil?
+        # Make it an Array, for consistency
+        raw_payee_line = [row[headers[:payee_line_1]]]
+      end
+
+      concat_payee_line = raw_payee_line.join(' ')
+
       # Moreover, UBS thought wise to append a bunch of junk information after
       # the transaction details within the third description field. *Most* of
       # this junk starts after the meaningful data and starts with ", OF",
-      # ", ON", ", ESR", two digits then five groups of five digits then ", TN"
-      # so we discard it; YNAB4 being unable to automatically categorize new
-      # transactions at the same store/payee because the payee always looks
-      # different (thanks to the variable nature of the appended junk).
-      # See `spec/fixtures/ubs_chequing/statement.csv` L18 and L2.
-      junk_desc_regex = /, (O[FN]|ESR|\d{2} \d{5} \d{5} \d{5} \d{5} \d{5}, TN)/
-
-      [
-        row[headers[:payee_line_1]],
-        row[headers[:payee_line_2]],
-        row[headers[:payee_line_3]]
-      ].join(' ').split(junk_desc_regex).first
+      # ", ON", ", ESR", ", QRR", two digits then five groups of five digits
+      # then ", TN" so we discard it; YNAB4 being unable to automatically
+      # categorize new transactions at the same store/payee because the payee
+      # always looks different (thanks to the variable nature of the appended
+      # junk).
+      # See `spec/fixtures/ubs_chequing/statement.csv` L2 and L18--22
+
+      # rubocop:disable Metrics/LineLength
+      junk_desc_regex = /,? (O[FN]|ESR|QRR|\d{2} \d{5} \d{5} \d{5} \d{5} \d{5}, TN).*/
+      # rubocop:enable Metrics/LineLength
+
+      # Of course, it wouldn't be complete with more junk information at the
+      # beginning of *some* lines (debit card payments)
+      debit_card_junk_regex = /CARD \d{8}\-\d \d{4} /
+
+      concat_payee_line.sub(junk_desc_regex, '').sub(debit_card_junk_regex, '')
     end
 
     def register_custom_converters

data/lib/ynab_convert/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module YnabConvert
-  VERSION = '1.0.5'
+  VERSION = '1.0.8'
 end

data/ynab_convert.gemspec

@@ -13,6 +13,11 @@ Gem::Specification.new do |spec|
   spec.summary       = 'Convert online banking CSV files to YNAB 4 format.'
   spec.homepage      = 'https://github.com/coaxial/ynab_convert'
   spec.license       = 'MIT'
+  spec.description   = <<~DESC
+    Utility to convert CSV statements into the YNAB4 format for easier
+    transation import. Supports several banks and can easily be extended to
+    add more.
+  DESC
 
   spec.required_ruby_version = '~> 2.6'
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ynab_convert
 version: !ruby/object:Gem::Version
-  version: 1.0.5
+  version: 1.0.8
 platform: ruby
 authors:
 - coaxial
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-03-06 00:00:00.000000000 Z
+date: 2022-03-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -192,7 +192,10 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-description: 
+description: |
+  Utility to convert CSV statements into the YNAB4 format for easier
+  transation import. Supports several banks and can easily be extended to
+  add more.
 email:
 - hi@64b.it
 executables: