ynab_convert 1.0.3 → 1.0.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2af241f007b8495197a8971ffbf3b3efe0dda41411c56a3543452dfea50fd03e
-  data.tar.gz: ac7c2614c064e005524c808dd62bddbbaaa8e8395bea6a02b0bf4ef45960133f
+  metadata.gz: 697f0d80eaec169e83bea48407e9d00c1b000a362aaa6147160be65bafef72a7
+  data.tar.gz: 8e45ffa5ec9094c54057ebba3f241c00764fc0e256ec19bdfa0d9395f590a156
 SHA512:
-  metadata.gz: 3f96f0a1839d1bc4111f8f53aeac6f7b503155f65b03e2ccd113e0847baa8637beeef7aeae182538b3f6f4cd5caf5a462b568b0ffae5a42f24062722c4a51cf7
-  data.tar.gz: 4f17efacff3b4b5cb62df38997863bad691b41a4f26d5a27ef3b7bfaa93072f217f4a824f11dd6e462ba422f862991e5ae14990e7f5f8c8879f49a7deba91274
+  metadata.gz: 8150a18508c46b6267b38ccf56ff6b542e82df49100c4fff164959a24445a36e8271cfca6bd07abbc583f76d372bfc77f9ab830a88dd9e37eb5d95af15ab6ef5
+  data.tar.gz: 7490a9741e4bf27fd21e526fe4aff6c777cca8882f64a9558ceb698f16b7c080f92ae24ebf136a21c3768f5e76077c4ccbe6536a81cdc0cd0dec1453e279a40d

data/.travis.yml

@@ -3,12 +3,12 @@ language: ruby
 cache: bundler
 rvm:
   - 2.6
+  - 2.7
 before_install: gem install bundler
 
 jobs:
   include:
     - stage: test
-      rvm: 2.6
       script: echo "Running tests for $(ruby -v)..." && bundle exec rake ci
     - stage: gem release
       rvm: 2.6

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    ynab_convert (1.0.3)
+    ynab_convert (1.0.6)
       i18n
       slop
 

data/bin/ynab_convert

@@ -9,7 +9,6 @@ require 'ynab_convert/processors'
 require 'ynab_convert/logger'
 require 'ynab_convert/error'
 require 'slop/symbol'
-require 'pry'
 
 # Add mixins and run converter
 class Convert

data/lib/ynab_convert/processor/base.rb

@@ -5,7 +5,8 @@ require 'csv'
 require 'ynab_convert/logger'
 
 module Processor
-  # Base class for a Processor, all processors must inherit from it
+  # Base class for a Processor, all processors must inherit from it.
+
   # rubocop:disable Metrics/ClassLength
   class Base
     include YnabLogger
@@ -13,8 +14,8 @@ module Processor
 
     attr_reader :loader_options
 
-    # @option opts [String] :file Path to the CSV file to process
-    # @option opts [Symbol] :format YNAB4 format to use, one of :flows or
+    # @option options [String] :file Path to the CSV file to process
+    # @option options [Symbol] :format YNAB4 format to use, one of :flows or
     #   :amounts. :flows is useful for CSVs with separate debit and credit
     #   columns, :amounts is for CSVs with only one amount columns and +/-
     #   numbers. See
@@ -140,8 +141,8 @@ module Processor
       logger.debug "Will write to `#{temp_filename}'"
 
       logger.debug(loader_options)
-      CSV.open(temp_filename, 'wb', output_options) do |converted|
-        CSV.foreach(@file, 'rb', loader_options) do |row|
+      CSV.open(temp_filename, 'wb', **output_options) do |converted|
+        CSV.foreach(@file, 'rb', **loader_options) do |row|
           logger.debug "Parsing row: `#{row.to_h}'"
           # Some rows don't contain valid or useful data
           catch :skip_row do

data/lib/ynab_convert/processor/n26.rb

@@ -2,21 +2,6 @@
 
 module Processor
   # Processes CSV files from N26
-  #
-  # An example of how to implement a custom processor
-  # Processes CSV files with this format:
-  # <<~ROWS
-  # "Date","Payee","Memo","Outflow","Inflow"
-  # "23/12/2019","coaxial","","1000000.00",""
-  # "30/12/2019","Santa","","50000.00",""
-  # "02/02/2020","Someone Else","","45.00",""
-  # ROWS
-  # The file name for the processor should be the institution name in
-  # camel case. It's ok to skip "Bank" or "Credit Union" when naming the file
-  # if it's redundant. For instance, this parser is for "Example Bank" but it's
-  # named "example.rb", its corresponding spec is
-  # "spec/example_processor_spec.rb" and its fixture would be
-  # "spec/fixtures/example.csv"
   class N26 < Processor::Base
     # @option options [String] :file Path to the CSV file to process
     def initialize(options)

data/lib/ynab_convert/processor/ubs_chequing.rb

@@ -59,12 +59,26 @@ module Processor
     end
 
     def transaction_payee(row)
-      # Transaction description is spread over 3 columns
+      # Transaction description is spread over 3 columns.
+      # Moreover, UBS thought wise to append a bunch of junk information after
+      # the transaction details within the third description field. *Most* of
+      # this junk starts after the meaningful data and starts with ", OF",
+      # ", ON", ", ESR", ", QRR", two digits then five groups of five digits
+      # then ", TN" so we discard it; YNAB4 being unable to automatically
+      # categorize new transactions at the same store/payee because the payee
+      # always looks different (thanks to the variable nature of the appended
+      # junk).
+      # See `spec/fixtures/ubs_chequing/statement.csv` L2 and L18--22
+
+      # rubocop:disable Metrics/LineLength
+      junk_desc_regex = /, (O[FN]|ESR|QRR|\d{2} \d{5} \d{5} \d{5} \d{5} \d{5}, TN)/
+      # rubocop:enable Metrics/LineLength
+
       [
         row[headers[:payee_line_1]],
         row[headers[:payee_line_2]],
         row[headers[:payee_line_3]]
-      ].join(' ')
+      ].join(' ').split(junk_desc_regex).first
     end
 
     def register_custom_converters

data/lib/ynab_convert/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module YnabConvert
-  VERSION = '1.0.3'
+  VERSION = '1.0.6'
 end

data/lib/ynab_convert.rb

@@ -2,7 +2,6 @@
 
 require 'ynab_convert/version'
 require 'slop'
-require 'pry'
 require 'ynab_convert/logger'
 require 'core_extensions/string.rb'
 

data/ynab_convert.gemspec

@@ -13,6 +13,21 @@ Gem::Specification.new do |spec|
   spec.summary       = 'Convert online banking CSV files to YNAB 4 format.'
   spec.homepage      = 'https://github.com/coaxial/ynab_convert'
   spec.license       = 'MIT'
+  spec.description   = <<~DESC
+    Utility to convert CSV statements into the YNAB4 format for easier
+    transation import. Supports several banks and can easily be extended to
+    add more.
+  DESC
+
+  spec.required_ruby_version = '~> 2.6'
+
+  spec.metadata = {
+    'bug_tracker_uri' => 'https://github.com/coaxial/ynab_convert/issues',
+    'documentation_uri' => 'https://rubydoc.info/github/coaxial/ynab_convert/master',
+    'homepage_uri' => 'https://github.com/coaxial/ynab_convert',
+    'source_code_uri' => 'https://github.com/coaxial/ynab_convert'
+  }
+  spec.post_install_message = 'Happy budgetting!'
 
   # Prevent pushing this gem to RubyGems.org. To allow pushes either set the 'allowed_push_host'
   # to allow pushing to a single host or delete this section to allow pushing to any host.

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ynab_convert
 version: !ruby/object:Gem::Version
-  version: 1.0.3
+  version: 1.0.6
 platform: ruby
 authors:
 - coaxial
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-03-05 00:00:00.000000000 Z
+date: 2022-03-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -192,7 +192,10 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-description: 
+description: |
+  Utility to convert CSV statements into the YNAB4 format for easier
+  transation import. Supports several banks and can easily be extended to
+  add more.
 email:
 - hi@64b.it
 executables:
@@ -236,18 +239,20 @@ homepage: https://github.com/coaxial/ynab_convert
 licenses:
 - MIT
 metadata:
-  allowed_push_host: https://rubygems.org
+  bug_tracker_uri: https://github.com/coaxial/ynab_convert/issues
+  documentation_uri: https://rubydoc.info/github/coaxial/ynab_convert/master
   homepage_uri: https://github.com/coaxial/ynab_convert
   source_code_uri: https://github.com/coaxial/ynab_convert
-post_install_message: 
+  allowed_push_host: https://rubygems.org
+post_install_message: Happy budgetting!
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - "~>"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: '2.6'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="