ynab_convert 1.0.2 → 1.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2e707b36e18c8b57f7b517bf6f1f29d769e22089316448da062165c35e5fb713
-  data.tar.gz: ee5dbf483c6252085860166c6371fd7d6ba75b91d90dc17a74a9a68ddff80026
+  metadata.gz: 58ad75b7f1c6b3093257d8ffb95068967324a621be48bc6e08063548d4a9f2bd
+  data.tar.gz: 70bc35076e068aece838b52853f5b7f7656199b67e5b2f3ca78a4aec66037ffb
 SHA512:
-  metadata.gz: 44f457015648d06a43c98da0622ae12de10eb84025636677b044020d98aa82dca85c2968f9b924541dd8260002a8e727bef22cf60515d6dc17e345d8e06cf0e5
-  data.tar.gz: 0fadae67422faf27caa356890121600879416545043c240ef951a3bc2c9caf9a8af544f25978a50e3e479994eb020e008e99c32a99c76363d239e82d09037fcb
+  metadata.gz: 56621762f02d97515a0f3ce829d5b7bfe9ffb1fe862a6b0e92197ac2b555abe84102900f7eef28f67c7c0570efdf0bc3ea8005c8adb68f9c598a7f0fba94f6e9
+  data.tar.gz: 86a99a7d007c05b7aa3f6e6f3ed211ac009989bd8e31fefbef0db3d9a503dc765ecea825b9e1f6d237d2e26c7c59a455010f975183085037cf8bd2dcb95e8a04

data/.rubocop.yml

@@ -1,6 +1,11 @@
 ---
+# See https://github.com/rubocop/rubocop/blob/master/config/default.yml for all
+# options
 require: rubocop-rake
 
+AllCops:
+  DisplayCopNames: true
+
 Metrics/LineLength:
   Exclude:
     - ynab_convert.gemspec

data/.travis.yml

@@ -3,12 +3,12 @@ language: ruby
 cache: bundler
 rvm:
   - 2.6
+  - 2.7
 before_install: gem install bundler
 
 jobs:
   include:
     - stage: test
-      rvm: 2.6
       script: echo "Running tests for $(ruby -v)..." && bundle exec rake ci
     - stage: gem release
       rvm: 2.6

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    ynab_convert (1.0.2)
+    ynab_convert (1.0.5)
       i18n
       slop
 
@@ -44,10 +44,10 @@ GEM
       rb-inotify (~> 0.9, >= 0.9.10)
     lumberjack (1.0.13)
     method_source (0.9.2)
-    mini_portile2 (2.6.1)
+    mini_portile2 (2.8.0)
     nenv (0.3.0)
-    nokogiri (1.12.5)
-      mini_portile2 (~> 2.6.1)
+    nokogiri (1.13.3)
+      mini_portile2 (~> 2.8.0)
       racc (~> 1.4)
     notiffany (0.1.3)
       nenv (~> 0.1)
@@ -61,7 +61,7 @@ GEM
     pry-byebug (3.7.0)
       byebug (~> 11.0)
       pry (~> 0.10)
-    racc (1.5.2)
+    racc (1.6.0)
     rainbow (3.0.0)
     rake (13.0.1)
     rb-fsevent (0.10.3)

data/Guardfile

@@ -74,7 +74,7 @@ group :red_green_refactor, halt_on_fail: true do
     end
   end
 
-  guard :rubocop, cli: ['--auto-correct'] do
+  guard :rubocop, cli: ['--auto-correct', '--display-cop-names'] do
     watch('Gemfile')
     watch('Rakefile')
     watch('bin/convert')

data/README.md

@@ -27,6 +27,7 @@ latest one on 2019-12-01.
 `-i` argument | Institution's full name | Institution's website | Remarks
 ---|---|---|---
 `example` | Example Bank | N/A | Reference processor implementation, not a real institution
+`n26` | N26 | [n26.com](n26.com) | N26 CSV statements
 `revolut` | Revolut Ltd | [revolut.com](https://www.revolut.com/) | The processor isn't aware of currencies. Make sure the statements processed with `revolut` are in the same currency that your YNAB is in
 `ubs_chequing` | UBS Switzerland (private banking) | [ubs.ch](https://ubs.ch) | Private chequing and joint accounts
 `ubs_credit` | UBS Switzerland (credit cards) | [ubs.ch](https://ubs.ch) | Both MasterCard and Visa
@@ -44,7 +45,8 @@ https://github.com/coaxial/ynab_convert.
 
 ### Enable debug output
 
-Run `ynab_convert` with `YNAB_CONVERT_DEBUG=true`, or use the rake task `spec:debug`. Debug logging goes to STDERR.
+Run `ynab_convert` with `YNAB_CONVERT_DEBUG=true`, or use the rake task
+`spec:debug`. Debug logging goes to STDERR.
 
 ### Adding a new financial institution
 

data/bin/ynab_convert

@@ -9,7 +9,6 @@ require 'ynab_convert/processors'
 require 'ynab_convert/logger'
 require 'ynab_convert/error'
 require 'slop/symbol'
-require 'pry'
 
 # Add mixins and run converter
 class Convert

data/lib/core_extensions/string.rb

@@ -6,7 +6,7 @@ module CoreExtensions
     # Adds convenience methods
     module Inflections
       def snake_case
-        downcase.tr(' ', '_').gsub(/[^a-z_]/, '')
+        downcase.tr(' ', '_').gsub(/[^a-z_0-9]/, '')
       end
 
       def camel_case

data/lib/ynab_convert/processor/base.rb

@@ -5,7 +5,8 @@ require 'csv'
 require 'ynab_convert/logger'
 
 module Processor
-  # Base class for a Processor, all processors must inherit from it
+  # Base class for a Processor, all processors must inherit from it.
+
   # rubocop:disable Metrics/ClassLength
   class Base
     include YnabLogger
@@ -13,13 +14,30 @@ module Processor
 
     attr_reader :loader_options
 
-    # @option opts [String] :file Path to the CSV file to process
-    def initialize(opts)
+    # @option options [String] :file Path to the CSV file to process
+    # @option options [Symbol] :format YNAB4 format to use, one of :flows or
+    #   :amounts. :flows is useful for CSVs with separate debit and credit
+    #   columns, :amounts is for CSVs with only one amount columns and +/-
+    #   numbers. See
+    #   https://docs.youneedabudget.com/article/921-formatting-csv-file
+    def initialize(options)
+      default_options = { file: '', format: :flows }
+      opts = default_options.merge(options)
+
       logger.debug "Initializing processor with options: `#{opts.to_h}'"
       raise ::Errno::ENOENT unless File.exist? opts[:file]
 
       @file = opts[:file]
-      @headers = { transaction_date: nil, payee: nil, debit: nil, credit: nil }
+      @headers = { transaction_date: nil, payee: nil }
+      @format = opts[:format]
+
+      if @format == :amounts
+        amounts_columns = { amount: nil }
+        @headers.merge!(amounts_columns)
+      else
+        flows_columns = { inflow: nil, outflow: nil }
+        @headers.merge!(flows_columns)
+      end
     end
 
     def to_ynab!
@@ -38,15 +56,41 @@ module Processor
 
     attr_accessor :statement_from, :statement_to, :headers
 
-    def inflow_or_outflow_missing?(row)
+    def amount_invalid?(row)
+      amount_index = 3
+
+      # If there is no amount,
+      # then the row is invalid.
+      row[amount_index].nil? || row[amount_index].empty?
+    end
+
+    def inflow_outflow_invalid?(row)
       inflow_index = 3
       outflow_index = 4
-      # If there is neither inflow and outflow values, or their value is 0,
-      # then the row is not valid to YNAB4
-      (row[inflow_index].nil? || row[inflow_index].empty? ||
-       row[inflow_index] == '0.00') &&
-        (row[outflow_index].nil? || row[outflow_index].empty? ||
-         row[outflow_index] == '0.00')
+
+      # If there is neither inflow and outflow values,
+      # or both the inflow and outflow amounts are 0,
+      # then the row is invalid.
+      (
+        row[inflow_index].nil? ||
+        row[inflow_index].empty? ||
+        row[inflow_index] == '0.00'
+      ) && (
+        row[outflow_index].nil? ||
+        row[outflow_index].empty? ||
+        row[outflow_index] == '0.00'
+      )
+    end
+
+    def amounts_missing?(row)
+      logger.debug "Checking for missing amount in `#{row}`"
+      if @format == :amounts
+        logger.debug 'Using `:amounts`'
+        amount_invalid?(row)
+      else
+        logger.debug 'Using `:flows`'
+        inflow_outflow_invalid?(row)
+      end
     end
 
     def skip_row(row)
@@ -96,14 +140,15 @@ module Processor
     def convert!
       logger.debug "Will write to `#{temp_filename}'"
 
-      CSV.open(temp_filename, 'wb', output_options) do |converted|
-        CSV.foreach(@file, 'rb', loader_options) do |row|
+      logger.debug(loader_options)
+      CSV.open(temp_filename, 'wb', **output_options) do |converted|
+        CSV.foreach(@file, 'rb', **loader_options) do |row|
           logger.debug "Parsing row: `#{row.to_h}'"
           # Some rows don't contain valid or useful data
           catch :skip_row do
             extract_header_names(row)
             ynab_row = transformers(row)
-            if inflow_or_outflow_missing?(ynab_row) ||
+            if amounts_missing?(ynab_row) ||
                transaction_date_missing?(ynab_row)
               logger.debug 'Empty row, skipping it'
               skip_row(row)
@@ -151,7 +196,17 @@ module Processor
     end
 
     def ynab_headers
-      %w[Date Payee Memo Outflow Inflow]
+      common_headers = %w[Date Payee Memo]
+
+      if @format == :amounts
+        amounts_headers = %w[Amount]
+        common_headers.concat(amounts_headers)
+      else
+        flows_headers = %w[Outflow Inflow]
+        common_headers.concat(flows_headers)
+      end
+
+      common_headers
     end
 
     def output_options

data/lib/ynab_convert/processor/example.rb

@@ -14,7 +14,7 @@ module Processor
   # if it's redundant. For instance, this parser is for "Example Bank" but it's
   # named "example.rb", its corresponding spec is
   # "spec/example_processor_spec.rb" and its fixture would be
-  # "spec/fixtures/example.csv"
+  # "spec/fixtures/example/statement.csv"
   class Example < Processor::Base
     # @option options [String] :file Path to the CSV file to process
     def initialize(options)

data/lib/ynab_convert/processor/n26.rb

@@ -0,0 +1,70 @@
+# frozen_string_literal: true
+
+module Processor
+  # Processes CSV files from N26
+  class N26 < Processor::Base
+    # @option options [String] :file Path to the CSV file to process
+    def initialize(options)
+      # Custom converters can be added so that the CSV data is parsed when
+      # loading the original file
+      register_custom_converters
+
+      # These are the options for the CSV module (see
+      # https://ruby-doc.org/stdlib-2.6/libdoc/csv/rdoc/CSV.html#method-c-new)
+      # They should match the format for the CSV file that the financial
+      # institution generates.
+      @loader_options = {
+        col_sep: ',',
+        quote_char: '"',
+        # Use your converters, if any
+        # converters: %i[],
+        headers: true,
+        encoding: 'bom|utf-8'
+      }
+
+      # This is the financial institution's full name as it calls itself. This
+      # usually matches the institution's letterhead and/or commercial name.
+      # It can happen that the same institution needs different parsers because
+      # its credit card CSV files are in one format, and its chequing accounts
+      # in another. In that case, more details can be added in parens.
+      # For instance:
+      # 'Example Bank (credit cards)' and 'Example Bank (chequing)'
+      @institution_name = 'N26 Bank'
+      # N26's CSV only has one columns for all transactions instead of separate
+      # debit and credit columns
+      additional_processor_options = { format: :amounts }
+
+      # This is mandatory.
+      super(options.merge(additional_processor_options))
+    end
+
+    private
+
+    def register_custom_converters; end
+
+    protected
+
+    def transformers(row)
+      transaction_date = row[headers[:transaction_date]]
+      payee = row[headers[:payee]]
+      amount = row[headers[:amount]]
+
+      converted_row = [transaction_date, payee, nil, amount]
+      logger.debug "Converted row: #{converted_row}"
+      converted_row
+    end
+
+    private
+
+    # Institutions love translating the column names, apparently. Rather than
+    # hardcoding the column name as a string, use the headers array at the
+    # right index.
+    # These lookups aren't particularly expensive but they're done on each row
+    # so why not memoize them with ||=
+    def extract_header_names(row)
+      headers[:transaction_date] ||= row.headers[0]
+      headers[:payee] ||= row.headers[1]
+      headers[:amount] ||= row.headers[5]
+    end
+  end
+end

data/lib/ynab_convert/processor/ubs_chequing.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 module Processor
-  # Processes CSV files from UBS Personal Banking Switzerland (French)
+  # Processes CSV files from UBS Personal Banking Switzerland
   class UbsChequing < Processor::Base
     # @option options [String] :file Path to the CSV file to process
     def initialize(options)
@@ -59,12 +59,22 @@ module Processor
     end
 
     def transaction_payee(row)
-      # Transaction description is spread over 3 columns
+      # Transaction description is spread over 3 columns.
+      # Moreover, UBS thought wise to append a bunch of junk information after
+      # the transaction details within the third description field. *Most* of
+      # this junk starts after the meaningful data and starts with ", OF",
+      # ", ON", ", ESR", two digits then five groups of five digits then ", TN"
+      # so we discard it; YNAB4 being unable to automatically categorize new
+      # transactions at the same store/payee because the payee always looks
+      # different (thanks to the variable nature of the appended junk).
+      # See `spec/fixtures/ubs_chequing/statement.csv` L18 and L2.
+      junk_desc_regex = /, (O[FN]|ESR|\d{2} \d{5} \d{5} \d{5} \d{5} \d{5}, TN)/
+
       [
         row[headers[:payee_line_1]],
         row[headers[:payee_line_2]],
         row[headers[:payee_line_3]]
-      ].join(' ')
+      ].join(' ').split(junk_desc_regex).first
     end
 
     def register_custom_converters

data/lib/ynab_convert/processor/ubs_credit.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 module Processor
-  # Processes CSV files from UBS Credit Cards Switzerland (French)
+  # Processes CSV files from UBS Credit Cards Switzerland
   class UbsCredit < Processor::Base
     # @option options [String] :file Path to the CSV file to process
     def initialize(options)

data/lib/ynab_convert/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module YnabConvert
-  VERSION = '1.0.2'
+  VERSION = '1.0.5'
 end

data/lib/ynab_convert.rb

@@ -2,7 +2,6 @@
 
 require 'ynab_convert/version'
 require 'slop'
-require 'pry'
 require 'ynab_convert/logger'
 require 'core_extensions/string.rb'
 

data/ynab_convert.gemspec

@@ -14,6 +14,16 @@ Gem::Specification.new do |spec|
   spec.homepage      = 'https://github.com/coaxial/ynab_convert'
   spec.license       = 'MIT'
 
+  spec.required_ruby_version = '~> 2.6'
+
+  spec.metadata = {
+    'bug_tracker_uri' => 'https://github.com/coaxial/ynab_convert/issues',
+    'documentation_uri' => 'https://rubydoc.info/github/coaxial/ynab_convert/master',
+    'homepage_uri' => 'https://github.com/coaxial/ynab_convert',
+    'source_code_uri' => 'https://github.com/coaxial/ynab_convert'
+  }
+  spec.post_install_message = 'Happy budgetting!'
+
   # Prevent pushing this gem to RubyGems.org. To allow pushes either set the 'allowed_push_host'
   # to allow pushing to a single host or delete this section to allow pushing to any host.
   if spec.respond_to?(:metadata)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ynab_convert
 version: !ruby/object:Gem::Version
-  version: 1.0.2
+  version: 1.0.5
 platform: ruby
 authors:
 - coaxial
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-02-24 00:00:00.000000000 Z
+date: 2022-03-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -225,6 +225,7 @@ files:
 - lib/ynab_convert/logger.rb
 - lib/ynab_convert/processor/base.rb
 - lib/ynab_convert/processor/example.rb
+- lib/ynab_convert/processor/n26.rb
 - lib/ynab_convert/processor/revolut.rb
 - lib/ynab_convert/processor/ubs_chequing.rb
 - lib/ynab_convert/processor/ubs_credit.rb
@@ -235,18 +236,20 @@ homepage: https://github.com/coaxial/ynab_convert
 licenses:
 - MIT
 metadata:
-  allowed_push_host: https://rubygems.org
+  bug_tracker_uri: https://github.com/coaxial/ynab_convert/issues
+  documentation_uri: https://rubydoc.info/github/coaxial/ynab_convert/master
   homepage_uri: https://github.com/coaxial/ynab_convert
   source_code_uri: https://github.com/coaxial/ynab_convert
-post_install_message: 
+  allowed_push_host: https://rubygems.org
+post_install_message: Happy budgetting!
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - "~>"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: '2.6'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="