yle_tf 0.4.0 → 1.3.0

data/lib/yle_tf/plugin/action_hook.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class YleTf
   class Plugin
     class ActionHook

data/lib/yle_tf/plugin/loader.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'yle_tf/logger'
 
 class YleTf
@@ -13,7 +15,7 @@ class YleTf
 
       def self.load_core_plugins
         core_plugins.each do |plugin_file|
-          Logger.debug("Loading core plugin: #{File.basename(plugin_file, '.rb')}")
+          Logger.debug { "Loading core plugin: #{core_plugin_name(plugin_file)}" }
           load(plugin_file)
         end
       end
@@ -33,7 +35,12 @@ class YleTf
       end
 
       def self.core_plugins
-        Dir.glob(File.expand_path('../../../yle_tf_plugins/**/plugin.rb', __FILE__))
+        Dir.glob(File.expand_path('../../yle_tf_plugins/**/plugin.rb', __dir__))
+      end
+
+      def self.core_plugin_name(path)
+        m = %r{.*/yle_tf_plugins/(?<name>.+?)/plugin\.rb$}.match(path)
+        m ? m[:name] : path
       end
 
       def self.bundler_plugins

data/lib/yle_tf/plugin/manager.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'yle_tf/logger'
 
 class YleTf
@@ -42,6 +44,7 @@ class YleTf
           registered.each do |plugin|
             backends.merge!(plugin.backends)
           end
+          backends.default = backends.delete(DEFAULT_BACKEND)
         end
       end
     end

data/lib/yle_tf/system.rb

@@ -1,6 +1,9 @@
+# frozen_string_literal: true
+
 require 'English'
 require 'open3'
 require 'shellwords'
+require 'stringio'
 require 'thwait'
 require 'yle_tf/error'
 require 'yle_tf/logger'
@@ -14,7 +17,7 @@ class YleTf
     DEFAULT_ERROR_HANDLER = ->(_exit_code, error) { raise error }.freeze
 
     DEFAULT_IO_HANDLERS = {
-      stdin: :dev_null,
+      stdin:  :dev_null,
       stdout: :info,
       stderr: :error
     }.freeze
@@ -44,7 +47,7 @@ class YleTf
 
     def self.read_cmd(*args, **opts)
       buffer = StringIO.new
-      cmd(*args, opts.merge(stdout: buffer))
+      cmd(*args, **opts.merge(stdout: buffer))
       buffer.string
     end
 

data/lib/yle_tf/system/io_handlers.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'yle_tf/error'
 require 'yle_tf/logger'
 require 'yle_tf/system/output_logger'
@@ -22,6 +24,7 @@ class YleTf
           if !handler.respond_to?(:call)
             raise YleTf::Error, "Unknown input handler #{handler.inspect}"
           end
+
           handler
         end
       end
@@ -42,6 +45,7 @@ class YleTf
           if !handler.respond_to?(:call)
             raise YleTf::Error, "Unknown output handler #{handler.inspect}"
           end
+
           handler
         end
       end
@@ -104,7 +108,7 @@ class YleTf
         while (data = source.readpartial(BLOCK_SIZE))
           target.write(data)
         end
-      rescue EOFError # rubocop:disable Lint/HandleExceptions
+      rescue EOFError # rubocop:disable Lint/SuppressedException
         # All read
       rescue IOError => e
         YleTf::Logger.debug e.full_message

data/lib/yle_tf/system/output_logger.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'yle_tf/logger'
 
 class YleTf

data/lib/yle_tf/system/tf_hook_output_logger.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'yle_tf/logger'
 require 'yle_tf/system/output_logger'
 

data/lib/yle_tf/tf_hook.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'fileutils'
 require 'tmpdir'
 
@@ -14,8 +16,8 @@ class YleTf
     def self.from_config(config, tf_env)
       TfHook.new(
         description: config['description'],
-        source: config['source'],
-        vars: merge_vars(config['vars'], tf_env)
+        source:      config['source'],
+        vars:        merge_vars(config['vars'], tf_env)
       )
     end
 
@@ -23,7 +25,7 @@ class YleTf
     def self.from_file(path)
       TfHook.new(
         description: File.basename(path),
-        path: path
+        path:        path
       )
     end
 
@@ -43,10 +45,10 @@ class YleTf
       Logger.info("Running hook '#{description}'")
       YleTf::System.cmd(
         path,
-        env: vars.merge(tf_vars),
+        env:      vars.merge(tf_vars),
         progname: File.basename(path),
-        stdout: System::TfHookOutputLogger.new(:info),
-        stderr: System::TfHookOutputLogger.new(:error)
+        stdout:   System::TfHookOutputLogger.new(:info),
+        stderr:   System::TfHookOutputLogger.new(:error)
       )
     ensure
       delete_tmpdir
@@ -57,9 +59,9 @@ class YleTf
       raise Error, "Invalid or missing `source` for hook '#{description}'" if !m
 
       {
-        uri: m[:uri],
+        uri:  m[:uri],
         path: m[:path],
-        ref: m[:ref] || 'master'
+        ref:  m[:ref] || 'master'
       }
     end
 
@@ -83,7 +85,7 @@ class YleTf
     end
 
     def delete_tmpdir
-      FileUtils.rm_r(@tmpdir) if @tmpdir && Dir.exist?(@tmpdir)
+      FileUtils.rm_rf(@tmpdir, secure: true) if @tmpdir && Dir.exist?(@tmpdir)
       @tmpdir = nil
     end
 

data/lib/yle_tf/tf_hook/runner.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'yle_tf/logger'
 require 'yle_tf/tf_hook'
 

data/lib/yle_tf/vars_file.rb

@@ -1,6 +1,8 @@
+# frozen_string_literal: true
+
 class YleTf
   class VarsFile
-    ENV_DIR = 'envs'.freeze
+    ENV_DIR = 'envs'
 
     # Returns the env specific tfvars file path if it exists
     def self.find_env_vars_file(config)
@@ -10,7 +12,7 @@ class YleTf
 
     # Returns all envs that have tfvars files
     def self.list_all_envs(config)
-      Dir.glob("#{config.module_dir}/#{ENV_DIR}/*.tfvars").map do |path|
+      Dir.glob("#{config.module_dir}/#{ENV_DIR}/*.tfvars").sort.map do |path|
         File.basename(path, '.tfvars')
       end
     end
@@ -36,9 +38,20 @@ class YleTf
       File.open(path, 'a') do |file|
         file.puts # ensure we don't append to an existing line
         vars.each do |key, value|
-          file.puts %(#{key} = "#{value}")
+          file.puts "#{key} = #{eval_value(value)}"
         end
       end
     end
+
+    def eval_value(value)
+      case value
+      when Hash
+        %({ #{value.map { |k, v| "#{k} = #{eval_value(v)}" }.join(', ')} })
+      when Array
+        %([ #{value.map { |item| eval_value(item) }.join(', ')} ])
+      else
+        %("#{value}")
+      end
+    end
   end
 end

data/lib/yle_tf/version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class YleTf
-  VERSION = '0.4.0'.freeze
+  VERSION = '1.3.0'
 end

data/lib/yle_tf/version_requirement.rb

@@ -1,13 +1,10 @@
+# frozen_string_literal: true
+
 require 'rubygems'
 
 class YleTf
   # Helper class for comparing versions
   class VersionRequirement
-    # Checks if the specified Terrform version is older than 0.9
-    def self.pre_0_9?(terraform_version)
-      new('< 0.9.0-beta').satisfied_by?(terraform_version)
-    end
-
     attr_reader :requirement
 
     def initialize(requirement)

data/lib/yle_tf_plugins/backends/{s3 → __default}/plugin.rb

@@ -1,14 +1,16 @@
+# frozen_string_literal: true
+
 require 'yle_tf'
+require 'yle_tf/backend'
 
 module YleTfPlugins
   module Backends
-    module S3
+    module Default
       class Plugin < YleTf::Plugin
         register
 
-        backend('s3') do
-          require_relative 'command'
-          Command
+        backend(DEFAULT_BACKEND) do
+          YleTf::Backend
         end
       end
     end

data/lib/yle_tf_plugins/backends/file/{command.rb → backend.rb}

@@ -1,25 +1,24 @@
-require_relative 'config'
+# frozen_string_literal: true
+
+require 'pathname'
+require 'yle_tf/backend'
+require 'yle_tf/logger'
 
 module YleTfPlugins
   module Backends
     module File
-      class Command
-        def backend_config(config)
-          local_path = Pathname.pwd.join('terraform.tfstate')
-          tfstate_path = tfstate_path(config)
-
+      class Backend < YleTf::Backend
+        # Symlinks local "terraform.tfstate" to the specified path
+        def configure
           YleTf::Logger.info("Symlinking state to '#{tfstate_path}'")
+          local_path = Pathname.pwd.join('terraform.tfstate')
           local_path.make_symlink(tfstate_path)
-          tfstate_path.write(tfstate_template, perm: 0o644) if !tfstate_path.exist?
 
-          Config.new(
-            'file',
-            'file' => tfstate_path.to_s
-          )
+          tfstate_path.write(tfstate_template, perm: 0o644) if !tfstate_path.exist?
         end
 
-        def tfstate_path(config)
-          config.module_dir.join(config.fetch('backend', 'file'))
+        def tfstate_path
+          @tfstate_path ||= config.module_dir.join(config.fetch('backend', 'file', 'path'))
         end
 
         def tfstate_template

data/lib/yle_tf_plugins/backends/file/plugin.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'yle_tf'
 
 module YleTfPlugins
@@ -7,8 +9,8 @@ module YleTfPlugins
         register
 
         backend('file') do
-          require_relative 'command'
-          Command
+          require_relative 'backend'
+          Backend
         end
       end
     end

data/lib/yle_tf_plugins/commands/__default/command.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'yle_tf/logger'
 require 'yle_tf/system'
 

data/lib/yle_tf_plugins/commands/__default/plugin.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'yle_tf'
 
 module YleTfPlugins

data/lib/yle_tf_plugins/commands/_config/command.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'yle_tf/logger'
 
 module YleTfPlugins

data/lib/yle_tf_plugins/commands/_config/plugin.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'yle_tf'
 
 module YleTfPlugins

data/lib/yle_tf_plugins/commands/_shell/command.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module YleTfPlugins
   module CommandShell
     class Command

data/lib/yle_tf_plugins/commands/_shell/plugin.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'yle_tf'
 
 module YleTfPlugins

data/lib/yle_tf_plugins/commands/help/command.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'optparse'
 
 require 'yle_tf/system'

data/lib/yle_tf_plugins/commands/help/plugin.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'yle_tf'
 
 module YleTfPlugins

data/lib/yle_tf_plugins/commands/version/command.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'yle_tf/system'
 require 'yle_tf/version'
 

data/lib/yle_tf_plugins/commands/version/plugin.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'yle_tf'
 
 module YleTfPlugins

metadata

@@ -1,59 +1,101 @@
 --- !ruby/object:Gem::Specification
 name: yle_tf
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 1.3.0
 platform: ruby
 authors:
 - Yleisradio
 - Teemu Matilainen
 - Antti Forsell
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2018-03-12 00:00:00.000000000 Z
+date: 2020-10-12 00:00:00.000000000 Z
 dependencies:
+- !ruby/object:Gem::Dependency
+  name: thwait
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.2.0
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.2.0
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.13'
+        version: '2.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.0'
+- !ruby/object:Gem::Dependency
+  name: guard-rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '4.7'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.13'
+        version: '4.7'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '12.0'
+        version: '13.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '12.0'
+        version: '13.0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.5'
+        version: '3.8'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.8'
+- !ruby/object:Gem::Dependency
+  name: serverspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.41'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.5'
+        version: '2.41'
 description: Tooling for Terraform to support environments, hooks, etc.
 email:
 - devops@yle.fi
@@ -77,15 +119,18 @@ files:
 - lib/yle_tf/action/tmpdir.rb
 - lib/yle_tf/action/verify_terraform_version.rb
 - lib/yle_tf/action/verify_tf_env.rb
+- lib/yle_tf/action/verify_yle_tf_version.rb
 - lib/yle_tf/action/write_terraformrc_defaults.rb
-- lib/yle_tf/backend_config.rb
+- lib/yle_tf/backend.rb
 - lib/yle_tf/cli.rb
 - lib/yle_tf/config.rb
 - lib/yle_tf/config/defaults.rb
 - lib/yle_tf/config/erb.rb
 - lib/yle_tf/config/file.rb
 - lib/yle_tf/config/loader.rb
+- lib/yle_tf/config/migration.rb
 - lib/yle_tf/error.rb
+- lib/yle_tf/helpers/hash.rb
 - lib/yle_tf/logger.rb
 - lib/yle_tf/logger/colorize.rb
 - lib/yle_tf/plugin.rb
@@ -101,11 +146,9 @@ files:
 - lib/yle_tf/vars_file.rb
 - lib/yle_tf/version.rb
 - lib/yle_tf/version_requirement.rb
-- lib/yle_tf_plugins/backends/file/command.rb
-- lib/yle_tf_plugins/backends/file/config.rb
+- lib/yle_tf_plugins/backends/__default/plugin.rb
+- lib/yle_tf_plugins/backends/file/backend.rb
 - lib/yle_tf_plugins/backends/file/plugin.rb
-- lib/yle_tf_plugins/backends/s3/command.rb
-- lib/yle_tf_plugins/backends/s3/plugin.rb
 - lib/yle_tf_plugins/commands/__default/command.rb
 - lib/yle_tf_plugins/commands/__default/plugin.rb
 - lib/yle_tf_plugins/commands/_config/command.rb
@@ -117,7 +160,6 @@ files:
 - lib/yle_tf_plugins/commands/version/command.rb
 - lib/yle_tf_plugins/commands/version/plugin.rb
 - vendor/hash_deep_merge.rb
-- vendor/logger_level_patch.rb
 - vendor/middleware/LICENSE
 - vendor/middleware/builder.rb
 - vendor/middleware/runner.rb
@@ -125,7 +167,7 @@ homepage: https://github.com/Yleisradio/yle_tf
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -133,16 +175,15 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '2.2'
+      version: '2.3'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.3
-signing_key: 
+rubygems_version: 3.1.2
+signing_key:
 specification_version: 4
 summary: Tooling for Terraform
 test_files: []