yiffspace-core 0.2.0 → 0.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 616274421a5c76dd24f3280528dba48846a7d8ffdbf2b6b77a8a9bc6ba243f5e
-  data.tar.gz: 49ef59c885784dc479dcc475a4bf55e24bf208a53e9a4288354a68072b2cfd1b
+  metadata.gz: dcc7debaf3de27ae727e1ff742fd67eda285f06cf098d623968298bf4ef5f32c
+  data.tar.gz: b17224bbb3249295b7f08132bf66c0c45770d638f5918909611e8d175d383afc
 SHA512:
-  metadata.gz: ae0ca898066aeb4781fc565f168189a42601476610b234bdf3fb3431a97dc275e2163a19db67fff2b10718b549bead50a715bcd721635f461d11028ae8b931d4
-  data.tar.gz: 7b358ed2a0c766ded8b197596eb768bcdfdc062d1f523f19bb271eda4259f484ce2aeaa7c48192600b1c11d44b91136772eae108a3a9ca594bb445305d475b70
+  metadata.gz: 6a84fcebd3d24a033798cd6f02d1e69aa8cdf0679bafea7f2987ff66cb849b858d18367db016d4bf23a93e01975e1bbc5b373eb186c354594bcdf458d43a7b87
+  data.tar.gz: da3e8a6557800d1c1259f6bf998fc8b52b79f8c2e4848729166a3667f16d1d28acb21f8661481071b716dc06bcf5f9b7e8287d4e8d6386cd9f5a381f13bf4b93

data/CHANGELOG.md

@@ -32,6 +32,25 @@
 - The dummy test app no longer needs Postgres - only the fixes table's
   `nulls_not_distinct` index required it, and that lives in `yiffspace-fixers`
   now. Back to plain sqlite3, `docker-compose.yml` removed.
+- Fixed `YiffSpace::Utils::Helpers`/`Routes` (`Helpers`/`Routes` under
+  `yiffspace-include`) dropping keyword arguments: their `method_missing` used
+  a bare `*, &` splat, which isn't `ruby2_keywords`-aware, so a call like
+  `h.some_helper(post, tags: tags)` arrived with the `tags:` hash flattened
+  into a positional argument instead of a keyword - silently landing in
+  whatever parameter came next rather than raising. Both now use `...` to
+  forward positional, keyword, and block arguments correctly.
+- `YiffSpace::Utils::Helpers` (`Helpers`) now also makes the app's route
+  `_path`/`_url` helpers available *inside* the helper methods it proxies to,
+  not just to callers going through it directly - a helper that itself calls
+  `some_path(...)` (with no receiver) now works the same way it would from a
+  real view, instead of raising `NoMethodError`.
+- Fixed `parallel_find_each` exhausting the connection pool: records run on
+  concurrent-ruby's shared `:io` pool, whose threads never exit, so any plain
+  `connection` call inside the block leased a connection to that thread for
+  good. Once enough threads held one, every other record waited out the pool
+  timeout and raised `ActiveRecord::ConnectionTimeoutError`. Each record now
+  runs inside `with_connection(prevent_permanent_checkout: true)`, which
+  returns the connection when the block finishes.
 
 ## 0.1.0
 

data/lib/yiffspace/concerns/concurrency_methods.rb

@@ -6,12 +6,16 @@ module YiffSpace
       extend(ActiveSupport::Concern)
 
       class_methods do
-        def parallel_find_each(**, &)
+        def parallel_find_each(**, &block)
           # XXX We may deadlock if a transaction is open; do a non-parallel each.
-          return find_each(&) if connection.transaction_open?
+          return find_each(&block) if connection.transaction_open?
 
           find_in_batches(error_on_ignore: true, **) do |batch|
-            batch.parallel_each(&)
+            # The pool threads are shared and never finish, so a connection leased on one (any plain
+            # `connection` call) would be held forever, starving the rest. Return it after each record
+            batch.parallel_each do |record|
+              connection_pool.with_connection(prevent_permanent_checkout: true) { block.call(record) }
+            end
           end
         end
       end

data/lib/yiffspace/core/version.rb

@@ -2,6 +2,6 @@
 
 module YiffSpace
   module Core
-    VERSION = "0.2.0"
+    VERSION = "0.2.2"
   end
 end

data/lib/yiffspace/utils/helpers.rb

@@ -10,16 +10,40 @@ module YiffSpace
       # `h.some_helper`), including ones marked private in their helper module - private only
       # restricts calling with an explicit receiver, and normal view rendering (which invokes
       # helpers without one) isn't affected either way.
-      def method_missing(name, *, &)
-        helpers = YiffSpace.config.application_controller_class.helpers
-        return helpers.send(name, *, &) if helpers.respond_to?(name, true)
+      def method_missing(name, ...)
+        helpers = target
+        return helpers.send(name, ...) if helpers.respond_to?(name, true)
 
         super
       end
 
       def respond_to_missing?(name, include_private = false)
-        YiffSpace.config.application_controller_class.helpers.respond_to?(name, true) || super
+        target.respond_to?(name, true) || super
+      end
+
+      # ApplicationController.helpers behaves like a view for registered helper modules, but
+      # (unlike an actual view) doesn't include the app's route url_helpers - so a helper method
+      # invoked through this proxy couldn't call `some_path`/`some_url` itself. Extend the shared
+      # proxy once so route helpers are available from inside helper methods too, not just to
+      # callers going through this module directly.
+      #
+      # `extend`ing the generated url_helpers module only grants the path/url helper methods
+      # themselves - they're written to call `url_options`/`_routes`/`optimize_routes_generation?`
+      # on whatever they're called on, and the module only defines those three on its own
+      # singleton class (so it works standalone), not as instance methods `extend` would carry
+      # over. Delegate them by hand so the extended methods have what they need to run.
+      def target
+        helpers = YiffSpace.config.application_controller_class.helpers
+        url_helpers = Rails.application.routes.url_helpers
+        unless helpers.is_a?(url_helpers)
+          helpers.define_singleton_method(:url_options) { url_helpers.url_options }
+          helpers.define_singleton_method(:_routes) { url_helpers._routes }
+          helpers.define_singleton_method(:optimize_routes_generation?) { url_helpers.optimize_routes_generation? }
+          helpers.extend(url_helpers)
+        end
+        helpers
       end
+      private_class_method(:target)
     end
   end
 end

data/lib/yiffspace/utils/routes.rb

@@ -13,9 +13,9 @@ module YiffSpace
     module Routes
       module_function
 
-      def method_missing(name, *, &)
+      def method_missing(name, ...)
         url_helpers = Rails.application.routes.url_helpers
-        return url_helpers.public_send(name, *, &) if url_helpers.respond_to?(name)
+        return url_helpers.public_send(name, ...) if url_helpers.respond_to?(name)
 
         super
       end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: yiffspace-core
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.2
 platform: ruby
 authors:
 - Donovan_DMC
 bindir: bin
 cert_chain: []
-date: 2026-09-04 00:00:00.000000000 Z
+date: 2026-10-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: abbrev