yiffspace-core 0.2.0 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 616274421a5c76dd24f3280528dba48846a7d8ffdbf2b6b77a8a9bc6ba243f5e
-  data.tar.gz: 49ef59c885784dc479dcc475a4bf55e24bf208a53e9a4288354a68072b2cfd1b
+  metadata.gz: d9e70befbca65b0155e1a317149268f3c4b88812312e6c382c331d306b04816e
+  data.tar.gz: 2bf60d4c568ac65d5dc97a6699b6f5d4e94a9066d9d4d7f3bd5808a3481b03d6
 SHA512:
-  metadata.gz: ae0ca898066aeb4781fc565f168189a42601476610b234bdf3fb3431a97dc275e2163a19db67fff2b10718b549bead50a715bcd721635f461d11028ae8b931d4
-  data.tar.gz: 7b358ed2a0c766ded8b197596eb768bcdfdc062d1f523f19bb271eda4259f484ce2aeaa7c48192600b1c11d44b91136772eae108a3a9ca594bb445305d475b70
+  metadata.gz: 86cc77b00d1b2308afddd100d3cc20ad8194669bb0e030ea2e44763e798c703560b321a58162b4acd09d5502777fde4283f57e981d5dcc7662dd5932037c8a77
+  data.tar.gz: a77cb9429d123a90b4d290934a453d55790c2978c50a03cdacb4804eb70dddfb6afd05ba9e38cb404b250f0b848e03dda36190044b81af697e5c6a28017906b6

data/CHANGELOG.md

@@ -32,6 +32,18 @@
 - The dummy test app no longer needs Postgres - only the fixes table's
   `nulls_not_distinct` index required it, and that lives in `yiffspace-fixers`
   now. Back to plain sqlite3, `docker-compose.yml` removed.
+- Fixed `YiffSpace::Utils::Helpers`/`Routes` (`Helpers`/`Routes` under
+  `yiffspace-include`) dropping keyword arguments: their `method_missing` used
+  a bare `*, &` splat, which isn't `ruby2_keywords`-aware, so a call like
+  `h.some_helper(post, tags: tags)` arrived with the `tags:` hash flattened
+  into a positional argument instead of a keyword - silently landing in
+  whatever parameter came next rather than raising. Both now use `...` to
+  forward positional, keyword, and block arguments correctly.
+- `YiffSpace::Utils::Helpers` (`Helpers`) now also makes the app's route
+  `_path`/`_url` helpers available *inside* the helper methods it proxies to,
+  not just to callers going through it directly - a helper that itself calls
+  `some_path(...)` (with no receiver) now works the same way it would from a
+  real view, instead of raising `NoMethodError`.
 
 ## 0.1.0
 

data/lib/yiffspace/core/version.rb

@@ -2,6 +2,6 @@
 
 module YiffSpace
   module Core
-    VERSION = "0.2.0"
+    VERSION = "0.2.1"
   end
 end

data/lib/yiffspace/utils/helpers.rb

@@ -10,16 +10,40 @@ module YiffSpace
       # `h.some_helper`), including ones marked private in their helper module - private only
       # restricts calling with an explicit receiver, and normal view rendering (which invokes
       # helpers without one) isn't affected either way.
-      def method_missing(name, *, &)
-        helpers = YiffSpace.config.application_controller_class.helpers
-        return helpers.send(name, *, &) if helpers.respond_to?(name, true)
+      def method_missing(name, ...)
+        helpers = target
+        return helpers.send(name, ...) if helpers.respond_to?(name, true)
 
         super
       end
 
       def respond_to_missing?(name, include_private = false)
-        YiffSpace.config.application_controller_class.helpers.respond_to?(name, true) || super
+        target.respond_to?(name, true) || super
+      end
+
+      # ApplicationController.helpers behaves like a view for registered helper modules, but
+      # (unlike an actual view) doesn't include the app's route url_helpers - so a helper method
+      # invoked through this proxy couldn't call `some_path`/`some_url` itself. Extend the shared
+      # proxy once so route helpers are available from inside helper methods too, not just to
+      # callers going through this module directly.
+      #
+      # `extend`ing the generated url_helpers module only grants the path/url helper methods
+      # themselves - they're written to call `url_options`/`_routes`/`optimize_routes_generation?`
+      # on whatever they're called on, and the module only defines those three on its own
+      # singleton class (so it works standalone), not as instance methods `extend` would carry
+      # over. Delegate them by hand so the extended methods have what they need to run.
+      def target
+        helpers = YiffSpace.config.application_controller_class.helpers
+        url_helpers = Rails.application.routes.url_helpers
+        unless helpers.is_a?(url_helpers)
+          helpers.define_singleton_method(:url_options) { url_helpers.url_options }
+          helpers.define_singleton_method(:_routes) { url_helpers._routes }
+          helpers.define_singleton_method(:optimize_routes_generation?) { url_helpers.optimize_routes_generation? }
+          helpers.extend(url_helpers)
+        end
+        helpers
       end
+      private_class_method(:target)
     end
   end
 end

data/lib/yiffspace/utils/routes.rb

@@ -13,9 +13,9 @@ module YiffSpace
     module Routes
       module_function
 
-      def method_missing(name, *, &)
+      def method_missing(name, ...)
         url_helpers = Rails.application.routes.url_helpers
-        return url_helpers.public_send(name, *, &) if url_helpers.respond_to?(name)
+        return url_helpers.public_send(name, ...) if url_helpers.respond_to?(name)
 
         super
       end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: yiffspace-core
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
 platform: ruby
 authors:
 - Donovan_DMC