yes_ship_it 0.0.5 → 0.0.6

data/spec/system/ruby_gem_spec.rb

@@ -117,8 +117,6 @@ EOT
     it "tells how to login" do
       @client.execute(["yes_ship_it.ruby2.1"], working_directory: "red_herring")
 
-      expect(@client.exit_code).to eq(1)
-
       expected_output = <<EOT
 Shipping...
 
@@ -134,8 +132,9 @@ Asserting published gem: error
 
 Ran into an error. Stopping shipping.
 EOT
+      expect(@client.err).to eq("")
       expect(@client.out).to eq(expected_output)
-      expect(@client.err.empty?).to be(true)
+      expect(@client.exit_code).to eq(1)
     end
   end
 end

data/spec/unit/assertion_spec.rb

@@ -1,6 +1,16 @@
 require_relative "spec_helper"
 
 describe YSI::Assertion do
+  describe ".class_name" do
+    it "converts simple name" do
+      expect(YSI::Assertion.class_name("simple")).to eq ("Simple")
+    end
+
+    it "converts multi-word name" do
+      expect(YSI::Assertion.class_name("multi_word")).to eq ("MultiWord")
+    end
+  end
+
   describe ".class_for_name" do
     it "creates VersionNumber class" do
       expect(YSI::Assertion.class_for_name("version")).
@@ -18,7 +28,7 @@ describe YSI::Assertion do
       parameter :some_thing
       parameter :some_other_thing, "default_hello"
 
-      def display_name
+      def self.display_name
         "My Assertion"
       end
 

data/spec/unit/assertions/change_log_spec.rb

@@ -6,7 +6,9 @@ describe YSI::ChangeLog do
       engine = YSI::Engine.new
       engine.version = "1.2.3"
       a = YSI::ChangeLog.new(engine)
-      expect(a.check_content("")).to eq("Can't find version 1.2.3 in change log")
+      expect {
+        a.check_content("")
+      }.to raise_error("Can't find version 1.2.3 in change log")
     end
 
     it "when no version" do
@@ -20,7 +22,9 @@ describe YSI::ChangeLog do
 
 * Some changes
 EOT
-      expect(a.check_content(content)).to eq("Can't find version 1.2.3 in change log")
+      expect {
+        a.check_content(content)
+      }.to raise_error("Can't find version 1.2.3 in change log")
     end
 
     it "when all info is there" do

data/spec/unit/assertions/published_gem_spec.rb

@@ -2,13 +2,15 @@ require_relative "../spec_helper.rb"
 
 describe YSI::PublishedGem do
   describe "#assert" do
-    it "returns nil if there is an error" do
-      engine = YSI::Engine
+    it "raises AssertionError if there is an error" do
+      engine = YSI::Engine.new
       allow(engine).to receive(:project_name).and_return("IdontExist")
       allow(engine).to receive(:version).and_return("0.0")
-      assertion = YSI::PublishedGem.new(YSI::Engine)
+      assertion = YSI::PublishedGem.new(engine)
 
-      expect(assertion.assert).to be(nil)
+      expect {
+        assertion.assert(engine.executor)
+      }.to raise_error(YSI::AssertionError)
     end
   end
 end

data/spec/unit/assertions/pushed_code_spec.rb

@@ -14,7 +14,7 @@ describe YSI::PushedCode do
     assertion = YSI::PushedCode.new(engine)
     Dir.chdir(File.join(dir, "red_herring")) do
       expect(assertion.check).to be(nil)
-      expect(assertion.assert).to eq "pushed"
+      expect(assertion.assert(engine.executor)).to eq "pushed"
     end
   end
 end

data/spec/unit/assertions/version_spec.rb

@@ -40,5 +40,10 @@ EOT
       file = given_file("version/version.go")
       expect(subject.parse_version(file)).to eq("0.0.1")
     end
+
+    it "in C++" do
+      file = given_file("version/polkaversion.h")
+      expect(subject.parse_version(file)).to eq("0.8")
+    end
   end
 end

data/spec/unit/assertions/yes_it_shipped_spec.rb

@@ -67,7 +67,7 @@ EOT
 
       assertion = YSI::YesItShipped.new(engine)
 
-      expect(assertion.assert).to eq("dummy-1.1.1")
+      expect(assertion.assert(engine.executor)).to eq("dummy-1.1.1")
     end
   end
 end

data/spec/unit/dry_executor_spec.rb

@@ -0,0 +1,5 @@
+require_relative "spec_helper"
+
+describe YSI::DryExecutor do
+  it_behaves_like "an executor"
+end

data/spec/unit/engine_spec.rb

@@ -149,4 +149,20 @@ EOT
       expect(@engine.config_url).to eq("https://raw.githubusercontent.com/cornelius/red_herring/master/yes_ship_it.conf")
     end
   end
+
+  describe "dry run" do
+    it "creates real executor by default" do
+      expect(subject.executor.class).to be(YSI::Executor)
+    end
+
+    it "sets dry run" do
+      subject.dry_run = true
+      expect(subject.executor.class).to be(YSI::DryExecutor)
+    end
+
+    it "unsets dry run" do
+      subject.dry_run = false
+      expect(subject.executor.class).to be(YSI::Executor)
+    end
+  end
 end

data/spec/unit/executor_spec.rb

@@ -0,0 +1,26 @@
+require_relative "spec_helper"
+
+describe YSI::Executor do
+  it_behaves_like "an executor"
+
+  describe "working directory" do
+    it "runs in the given working directory" do
+      working_directory = subject.run_command(["pwd"], working_directory: "/tmp")
+      expect(working_directory).to eq("/tmp\n")
+    end
+
+    it "sets back the working directory to the original value" do
+      current_working_directory = Dir.pwd
+      subject.run_command(["ls"], working_directory: "/tmp")
+      expect(Dir.pwd).to eq(current_working_directory)
+    end
+
+    it "sets back the working directory to the original value when there is an error" do
+      current_working_directory = Dir.pwd
+      expect {
+        subject.run_command(["ls /IMNOTTHERE"], working_directory: "/tmp")
+      }.to raise_error(YSI::AssertionError)
+      expect(Dir.pwd).to eq(current_working_directory)
+    end
+  end
+end

data/spec/unit/git_spec.rb

@@ -4,9 +4,10 @@ include GivenFilesystemSpecHelpers
 
 describe YSI::Git do
   describe "#origin" do
+    subject { YSI::Git.new(YSI::Executor.new) }
 
     it "grabs the url without the extension" do
-      allow(subject).to receive(:run_git).with("remote -v").and_return(<<EOT
+      allow(subject).to receive(:run_git).with(["remote","-v"]).and_return(<<EOT
 origin  git@github.com:cornelius/red_herring (fetch)
 origin  git@github.com:cornelius/red_herring (push)
 EOT
@@ -15,7 +16,7 @@ EOT
     end
 
     it "grabs the url with the extension" do
-      allow(subject).to receive(:run_git).with("remote -v").and_return(<<EOT
+      allow(subject).to receive(:run_git).with(["remote","-v"]).and_return(<<EOT
 origin  git@github.com:cornelius/red_herring.git (fetch)
 origin  git@github.com:cornelius/red_herring.git (push)
 EOT
@@ -30,7 +31,7 @@ EOT
     it "returns true if local changes are not in remote branch" do
       dir = given_directory
       setup_test_git_repo("007", dir)
-      git = YSI::Git.new(File.join(dir, "red_herring"))
+      git = YSI::Git.new(YSI::Executor.new, File.join(dir, "red_herring"))
 
       expect(git.needs_push?).to be(true)
     end
@@ -38,7 +39,7 @@ EOT
     it "returns false if local changes are in remote branch" do
       dir = given_directory
       setup_test_git_repo("008", dir)
-      git = YSI::Git.new(File.join(dir, "red_herring"))
+      git = YSI::Git.new(YSI::Executor.new, File.join(dir, "red_herring"))
 
       expect(git.needs_push?).to be(false)
     end

data/spec/unit/init_spec.rb

@@ -0,0 +1,49 @@
+require_relative "spec_helper"
+
+describe YSI::Init do
+  use_given_filesystem
+
+  it "falls back to generic project if it can not detect type" do
+    path = given_directory
+
+    init = YSI::Init.new(path)
+    out = double
+    allow(out).to receive(:puts)
+    init.out = out
+    init.setup_config
+
+    expected_config = <<-EOT
+# Experimental release automation. See https://github.com/cornelius/yes_ship_it.
+assertions:
+  - release_branch
+  - working_directory
+  - version
+  - change_log
+  - tag
+  - pushed_tag
+  - pushed_code
+  - yes_it_shipped
+EOT
+    expect(File.read(File.join(path, "yes_ship_it.conf"))).to eq(expected_config)
+  end
+
+  it "detects ruby" do
+    path = nil
+    given_directory("init") do
+      path = given_directory_from_data("ruby", from: "init/ruby" )
+    end
+
+    init = YSI::Init.new(path)
+    out = double
+    allow(out).to receive(:puts)
+    init.out = out
+    init.setup_config
+
+    expected_config = <<-EOT
+# Experimental release automation. See https://github.com/cornelius/yes_ship_it.
+include:
+  ruby_gem
+EOT
+    expect(File.read(File.join(path, "yes_ship_it.conf"))).to eq(expected_config)
+  end
+end

data/spec/unit/plugin_spec.rb

@@ -0,0 +1,18 @@
+require_relative "spec_helper"
+
+describe YSI::Plugin do
+  use_given_filesystem
+
+  it "loads plugins" do
+    dir = given_directory do
+      given_directory "yes_ship_it" do
+        given_directory_from_data "assertions", from: "plugins"
+      end
+    end
+
+    expect(YSI::Plugin.new(dir).load).to eq({
+      "my_other_plugin" => YSI::MyOtherPlugin,
+      "my_plugin" => YSI::MyPlugin
+    })
+  end
+end

data/spec/unit/support/assertion_examples.rb

@@ -7,6 +7,10 @@ shared_examples "an assertion" do
     expect(assertion.display_name).to be_a(String)
   end
 
+  it "has a display name as class method" do
+    expect(assertion.class.display_name).to be_a(String)
+  end
+
   it "checks" do
     expect(assertion).to respond_to(:check)
   end
@@ -14,8 +18,4 @@ shared_examples "an assertion" do
   it "asserts" do
     expect(assertion).to respond_to(:assert)
   end
-
-  it "reports errors" do
-    expect(assertion).to respond_to(:error)
-  end
 end

data/spec/unit/support/executor_examples.rb

@@ -0,0 +1,17 @@
+shared_examples "an executor" do
+  it "runs command" do
+    expect(subject).to respond_to(:run_command)
+  end
+
+  it "posts http" do
+    expect(subject).to respond_to(:http_post)
+  end
+
+  it "puts http" do
+    expect(subject).to respond_to(:http_put)
+  end
+
+  it "deletes http" do
+    expect(subject).to respond_to(:http_delete)
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: yes_ship_it
 version: !ruby/object:Gem::Version
-  version: 0.0.5
+  version: 0.0.6
 platform: ruby
 authors:
 - Cornelius Schumacher
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-12-10 00:00:00.000000000 Z
+date: 2016-01-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: inifile
@@ -135,6 +135,7 @@ files:
 - ".rspec"
 - CHANGELOG.md
 - Gemfile
+- MIT-LICENSE
 - README.md
 - USERS.md
 - assertions/built_gem.rb
@@ -154,11 +155,18 @@ files:
 - lib/version.rb
 - lib/yes_ship_it.rb
 - lib/yes_ship_it/assertion.rb
+- lib/yes_ship_it/dry_executor.rb
 - lib/yes_ship_it/engine.rb
 - lib/yes_ship_it/exceptions.rb
+- lib/yes_ship_it/executor.rb
 - lib/yes_ship_it/git.rb
+- lib/yes_ship_it/init.rb
+- lib/yes_ship_it/plugin.rb
+- spec/data/init/ruby/lib/version.rb
 - spec/data/obs/mycroft.spec.erb
 - spec/data/obs/oscrc
+- spec/data/plugins/my_other_plugin.rb
+- spec/data/plugins/my_plugin.rb
 - spec/data/red_herring-000.tar.gz
 - spec/data/red_herring-001.tar.gz
 - spec/data/red_herring-002.tar.gz
@@ -168,18 +176,24 @@ files:
 - spec/data/red_herring-006.tar.gz
 - spec/data/red_herring-007.tar.gz
 - spec/data/red_herring-008.tar.gz
+- spec/data/version/polkaversion.h
 - spec/data/version/version.go
 - spec/data/version/version.rb
 - spec/data/yes_ship_it.conf
 - spec/data/yes_ship_it.include.conf
+- spec/data/yes_ship_it.plugins.conf
 - spec/data/yes_ship_it.unknown.conf
 - spec/integration/cli_spec.rb
 - spec/integration/spec_helper.rb
 - spec/spec_helper.rb
 - spec/system/data/red_herring-checkout-build.tar.gz
+- spec/system/data/red_herring-checkout-dry-run.tar.gz
 - spec/system/data/red_herring-checkout-not-push.tar.gz
 - spec/system/data/red_herring-checkout-push.tar.gz
+- spec/system/data/red_herring-checkout-rpm.tar.gz
 - spec/system/data/red_herring-remote.tar.gz
+- spec/system/dry_run_spec.rb
+- spec/system/rpm_spec.rb
 - spec/system/ruby_gem_spec.rb
 - spec/system/spec_helper.rb
 - spec/unit/assertion_spec.rb
@@ -194,10 +208,15 @@ files:
 - spec/unit/assertions/working_directory_spec.rb
 - spec/unit/assertions/yes_it_shipped_spec.rb
 - spec/unit/assertions_spec.rb
+- spec/unit/dry_executor_spec.rb
 - spec/unit/engine_spec.rb
+- spec/unit/executor_spec.rb
 - spec/unit/git_spec.rb
+- spec/unit/init_spec.rb
+- spec/unit/plugin_spec.rb
 - spec/unit/spec_helper.rb
 - spec/unit/support/assertion_examples.rb
+- spec/unit/support/executor_examples.rb
 - yes_ship_it-0.0.1.gem
 - yes_ship_it.conf
 - yes_ship_it.gemspec
@@ -221,8 +240,9 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: 1.3.6
 requirements: []
 rubyforge_project: yes_ship_it
-rubygems_version: 2.4.5.1
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: The ultimate release script
 test_files: []
+has_rdoc: