yes_ship_it 0.0.2 → 0.0.3

data/configs/ruby_gem.conf

@@ -1,4 +1,6 @@
 assertions:
+  - release_branch
+  - working_directory
   - version
   - change_log
   - tag

data/lib/version.rb

@@ -1,3 +1,3 @@
 module YSI
-  VERSION = "0.0.2"
+  VERSION = "0.0.3"
 end

data/lib/yes_ship_it.rb

@@ -1,6 +1,9 @@
 require "yaml"
 require "rest-client"
 require "optparse"
+require "inifile"
+require "rexml/document"
+require "erb"
 
 require_relative "yes_ship_it/assertion.rb"
 require_relative "yes_ship_it/engine.rb"

data/lib/yes_ship_it/assertion.rb

@@ -23,8 +23,34 @@ module YSI
       @dependency_names || []
     end
 
+    def self.parameter(name, default_value = nil)
+      define_method("#{name}=") do |value|
+        @parameters[name] = value
+      end
+
+      if default_value
+        define_method("#{name}_default") do
+          return default_value
+        end
+      end
+
+      define_method("#{name}") do
+        if @parameters.has_key?(name)
+          return @parameters[name]
+        else
+          if respond_to?("#{name}_default")
+            return send("#{name}_default")
+          else
+            return nil
+          end
+        end
+      end
+    end
+
     def initialize(engine)
       @engine = engine
+      @parameters = {}
+      @parameter_defaults = {}
     end
 
     def needs

data/lib/yes_ship_it/engine.rb

@@ -1,18 +1,28 @@
 module YSI
   class Engine
     attr_reader :assertions
-    attr_accessor :version, :tag_date
+    attr_accessor :version, :tag_date, :release_archive
     attr_accessor :out
     attr_accessor :dry_run
+    attr_accessor :data_dir
 
     def initialize
       @assertions = []
       @out = STDOUT
+      @data_dir = File.expand_path("~/.ysi")
+    end
+
+    def read_config(yaml)
+      config = YAML.load(yaml)
+      parse(config)
     end
 
     def read(filename)
       config = YAML.load_file(filename)
+      parse(config)
+    end
 
+    def parse(config)
       config.each do |key,value|
         if key == "include"
           included_file = value
@@ -21,14 +31,20 @@ module YSI
         elsif key == "assertions"
           assertions = value
           if assertions
-            assertions.each do |assertion|
-              if assertion == "version_number"
+            assertions.each do |assertion_name, parameters|
+              if assertion_name == "version_number"
                 out.puts "Warning: use `version` instead of `version_number`."
                 out.puts
-                assertion = "version"
+                assertion_name = "version"
               end
 
-              @assertions << YSI::Assertion.class_for_name(assertion).new(self)
+              assertion = YSI::Assertion.class_for_name(assertion_name).new(self)
+              if parameters
+                parameters.each do |parameter_name, parameter_value|
+                  assertion.send(parameter_name + "=", parameter_value)
+                end
+              end
+              @assertions << assertion
             end
           end
         end
@@ -47,6 +63,10 @@ module YSI
       "v#{version}"
     end
 
+    def release_archive_file_name
+      File.basename(release_archive)
+    end
+
     def dependency_errored?(assertion, errored_assertions)
       assertion.needs.each do |need|
         errored_assertions.each do |errored_assertion|

data/spec/data/obs/mycroft.spec.erb

@@ -0,0 +1,11 @@
+# Header of artificial RPM spec file snippet
+
+Name:           go-mycroft
+Version:        <%= version %>
+Release:        0
+Source:         <%= release_archive %>
+
+%prep
+%setup -q -n <%= release_directory %>
+
+%changelog

data/spec/data/obs/oscrc

@@ -0,0 +1,8 @@
+[general]
+# URL to access API server, e.g. https://api.opensuse.org
+# you also need a section [https://api.opensuse.org] with the credentials
+apiurl = https://api.opensuse.org
+
+[https://api.opensuse.org]
+user = myuser
+pass = mypassword

data/spec/data/version/version.go

@@ -0,0 +1,5 @@
+package main
+
+const (
+  Version = "0.0.1"
+)

data/spec/data/version/version.rb

@@ -0,0 +1,3 @@
+module YSI
+  VERSION = "0.0.2"
+end

data/spec/integration/cli_spec.rb

@@ -146,11 +146,16 @@ EOT
         dir = given_directory "test_project" do
           given_file("yes_ship_it.conf", from: "yes_ship_it.include.conf")
         end
+        system("cd #{dir}; git init >/dev/null")
       end
 
       expected_output = <<EOT
 Shipping...
 
+Checking release branch: error
+  Not on release branch 'master'
+Checking working directory: error
+  untracked files
 Checking version number: error
   Expected version in lib/version.rb
 Checking change log: skip (because dependency errored)
@@ -166,6 +171,54 @@ EOT
       expect(run_command(working_directory: dir)).
         to exit_with_error(1, "", expected_output)
     end
+
+    it "creates release archive" do
+      git_dir = given_directory
+      setup_test_git_repo("006", git_dir)
+
+      data_dir = given_directory
+
+      expected_output = <<EOT
+Shipping...
+
+Checking version number: 0.0.2
+Checking tag: fail
+Checking release archive: fail
+
+Asserting tag: v0.0.2
+Asserting release archive: red_herring-0.0.2.tar.gz
+
+Shipped red_herring 0.0.2. Hooray!
+EOT
+
+      expect(run_command(args: ["--data-dir=#{data_dir}"],
+        working_directory: File.join(git_dir, "red_herring"))).
+        to exit_with_success(expected_output)
+
+      release_archive = File.join(data_dir, "release_archives", "red_herring",
+        "4ba08cb0f26d813cd754bc9ccb9f89274f24f2b6",
+        "red_herring-0.0.2.tar.gz")
+
+      expect(File.exist?(File.join(git_dir, "red_herring", "red_herring-0.0.2"))).to be(false)
+
+      expect(File.exist?(release_archive)).to be(true)
+
+      expected_file_list = <<EOT
+red_herring-0.0.2/
+red_herring-0.0.2/bin/
+red_herring-0.0.2/bin/tickle
+red_herring-0.0.2/CHANGELOG.md
+red_herring-0.0.2/Gemfile
+red_herring-0.0.2/red_herring.gemspec
+red_herring-0.0.2/MIT-LICENSE
+red_herring-0.0.2/README.md
+red_herring-0.0.2/lib/
+red_herring-0.0.2/lib/red_herring.rb
+red_herring-0.0.2/lib/version.rb
+EOT
+      file_list = `tar tzf #{release_archive}`.split("\n").sort
+      expect(file_list).to eq(expected_file_list.split("\n").sort)
+    end
   end
 
   describe "changelog helper" do
@@ -193,4 +246,25 @@ EOT
         to exit_with_success(expected_output)
     end
   end
+
+  describe "init" do
+    it "initializes directory with generic template" do
+      dir = given_directory
+
+      expected_output = <<EOT
+Initialized directory for shipping.
+
+Check the file `yes_ship_it.conf` and adapt it to your needs.
+
+Happy shipping!
+EOT
+
+      expect(run_command(args: ["init"], working_directory: dir)).
+        to exit_with_success(expected_output)
+
+      expect(File.read(File.join(dir, "yes_ship_it.conf"))).to eq(
+       "# Experimental release automation. See https://github.com/cornelius/yes_ship_it.\ninclude:\n  ruby_gem\n"
+      )
+    end
+  end
 end

data/spec/system/ruby_gem_spec.rb

@@ -0,0 +1,119 @@
+require_relative "spec_helper"
+
+describe "ship ruby gem" do
+  it "builds gem" do
+    out = double
+    allow(out).to receive(:puts)
+
+    test = Httpotemkin::Test.new(out: out)
+    test.add_server("rubygems")
+    test.add_server("api.rubygems")
+    test.add_server("obs")
+
+    test.run do |client|
+      client.install_gem_from_spec("yes_ship_it.gemspec")
+
+      remote_tar = File.expand_path("../data/red_herring-remote.tar.gz", __FILE__)
+      checkout_tar = File.expand_path("../data/red_herring-checkout-build.tar.gz", __FILE__)
+      client.inject_tarball(remote_tar)
+      client.inject_tarball(checkout_tar)
+
+      client.execute(["yes_ship_it.ruby2.1"], working_directory: "red_herring")
+
+      expect(client.exit_code).to eq(0)
+
+      expected_output = <<EOT
+Shipping...
+
+Checking version number: 0.0.2
+Checking tag: fail
+Checking release archive: fail
+
+Asserting tag: v0.0.2
+Asserting release archive: red_herring-0.0.2.tar.gz
+
+Shipped red_herring 0.0.2. Hooray!
+EOT
+      expect(client.out).to eq(expected_output)
+
+      expect(client.err.empty?).to be(true)
+    end
+  end
+
+  it "pushes gem if it isn't pushed yet" do
+    out = double
+    allow(out).to receive(:puts)
+
+    test = Httpotemkin::Test.new(out: out)
+    test.add_server("rubygems")
+    test.add_server("api.rubygems")
+    test.add_server("obs")
+
+    test.run do |client|
+      client.install_gem_from_spec("yes_ship_it.gemspec")
+
+      remote_tar = File.expand_path("../data/red_herring-remote.tar.gz", __FILE__)
+      checkout_tar = File.expand_path("../data/red_herring-checkout-push.tar.gz", __FILE__)
+      client.inject_tarball(remote_tar)
+      client.inject_tarball(checkout_tar)
+
+      client.execute(["yes_ship_it.ruby2.1"], working_directory: "red_herring")
+
+      expect(client.exit_code).to eq(0)
+
+      expected_output = <<EOT
+Shipping...
+
+Checking version number: 0.0.2
+Checking tag: fail
+Checking built gem: fail
+Checking published gem: fail
+
+Asserting tag: v0.0.2
+Asserting built gem: red_herring-0.0.2.gem
+Asserting published gem: red_herring-0.0.2.gem
+
+Shipped red_herring 0.0.2. Hooray!
+EOT
+      expect(client.out).to eq(expected_output)
+
+      expect(client.err.empty?).to be(true)
+    end
+  end
+
+  it "doesn't push gem if it already is pushed" do
+    out = double
+    allow(out).to receive(:puts)
+
+    test = Httpotemkin::Test.new(out: out)
+    test.add_server("rubygems")
+    test.add_server("api.rubygems")
+    test.add_server("obs")
+
+    test.run do |client|
+      client.install_gem_from_spec("yes_ship_it.gemspec")
+
+      remote_tar = File.expand_path("../data/red_herring-remote.tar.gz", __FILE__)
+      checkout_tar = File.expand_path("../data/red_herring-checkout-not-push.tar.gz", __FILE__)
+      client.inject_tarball(remote_tar)
+      client.inject_tarball(checkout_tar)
+
+      client.execute(["yes_ship_it.ruby2.1"], working_directory: "red_herring")
+
+      expect(client.exit_code).to eq(0)
+
+      expected_output = <<EOT
+Shipping...
+
+Checking version number: 0.0.1
+Checking built gem: red_herring-0.0.1.gem
+Checking published gem: 0.0.1
+
+red_herring 0.0.1 already shipped
+EOT
+      expect(client.out).to eq(expected_output)
+
+      expect(client.err.empty?).to be(true)
+    end
+  end
+end

data/spec/system/spec_helper.rb

@@ -0,0 +1 @@
+require "httpotemkin"

data/spec/unit/assertion_spec.rb

@@ -12,4 +12,50 @@ describe YSI::Assertion do
         to be(YSI::ChangeLog)
     end
   end
+
+  describe "parameters" do
+    class MyAssertion < YSI::Assertion
+      parameter :some_thing
+      parameter :some_other_thing, "default_hello"
+
+      def display_name
+        "My Assertion"
+      end
+
+      def check
+      end
+
+      def assert
+      end
+    end
+
+    it "has methods for parameter" do
+      my = MyAssertion.new(YSI::Engine.new)
+      my.some_thing = "hello"
+      expect(my.some_thing).to eq("hello")
+    end
+
+    it "has default value for parameter" do
+      my = MyAssertion.new(YSI::Engine.new)
+      expect(my.some_other_thing).to eq("default_hello")
+    end
+
+    it "returns nil when parameter is not set" do
+      my = MyAssertion.new(YSI::Engine.new)
+      expect(my.some_thing).to be(nil)
+    end
+
+    it "reads parameter from config" do
+      config = <<EOT
+assertions:
+  my_assertion:
+    some_thing: world
+EOT
+      engine = YSI::Engine.new
+      engine.read_config(config)
+      my = engine.assertions.first
+
+      expect(my.some_thing).to eq("world")
+    end
+  end
 end

data/spec/unit/assertions/release_archive_spec.rb

@@ -0,0 +1,13 @@
+require_relative "../spec_helper.rb"
+
+describe YSI::ReleaseArchive do
+  describe "#check" do
+    it "sets engine.release_archive" do
+      engine = YSI::Engine.new
+      a = YSI::ReleaseArchive.new(engine)
+      a.check
+
+      expect(engine.release_archive).to_not be(nil)
+    end
+  end
+end