yes-core 1.2.0 → 1.3.0

data/lib/yes/core/test_support/aggregate/command_test_dsl.rb

@@ -21,6 +21,28 @@ module Yes
         #     end
         #   end
         module CommandTestDsl
+          # Returns the event-type aggregate prefix that the runtime publishes
+          # for a given aggregate and draft flag. Mirrors
+          # `CommandUtils#aggregate_name_with_draft_suffix` so DSL-generated
+          # `expected_event_type` values match the runtime-published event
+          # types — including the case where `draftable changes_read_model:`
+          # was set explicitly, which makes the camelized read-model name the
+          # event-type prefix instead of the generic `<Aggregate>Draft`.
+          #
+          # @param aggregate_class [Class] The aggregate class under test
+          # @param draft [Boolean] Whether the test exercises a draft command
+          # @return [String] The event-type aggregate prefix
+          def self.expected_event_prefix(aggregate_class, draft:)
+            return aggregate_class.aggregate unless draft
+
+            if aggregate_class.respond_to?(:_changes_read_model_explicit) &&
+               aggregate_class._changes_read_model_explicit
+              aggregate_class.changes_read_model_name.camelize
+            else
+              "#{aggregate_class.aggregate}Draft"
+            end
+          end
+
           # Defines a test block for a command
           #
           # @param command_name [String, Symbol] the name of the command to test
@@ -41,8 +63,8 @@ module Yes
               end
               let(:command_data) { {} }
               let(:expected_event_type) do
-                "#{aggregate_class.context}::#{aggregate_class.aggregate}" \
-                  "#{'Draft' if draft}#{aggregate_class.commands[command].event_name.to_s.classify}"
+                prefix = CommandTestDsl.expected_event_prefix(aggregate_class, draft:)
+                "#{aggregate_class.context}::#{prefix}#{aggregate_class.commands[command].event_name.to_s.classify}"
               end
               let(:expected_event_data) { command_data_with_id }
               let(:expected_event_metadata) { nil }
@@ -99,6 +121,59 @@ module Yes
           def setup(&)
             before(&)
           end
+
+          # Defines a test block for a command group, mirroring {.command}.
+          #
+          # @param group_name [String, Symbol] the command_group name
+          # @param options [Array<Hash>] additional options (e.g., `draft: true`)
+          # @yield block for configuring test cases (success, invalid, no_change)
+          def command_group(group_name, *options, &block)
+            describe group_name.to_s, *options do
+              let(:draft) { options.first&.dig(:draft) }
+              let(:aggregate) { described_class.new(draft:) } unless method_defined?(:aggregate)
+
+              subject { aggregate.public_send(group, command_data) }
+
+              let(:group) { group_name.to_sym }
+              let(:aggregate_class) { aggregate.class }
+              let(:command_data) { {} }
+              let(:expected_event_types) do
+                prefix = CommandTestDsl.expected_event_prefix(aggregate_class, draft:)
+                aggregate_class.command_groups[group].sub_command_names.map do |sub_name|
+                  sub_event_name = aggregate_class.commands[sub_name].event_name.to_s.classify
+                  "#{aggregate_class.context}::#{prefix}#{sub_event_name}"
+                end
+              end
+              let(:success_attributes) { command_data.without(:locale) } unless method_defined?(:success_attributes)
+
+              class_eval(&block) if block_given?
+            end
+          end
+
+          # Defines a successful test for a command group.
+          def success_group(description = 'when successfully executing command group', options = {}, &block)
+            context description, options do
+              instance_eval(&block) if block_given?
+              it_behaves_like 'successful command group'
+            end
+          end
+
+          # Defines an invalid-transition test for a command group.
+          def invalid_group(description, options = {}, &block)
+            context "when #{description}", options do
+              instance_eval(&block) if block_given?
+              it_behaves_like 'invalid command group transition'
+            end
+          end
+
+          # Defines a no-change test for a command group.
+          def no_change_group(description = 'when command group causes no change', options = {}, &block)
+            context description.to_s, options do
+              instance_eval(&block) if block_given?
+              before { aggregate.public_send(group, command_data) }
+              it_behaves_like 'no change command group transition'
+            end
+          end
         end
       end
     end

data/lib/yes/core/test_support/aggregate/shared_examples.rb

@@ -75,3 +75,48 @@ RSpec.shared_examples 'no change transition' do
     )
   end
 end
+
+RSpec.shared_examples 'successful command group' do
+  it 'returns a successful CommandGroupResponse' do
+    expect(subject).to be_a(Yes::Core::Commands::CommandGroupResponse)
+    expect(subject).to be_success
+  end
+
+  it 'publishes one event per sub-command in declaration order' do
+    expect(subject.events.map(&:type)).to eq(expected_event_types)
+  end
+
+  it 'reflects the cumulative state on the read model' do
+    if success_attributes.any?
+      expect { subject }.to change {
+        aggregate.read_model.reload.attributes.to_h.symbolize_keys.slice(*success_attributes.keys)
+      }.to(success_attributes)
+    end
+  end
+end
+
+RSpec.shared_examples 'invalid command group transition' do
+  it 'returns an InvalidTransition error and no events' do
+    aggregate_failures do
+      expect(subject).not_to be_success
+      expect(subject.error).to be_a(Yes::Core::CommandHandling::GuardEvaluator::InvalidTransition)
+      expect(subject.events).to be_empty
+    end
+  end
+
+  it 'does not change the aggregate state' do
+    success_attributes.each_key do |attribute|
+      expect { subject }.not_to(change { aggregate.public_send(attribute) })
+    end
+  end
+end
+
+RSpec.shared_examples 'no change command group transition' do
+  it 'returns a NoChangeTransition error and no events' do
+    aggregate_failures do
+      expect(subject).not_to be_success
+      expect(subject.error).to be_a(Yes::Core::CommandHandling::GuardEvaluator::NoChangeTransition)
+      expect(subject.events).to be_empty
+    end
+  end
+end

data/lib/yes/core/utils/command_utils.rb

@@ -51,6 +51,27 @@ module Yes
           fetch_class(name, :guard_evaluator)
         end
 
+        # Builds a command_group instance for a given group name and flat payload.
+        # The aggregate_id is injected automatically.
+        #
+        # @param group_name [Symbol] The command group name
+        # @param payload [Hash] The flat / partially-nested input payload
+        # @return [Yes::Core::Commands::CommandGroup] The instantiated group command
+        # @raise [RuntimeError] If the command_group class cannot be found
+        def build_group_command(group_name, payload)
+          group_class = fetch_class(group_name, :command_group)
+          group_class.new("#{aggregate.underscore}_id": aggregate_id, **payload)
+        end
+
+        # Fetches the guard evaluator class for a given command group name.
+        #
+        # @param group_name [Symbol] The command group name
+        # @return [Class] The guard evaluator class
+        # @raise [RuntimeError] If the guard evaluator class cannot be found
+        def fetch_guard_evaluator_class_for_group(group_name)
+          fetch_class(group_name, :command_group_guard_evaluator)
+        end
+
         # Fetches the state updater class for a given command name
         #
         # @param name [Symbol] The command name

data/lib/yes/core/version.rb

@@ -2,6 +2,6 @@
 
 module Yes
   module Core
-    VERSION = '1.2.0'
+    VERSION = '1.3.0'
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: yes-core
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.3.0
 platform: ruby
 authors:
 - Nico Ritsche
@@ -195,11 +195,16 @@ files:
 - lib/yes/core/aggregate/dsl/class_resolvers/command/guard_evaluator.rb
 - lib/yes/core/aggregate/dsl/class_resolvers/command/simple_authorizer.rb
 - lib/yes/core/aggregate/dsl/class_resolvers/command/state_updater.rb
+- lib/yes/core/aggregate/dsl/class_resolvers/command_group/base.rb
+- lib/yes/core/aggregate/dsl/class_resolvers/command_group/command.rb
+- lib/yes/core/aggregate/dsl/class_resolvers/command_group/guard_evaluator.rb
 - lib/yes/core/aggregate/dsl/class_resolvers/read_model.rb
 - lib/yes/core/aggregate/dsl/class_resolvers/read_model_filter.rb
 - lib/yes/core/aggregate/dsl/class_resolvers/read_model_serializer.rb
 - lib/yes/core/aggregate/dsl/command_data.rb
 - lib/yes/core/aggregate/dsl/command_definer.rb
+- lib/yes/core/aggregate/dsl/command_group_data.rb
+- lib/yes/core/aggregate/dsl/command_group_definer.rb
 - lib/yes/core/aggregate/dsl/command_shortcut_expander.rb
 - lib/yes/core/aggregate/dsl/constant_resolver.rb
 - lib/yes/core/aggregate/dsl/method_definers/attribute/accessor.rb
@@ -208,6 +213,9 @@ files:
 - lib/yes/core/aggregate/dsl/method_definers/command/base.rb
 - lib/yes/core/aggregate/dsl/method_definers/command/can_command.rb
 - lib/yes/core/aggregate/dsl/method_definers/command/command.rb
+- lib/yes/core/aggregate/dsl/method_definers/command_group/base.rb
+- lib/yes/core/aggregate/dsl/method_definers/command_group/can_command_group.rb
+- lib/yes/core/aggregate/dsl/method_definers/command_group/command_group.rb
 - lib/yes/core/aggregate/has_authorizer.rb
 - lib/yes/core/aggregate/has_read_model.rb
 - lib/yes/core/aggregate/read_model_rebuilder.rb
@@ -223,6 +231,8 @@ files:
 - lib/yes/core/command.rb
 - lib/yes/core/command_handling/aggregate_tracker.rb
 - lib/yes/core/command_handling/command_executor.rb
+- lib/yes/core/command_handling/command_group_executor.rb
+- lib/yes/core/command_handling/command_group_handler.rb
 - lib/yes/core/command_handling/command_handler.rb
 - lib/yes/core/command_handling/event_publisher.rb
 - lib/yes/core/command_handling/guard_evaluator.rb
@@ -233,7 +243,10 @@ files:
 - lib/yes/core/command_handling/read_model_updater.rb
 - lib/yes/core/command_handling/state_updater.rb
 - lib/yes/core/commands/bus.rb
+- lib/yes/core/commands/command_group.rb
+- lib/yes/core/commands/command_group_response.rb
 - lib/yes/core/commands/group.rb
+- lib/yes/core/commands/group_payload_normalizer.rb
 - lib/yes/core/commands/group_response.rb
 - lib/yes/core/commands/helper.rb
 - lib/yes/core/commands/notifier.rb