yerba 0.5.1-x86_64-linux-gnu → 0.6.0-x86_64-linux-gnu

data/rust/src/document/insert.rs

@@ -126,23 +126,109 @@ impl Document {
     Self::validate_path(dot_path)?;
 
     if let Ok(current_node) = self.navigate(dot_path) {
-      if current_node.descendants().find_map(BlockSeq::cast).is_some() {
+      if current_node.descendants().find_map(BlockSeq::cast).is_some()
+        || matches!(self.get_value(dot_path).as_ref(), Some(yaml_serde::Value::Sequence(sequence)) if sequence.is_empty())
+      {
         return self.insert_sequence_item(dot_path, value, position);
       }
     }
 
+    let selector = crate::selector::Selector::parse(dot_path);
+    let has_wildcard = selector.has_wildcard() || selector.has_brackets();
     let (parent_path, key) = dot_path.rsplit_once('.').unwrap_or(("", dot_path));
 
+    if has_wildcard {
+      let count = self.navigate_all_compact(parent_path).len();
+
+      if count == 0 {
+        return Ok(());
+      }
+
+      for i in (0..count).rev() {
+        let nodes = self.navigate_all_compact(parent_path);
+
+        let node = match nodes.get(i) {
+          Some(node) => node.clone(),
+          None => continue,
+        };
+
+        let map = match node.descendants().find_map(BlockMap::cast) {
+          Some(map) => map,
+          None => continue,
+        };
+
+        if find_entry_by_key(&map, key).is_some() {
+          continue;
+        }
+
+        let entries: Vec<_> = map.entries().collect();
+
+        if entries.is_empty() {
+          continue;
+        }
+
+        let first_entry = entries.first().unwrap();
+
+        let start_col = {
+          let offset: usize = first_entry.syntax().text_range().start().into();
+          let source = self.to_string();
+          let before = &source[..offset];
+
+          offset - before.rfind('\n').map(|p| p + 1).unwrap_or(0)
+        };
+
+        let indent = " ".repeat(start_col);
+        let new_entry_text = format!("{}: {}", key, value);
+
+        match &position {
+          InsertPosition::After(target_key) => {
+            let target = find_entry_by_key(&map, target_key);
+            let after_node = target.map(|e| e.syntax().clone()).unwrap_or_else(|| entries.last().unwrap().syntax().clone());
+            let new_text = format!("\n{}{}", indent, new_entry_text);
+
+            self.insert_after_node(&after_node, &new_text)?;
+          }
+
+          InsertPosition::Before(target_key) => {
+            if let Some(target_entry) = find_entry_by_key(&map, target_key) {
+              let target_range = target_entry.syntax().text_range();
+              let replacement = format!("{}\n{}", new_entry_text, indent);
+              let insert_range = TextRange::new(target_range.start(), target_range.start());
+
+              self.apply_edit(insert_range, &replacement)?;
+            } else {
+              let last_entry = entries.last().unwrap();
+              let new_text = format!("\n{}{}", indent, new_entry_text);
+
+              self.insert_after_node(last_entry.syntax(), &new_text)?;
+            }
+          }
+
+          _ => {
+            let last_entry = entries.last().unwrap();
+            let new_text = format!("\n{}{}", indent, new_entry_text);
+
+            self.insert_after_node(last_entry.syntax(), &new_text)?;
+          }
+        }
+      }
+
+      return Ok(());
+    }
+
     self.insert_map_key(parent_path, key, value, position)
   }
 
   fn insert_sequence_item(&mut self, dot_path: &str, value: &str, position: InsertPosition) -> Result<(), YerbaError> {
     let current_node = self.navigate(dot_path)?;
 
-    let sequence = current_node
-      .descendants()
-      .find_map(BlockSeq::cast)
-      .ok_or_else(|| YerbaError::NotASequence(dot_path.to_string()))?;
+    let Some(sequence) = current_node.descendants().find_map(BlockSeq::cast) else {
+      if matches!(self.get_value(dot_path).as_ref(), Some(yaml_serde::Value::Sequence(sequence)) if sequence.is_empty()) {
+        return self.replace_empty_inline_sequence(dot_path, value);
+      }
+
+      return Err(YerbaError::NotASequence(dot_path.to_string()));
+    };
 
     let entries: Vec<_> = sequence.entries().collect();
 
@@ -308,7 +394,34 @@ impl Document {
       .map(|entry| preceding_whitespace_indent(entry.syntax()))
       .unwrap_or_default();
 
-    let new_entry_text = format!("{}: {}", key, value);
+    let is_block_value = value.contains('\n') || value.starts_with("- ");
+    let new_entry_text = if is_block_value {
+      let value_indent = format!("{}  ", indent);
+      let lines: Vec<&str> = value.lines().collect();
+
+      let min_indent = lines
+        .iter()
+        .filter(|line| !line.trim().is_empty())
+        .map(|line| line.len() - line.trim_start().len())
+        .min()
+        .unwrap_or(0);
+
+      let indented_lines: Vec<String> = lines
+        .iter()
+        .map(|line| {
+          if line.trim().is_empty() {
+            String::new()
+          } else {
+            let relative = &line[min_indent..];
+            format!("{}{}", value_indent, relative)
+          }
+        })
+        .collect();
+
+      format!("{}:\n{}", key, indented_lines.join("\n"))
+    } else {
+      format!("{}: {}", key, value)
+    };
 
     match position {
       InsertPosition::Last => {
@@ -381,4 +494,86 @@ impl Document {
       }
     }
   }
+
+  fn replace_empty_inline_sequence(&mut self, dot_path: &str, value: &str) -> Result<(), YerbaError> {
+    let (parent_path, key) = dot_path.rsplit_once('.').unwrap_or(("", dot_path));
+    let parent_node = self.navigate(parent_path)?;
+    let map = parent_node
+      .descendants()
+      .find_map(BlockMap::cast)
+      .ok_or_else(|| YerbaError::NotASequence(dot_path.to_string()))?;
+    let entry = find_entry_by_key(&map, key).ok_or_else(|| YerbaError::SelectorNotFound(dot_path.to_string()))?;
+
+    let item_indent = format!("{}  ", preceding_whitespace_indent(entry.syntax()));
+    let new_item = Self::format_sequence_item(value, &item_indent);
+    let current_node = self.navigate(dot_path)?;
+    let mut range = current_node.text_range();
+    let inline_comment = self.trailing_inline_comment(&current_node);
+
+    if let Some(previous) = current_node.prev_sibling_or_token().and_then(|element| element.into_token()) {
+      if previous.kind() == SyntaxKind::WHITESPACE && !previous.text().contains('\n') {
+        range = TextRange::new(previous.text_range().start(), range.end());
+      }
+    }
+
+    if let Some((_, comment_end)) = inline_comment {
+      range = TextRange::new(range.start(), comment_end);
+    }
+
+    let replacement = match inline_comment {
+      Some((comment_text, _)) => format!(" {}\n{}{}", comment_text, item_indent, new_item),
+      None => format!("\n{}{}", item_indent, new_item),
+    };
+
+    self.apply_edit(range, &replacement)
+  }
+
+  fn trailing_inline_comment(&self, node: &SyntaxNode) -> Option<(String, rowan::TextSize)> {
+    let source = self.root.text().to_string();
+    let start: usize = node.text_range().end().into();
+    let rest = &source[start..];
+    let line_end = rest.find('\n').unwrap_or(rest.len());
+    let trailing = &rest[..line_end];
+    let comment_start = trailing.find('#')?;
+
+    if !trailing[..comment_start].trim().is_empty() {
+      return None;
+    }
+
+    Some((trailing[comment_start..].to_string(), rowan::TextSize::from((start + line_end) as u32)))
+  }
+
+  fn format_sequence_item(value: &str, indent: &str) -> String {
+    if value.contains('\n') {
+      let item_indent = format!("{}  ", indent);
+      let lines: Vec<&str> = value.split('\n').collect();
+
+      let min_indent = lines
+        .iter()
+        .skip(1)
+        .filter(|line| !line.trim().is_empty())
+        .map(|line| line.len() - line.trim_start().len())
+        .min()
+        .unwrap_or(0);
+
+      let indented: Vec<String> = lines
+        .iter()
+        .enumerate()
+        .map(|(index, line)| {
+          if index == 0 {
+            line.to_string()
+          } else if line.trim().is_empty() {
+            String::new()
+          } else {
+            let relative = &line[min_indent..];
+            format!("{}{}", item_indent, relative)
+          }
+        })
+        .collect();
+
+      format!("- {}", indented.join("\n"))
+    } else {
+      format!("- {}", value)
+    }
+  }
 }

data/rust/src/document/mod.rs

@@ -5,7 +5,7 @@ mod insert;
 mod schema;
 mod set;
 mod sort;
-mod style;
+pub mod style;
 mod unique;
 pub use unique::DuplicateInfo;
 
@@ -25,9 +25,9 @@ use std::fs;
 use std::path::{Path, PathBuf};
 
 use rowan::ast::AstNode;
-use rowan::TextRange;
+use rowan::{TextRange, TextSize};
 
-use yaml_parser::ast::{BlockMap, BlockSeq, Root};
+use yaml_parser::ast::{BlockMap, BlockMapEntry, BlockSeq, Root};
 use yaml_parser::{SyntaxKind, SyntaxNode, SyntaxToken};
 
 use crate::error::YerbaError;
@@ -35,7 +35,7 @@ use crate::QuoteStyle;
 
 use crate::syntax::{
   dedent_block_scalar, extract_scalar, extract_scalar_text, find_entry_by_key, find_scalar_token, format_scalar_value, is_map_key, is_yaml_non_string,
-  preceding_whitespace_indent, removal_range, unescape_double_quoted, unescape_single_quoted, ScalarValue,
+  preceding_whitespace_indent, preceding_whitespace_token, removal_range, unescape_double_quoted, unescape_single_quoted, ScalarValue,
 };
 
 #[derive(Debug, Clone)]
@@ -297,6 +297,45 @@ impl Document {
     self.apply_edit(range, text)
   }
 
+  fn remove_map_entry(&mut self, entry: &BlockMapEntry) -> Result<(), YerbaError> {
+    let entry_node = entry.syntax();
+    let entry_range = entry_node.text_range();
+
+    let has_block_value = entry
+      .value()
+      .map(|value| {
+        value
+          .syntax()
+          .descendants()
+          .any(|descendant| descendant.kind() == SyntaxKind::BLOCK_SEQ || descendant.kind() == SyntaxKind::BLOCK_MAP)
+      })
+      .unwrap_or(false);
+
+    if !has_block_value {
+      return self.remove_node(entry_node);
+    }
+
+    let end = if let Some(next_sibling) = entry_node.next_sibling() {
+      next_sibling.text_range().start()
+    } else {
+      entry_node.parent().map(|parent| parent.text_range().end()).unwrap_or(entry_range.end())
+    };
+
+    let start = if let Some(whitespace_token) = preceding_whitespace_token(entry_node) {
+      let whitespace_text = whitespace_token.text();
+      let whitespace_start = whitespace_token.text_range().start();
+
+      whitespace_text
+        .rfind('\n')
+        .map(|offset| whitespace_start + TextSize::from(offset as u32))
+        .unwrap_or(whitespace_start)
+    } else {
+      entry_range.start()
+    };
+
+    self.apply_edit(TextRange::new(start, end), "")
+  }
+
   fn remove_node(&mut self, node: &SyntaxNode) -> Result<(), YerbaError> {
     let inline_comment = self.find_inline_comment(node);
     let range = removal_range(node);
@@ -524,6 +563,17 @@ pub(crate) fn node_to_yaml_value(node: &SyntaxNode) -> yaml_serde::Value {
     return yaml_serde::Value::String(text);
   }
 
+  if node
+    .descendants()
+    .any(|descendant| descendant.kind() == SyntaxKind::FLOW_SEQ || descendant.kind() == SyntaxKind::FLOW_MAP)
+  {
+    let text = node.text().to_string().trim().to_string();
+
+    if let Ok(value) = yaml_serde::from_str(&text) {
+      return value;
+    }
+  }
+
   if let Some(scalar) = extract_scalar(node) {
     use crate::syntax::{detect_yaml_type, is_yaml_truthy, YerbaValueType};