yelp 2.1.2 → 2.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1d7b25abb238f773d41b4c56348c28cf1dd8875f
-  data.tar.gz: c36ca4257db000965d16861e1457e49b3d0e4414
+  metadata.gz: 56a26261a87144e796fc952682cf9d64a00fafa8
+  data.tar.gz: d6ec8e7c5d4972ae6d7c73ad1e23c3757b2b1e87
 SHA512:
-  metadata.gz: 2c21ab0c24f81659212d35bb298e6155dd1fbe6efff623bd5fdcb0de76e67fd5a597bbfdf71f4c8d53bdd6fccc0cf789119b6ba9d6e5b02b1e5c52efe03e8003
-  data.tar.gz: b7bef05e2332c99bf2842d069086255598610907395ab860d1a285f6635fde274f2d792dc88e08116e2ddd199c5f05e571bcb5b8203bb2b0059903b1fd4cc151
+  metadata.gz: ae8700880ac6d3ac60126062350109257a340afa3e26ba6e60fb9fc43585804c3844d25cbf56b4ac9d506ffdae5831ec58e0980aa24d7c77f34630e0949fe15b
+  data.tar.gz: 9eaee0908609b12531a04de473d6633c79fd788f480b8f3421a78490e47def9a8717bc848e0d7a750a344995da72b61a4b6b1594b09b1d062869dd05b906adb5

data/lib/yelp/error.rb

@@ -47,6 +47,7 @@ module Yelp
 
     class Base < StandardError
       def initialize(msg,error=nil)
+        super(msg)
       end
     end
 
@@ -76,9 +77,15 @@ module Yelp
     end
 
     class InvalidParameter < Base
+      attr_reader :text, :field 
+
       def initialize(msg='One or more parameters were invalid', error=nil)
-        msg = msg + ': ' + error['field'] unless error.nil?
-        super
+        unless error.nil?
+          @text = error['text']
+          @field = error['field']
+          msg = msg + ': ' + @field
+        end
+        super(msg,error)
       end
     end
 

data/lib/yelp/version.rb

@@ -1,3 +1,3 @@
 module Yelp
-  VERSION = "2.1.2"
+  VERSION = "2.1.3"
 end

data/spec/yelp/error_spec.rb

@@ -18,4 +18,27 @@ describe Yelp::Error do
       }.to raise_error(Yelp::Error::InternalError)
     end
   end
+
+  context 'invalid parameter' do 
+    let(:response_body) { "{\"error\": {\"text\": \"One or more parameters are invalid in request\", \"id\": \"INVALID_PARAMETER\", \"field\": \"oauth_token\"}}" }
+    let(:bad_response)  { double('response', status: 400, body: response_body) }
+
+    it 'should raise an invalid response error' do 
+      expect {
+        Yelp::Error.check_for_error(bad_response)
+      }.to raise_error(Yelp::Error::InvalidParameter)
+    end
+
+    it 'should expose the field parameter' do 
+      begin
+        Yelp::Error.check_for_error(bad_response)
+      rescue Yelp::Error::InvalidParameter => e 
+        # verifies that StandardError message attribute is available
+        expect(e.message).to eq("One or more parameters are invalid in request: oauth_token")
+        # verifies that we can get access to the specific field that was invalid
+        expect(e.field).to eq("oauth_token")
+      end        
+    end
+
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: yelp
 version: !ruby/object:Gem::Version
-  version: 2.1.2
+  version: 2.1.3
 platform: ruby
 authors:
 - Tomer Elmalem
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-03-22 00:00:00.000000000 Z
+date: 2016-07-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler