yelp 2.0.7 → 2.1.0

data/spec/yelp/endpoint/business_spec.rb

@@ -14,8 +14,8 @@ describe Yelp::Endpoint::Business do
       end
     }
 
-    it { should be_a(BurstStruct::Burst) }
-    its(:name) { should eql('Yelp') }
+    it { should be_a(Yelp::Response::Business) }
+    its('business.name') { should eql('Yelp') }
   end
 
   describe 'errors' do

data/spec/yelp/endpoint/phone_search_spec.rb

@@ -15,7 +15,7 @@ describe Yelp::Endpoint::PhoneSearch do
       end
     }
 
-    it { should be_a(BurstStruct::Burst) }
+    it { should be_a(Yelp::Response::PhoneSearch) }
     it 'should get results' do
       expect(results.businesses.size).to be > 0
     end

data/spec/yelp/endpoint/search_spec.rb

@@ -16,7 +16,7 @@ describe Yelp::Endpoint::Search do
       end
     }
 
-    it { should be_a(BurstStruct::Burst) }
+    it { should be_a(Yelp::Response::Search) }
     it 'should get results' do
       expect(results.businesses.size).to be > 0
     end

data/spec/yelp/responses/base_spec.rb

@@ -0,0 +1,22 @@
+require 'spec_helper'
+
+describe Yelp::Response::Base do
+  describe '#initialize' do
+    let(:json) { Hash['a' => 10, 'b' => 20] }
+
+    subject(:base) { base = Yelp::Response::Base.new(json) }
+
+    it { should be_a(Yelp::Response::Base) }
+
+    it 'should create variables' do
+      expect(base.instance_variable_get('@a')).to eql 10
+      expect(base.instance_variable_get('@b')).to eql 20
+    end
+  end
+
+  describe '#initialize nil' do
+    subject(:base) { Yelp::Response::Base.new(nil) }
+
+    it { should be_a(Yelp::Response::Base) }
+  end
+end

data/tasks/console.rake

@@ -1,4 +1,4 @@
-desc "Open an irb session preloaded with this library"
+desc "Open a pry session preloaded with this library"
 task :console do
   sh "pry --gem"
-end
+end

data/yelp.gemspec

@@ -9,7 +9,7 @@ Gem::Specification.new do |spec|
   spec.authors       = ['Tomer Elmalem', 'Justin Cunningham', 'Yelp']
   spec.email         = ['telmalem@gmail.com', 'partnerships@yelp.com']
   spec.summary       = %q{Ruby client library for the Yelp API}
-  spec.description   = 'Provides easy way to interact with the Yelp API in any kind of application'
+  spec.description   = 'Provides an easy way to interact with the Yelp API in any kind of application'
   spec.homepage      = 'https://github.com/Yelp/yelp-ruby'
   spec.license       = 'MIT'
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: yelp
 version: !ruby/object:Gem::Version
-  version: 2.0.7
+  version: 2.1.0
 platform: ruby
 authors:
 - Tomer Elmalem
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-10-14 00:00:00.000000000 Z
+date: 2015-10-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -202,7 +202,7 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 0.3.1
-description: Provides easy way to interact with the Yelp API in any kind of application
+description: Provides an easy way to interact with the Yelp API in any kind of application
 email:
 - telmalem@gmail.com
 - partnerships@yelp.com
@@ -220,13 +220,29 @@ files:
 - README.md
 - Rakefile
 - lib/yelp.rb
-- lib/yelp/burst_struct.rb
 - lib/yelp/client.rb
 - lib/yelp/configuration.rb
 - lib/yelp/endpoint/business.rb
 - lib/yelp/endpoint/phone_search.rb
 - lib/yelp/endpoint/search.rb
 - lib/yelp/error.rb
+- lib/yelp/responses/base.rb
+- lib/yelp/responses/business.rb
+- lib/yelp/responses/models/business.rb
+- lib/yelp/responses/models/coordinate.rb
+- lib/yelp/responses/models/deal.rb
+- lib/yelp/responses/models/deal_option.rb
+- lib/yelp/responses/models/gift_certificate.rb
+- lib/yelp/responses/models/gift_certificate_option.rb
+- lib/yelp/responses/models/location.rb
+- lib/yelp/responses/models/rating.rb
+- lib/yelp/responses/models/region.rb
+- lib/yelp/responses/models/region_center.rb
+- lib/yelp/responses/models/region_span.rb
+- lib/yelp/responses/models/review.rb
+- lib/yelp/responses/models/user.rb
+- lib/yelp/responses/phone_search.rb
+- lib/yelp/responses/search.rb
 - lib/yelp/version.rb
 - spec/fixtures/vcr_cassettes/business.yml
 - spec/fixtures/vcr_cassettes/phone_search.yml
@@ -236,13 +252,13 @@ files:
 - spec/spec_helper.rb
 - spec/support/request_error.rb
 - spec/support/shared_configuration.rb
-- spec/yelp/burst_struct_spec.rb
 - spec/yelp/client_spec.rb
 - spec/yelp/configuration_spec.rb
 - spec/yelp/endpoint/business_spec.rb
 - spec/yelp/endpoint/phone_search_spec.rb
 - spec/yelp/endpoint/search_spec.rb
 - spec/yelp/error_spec.rb
+- spec/yelp/responses/base_spec.rb
 - spec/yelp/yelp_spec.rb
 - tasks/console.rake
 - yelp.gemspec
@@ -266,7 +282,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5
+rubygems_version: 2.4.3
 signing_key: 
 specification_version: 4
 summary: Ruby client library for the Yelp API
@@ -279,11 +295,12 @@ test_files:
 - spec/spec_helper.rb
 - spec/support/request_error.rb
 - spec/support/shared_configuration.rb
-- spec/yelp/burst_struct_spec.rb
 - spec/yelp/client_spec.rb
 - spec/yelp/configuration_spec.rb
 - spec/yelp/endpoint/business_spec.rb
 - spec/yelp/endpoint/phone_search_spec.rb
 - spec/yelp/endpoint/search_spec.rb
 - spec/yelp/error_spec.rb
+- spec/yelp/responses/base_spec.rb
 - spec/yelp/yelp_spec.rb
+has_rdoc: 

data/lib/yelp/burst_struct.rb

@@ -1,63 +0,0 @@
-module BurstStruct
-  class Burst
-    def initialize(hash = {})
-      @hash = hash
-    end
-
-    def keys
-      @hash.keys
-    end
-
-    def method_missing(method_name, *arguments, &block)
-      key = find_key(method_name)
-
-      if key
-        return_or_build_struct(key)
-      else
-        super
-      end
-    end
-
-    def respond_to?(method_name, include_private = false)
-      has_key?(method_name) || super
-    end
-
-    def self.convert_array(array)
-      array.map do |item|
-        case item
-        when Hash
-          Burst.new(item)
-        when Array
-          Burst.convert_array(item)
-        else
-          item
-        end
-      end
-    end
-
-    def to_json(options = {})
-      JSON.generate(@hash)
-    end
-
-    def has_key?(method_name)
-      !find_key(method_name).nil?
-    end
-
-    def raw_data
-      @hash
-    end
-
-    private
-
-    def return_or_build_struct(method_name)
-      return Burst.new(@hash[method_name])           if @hash[method_name].is_a?(Hash)
-      return Burst.convert_array(@hash[method_name]) if @hash[method_name].is_a?(Array)
-      @hash[method_name]
-    end
-
-    def find_key(method_name)
-      return method_name.to_sym if @hash.keys.include? method_name.to_sym
-      return method_name.to_s   if @hash.keys.include? method_name.to_s
-    end
-  end
-end

data/spec/yelp/burst_struct_spec.rb

@@ -1,155 +0,0 @@
-require 'yelp/burst_struct'
-
-describe BurstStruct::Burst do
-  describe '#keys' do
-    subject(:struct) { BurstStruct::Burst.new(foo: 'bar', baz: 'qux') }
-
-    it 'should return' do
-      expect(struct.keys).to eql [:foo, :baz]
-    end
-  end
-
-  describe '#foo' do
-    subject(:struct) { BurstStruct::Burst.new(foo: 'bar') }
-
-    context 'when a key exists' do
-      it 'should return' do
-        expect(struct.foo).to eql 'bar'
-      end
-
-      it { should have_key(:foo) }
-      it { should have_key('foo') }
-
-      it { should respond_to(:foo) }
-    end
-
-    context 'when a key does not exist' do
-      it 'should not respond to it' do
-        expect(struct.respond_to? :super_foo).to eql false
-      end
-
-      it { should_not have_key(:super_foo) }
-      it { should_not have_key('super_foo') }
-    end
-  end
-
-  context 'n deep nested hash' do
-    let(:hash) { Hash[ futurama: { characters: { robots: { best: 'bender' } } } ] }
-
-    subject(:struct) { BurstStruct::Burst.new(hash) }
-
-    describe '#foo#bar#baz#biz' do
-      it 'should return' do
-        expect(struct.futurama.characters.robots.best).to eql 'bender'
-      end
-    end
-  end
-
-  context 'arrays' do
-    let(:hash) { Hash[ businesses: [ { name: 'Yelp', location: 'San Francisco' },
-                                     { name: 'Ice Cream', flavor: 'Chocolate' },
-                                     [ { name: 'Moe', occupation: 'Bartender' } ] ] ] }
-
-    subject(:struct) { BurstStruct::Burst.new(hash) }
-
-    describe '#businesses[0].name' do
-      it 'should return' do
-        expect(struct.businesses[0].name).to eql 'Yelp'
-        expect(struct.businesses[0].location).to eql 'San Francisco'
-      end
-    end
-
-    describe '#business[1].name' do
-      it 'should return' do
-        expect(struct.businesses[1].name).to eql 'Ice Cream'
-        expect(struct.businesses[1].flavor).to eql 'Chocolate'
-      end
-    end
-
-    describe 'nested arrays' do
-      it 'should parse arrays all the way down' do
-        expect(struct.businesses[2][0].name).to eql 'Moe'
-      end
-    end
-  end
-
-  context 'large hash' do
-    let(:hash) do
-      { foo: 1,
-        bar: {
-          baz: 2,
-          bender: {
-            bending: {
-              rodriguez: true
-            }
-          }
-        },
-        fry: [
-          {past: true},
-          {present: true},
-          {future: true}
-        ],
-        turunga: 'leela',
-        'hubert' => 'farnsworth',
-        zoidberg: [
-          'doctor',
-          'homeowner',
-          'moviestar'
-        ]
-      }
-    end
-
-    subject(:struct) { BurstStruct::Burst.new(hash) }
-
-    it 'turns top level into a struct' do
-      expect(struct.foo).to eql 1
-    end
-
-    it 'recursively creates structs all the way down the hash' do
-      expect(struct.bar.baz).to equal 2
-      expect(struct.bar.bender.bending.rodriguez).to eql true
-    end
-
-    it 'creates arrays with hashes into new structs' do
-      expect(struct.fry[0].past).to eql true
-      expect(struct.fry[1].present).to eql true
-      expect(struct.fry[2].future).to eql true
-    end
-
-    it 'turns string keys into structs' do
-      expect(struct.hubert).to eql 'farnsworth'
-    end
-
-    it 'should maintain arrays with non hashes' do
-      expect(struct.zoidberg.size).to eql 3
-      expect(struct.zoidberg[0]).to eql 'doctor'
-    end
-  end
-
-  context 'deserialize' do
-    let(:hash) do
-      { name: 'Bender', company: 'Yelp', title: 'Bending Engineer' }
-    end
-
-    subject(:struct) { BurstStruct::Burst.new(hash) }
-
-    it 'should deserialize to the same json' do
-      expect(struct.to_json).to eql hash.to_json
-    end
-  end
-
-  context 'struct with string keys' do
-    subject(:struct) { BurstStruct::Burst.new('foo' => 'bar') }
-
-    context 'when a key exists' do
-      it 'should return' do
-        expect(struct.foo).to eql 'bar'
-      end
-
-      it { should have_key(:foo) }
-      it { should have_key('foo') }
-
-      it { should respond_to(:foo) }
-    end
-  end
-end