yawast 0.7.0.beta1 → 0.7.0.beta2

data/lib/scanner/plugins/spider/spider.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'nokogiri'
 
 module Yawast
@@ -19,14 +21,14 @@ module Yawast
             results = Thread.new do
               begin
                 while true
-                  if @results.length > 0
+                  if @results.length.positive?
                     out = @results.pop(true)
                     Yawast::Utilities.puts_info out
                     Yawast::Shared::Output.log_append_value 'spider', 'get', out
                   end
                 end
-              rescue ThreadError
-                #do nothing
+              rescue ThreadError # rubocop:disable Lint/HandleExceptions
+                # do nothing
               end
             end
 
@@ -49,11 +51,9 @@ module Yawast
                 # check to see if we've already seen this one
                 unless @links.include? link.to_s
                   @links.push link.to_s
-                  @results.push "#{link.to_s}"
+                  @results.push link.to_s
 
-                  @workers.push Thread.new {
-                    get_links URI.parse(link)
-                  }
+                  @workers.push(Thread.new {get_links URI.parse(link)})
                 end
               end
             end

data/lib/scanner/plugins/ssl/ssl.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Yawast
   module Scanner
     module Plugins
@@ -23,9 +25,7 @@ module Yawast
             found = ''
 
             head.each do |k, v|
-              if k.downcase.include? 'strict-transport-security'
-                found = "#{k}: #{v}"
-              end
+              found = "#{k}: #{v}" if k.downcase.include? 'strict-transport-security'
             end
 
             if found == ''
@@ -39,14 +39,14 @@ module Yawast
             begin
               info = Yawast::Shared::Http.get_json URI("https://hstspreload.com/api/v1/status/#{uri.host}")
 
-              chrome = info['chrome'] != nil
-              firefox = info['firefox'] != nil
-              tor = info['tor'] != nil
+              chrome = !info['chrome'].nil?
+              firefox = !info['firefox'].nil?
+              tor = !info['tor'].nil?
 
               Yawast::Utilities.puts_info "HSTS Preload: Chrome - #{chrome}; Firefox - #{firefox}; Tor - #{tor}"
-            rescue => e
+            rescue => e # rubocop:disable Style/RescueStandardError
               if e.message.include? 'unexpected token'
-                #this means we have a parsing error - don't need to include the entire message
+                # this means we have a parsing error - don't need to include the entire message
                 Yawast::Utilities.puts_error "Error getting HSTS preload information: #{e.message.truncate(30)}"
               else
                 Yawast::Utilities.puts_error "Error getting HSTS preload information: #{e.message}"
@@ -67,7 +67,7 @@ module Yawast
             if uri.scheme != 'https'
               head = Yawast::Shared::Http.head(uri)
 
-              if head['Location'] != nil
+              unless head['Location'].nil?
                 begin
                   location = URI.parse(head['Location'])
 
@@ -75,13 +75,13 @@ module Yawast
                     # we run this through extract_uri as it performs a few checks we need
                     return Yawast::Shared::Uri.extract_uri location.to_s
                   end
-                rescue
+                rescue # rubocop:disable Style/RescueStandardError, Lint/HandleExceptions
                   # we don't care if this fails
                 end
               end
             end
 
-            return nil
+            nil
           end
 
           def self.ssl_connection_info(uri)
@@ -107,13 +107,13 @@ module Yawast
 
                 puts
               end
-            rescue => e
+            rescue => e # rubocop:disable Style/RescueStandardError
               Yawast::Utilities.puts_error "SSL Information: Error Getting Details: #{e.message}"
             end
           end
 
           def self.check_symantec_root(hash)
-            roots = ['08297a4047dba23680c731db6e317653ca7848e1bebd3a0b0179a707f92cf178',
+            roots = ['08297a4047dba23680c731db6e317653ca7848e1bebd3a0b0179a707f92cf178', # rubocop:disable Style/WordArray
                      '2399561127a57125de8cefea610ddf2fa078b5c8067f4e828290bfb860e84b3c',
                      '2834991cf677466d22baac3b0055e5b911d9a9e55f5b85ba02dc566782c30e8a',
                      '2930bd09a07126bdc17288d4f2ad84645ec948607907a97b5ed0b0b05879ef69',
@@ -171,7 +171,7 @@ module Yawast
                      'f59db3f45d57fcec94ccd516e6c8ccb20dd4363feb2c44d8656e95f50fdd8df8',
                      'fe863d0822fe7a2353fa484d5924e875656d3dc9fb58771f6f616f9d571bc592',
                      'ff856a2d251dcd88d36656f450126798cfabaade40799c722de4d2b5db36a73a']
-            return roots.include? hash
+            roots.include? hash
           end
         end
       end

data/lib/scanner/plugins/ssl/ssl_labs/analyze.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'json'
 
 module Yawast
@@ -17,27 +19,26 @@ module Yawast
               uri = endpoint.copy
               uri.path = '/api/v3/analyze'
 
-              if start_new
-                uri.query = "host=#{target}&publish=off&startNew=on&all=done&ignoreMismatch=on"
-              else
-                uri.query = "host=#{target}&publish=off&all=done&ignoreMismatch=on"
-              end
+              uri.query = if start_new
+                            "host=#{target}&publish=off&startNew=on&all=done&ignoreMismatch=on"
+                          else
+                            "host=#{target}&publish=off&all=done&ignoreMismatch=on"
+                          end
 
               req = Yawast::Shared::Http.get_http(uri)
               req.use_ssl = uri.scheme == 'https'
-              res = req.request_get(uri, { 'User-Agent' => "YAWAST/#{Yawast::VERSION}" })
+              res = req.request_get(uri, {'User-Agent' => "YAWAST/#{Yawast::VERSION}"})
               body = res.read_body
               code = res.code.to_i
 
               # check for error in the response - if we don't, we'll wait forever for nothing
               begin
                 json = JSON.parse body
-              rescue => e
+              rescue => e # rubocop:disable Style/RescueStandardError
                 raise StandardError, "Invalid response from SSL Labs: '#{e.message}'"
               end
-              if json.key?('errors')
-                raise InvocationError, "API returned: #{json['errors']}"
-              end
+
+              raise InvocationError, "API returned: #{json['errors']}" if json.key?('errors')
 
               Yawast::Shared::Output.log_json 'ssl', 'ssl_labs', body
 
@@ -59,17 +60,17 @@ module Yawast
                 end
               end
 
-              return body
+              body
             end
 
             def self.extract_status(body)
               begin
                 json = JSON.parse body
-              rescue => e
+              rescue => e # rubocop:disable Style/RescueStandardError
                 raise StandardError, "Invalid response from SSL Labs: '#{e.message}'"
               end
 
-              return json['status']
+              json['status']
             end
           end
         end

data/lib/scanner/plugins/ssl/ssl_labs/info.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'json'
 
 module Yawast
@@ -12,15 +14,15 @@ module Yawast
 
               body = Yawast::Shared::Http.get uri
 
-              return body
+              body
             end
 
             def self.extract_msg(body)
-              ret = Array.new
+              ret = []
 
               begin
                 json = JSON.parse body
-              rescue => e
+              rescue => e # rubocop:disable Style/RescueStandardError
                 raise Exception, "Invalid response from SSL Labs: '#{e.message}'"
               end
 
@@ -30,7 +32,7 @@ module Yawast
                 end
               end
 
-              return ret
+              ret
             end
           end
         end

data/lib/scanner/plugins/ssl/sweet32.rb

@@ -1,9 +1,11 @@
+# frozen_string_literal: true
+
 module Yawast
   module Scanner
     module Plugins
       module SSL
         class Sweet32
-          def self.get_tdes_session_msg_count(uri, limit = 10000)
+          def self.get_tdes_session_msg_count(uri, limit = 10_000)
             Yawast::Shared::Output.log_value 'ssl', 'sweet32', 'limit', limit
 
             # this method will send a number of HEAD requests to see
@@ -38,52 +40,52 @@ module Yawast
               # attempt to find a version that supports 3DES
               versions = OpenSSL::SSL::SSLContext::METHODS.find_all { |v| !v.to_s.include?('_client') && !v.to_s.include?('_server')}
               versions.each do |version|
-                if version.to_s != 'SSLv23'
-                  req.ssl_version = version
-
-                  begin
-                    req.start do |http|
-
-                      head = nil
-                      begin
-                        if use_head
-                          head = http.head(uri.path, headers)
-                        else
-                          head = http.request_get(uri.path, headers)
-                        end
-
-                        cipher = http.instance_variable_get(:@socket).io.cipher[0]
-                      rescue
-                        # check if we are using HEAD or GET. If we've already switched to GET, no need to do this again.
-                        if use_head
-                          head = http.request_get(uri.path, headers)
+                next unless version.to_s != 'SSLv23'
+                req.ssl_version = version
 
-                          #if we are here, that means that HEAD failed, but GET didn't, so we'll use GET from now on.
-                          use_head = false
-                          Yawast::Utilities.puts_error 'Error: HEAD request failed; using GET requests for SWEET32 check...'
-                        end
+                begin
+                  req.start do |http|
+
+                    head = nil
+                    begin
+                      head = if use_head
+                               http.head(uri.path, headers)
+                             else
+                               http.request_get(uri.path, headers)
+                             end
+
+                      cipher = http.instance_variable_get(:@socket).io.cipher[0]
+                    rescue StandardError
+                      # check if we are using HEAD or GET. If we've already switched to GET, no need to do this again.
+                      if use_head
+                        head = http.request_get(uri.path, headers)
+
+                        # if we are here, that means that HEAD failed, but GET didn't, so we'll use GET from now on.
+                        use_head = false
+                        Yawast::Utilities.puts_error 'Error: HEAD request failed; using GET requests for SWEET32 check...'
                       end
+                    end
 
-                      # check to see if this is on Cloudflare - they break Keep-Alive limits, creating a false positive
+                    # check to see if this is on Cloudflare - they break Keep-Alive limits, creating a false positive
+                    unless head.nil?
                       head.each do |k, v|
-                        if k.downcase == 'server'
-                          if v == 'cloudflare'
-                            puts 'Cloudflare server found: SWEET32 mitigated: https://support.cloudflare.com/hc/en-us/articles/231510928'
-                          end
+                        next unless k.casecmp('server').zero?
+                        if v == 'cloudflare'
+                          puts 'Cloudflare server found: SWEET32 mitigated: https://support.cloudflare.com/hc/en-us/articles/231510928'
                         end
                       end
                     end
+                  end
 
-                    print "Using #{version} (#{cipher})"
+                  print "Using #{version} (#{cipher})"
 
-                    Yawast::Shared::Output.log_value 'ssl', 'sweet32', 'tls_version', version
-                    Yawast::Shared::Output.log_value 'ssl', 'sweet32', 'tls_cipher', cipher
-                    Yawast::Shared::Output.log_value 'ssl', 'sweet32', 'use_head_req', use_head
+                  Yawast::Shared::Output.log_value 'ssl', 'sweet32', 'tls_version', version
+                  Yawast::Shared::Output.log_value 'ssl', 'sweet32', 'tls_cipher', cipher
+                  Yawast::Shared::Output.log_value 'ssl', 'sweet32', 'use_head_req', use_head
 
-                    break
-                  rescue
-                    # we don't care
-                  end
+                  break
+                rescue StandardError # rubocop:disable Lint/HandleExceptions
+                  # we don't care
                 end
               end
 
@@ -109,12 +111,10 @@ module Yawast
 
                   count += 1
 
-                  if i % 20 == 0
-                    print '.'
-                  end
+                  print '.' if (i % 20).zero?
                 end
               end
-            rescue => e
+            rescue StandardError => e
               puts
 
               if e.message.include?('alert handshake failure') || e.message.include?('no cipher match')
@@ -127,6 +127,10 @@ module Yawast
               Yawast::Shared::Output.log_value 'ssl', 'sweet32', 'requests', count
               Yawast::Shared::Output.log_value 'ssl', 'sweet32', 'exception', e.message
 
+              Yawast::Shared::Output.log_hash 'vulnerabilities',
+                                              'tls_sweet32',
+                                              {vulnerable: false}
+
               return
             end
 
@@ -136,6 +140,10 @@ module Yawast
 
             Yawast::Shared::Output.log_value 'ssl', 'sweet32', 'vulnerable', true
             Yawast::Shared::Output.log_value 'ssl', 'sweet32', 'requests', count
+
+            Yawast::Shared::Output.log_hash 'vulnerabilities',
+                                            'tls_sweet32',
+                                            {vulnerable: true}
           end
 
           def self.check_tdes
@@ -147,31 +155,28 @@ module Yawast
 
             versions.each do |version|
               # ignore SSLv23, as it's an auto-negotiate, which just adds noise
-              if version.to_s != 'SSLv23' && version.to_s != 'SSLv2'
-                # try to get the list of ciphers supported for each version
-                Yawast::Shared::Output.log_append_value 'openssl', 'tls_versions', version.to_s
-
-                ciphers = nil
-
-                get_ciphers_failed = false
-                begin
-                  ciphers = OpenSSL::SSL::SSLContext.new(version).ciphers
-                rescue => e
-                  Yawast::Utilities.puts_error "\tError getting cipher suites for #{version}, skipping. (#{e.message})"
-                  get_ciphers_failed = true
-                end
+              next unless version.to_s != 'SSLv23' && version.to_s != 'SSLv2'
+              # try to get the list of ciphers supported for each version
+              Yawast::Shared::Output.log_append_value 'openssl', 'tls_versions', version.to_s
+
+              ciphers = nil
+
+              get_ciphers_failed = false
+              begin
+                ciphers = OpenSSL::SSL::SSLContext.new(version).ciphers
+              rescue StandardError => e
+                Yawast::Utilities.puts_error "\tError getting cipher suites for #{version}, skipping. (#{e.message})"
+                get_ciphers_failed = true
+              end
 
-                if ciphers != nil
-                  ciphers.each do |cipher|
-                    if cipher[0].include?('3DES') || cipher[0].include?('CBC3')
-                      ret = true
-                    end
+              if !ciphers.nil?
+                ciphers.each do |cipher|
+                  ret = true if cipher[0].include?('3DES') || cipher[0].include?('CBC3')
 
-                    Yawast::Shared::Output.log_append_value 'openssl', 'tls_ciphers', version.to_s, cipher[0]
-                  end
-                elsif !get_ciphers_failed
-                  Yawast::Utilities.puts_info "\t#{version}: No cipher suites available."
+                  Yawast::Shared::Output.log_append_value 'openssl', 'tls_ciphers', version.to_s, cipher[0]
                 end
+              elsif !get_ciphers_failed
+                Yawast::Utilities.puts_info "\t#{version}: No cipher suites available."
               end
             end
 

data/lib/scanner/ssl.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'openssl'
 require 'openssl-extensions/all'
 require 'digest/sha1'
@@ -24,9 +26,7 @@ module Yawast
 
           cert = ssl.peer_cert
 
-          unless cert.nil?
-            get_cert_info cert
-          end
+          get_cert_info cert unless cert.nil?
 
           cert_chain = ssl.peer_cert_chain
           get_cert_chain_info cert_chain, cert
@@ -34,14 +34,12 @@ module Yawast
           puts "\t\tQualys SSL Labs: https://www.ssllabs.com/ssltest/analyze.html?d=#{uri.host}&hideResults=on"
           puts ''
 
-          if check_ciphers
-            get_ciphers(uri)
-          end
+          get_ciphers(uri) if check_ciphers
 
           ssl.sysclose
 
           Yawast::Scanner::Plugins::SSL::Sweet32.get_tdes_session_msg_count(uri) if tdes_session_count
-        rescue => e
+        rescue => e # rubocop:disable Style/RescueStandardError
           Yawast::Utilities.puts_error "SSL: Error Reading X509 Details: #{e.message}"
         end
       end
@@ -54,14 +52,14 @@ module Yawast
         Yawast::Utilities.puts_info "\t\tSerial: #{cert.serial}"
         Yawast::Utilities.puts_info "\t\tSubject: #{cert.subject}"
 
-        #check to see if cert is expired
+        # check to see if cert is expired
         if cert.not_after > Time.now
           Yawast::Utilities.puts_info "\t\tExpires: #{cert.not_after}"
         else
           Yawast::Utilities.puts_vuln "\t\tExpires: #{cert.not_after} (Expired)"
         end
 
-        #check for SHA1 & MD5 certs
+        # check for SHA1 & MD5 certs
         if cert.signature_algorithm.include?('md5') || cert.signature_algorithm.include?('sha1')
           Yawast::Utilities.puts_vuln "\t\tSignature Algorithm: #{cert.signature_algorithm}"
         else
@@ -76,7 +74,7 @@ module Yawast
         # ct_precert_scts
         Yawast::Scanner::Plugins::SSL::SSL.print_precert cert
 
-        #alt names
+        # alt names
         alt_names = cert.extensions.find {|e| e.oid == 'subjectAltName'}
         unless alt_names.nil?
           Yawast::Utilities.puts_info "\t\tAlternate Names:"
@@ -90,8 +88,8 @@ module Yawast
 
       def self.get_cert_chain_info(cert_chain, cert)
         if cert_chain.count == 1
-          #HACK: This is an ugly way to guess if it's a missing intermediate, or self-signed
-          #It looks like a change to Ruby's OpenSSL wrapper is needed to actually fix this right.
+          # HACK: This is an ugly way to guess if it's a missing intermediate, or self-signed
+          # It looks like a change to Ruby's OpenSSL wrapper is needed to actually fix this right.
 
           if cert.issuer == cert.subject
             Yawast::Utilities.puts_vuln "\t\tCertificate Is Self-Signed"
@@ -123,34 +121,32 @@ module Yawast
 
         dns = Resolv::DNS.new
 
-        if IPAddress.valid? uri.host
-          ip = IPAddress.parse uri.host
-        else
-          ip = dns.getaddresses(uri.host)[0]
-        end
+        ip = if IPAddress.valid? uri.host
+               IPAddress.parse uri.host
+             else
+               dns.getaddresses(uri.host)[0]
+             end
 
-        protocols = %w(ssl2 ssl3 tls1.0 tls1.1 tls1.2)
+        protocols = %w[ssl2 ssl3 tls1.0 tls1.1 tls1.2]
 
         protocols.each do |protocol|
-          case protocol
-            when 'ssl2'
-              ciphers = SSLShake::SSLv2::CIPHERS
-            when 'ssl3'
-              ciphers = SSLShake::TLS::SSL3_CIPHERS
-            else
-              ciphers = SSLShake::TLS::TLS_CIPHERS
-          end
+          ciphers = case protocol
+                      when 'ssl2'
+                        SSLShake::SSLv2::CIPHERS
+                      when 'ssl3'
+                        SSLShake::TLS::SSL3_CIPHERS
+                      else
+                        SSLShake::TLS::TLS_CIPHERS
+                    end
 
           puts "\tChecking for #{protocol} suites (#{ciphers.count} possible suites)"
 
           ciphers.each_key do |cipher|
             begin
-              res = SSLShake.hello(ip.to_s, port: uri.port, protocol: protocol, ciphers: cipher, servername: uri.host)
+              res = SSLShake.hello(ip.to_s, {port: uri.port, protocol: protocol, ciphers: cipher, servername: uri.host})
 
-              if res['error'] == nil
-                Yawast::Utilities.puts_info "\t\tCipher: #{res['cipher_suite']}"
-              end
-            rescue => e
+              Yawast::Utilities.puts_info "\t\tCipher: #{res['cipher_suite']}" if res['error'].nil?
+            rescue => e # rubocop:disable Style/RescueStandardError
               Yawast::Utilities.puts_error "SSL: Error Reading Cipher Details: #{e.message}"
             end
           end
@@ -161,20 +157,21 @@ module Yawast
 
       def self.check_cipher_strength(cipher, ssl)
         if cipher[2] < 112 || cipher[0].include?('RC4')
-          #less than 112 bits or RC4, flag as a vuln
+          # less than 112 bits or RC4, flag as a vuln
           Yawast::Utilities.puts_vuln "\t\tVersion: #{ssl.ssl_version.ljust(7)}\tBits: #{cipher[2]}\tCipher: #{cipher[0]}"
         elsif cipher[2] >= 128
-          #secure, probably safe
+          # secure, probably safe
           Yawast::Utilities.puts_info "\t\tVersion: #{ssl.ssl_version.ljust(7)}\tBits: #{cipher[2]}\tCipher: #{cipher[0]}"
         else
-          #weak, but not "omg!" weak.
+          # weak, but not "omg!" weak.
           Yawast::Utilities.puts_warn "\t\tVersion: #{ssl.ssl_version.ljust(7)}\tBits: #{cipher[2]}\tCipher: #{cipher[0]}"
         end
       end
 
-      #private methods
+      # private methods
       class << self
         private
+
         def get_x509_pub_key_strength(cert)
           begin
             if cert.public_key.class == OpenSSL::PKey::EC
@@ -182,7 +179,7 @@ module Yawast
             else
               cert.public_key.strength
             end
-          rescue => e
+          rescue => e # rubocop:disable Style/RescueStandardError
             "(Strength Unknown: #{e.message})"
           end
         end