yaso 1.2.0 → 1.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 293839b577b5832d54938e07a07729d49ddd74fd226f0077076fe6f4986340ae
-  data.tar.gz: 72d9d2bde9edbc0050f1473e3efc33a9c81952fe78906eaeb35acbba2ccc80bf
+  metadata.gz: 82a14582b1dadeb5c6103880c2ec7b3d7afe887ec9d8eb90601d77c02cfaf785
+  data.tar.gz: 94eab6547c4c0eaa87285bf09aa78534c33c06164fb98435dc7fe0b2f6d84d54
 SHA512:
-  metadata.gz: a54b6acc15d5d8e71b25a4273ce87816ae58a1e63bd815e4cf338d671b5b71b3378016c076d9db44122e7612619e69e06c60e63cf7afd388b0de7509ad42ac0f
-  data.tar.gz: 55a031ce994ac21ed04e659d70b2871cae67ed64d088799e26663b1d5e2ac5f76593d0ea4d0e3e181ff72b63fed7aa626abf67b063eed696be4418e74930e9e8
+  metadata.gz: 0104e325136a9952cff6309951c67915d015cf67897fcf257e73a51e335eb0d8e12bf87ecf2ec09bb5d326bf3c7622101f2b02a6c06deb75c16f511c91eff3a5
+  data.tar.gz: 04525a4314e1417f48f699e71d0b77ecf888ce44524e972fb2b811ddcfe9ef68f399c1771cf81031df6127d63287091e2b9fe36e3679cd0e6c26775554b7c3e7

data/.ruby-version

@@ -1 +1 @@
-3.1.2
+3.1.3

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    yaso (1.2.0)
+    yaso (1.3.1)
 
 GEM
   remote: https://rubygems.org/
@@ -14,7 +14,7 @@ GEM
     lefthook (1.0.5)
     method_source (1.0.0)
     parallel (1.22.1)
-    parser (3.1.2.0)
+    parser (3.1.2.1)
       ast (~> 2.4.1)
     pry (0.14.1)
       coderay (~> 1.1)
@@ -29,13 +29,13 @@ GEM
       rspec-mocks (~> 3.11.0)
     rspec-core (3.11.0)
       rspec-support (~> 3.11.0)
-    rspec-expectations (3.11.0)
+    rspec-expectations (3.11.1)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.11.0)
     rspec-mocks (3.11.1)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.11.0)
-    rspec-support (3.11.0)
+    rspec-support (3.11.1)
     rubocop (1.28.2)
       parallel (~> 1.10)
       parser (>= 3.1.0.0)
@@ -59,10 +59,11 @@ GEM
       simplecov_json_formatter (~> 0.1)
     simplecov-html (0.12.3)
     simplecov_json_formatter (0.1.4)
-    unicode-display_width (2.2.0)
+    unicode-display_width (2.3.0)
 
 PLATFORMS
   x86_64-darwin-21
+  x86_64-darwin-22
   x86_64-linux
 
 DEPENDENCIES

data/README.md

@@ -1,8 +1,7 @@
 # Yaso
 [![Ruby](https://github.com/Ar2emis/yaso/actions/workflows/main.yml/badge.svg?branch=master)](https://github.com/Ar2emis/yaso/actions/workflows/main.yml) ![gem](https://img.shields.io/gem/v/yaso) [![GitHub license](https://img.shields.io/github/license/Ar2emis/yaso)](https://github.com/Ar2emis/yaso/blob/master/LICENSE.txt)
 
-That's my (Yet Another) ServiceObject pattern implementation. I made it fast ([the fastest actually](https://github.com/Ar2emis/yaso/wiki/Benchmarks)) and simple to use.
-I was inspired by those alternatives and I hope this will encourage them to be even better:
+That's my (Yet Another) ServiceObject pattern implementation. I made it fast ([the fastest of this kind actually](https://github.com/Ar2emis/yaso/wiki/Benchmarks); [simple_command](https://github.com/nebulab/simple_command), you got me this time) and simple to use (I hope). I was inspired by those alternatives and I hope this will encourage them to be even better:
 - [Trailblazer](https://github.com/trailblazer/trailblazer)
 - [Decouplio](https://github.com/differencialx/decouplio)
 
@@ -28,7 +27,7 @@ All the information you can find in the gem [wiki](https://github.com/Ar2emis/ya
 
 ## Development
 
-I don't think that someone would like to help me developing the gem but if so just fork a new branch from the master, do your dark business, open a pull request and assign me as a reviewer. 
+I don't think that someone would like to help me developing the gem but if so just fork a repository, do your dark business, open a pull request and assign me as a reviewer. 
 
 ## Contributing
 

data/benchmark/Gemfile

@@ -3,11 +3,23 @@
 source 'https://rubygems.org'
 
 gem 'benchmark-ips', '~> 2.10.0'
+
+DRY_CONTAINER = {
+  '2.5' => '~> 0.7.2',
+  '2.6' => '~> 0.9.0'
+}.freeze
+gem 'dry-container', DRY_CONTAINER.fetch(RUBY_VERSION.match(/\A\d+\.\d+/)[0], '~> 0.11.0')
+DRY_TRANSACTION = {
+  '2.5' => '~> 0.13.2',
+  '2.6' => '~> 0.13.3'
+}.freeze
+gem 'dry-transaction', DRY_TRANSACTION.fetch(RUBY_VERSION.match(/\A\d+\.\d+/)[0], '~> 0.15.0')
 gem 'interactor', '~> 3.1.2'
 gem 'kalibera', '~> 0.1.2'
 gem 'simple_command', RUBY_VERSION.include?('2.5') ? '~> 0.2.0' : '~> 1.0.1'
 gem 'trailblazer', '~> 2.1.0'
+gem 'yaso', path: '..'
 
 gem 'active_interaction', %w[2.5 2.6].any? { |version| RUBY_VERSION.include?(version) } ? '~> 4.1.0' : '~> 5.1.0'
 
-RUBY_VERSION.include?('2.5') || gem('decouplio', '~> 1.0.0alpha8')
+RUBY_VERSION.include?('2.5') || gem('decouplio', '~> 1.0.0rc')

data/benchmark/index.rb

@@ -2,14 +2,16 @@
 
 require 'bundler/setup'
 
-require_relative '../lib/yaso'
-
 require 'benchmark/ips'
 RUBY_VERSION.include?('2.5') || require('decouplio')
 require 'interactor'
 require 'active_interaction'
 require 'trailblazer'
 require 'simple_command'
+require 'yaso'
+require 'dry/container'
+require 'dry/transaction'
+require 'dry/transaction/operation'
 
 require_relative 'shared/yaso_service'
 RUBY_VERSION.include?('2.5') || require_relative('shared/decouplio_service')
@@ -27,4 +29,5 @@ require_relative 'step/simple_command'
 require_relative 'step/interactor'
 require_relative 'step/active_interaction'
 require_relative 'step/trailblazer'
+require_relative 'step/dry_transaction'
 require_relative 'step/benchmark'

data/benchmark/step/benchmark.rb

@@ -13,6 +13,7 @@ Benchmark.ips do |x|
   x.report('Interactor') { InteractorStepsService.call }
   x.report('ActiveInteraction') { ActiveInteractionStepsService.run }
   x.report('Trailblazer') { TrailblazerStepsService.call }
+  x.report('DryTransaction') { DryTransactionStepsService.new.call({}) }
 
   x.compare!
 end
@@ -28,6 +29,7 @@ Benchmark.ips do |x|
   x.report('Interactor') { InteractorCallablesService.call }
   x.report('ActiveInteraction') { ActiveInteractionCallablesService.run }
   x.report('Trailblazer') { TrailblazerCallablesService.call }
+  x.report('DryTransaction') { DryTransactionCallablesService.new.call({}) }
 
   x.compare!
 end

data/benchmark/step/decouplio.rb

@@ -56,7 +56,7 @@ class DecouplioStepsService < DecouplioService
 end
 
 class DecouplioCallableStep
-  def self.call(ctx:, key:, value:, **)
+  def self.call(ctx, _, key:, value:, **)
     ctx[key] = value
   end
 end

data/benchmark/step/dry_transaction.rb

@@ -0,0 +1,113 @@
+# frozen_string_literal: true
+
+class DryTransactionStepsService
+  include Dry::Transaction
+
+  step :one
+  step :two
+  step :three
+  step :four
+  step :five
+  step :six
+  step :seven
+  step :eight
+  step :nine
+  step :ten
+
+  private
+
+  def one(ctx)
+    ctx[:one] = true
+    Success(ctx)
+  end
+
+  def two(ctx)
+    ctx[:two] = true
+    Success(ctx)
+  end
+
+  def three(ctx)
+    ctx[:three] = true
+    Success(ctx)
+  end
+
+  def four(ctx)
+    ctx[:four] = true
+    Success(ctx)
+  end
+
+  def five(ctx)
+    ctx[:five] = true
+    Success(ctx)
+  end
+
+  def six(ctx)
+    ctx[:six] = true
+    Success(ctx)
+  end
+
+  def seven(ctx)
+    ctx[:seven] = true
+    Success(ctx)
+  end
+
+  def eight(ctx)
+    ctx[:eight] = true
+    Success(ctx)
+  end
+
+  def nine(ctx)
+    ctx[:nine] = true
+    Success(ctx)
+  end
+
+  def ten(ctx)
+    ctx[:ten] = true
+    Success(ctx)
+  end
+end
+
+class DryTansactionCallable
+  include Dry::Transaction::Operation
+
+  def initialize(key)
+    @key = key
+  end
+
+  def call(ctx)
+    ctx[@key] = true
+    Success(ctx)
+  end
+end
+
+class DryTransactionContainer
+  extend Dry::Container::Mixin
+
+  namespace :callable do
+    register(:one) { DryTansactionCallable.new(:one) }
+    register(:two) { DryTansactionCallable.new(:two) }
+    register(:three) { DryTansactionCallable.new(:three) }
+    register(:four) { DryTansactionCallable.new(:four) }
+    register(:five) { DryTansactionCallable.new(:five) }
+    register(:six) { DryTansactionCallable.new(:six) }
+    register(:seven) { DryTansactionCallable.new(:seven) }
+    register(:eight) { DryTansactionCallable.new(:eight) }
+    register(:nine) { DryTansactionCallable.new(:nine) }
+    register(:ten) { DryTansactionCallable.new(:ten) }
+  end
+end
+
+class DryTransactionCallablesService
+  include Dry::Transaction(container: DryTransactionContainer)
+
+  step :one, with: :'callable.one'
+  step :two, with: :'callable.two'
+  step :three, with: :'callable.three'
+  step :four, with: :'callable.four'
+  step :five, with: :'callable.five'
+  step :six, with: :'callable.six'
+  step :seven, with: :'callable.seven'
+  step :eight, with: :'callable.eight'
+  step :nine, with: :'callable.nine'
+  step :ten, with: :'callable.ten'
+end

data/benchmark/step/trailblazer.rb

@@ -64,7 +64,7 @@ module TrailblazerMacro
       ctx[:"result.#{id}"] = Trailblazer::Operation::Result.new(false, {})
       false
     end
-    task = Trailblazer::Activity::TaskBuilder::Binary(step)
+    task = Trailblazer::Activity::Circuit::TaskAdapter.for_step(step)
     { task: task, id: id }
   end
   # rubocop:enable Naming/MethodName

data/docker/Dockerfile

@@ -0,0 +1,7 @@
+ARG VERSION=latest
+
+FROM ruby:${VERSION}
+
+ENTRYPOINT [ "/yaso/docker/entrypoint.sh" ]
+
+WORKDIR /yaso/benchmark

data/docker/entrypoint.sh

@@ -0,0 +1,15 @@
+#!/bin/bash
+
+if [[ `bundle -v` =~ "Bundler version 2" ]]; then
+  bundle config set --local path '/bundle/cache'
+  bundle config set --local without 'development'
+else
+  bundle config --local path '/bundle/cache'
+  bundle config --local without 'development'
+fi
+
+bundle
+
+ruby index.rb
+
+rm Gemfile.lock

data/docker-compose.yml

@@ -0,0 +1,9 @@
+services:
+  benchmark:
+    build: docker
+    volumes:
+      - .:/yaso
+      - bundle:/bundle/cache
+
+volumes:
+  bundle:

data/lib/yaso/invocable.rb

@@ -7,12 +7,12 @@ module Yaso
     YASO = :yaso
 
     class << self
-      def call(object, options: {}, **)
+      def call(object, options: {}, with_block: false, **)
         type = object_type(object)
         invocable = case type
-                    when YASO then proc { |context, _| object.call(context.clone).success? }
-                    when CALLABLE then proc { |context, _, &block| object.call(context, **options, &block) }
-                    else method_invocable(object)
+                    when YASO then proc { |context| object.call(context).success? }
+                    when CALLABLE then callable_invocable(object, options, with_block: with_block)
+                    else method_invocable(object, with_block: with_block)
                     end
         [type, invocable]
       end
@@ -25,11 +25,25 @@ module Yaso
         object < ::Yaso::Service ? Invocable::YASO : Invocable::CALLABLE
       end
 
-      def method_invocable(object)
+      def callable_invocable(object, options, with_block:)
+        return proc { |context, &block| object.call(context, **options, &block) } if with_block
+
+        proc { |context| object.call(context, **options) }
+      end
+
+      def method_invocable(object, with_block:)
+        if with_block
+          return instance_eval <<-RUBY, __FILE__, __LINE__ + 1
+            proc { |context, instance, &block|               # proc { |context, instance, &block|
+              instance.#{object}(context, **context, &block) #   instance.<method_name>(context, **context, &block)
+            }                                                # }
+          RUBY
+        end
+
         instance_eval <<-RUBY, __FILE__, __LINE__ + 1
-          proc { |context, instance, &block|                    # proc { |context, instance, &block|
-            instance.#{object}(context, **context.data, &block) #   instance.<method_name>(context, **context.data, &block)
-          }                                                     # }
+          proc { |context, instance|               # proc { |context, instance|
+            instance.#{object}(context, **context) #   instance.<method_name>(context, **context)
+          }                                        # }
         RUBY
       end
     end

data/lib/yaso/logic/failure.rb

@@ -4,7 +4,7 @@ module Yaso
   module Logic
     class Failure < Base
       def call(context, instance)
-        context.success = false
+        instance.success = false
         @invocable.call(context, instance) ? @next_step : @failure
       end
     end

data/lib/yaso/logic/pass.rb

@@ -4,7 +4,7 @@ module Yaso
   module Logic
     class Pass < Base
       def call(context, instance)
-        context.success = true
+        instance.success = true
         @invocable.call(context, instance) ? @next_step : @failure
       end
     end

data/lib/yaso/logic/step.rb

@@ -4,11 +4,11 @@ module Yaso
   module Logic
     class Step < Base
       def call(context, instance)
-        context.success = true
+        instance.success = true
         if @invocable.call(context, instance)
           @next_step
         else
-          context.success = false
+          instance.success = false
           @failure
         end
       end

data/lib/yaso/logic/step_builder.rb

@@ -16,8 +16,8 @@ module Yaso
       end
 
       def call(object:, category:, block:, **opts)
-        invocable_type, invocable = Invocable.call(object, **opts)
         logic_class = CATEGORIES[category]
+        invocable_type, invocable = Invocable.call(object, with_block: logic_class == Wrap, **opts)
         if invocable_type == Invocable::METHOD
           opts[:name] = logic_class == Switch ? build_switch(object, **opts, &block) : build_method(object, &block)
         end
@@ -51,14 +51,11 @@ module Yaso
       end
 
       def build_wrapper_methods(wrapper_class, service_class)
-        wrapper_class.define_singleton_method(:flow) do
-          service_class.flow
-        end
         wrapper_class.define_singleton_method(:call) do |context, instance|
-          @entry ||= flow.call(service_class, steps)
+          @entry ||= service_class.flow.call(service_class, steps)
           step = @entry
           step = step.call(context, instance) while step
-          context
+          instance
         end
       end
     end

data/lib/yaso/logic/switch.rb

@@ -4,13 +4,12 @@ module Yaso
   module Logic
     class Switch < Base
       def call(context, instance)
-        context.success = true
+        instance.success = true
         switch_case = @invocable.call(context, instance) || raise(UnhandledSwitchCaseError, instance.class)
-
         if Invocable.call(switch_case).last.call(context, instance)
           @next_step
         else
-          context.success = false
+          instance.success = false
           @failure
         end
       end

data/lib/yaso/logic/wrap.rb

@@ -9,11 +9,12 @@ module Yaso
       end
 
       def call(context, instance)
-        context.success = true
-        if @invocable.call(context, instance) { @wrapper.call(context, instance).success? }
+        instance.success = true
+        result = @invocable.call(context, instance) { @wrapper.call(context, instance).success? }
+        if result
           @next_step
         else
-          context.success = false
+          instance.success = false
           @failure
         end
       end

data/lib/yaso/service.rb

@@ -4,14 +4,44 @@ module Yaso
   class Service
     extend Stepable
 
+    attr_writer :success
+
+    def initialize(context)
+      @context = context
+      @success = true
+    end
+
+    def [](key)
+      @context[key]
+    end
+
+    def []=(key, value)
+      @context[key] = value
+    end
+
+    def success?
+      @success
+    end
+
+    def failure?
+      !@success
+    end
+
+    def to_h
+      @context.dup
+    end
+
+    def inspect
+      "Result:#{self.class} successful: #{@success}, context: #{@context}"
+    end
+
     class << self
       def call(context = {})
-        context = context.is_a?(Context) ? context : Context.new(context)
         @entry ||= flow.call(self, steps)
         step = @entry
-        instance = new
+        instance = new(context)
         step = step.call(context, instance) while step
-        context
+        instance
       end
 
       def flow(name = nil)

data/lib/yaso/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Yaso
-  VERSION = '1.2.0'
+  VERSION = '1.3.1'
 end

data/lib/yaso.rb

@@ -2,7 +2,6 @@
 
 require_relative 'yaso/version'
 require_relative 'yaso/errors'
-require_relative 'yaso/context'
 require_relative 'yaso/invocable'
 require_relative 'yaso/stepable'
 require_relative 'yaso/logic'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: yaso
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.3.1
 platform: ruby
 authors:
 - Artem Shevchenko
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-08-27 00:00:00.000000000 Z
+date: 2022-12-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ffaker
@@ -203,14 +203,17 @@ files:
 - benchmark/step/active_interaction.rb
 - benchmark/step/benchmark.rb
 - benchmark/step/decouplio.rb
+- benchmark/step/dry_transaction.rb
 - benchmark/step/interactor.rb
 - benchmark/step/pure.rb
 - benchmark/step/simple_command.rb
 - benchmark/step/trailblazer.rb
 - benchmark/step/yaso.rb
+- docker-compose.yml
+- docker/Dockerfile
+- docker/entrypoint.sh
 - lefthook.yml
 - lib/yaso.rb
-- lib/yaso/context.rb
 - lib/yaso/errors.rb
 - lib/yaso/invocable.rb
 - lib/yaso/logic.rb
@@ -248,7 +251,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.7
+rubygems_version: 3.3.26
 signing_key:
 specification_version: 4
 summary: Yet Another Service Object

data/lib/yaso/context.rb

@@ -1,33 +0,0 @@
-# frozen_string_literal: true
-
-module Yaso
-  class Context
-    attr_writer :success
-    attr_reader :data
-
-    def initialize(kwargs)
-      @success = true
-      @data = kwargs
-    end
-
-    def [](key)
-      @data[key]
-    end
-
-    def []=(key, value)
-      @data[key] = value
-    end
-
-    def to_h
-      @data.dup
-    end
-
-    def success?
-      @success
-    end
-
-    def failure?
-      !@success
-    end
-  end
-end