yardstick 0.9.7 → 0.9.8

data/.travis.yml

@@ -1,12 +1,17 @@
 language: ruby
-before_install: gem install bundler
+before_install:
+  - gem update bundler
+  - bundle --version
+  - gem update --system 2.1.11
+  - gem --version
 bundler_args: --without yard guard benchmarks
 script: "bundle exec rake ci"
 rvm:
+  - 1.8.7
   - 1.9.3
   - 2.0.0
-  - ruby-head
   - rbx-19mode
+  - ruby-head
 matrix:
   include:
     - rvm: jruby-19mode
@@ -14,10 +19,12 @@ matrix:
     - rvm: jruby-head
       env: JRUBY_OPTS="$JRUBY_OPTS --debug"
   allow_failures:
+    - rvm: 1.8.7       # mutant fails
     - rvm: 1.9.3       # mutant fails
     - rvm: 2.0.0       # mutant fails
-    - rvm: ruby-head   # travis broken
     - rvm: rbx-19mode  # mutant fails
+    - rvm: ruby-head   # travis broken
+  fast_finish: true
 notifications:
   irc:
     channels:

data/Gemfile

@@ -5,7 +5,7 @@ source 'https://rubygems.org'
 gemspec
 
 group :development, :test do
-  gem 'devtools', git: 'https://github.com/rom-rb/devtools.git'
+  gem 'devtools', :git => 'https://github.com/rom-rb/devtools.git'
 end
 
 eval_gemfile 'Gemfile.devtools'

data/Gemfile.devtools

@@ -4,43 +4,57 @@ group :development do
   gem 'rake',  '~> 10.1.0'
   gem 'rspec', '~> 2.14.1'
   gem 'yard',  '~> 0.8.7'
+
+  platform :rbx do
+    gem 'rubysl-singleton', '~> 2.0.0'
+  end
 end
 
 group :yard do
-  gem 'kramdown', '~> 1.2.0'
+  gem 'kramdown', '~> 1.3.0'
 end
 
 group :guard do
-  gem 'guard',         '~> 1.8.1'
-  gem 'guard-bundler', '~> 1.0.0'
-  gem 'guard-rspec',   '~> 3.0.2'
-  gem 'guard-rubocop', '~> 0.2.0'
-  gem 'guard-mutant',  '~> 0.0.1'
+  gem 'guard',         '~> 2.2.4'
+  gem 'guard-bundler', '~> 2.0.0'
+  gem 'guard-rspec',   '~> 4.2.0'
+  gem 'guard-rubocop', '~> 1.0.0'
 
   # file system change event handling
-  gem 'listen',     '~> 1.3.0'
-  gem 'rb-fchange', '~> 0.0.6', require: false
-  gem 'rb-fsevent', '~> 0.9.3', require: false
-  gem 'rb-inotify', '~> 0.9.0', require: false
+  gem 'listen',     '~> 2.4.0'
+  gem 'rb-fchange', '~> 0.0.6', :require => false
+  gem 'rb-fsevent', '~> 0.9.3', :require => false
+  gem 'rb-inotify', '~> 0.9.0', :require => false
 
   # notification handling
-  gem 'libnotify',               '~> 0.8.0', require: false
-  gem 'rb-notifu',               '~> 0.0.4', require: false
-  gem 'terminal-notifier-guard', '~> 1.5.3', require: false
+  gem 'libnotify',               '~> 0.8.0', :require => false
+  gem 'rb-notifu',               '~> 0.0.4', :require => false
+  gem 'terminal-notifier-guard', '~> 1.5.3', :require => false
 end
 
 group :metrics do
-  gem 'coveralls', '~> 0.6.7'
+  gem 'coveralls', '~> 0.7.0'
   gem 'flay',      '~> 2.4.0'
-  gem 'flog',      '~> 4.1.1'
+  gem 'flog',      '~> 4.2.0'
   gem 'reek',      '~> 1.3.2'
-  gem 'rubocop',   '~> 0.12.0'
-  gem 'simplecov', '~> 0.7.1'
+  gem 'rubocop',   '~> 0.16.0'
+  gem 'simplecov', '~> 0.8.2'
+
+  platforms :mri do
+    gem 'mutant', '~> 0.3.4'
+  end
 
   platforms :ruby_19, :ruby_20 do
-    gem 'mutant', git: 'https://github.com/mbj/mutant.git'
     gem 'yard-spellcheck', '~> 0.1.5'
   end
+
+  platform :rbx do
+    gem 'json',               '~> 1.8.1'
+    gem 'racc',               '~> 1.4.10'
+    gem 'rubysl-logger',      '~> 2.0.0'
+    gem 'rubysl-open-uri',    '~> 2.0.0'
+    gem 'rubysl-prettyprint', '~> 2.0.2'
+  end
 end
 
 group :benchmarks do

data/README.md

@@ -87,7 +87,7 @@ RUBY
 
 ### 4. Configuration
 
-Every rule in Yardstick can be turned off globally and locally. All rules are enabled and threshold is set to maximum by default.
+Every rule in Yardstick can be turned off globally and locally. All rules are enabled and threshold is set to maximum by default (100%). If your documentation coverage is below or above this threshold then yardstick will exit with a nonzero status and print that fact.
 
 Default configuration:
 ```yaml

data/config/devtools.yml

@@ -1,2 +1,4 @@
 ---
-unit_test_timeout: 0.3
+unit_test_timeout: 0.1
+fail_on_branch:
+- "master"

data/config/reek.yml

@@ -13,7 +13,9 @@ ClassVariable:
   exclude: []
 ControlParameter:
   enabled: true
-  exclude: []
+  exclude:
+  # False positive
+  - Yardstick::OrderedSet#initialize
 DataClump:
   enabled: true
   exclude: []
@@ -68,8 +70,10 @@ TooManyStatements:
   exclude:
   - Yardstick::CLI#self.option_parser
   - Yardstick::CLI#self.parse_config
-  - Yardstick::Config#set_defaults
   - Yardstick::Config#self.normalize_hash
+  - Yardstick::Config#defaults=
+  - Yardstick::Config#set_defaults
+  - Yardstick::Rake::Verify#initialize
   max_statements: 3
 UncommunicativeMethodName:
   enabled: true

data/config/rubocop.yml

@@ -5,6 +5,7 @@ AllCops:
     - 'Gemfile.devtools'
   Excludes:
     - '**/vendor/**'
+    - '**/benchmarks/**'
 
 # Avoid parameter lists longer than five parameters.
 ParameterLists:
@@ -29,7 +30,7 @@ CollectionMethods:
 # sections of code and visually separate them. When the keyword is at the same
 # level I think it sort of blends in with the def keywords and makes it harder
 # to scan the code and see where the sections are.
-AccessControl:
+AccessModifierIndentation:
   Enabled: false
 
 # Limit line length
@@ -47,3 +48,11 @@ IfUnlessModifier:
 # Do not use sprintf instead of String#%.
 FavorSprintf:
   Enabled: false
+
+# Not all trivial readers/writers can be defined with attr_* methods
+TrivialAccessors:
+  Enabled: false
+
+# Enforce Ruby 1.8-compatible hash syntax
+HashSyntax:
+  EnforcedStyle: hash_rockets

data/lib/yardstick.rb

@@ -1,9 +1,9 @@
 # encoding: utf-8
 
+require 'set'
 require 'pathname'
 require 'delegate'
 
-require 'backports'
 require 'yard'
 
 require 'yardstick/ordered_set'
@@ -81,5 +81,4 @@ module Yardstick
   def self.round_percentage(percentage)
     (percentage * 10).floor / 10.0
   end
-
 end # module Yardstick

data/lib/yardstick/cli.rb

@@ -3,10 +3,8 @@
 require 'optparse'
 
 module Yardstick
-
   # Handle the yardstick command line interface
   class CLI
-
     # Parse the command line options, and run the command
     #
     # @example
@@ -38,7 +36,7 @@ module Yardstick
       args << '--help' if args.empty?
       options = {}
       option_parser(options).parse!(args)
-      Config.new(options.merge(path: args))
+      Config.new(options.merge(:path => args))
     rescue OptionParser::InvalidOption => error
       display_exit(error.message)
     end
@@ -75,6 +73,5 @@ module Yardstick
     class << self
       private :option_parser, :parse_config, :display_exit
     end
-
   end # module CLI
 end # module Yardstick

data/lib/yardstick/config.rb

@@ -80,9 +80,10 @@ module Yardstick
     #
     # @api private
     def self.normalize_hash(hash)
-      hash.each_with_object({}) do |(key, value), normalized_hash|
+      hash.reduce({}) do |normalized_hash, (key, value)|
         normalized_value = value.is_a?(Hash) ? normalize_hash(value) : value
         normalized_hash[key.to_sym] = normalized_value
+        normalized_hash
       end
     end
 
@@ -98,7 +99,7 @@ module Yardstick
     #
     # @api private
     def initialize(options = {}, &block)
-      set_defaults(options)
+      self.defaults = options
 
       yield(self) if block_given?
     end
@@ -116,7 +117,7 @@ module Yardstick
       if key
         RuleConfig.new(@rules.fetch(key.to_sym, {}))
       else
-        raise InvalidRule, "every rule must begin with #{NAMESPACE_PREFIX}"
+        fail InvalidRule, "every rule must begin with #{NAMESPACE_PREFIX}"
       end
     end
 
@@ -160,7 +161,7 @@ module Yardstick
     # @return [undefined]
     #
     # @api private
-    def set_defaults(options)
+    def defaults=(options)
       @threshold               = options.fetch(:threshold, 100)
       @verbose                 = options.fetch(:verbose, true)
       @path                    = options.fetch(:path, 'lib/**/*.rb')

data/lib/yardstick/document.rb

@@ -1,7 +1,6 @@
 # encoding: utf-8
 
 module Yardstick
-
   # Wraps a yard docstring to make a nicer interface
   class Document
     @registered_rules = Set.new
@@ -82,7 +81,7 @@ module Yardstick
     #   true if tag exists
     #
     # @api private
-    def has_tag?(name)
+    def has_tag?(name) # rubocop:disable PredicateName
       @docstring.has_tag?(name)
     end
 

data/lib/yardstick/document_set.rb

@@ -1,10 +1,8 @@
 # encoding: utf-8
 
 module Yardstick
-
   # A set of yardstick documents
   class DocumentSet < OrderedSet
-
     # Measure documents using given config
     #
     # @return [Yardstick::MeasurementSet]
@@ -12,10 +10,10 @@ module Yardstick
     #
     # @api private
     def measure(config)
-      each_with_object(MeasurementSet.new) do |document, set|
+      reduce(MeasurementSet.new) do |set, document|
         set.merge(Document.measure(document, config))
+        set
       end
     end
-
   end
 end

data/lib/yardstick/measurement.rb

@@ -1,7 +1,6 @@
 # encoding: utf-8
 
 module Yardstick
-
   # A measurement given a constraint on the docs
   class Measurement
     # Return a Measurement instance
@@ -97,6 +96,5 @@ module Yardstick
       return :skip if !@rule.enabled? || !@rule.validatable?
       @rule.valid?
     end
-
   end # class Measurement
 end # module Yardstick

data/lib/yardstick/measurement_set.rb

@@ -1,10 +1,8 @@
 # encoding: utf-8
 
 module Yardstick
-
   # A set of yardstick measurements
   class MeasurementSet < OrderedSet
-
     # The total number of measurements
     #
     # @example
@@ -127,6 +125,5 @@ module Yardstick
     def total_text
       'Total: %d' % total
     end
-
   end # class MeasurementSet
 end # module Yardstick

data/lib/yardstick/ordered_set.rb

@@ -1,7 +1,6 @@
 # encoding: utf-8
 
 module Yardstick
-
   # A base class for an ordered set
   class OrderedSet
     include Enumerable
@@ -114,6 +113,5 @@ module Yardstick
     def index(entry)
       @index[entry]
     end
-
   end # class OrderedSet
 end # module Yardstick

data/lib/yardstick/parser.rb

@@ -1,10 +1,8 @@
 # encoding: utf-8
 
 module Yardstick
-
   # Parses files and strings using YARD
   class Parser
-
     # Measure files specified in the paths
     #
     # @return [Array<Document>]
@@ -36,8 +34,9 @@ module Yardstick
     #
     # @api private
     def self.documents
-      method_objects.each_with_object(DocumentSet.new) do |method_object, set|
+      method_objects.reduce(DocumentSet.new) do |set, method_object|
         set << Document.new(method_object.docstring)
+        set
       end
     end
     private_class_method :documents
@@ -50,12 +49,11 @@ module Yardstick
     # @api private
     def self.method_objects
       YARD::Registry.all(:method).sort_by do |method_object|
-        [method_object.file, method_object.line]
+        [method_object.file || '', method_object.line || 0]
       end
     ensure
       YARD::Registry.clear
     end
     private_class_method :method_objects
-
   end
 end

data/lib/yardstick/processor.rb

@@ -1,10 +1,8 @@
 # encoding: utf-8
 
 module Yardstick
-
   # Handle procesing a docstring or path of files
   class Processor
-
     # Initializes new Processor instance
     #
     # @param [Yardstick::Config] config
@@ -50,6 +48,5 @@ module Yardstick
     def paths
       Array(@config.path).map(&:to_s)
     end
-
   end # class Processor
 end # module Yardstick

data/lib/yardstick/rake/measurement.rb

@@ -8,10 +8,8 @@ require 'yardstick'
 
 module Yardstick
   module Rake
-
     # A rake task for measuring docs in a set of files
     class Measurement < ::Rake::TaskLib
-
       # Initializes a Measurement task
       #
       # @example
@@ -57,7 +55,6 @@ module Yardstick
         desc "Measure docs in #{@config.path} with yardstick"
         task(@name) { yardstick_measure }
       end
-
     end # class Measurement
   end # module Rake
 end # module Yardstick

data/lib/yardstick/rake/verify.rb

@@ -7,10 +7,8 @@ require 'yardstick'
 
 module Yardstick
   module Rake
-
     # A rake task for verifying the doc thresholds
     class Verify < ::Rake::TaskLib
-
       # Initialize a Verify task
       #
       # @example
@@ -93,7 +91,7 @@ module Yardstick
       # @api private
       def assert_threshold
         unless @threshold
-          raise 'threshold must be set'
+          fail 'threshold must be set'
         end
       end
 
@@ -107,7 +105,7 @@ module Yardstick
       # @api private
       def assert_meets_threshold
         if lower_coverage?
-          raise "YARD-Coverage must be at least #{@threshold}% but was #{total_coverage}%"
+          fail "YARD-Coverage must be at least #{@threshold}% but was #{total_coverage}%"
         end
       end
 
@@ -121,7 +119,7 @@ module Yardstick
       # @api private
       def assert_matches_threshold
         if @config.require_exact_threshold? && higher_coverage?
-          raise "YARD-Coverage has increased above the threshold of #{@threshold}% to #{total_coverage}%. You should update your threshold value."
+          fail "YARD-Coverage has increased above the threshold of #{@threshold}% to #{total_coverage}%. You should update your threshold value."
         end
       end
 
@@ -144,7 +142,6 @@ module Yardstick
       def higher_coverage?
         total_coverage > @threshold
       end
-
     end # class Verify
   end # module Rake
 end # module Yardstick

data/lib/yardstick/report_output.rb

@@ -1,10 +1,8 @@
 # encoding: utf-8
 
 module Yardstick
-
   # Handles writing reports
   class ReportOutput
-
     # Coerces string path into proper output object
     #
     # @param [String, Pathname] target
@@ -52,6 +50,5 @@ module Yardstick
     def to_s
       @target.to_s
     end
-
   end
 end

data/lib/yardstick/rule.rb

@@ -1,5 +1,7 @@
 # encoding: utf-8
 
+require 'forwardable'
+
 module Yardstick
   # Base class of every rule
   #

data/lib/yardstick/version.rb

@@ -1,8 +1,6 @@
 # encoding: utf-8
 
 module Yardstick
-
   # Gem version
-  VERSION = '0.9.7'.freeze
-
+  VERSION = '0.9.8'.freeze
 end # module Yardstick

data/lib/yardstick/yard_ext.rb

@@ -1,11 +1,9 @@
 # encoding: utf-8
 
 module YARD  #:nodoc: all
-
   # Test if JRuby head is being used
   JRUBY_19MODE = RUBY_VERSION >= '1.9' && RUBY_ENGINE == 'jruby'
 
   # Fix jruby-head to use the ruby 1.8 parser until their ripper port is working
   Parser::SourceParser.parser_type = :ruby18 if JRUBY_19MODE
-
 end # module YARD

data/spec/integration/yardstick/class_methods/measure_spec.rb

@@ -13,7 +13,7 @@ describe Yardstick, '.measure' do
 
   describe 'with a config' do
     before :all do
-      config = Yardstick::Config.new(path: Yardstick::ROOT.join('lib', 'yardstick.rb'))
+      config = Yardstick::Config.new(:path => Yardstick::ROOT.join('lib', 'yardstick.rb'))
       @measurements = Yardstick.measure(config)
     end
 

data/spec/integration/yardstick/processor/process_string_spec.rb

@@ -55,8 +55,8 @@ describe Yardstick::Document, '#process_string' do
 
   describe 'without a method summary when validations are turned off' do
     let(:config) do
-      Yardstick::Config.new(rules: {
-        'Summary::Presence'.to_sym => { enabled: false }
+      Yardstick::Config.new(:rules => {
+        'Summary::Presence'.to_sym => { :enabled => false }
       })
     end
     let(:method) { 'def test(value); end' }
@@ -70,8 +70,8 @@ describe Yardstick::Document, '#process_string' do
 
   describe 'without a method summary when validations are turned off for given class' do
     let(:config) do
-      Yardstick::Config.new(rules: {
-        'Summary::Presence'.to_sym => { enabled: true, exclude: %w[World] }
+      Yardstick::Config.new(:rules => {
+        'Summary::Presence'.to_sym => { :enabled => true, :exclude => %w[World] }
       })
     end
     let(:method) { 'class World; def test(value); end; end' }

data/spec/unit/yardstick/config/class_methods/coerce_spec.rb

@@ -12,7 +12,7 @@ describe Yardstick::Config, '.coerce' do
 
     it 'coerces hash' do
       rules = subject.instance_variable_get(:@rules)
-      expect(rules).to eql(foo: 'bar')
+      expect(rules).to eql(:foo => 'bar')
     end
   end
 

data/spec/unit/yardstick/config/for_rule_spec.rb

@@ -1,13 +1,12 @@
 # encoding: utf-8
 
-
 require 'spec_helper'
 
 describe Yardstick::Config, '#for_rule' do
   subject { described_class.new(options).for_rule(rule_class) }
 
   let(:options) do
-    { rules: { 'Summary::Presence'.to_sym => { enabled: false } } }
+    { :rules => { 'Summary::Presence'.to_sym => { :enabled => false } } }
   end
 
   let(:rule_config) { double('RuleConfig') }
@@ -16,7 +15,7 @@ describe Yardstick::Config, '#for_rule' do
     let(:rule_class) { Yardstick::Rules::Summary::Presence }
 
     before do
-      allow(Yardstick::RuleConfig).to receive(:new).with(enabled: false)
+      allow(Yardstick::RuleConfig).to receive(:new).with(:enabled => false)
         .and_return(rule_config)
     end
 

data/spec/unit/yardstick/config/require_exact_threshold_predicate_spec.rb

@@ -6,13 +6,13 @@ describe Yardstick::Config, '#require_exact_threshold?' do
   subject { described_class.new(config).require_exact_threshold? }
 
   context 'when set to true' do
-    let(:config) { { require_exact_threshold: true } }
+    let(:config) { { :require_exact_threshold => true } }
 
     it { should be(true) }
   end
 
   context 'when set to false' do
-    let(:config) { { require_exact_threshold: false } }
+    let(:config) { { :require_exact_threshold => false } }
 
     it { should be(false) }
   end

data/spec/unit/yardstick/config/set_defaults_spec.rb

@@ -24,10 +24,10 @@ describe Yardstick::Config, '#set_defaults' do
   context 'when with options' do
     let(:options) do
       {
-        threshold: 15,
-        verbose: false,
-        path: 'tmp/*.rb',
-        require_exact_threshold: false
+        :threshold => 15,
+        :verbose => false,
+        :path => 'tmp/*.rb',
+        :require_exact_threshold => false
       }
     end
 

data/spec/unit/yardstick/config/verbose_predicate_spec.rb

@@ -6,13 +6,13 @@ describe Yardstick::Config, '#verbose?' do
   subject { described_class.new(config).verbose? }
 
   context 'when set to true' do
-    let(:config) { { verbose: true } }
+    let(:config) { { :verbose => true } }
 
     it { should be(true) }
   end
 
   context 'when set to false' do
-    let(:config) { { verbose: false } }
+    let(:config) { { :verbose => false } }
 
     it { should be(false) }
   end

data/spec/unit/yardstick/document/api_predicate_spec.rb

@@ -8,7 +8,7 @@ describe Yardstick::Document, '#api?' do
   let(:docstring) { double('docstring') }
 
   before do
-    docstring.stub(:tag).with('api') { double(text: 'private') }
+    docstring.stub(:tag).with('api') { double(:text => 'private') }
   end
 
   context 'when tag is equal' do

data/spec/unit/yardstick/document/file_spec.rb

@@ -5,8 +5,8 @@ require 'spec_helper'
 describe Yardstick::Document, '#file' do
   subject { described_class.new(docstring).file }
 
-  let(:docstring) { double('docstring', object: object)   }
-  let(:object)    { double('object', file: '/foo/bar.rb') }
+  let(:docstring) { double('docstring', :object => object)   }
+  let(:object)    { double('object', :file => '/foo/bar.rb') }
 
   it { should be_kind_of(Pathname) }
 

data/spec/unit/yardstick/document/line_spec.rb

@@ -5,8 +5,8 @@ require 'spec_helper'
 describe Yardstick::Document, '#line' do
   subject { described_class.new(docstring).line }
 
-  let(:docstring) { double('docstring', object: object) }
-  let(:object)    { double('object', line: 3)           }
+  let(:docstring) { double('docstring', :object => object) }
+  let(:object)    { double('object', :line => 3)           }
 
   it { should be(3) }
 end

data/spec/unit/yardstick/document/path_spec.rb

@@ -5,8 +5,8 @@ require 'spec_helper'
 describe Yardstick::Document, '#path' do
   subject { described_class.new(docstring).path }
 
-  let(:docstring) { double('docstring', object: object) }
-  let(:object)    { double('object', path: 'Foo#bar')   }
+  let(:docstring) { double('docstring', :object => object) }
+  let(:object)    { double('object', :path => 'Foo#bar')   }
 
   it { should eq('Foo#bar') }
 end

data/spec/unit/yardstick/document/tag_text_spec.rb

@@ -7,7 +7,7 @@ describe Yardstick::Document, '#tag_text' do
 
   let(:name)      { 'api'                   }
   let(:docstring) { double('docstring')     }
-  let(:yard_tag)  { double(text: 'private') }
+  let(:yard_tag)  { double(:text => 'private') }
 
   before do
     docstring.stub(:tag).with(name) { yard_tag }

data/spec/unit/yardstick/document/tag_types_spec.rb

@@ -7,7 +7,7 @@ describe Yardstick::Document, '#tag_types' do
 
   let(:name)      { 'tag name'           }
   let(:docstring) { double('docstring')  }
-  let(:yard_tag)  { double(types: types) }
+  let(:yard_tag)  { double(:types => types) }
   let(:types)     { %w[type1 type2]      }
 
   before do

data/spec/unit/yardstick/document/visibility_spec.rb

@@ -5,8 +5,8 @@ require 'spec_helper'
 describe Yardstick::Document, '#visibility' do
   subject { described_class.new(docstring).visibility }
 
-  let(:docstring) { double('docstring', object: object)      }
-  let(:object)    { double('object', visibility: visibility) }
+  let(:docstring) { double('docstring', :object => object)      }
+  let(:object)    { double('object', :visibility => visibility) }
 
   context 'when true' do
     let(:visibility) { true }

data/spec/unit/yardstick/parser/class_methods/parse_paths_spec.rb

@@ -6,7 +6,7 @@ describe Yardstick::Parser, '.parse_paths' do
   subject(:document_set) { described_class.parse_paths(paths) }
 
   let(:paths)         { double('paths')                                       }
-  let(:method_object) { double(file: 'foo.rb', line: 4, docstring: docstring) }
+  let(:method_object) { double(:file => 'foo.rb', :line => 4, :docstring => docstring) }
   let(:docstring)     { double('docstring')                                   }
 
   before do

data/spec/unit/yardstick/parser/class_methods/parse_string_spec.rb

@@ -5,13 +5,15 @@ require 'spec_helper'
 describe Yardstick::Parser, '.parse_string' do
   subject(:document_set) { described_class.parse_string(string) }
 
-  let(:string)        { double('string', to_str: 'body')                      }
-  let(:method_object) { double(file: 'foo.rb', line: 4, docstring: docstring) }
+  let(:string)        { double('string', :to_str => 'body')                      }
+  let(:method_object) { double(:file => 'foo.rb', :line => 4, :docstring => docstring) }
   let(:docstring)     { double('docstring')                                   }
 
+  let(:method_objects) { [method_object] }
+
   before do
     YARD.should_receive(:parse_string).with('body')
-    YARD::Registry.stub(:all).with(:method).and_return([method_object])
+    YARD::Registry.stub(:all).with(:method).and_return(method_objects)
   end
 
   it { should be_a(Yardstick::DocumentSet) }
@@ -25,4 +27,15 @@ describe Yardstick::Parser, '.parse_string' do
 
     its(:docstring) { should eq(docstring) }
   end
+
+  context 'when method one object does not have file information' do
+    let(:method_objects) do
+      [
+        method_object,
+        double(:file => nil, :line => nil, :docstring => docstring)
+      ]
+    end
+
+    it { should be_a(Yardstick::DocumentSet) }
+  end
 end

data/spec/unit/yardstick/processor/process_spec.rb

@@ -5,7 +5,7 @@ require 'spec_helper'
 describe Yardstick::Processor, '#process' do
   subject { described_class.new(config).process }
 
-  let(:config)    { double('config', path: path) }
+  let(:config)    { double('config', :path => path) }
   let(:path)      { Pathname('foo/bar.rb')       }
   let(:documents) { double('document set')       }
 

data/spec/unit/yardstick/rake/measurement/yardstick_measure_spec.rb

@@ -6,7 +6,7 @@ require 'yardstick/rake/measurement'
 describe Yardstick::Rake::Measurement, '#yardstick_measure' do
   subject { described_class.new(:yardstick_measure, options).yardstick_measure }
 
-  let(:config)        { double('config', path: 'tmp', output: report_writer) }
+  let(:config)        { double('config', :path => 'tmp', :output => report_writer) }
   let(:report_writer) { double('report writer')                              }
   let(:options)       { double('options')                                    }
   let(:measurements)  { double('measurements')                               }

data/spec/unit/yardstick/rake/verify/initialize_spec.rb

@@ -7,7 +7,7 @@ describe Yardstick::Rake::Verify, '#initialize' do
   context 'with custom arguments' do
     subject(:task) { described_class.new(:verify, options) }
 
-    let(:config)  { Yardstick::Config.new(threshold: 90) }
+    let(:config)  { Yardstick::Config.new(:threshold => 90) }
     let(:options) { double('options')                    }
 
     before do

data/spec/unit/yardstick/rake/verify/verify_measurements_spec.rb

@@ -8,7 +8,7 @@ describe Yardstick::Rake::Verify, '#verify_measurements' do
     capture_stdout { described_class.new(:verify, options).verify_measurements }
   end
 
-  let(:config)  { Yardstick::Config.new(threshold: 90) }
+  let(:config)  { Yardstick::Config.new(:threshold => 90) }
   let(:options) { double('options')                    }
 
   before do
@@ -17,7 +17,7 @@ describe Yardstick::Rake::Verify, '#verify_measurements' do
   end
 
   context 'when verbose' do
-    let(:measurements) { double('measurements', coverage: 0.9) }
+    let(:measurements) { double('measurements', :coverage => 0.9) }
 
     it 'outputs coverage' do
       measure
@@ -26,7 +26,7 @@ describe Yardstick::Rake::Verify, '#verify_measurements' do
   end
 
   context 'when not verbose' do
-    let(:measurements) { double('measurements', coverage: 0.9) }
+    let(:measurements) { double('measurements', :coverage => 0.9) }
 
     before do
       config.verbose = false
@@ -39,7 +39,7 @@ describe Yardstick::Rake::Verify, '#verify_measurements' do
   end
 
   context 'when lower coverage' do
-    let(:measurements) { double('measurements', coverage: 0.434) }
+    let(:measurements) { double('measurements', :coverage => 0.434) }
 
     it 'outputs coverage' do
       expect { measure }.to raise_error
@@ -53,7 +53,7 @@ describe Yardstick::Rake::Verify, '#verify_measurements' do
   end
 
   context 'when higher coverage' do
-    let(:measurements) { double('measurements', coverage: 0.9989) }
+    let(:measurements) { double('measurements', :coverage => 0.9989) }
 
     it 'outputs coverage' do
       expect { measure }.to raise_error
@@ -67,7 +67,7 @@ describe Yardstick::Rake::Verify, '#verify_measurements' do
   end
 
   context 'when higher coverage without exact threshold requirement' do
-    let(:measurements) { double('measurements', coverage: 1) }
+    let(:measurements) { double('measurements', :coverage => 1) }
 
     before do
       config.require_exact_threshold = false

data/spec/unit/yardstick/report_output/write_spec.rb

@@ -9,7 +9,7 @@ describe Yardstick::ReportOutput, 'write' do
     end
   end
 
-  let(:target)  { double('Pathname', dirname: dirname) }
+  let(:target)  { double('Pathname', :dirname => dirname) }
   let(:dirname) { double                               }
 
   before do

data/spec/unit/yardstick/rule/class_methods/coerce_spec.rb

@@ -7,7 +7,7 @@ describe Yardstick::Rule, '.coerce' do
 
   let(:document)    { DocumentMock.new                          }
   let(:config)      { double('config')                          }
-  let(:rule_config) { Yardstick::RuleConfig.new(enabled: false) }
+  let(:rule_config) { Yardstick::RuleConfig.new(:enabled => false) }
 
   before do
     config.stub(:for_rule).with(described_class) { rule_config }

data/spec/unit/yardstick/rule/enabled_predicate_spec.rb

@@ -5,7 +5,7 @@ require 'spec_helper'
 describe Yardstick::Rule, '#enabled?' do
   subject { described_class.new(document, config).enabled? }
 
-  let(:document)     { double('document', path: 'Foo#bar') }
+  let(:document)     { double('document', :path => 'Foo#bar') }
   let(:config)       { double('RuleConfig')                }
   let(:return_value) { double('Boolean')                   }
 

data/spec/unit/yardstick/rule/initialize_spec.rb

@@ -16,7 +16,7 @@ describe Yardstick::Rule, '#initialize' do
   context 'when rule config is given' do
     subject { described_class.new(document, config) }
 
-    let(:config) { Yardstick::RuleConfig.new(enabled: false) }
+    let(:config) { Yardstick::RuleConfig.new(:enabled => false) }
 
     it { should be_a(described_class) }
 

data/spec/unit/yardstick/rules/api_tag/private_method/validatable_predicate_spec.rb

@@ -5,7 +5,7 @@ require 'spec_helper'
 describe Yardstick::Rules::ApiTag::PrivateMethod, '#validatable?' do
   subject { described_class.new(document).validatable? }
 
-  let(:document) { double('document', visibility: visibility) }
+  let(:document) { double('document', :visibility => visibility) }
 
   context 'when protected visibility' do
     let(:visibility) { :private }

data/spec/unit/yardstick/rules/api_tag/protected_method/validatable_predicate_spec.rb

@@ -5,7 +5,7 @@ require 'spec_helper'
 describe Yardstick::Rules::ApiTag::ProtectedMethod, '#validatable?' do
   subject { described_class.new(document).validatable? }
 
-  let(:document) { double('document', visibility: visibility) }
+  let(:document) { double('document', :visibility => visibility) }
 
   context 'when protected visibility' do
     let(:visibility) { :protected }

data/spec/unit/yardstick/rules/summary/delimiter/valid_predicate_spec.rb

@@ -5,7 +5,7 @@ require 'spec_helper'
 describe Yardstick::Rules::Summary::Delimiter, '#valid?' do
   subject { described_class.new(document).valid? }
 
-  let(:document) { double('document', summary_text: text) }
+  let(:document) { double('document', :summary_text => text) }
 
   context 'without a dot' do
     let(:text) { 'A summary' }

data/spec/unit/yardstick/rules/summary/length/valid_predicate_spec.rb

@@ -5,7 +5,7 @@ require 'spec_helper'
 describe Yardstick::Rules::Summary::Length, '#valid?' do
   subject { described_class.new(document).valid? }
 
-  let(:document) { double('document', summary_text: text) }
+  let(:document) { double('document', :summary_text => text) }
 
   context 'with short summary' do
     let(:text) { 'A summary' }

data/spec/unit/yardstick/rules/summary/presence/valid_predicate_spec.rb

@@ -5,7 +5,7 @@ require 'spec_helper'
 describe Yardstick::Rules::Summary::Presence, '#valid?' do
   subject { described_class.new(document).valid? }
 
-  let(:document) { double('document', summary_text: text) }
+  let(:document) { double('document', :summary_text => text) }
 
   context 'with summary' do
     let(:text) { 'A summary' }

data/spec/unit/yardstick/rules/summary/single_line/valid_predicate_spec.rb

@@ -5,7 +5,7 @@ require 'spec_helper'
 describe Yardstick::Rules::Summary::SingleLine, '#valid?' do
   subject { described_class.new(document).valid? }
 
-  let(:document) { double('document', summary_text: text) }
+  let(:document) { double('document', :summary_text => text) }
 
   context 'with one line summary' do
     let(:text) { 'A summary' }

data/yardstick.gemspec

@@ -18,7 +18,7 @@ Gem::Specification.new do |gem|
   gem.extra_rdoc_files = %w[LICENSE README.md CONTRIBUTING.md TODO]
   gem.executables      = %w[yardstick]
 
-  gem.add_runtime_dependency('yard', '~> 0.8', '>= 0.8.7')
+  gem.add_runtime_dependency('yard', '~> 0.8', '>= 0.8.7.2')
 
   gem.add_development_dependency('bundler', '~> 1.3', '>= 1.3.5')
 end

metadata

@@ -1,53 +1,58 @@
 --- !ruby/object:Gem::Specification
 name: yardstick
 version: !ruby/object:Gem::Version
-  version: 0.9.7
+  version: 0.9.8
+  prerelease: 
 platform: ruby
 authors:
 - Dan Kubb
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-09-15 00:00:00.000000000 Z
+date: 2014-01-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: yard
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
         version: '0.8'
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
-        version: 0.8.7
+        version: 0.8.7.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
         version: '0.8'
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
-        version: 0.8.7
+        version: 0.8.7.2
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
         version: '1.3'
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: 1.3.5
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
         version: '1.3'
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: 1.3.5
 description: Measure YARD documentation coverage
@@ -207,26 +212,27 @@ files:
 homepage: https://github.com/dkubb/yardstick
 licenses:
 - MIT
-metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
+  none: false
   requirements:
-  - - '>='
+  - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
+  none: false
   requirements:
-  - - '>='
+  - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.2
+rubygems_version: 1.8.23
 signing_key: 
-specification_version: 4
+specification_version: 3
 summary: A tool for verifying YARD documentation coverage
 test_files:
 - spec/integration/yardstick/class_methods/measure_spec.rb

checksums.yaml

@@ -1,7 +0,0 @@
----
-SHA1:
-  metadata.gz: 9c2137c6b2747b94bf79c7d18f96f3046b88cad1
-  data.tar.gz: 3b701a6a2923c7925ff69040a03befa7a6a6ba85
-SHA512:
-  metadata.gz: 2cd3503aa97404404f678d781a4f144f73cf80662389cef07a2252af4236ffe51b10311e274847b457c1ce2cd4c4da44e7b4225f0a23c51704f0d50ee1258bf1
-  data.tar.gz: dc976e0b2f8477add7b52a5bdf2142bea4e5d22150601da3e0e8e493cfe1794c851eb83d14e8bef81ee6f0788865986d38a0f1ac301cd9bf124809c7d212ad48