yardi 4.0.8 → 4.11.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 23da65dd97a13b80552415335b257aad1f1ae7f8
-  data.tar.gz: 75a31101f34ac6e8d129cc97aeb82b0f05710c86
+SHA256:
+  metadata.gz: 68fbe6d401e805c229f86a032096d90ebed0a01a4905a1bfb3969f81882ee573
+  data.tar.gz: 933e0b3d08fc6efdadb5d63baf13da4bc0baddd920cf49768ced911105085dc5
 SHA512:
-  metadata.gz: a8ee7e3f3e4edeb6a33dea96055ae771e197870df3df603e9ca90145faa10afa7497725b8fb4884d5e39b2bf61bcb79575ef3162f677990e58209e23db59aae8
-  data.tar.gz: b1f9f8ebde63520dcf5242153dcc37f939e63e2faa3d7b4950ac7147a70e195f54873804ed190291d427212599dc3499567dd7f5d9e0540ea64344854c693529
+  metadata.gz: 2c31996f6eb55e04979218a35347ce08fd1b676fa12013cc8c6478b306fe86f8fc8031eec764577d51ebc98776bbfc415a068772ef5998dbdae2f7202886f75e
+  data.tar.gz: 7db5eb29a4889fd1e1073ed9a20ef45b16499a3d1de3651234234da5743920627a15b77f687183e959b3e6c143fe012b73dd1ebf2e591a0653f88c4b49ccb5f6

data/.gitignore

@@ -3,3 +3,6 @@ Gemfile.lock
 yardi-*.gem
 # Ignore bundler config
 /.bundle
+
+# Rubocop cache files
+.rubocop-http*

data/.rubocop.yml

@@ -1,20 +1,7 @@
-AllCops:
-  TargetRubyVersion: 2.3
+require:
+  - rubocop-rspec
+  - rubocop-rails
 
-Style/MultilineMethodCallIndentation:
-  EnforcedStyle: indented
-
-Style/NumericLiterals:
-  Enabled: false
-
-Style/FrozenStringLiteralComment:
-  Enabled: false
-
-# We prefer [] over () for % delimited Arrays such as %w and %i.
-PercentLiteralDelimiters:
- PreferredDelimiters:
-    '%i': '[]'
-    '%w': '[]'
-
-Performance/Casecmp:
-  Enabled: false
+inherit_from:
+  - https://raw.githubusercontent.com/apartmentlist/style/rubocop-2022/ruby/global.yml
+  - .rubocop_todo.yml

data/.rubocop_todo.yml

@@ -0,0 +1,264 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config --exclude-limit 100`
+# on 2022-01-14 17:22:04 UTC using RuboCop version 1.23.0.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 2
+# Configuration parameters: AllowedMethods.
+# AllowedMethods: enums
+Lint/ConstantDefinitionInBlock:
+  Exclude:
+    - 'spec/yardi/utils/request_generator_spec.rb'
+
+# Offense count: 1
+Lint/DuplicateHashKey:
+  Exclude:
+    - 'spec/behaviors/get_residents_spec.rb'
+
+# Offense count: 6
+# Configuration parameters: AllowComments, AllowEmptyLambdas.
+Lint/EmptyBlock:
+  Exclude:
+    - 'lib/yardi/request_section/lead_management.rb'
+    - 'spec/yardi/utils/snowflake_event_tracker_spec.rb'
+
+# Offense count: 6
+Lint/MissingSuper:
+  Exclude:
+    - 'lib/yardi/validator/empty_response.rb'
+    - 'lib/yardi/validator/error_response.rb'
+    - 'lib/yardi/validator/fault_response.rb'
+    - 'lib/yardi/validator/missing_property.rb'
+    - 'lib/yardi/validator/prospect_eventing.rb'
+    - 'lib/yardi/validator/resident_eventing.rb'
+
+# Offense count: 1
+Lint/MixedRegexpCaptureTypes:
+  Exclude:
+    - 'lib/yardi/document_parser/guest_card_import_response_object.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Lint/NonDeterministicRequireOrder:
+  Exclude:
+    - 'spec/spec_helper.rb'
+
+# Offense count: 1
+Lint/UselessAssignment:
+  Exclude:
+    - 'lib/yardi/document_parser/base.rb'
+
+# Offense count: 1
+# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods.
+# IgnoredMethods: refine
+Metrics/BlockLength:
+  Max: 51
+
+# Offense count: 6
+# Configuration parameters: CountKeywordArgs, MaxOptionalParameters.
+Metrics/ParameterLists:
+  Max: 14
+
+# Offense count: 3
+# Configuration parameters: EnforcedStyle, CheckMethodNames, CheckSymbols, AllowedIdentifiers.
+# SupportedStyles: snake_case, normalcase, non_integer
+# AllowedIdentifiers: capture3, iso8601, rfc1123_date, rfc822, rfc2822, rfc3339
+Naming/VariableNumber:
+  Exclude:
+    - 'lib/yardi/model/property.rb'
+
+# Offense count: 43
+# Configuration parameters: Prefixes.
+# Prefixes: when, with, without
+RSpec/ContextWording:
+  Exclude:
+    - 'spec/behaviors/get_property_configurations_spec.rb'
+    - 'spec/behaviors/get_residents_spec.rb'
+    - 'spec/behaviors/get_yardi_guest_activity_spec.rb'
+    - 'spec/yardi/request_section/lead_management_spec.rb'
+    - 'spec/yardi/utils/request_fetcher_spec.rb'
+
+# Offense count: 8
+# Cop supports --auto-correct.
+# Configuration parameters: SkipBlocks, EnforcedStyle.
+# SupportedStyles: described_class, explicit
+RSpec/DescribedClass:
+  Exclude:
+    - 'spec/yardi/request_section/authentication_spec.rb'
+    - 'spec/yardi/request_section/lead_management_spec.rb'
+    - 'spec/yardi/request_section/prospect_spec.rb'
+    - 'spec/yardi/request_section/residents_spec.rb'
+    - 'spec/yardi/utils/request_fetcher_spec.rb'
+    - 'spec/yardi/utils/request_generator_spec.rb'
+    - 'spec/yardi/utils/snowflake_event_tracker_spec.rb'
+
+# Offense count: 1
+# Configuration parameters: Include, CustomTransform, IgnoreMethods, SpecSuffixOnly.
+# Include: **/*_spec*rb*, **/spec/**/*
+RSpec/FilePath:
+  Exclude:
+    - 'spec/yardi/models/resident_spec.rb'
+
+# Offense count: 2
+RSpec/IteratedExpectation:
+  Exclude:
+    - 'spec/behaviors/get_property_configurations_spec.rb'
+    - 'spec/behaviors/get_residents_spec.rb'
+
+# Offense count: 2
+RSpec/LeakyConstantDeclaration:
+  Exclude:
+    - 'spec/yardi/utils/request_generator_spec.rb'
+
+# Offense count: 7
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: strict, flexible
+Rails/TimeZone:
+  Exclude:
+    - 'spec/behaviors/import_yardi_guest_spec.rb'
+    - 'spec/yardi/request_section/lead_management_spec.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/CaseLikeIf:
+  Exclude:
+    - 'lib/yardi/validator/error_response.rb'
+
+# Offense count: 29
+# Configuration parameters: AllowedConstants.
+Style/Documentation:
+  Exclude:
+    - 'lib/yardi/document_parser.rb'
+    - 'lib/yardi/document_parser/properties.rb'
+    - 'lib/yardi/document_parser/residents.rb'
+    - 'lib/yardi/model/event.rb'
+    - 'lib/yardi/model/guest_card_response.rb'
+    - 'lib/yardi/model/property.rb'
+    - 'lib/yardi/model/resident.rb'
+    - 'lib/yardi/parameter/contact_info.rb'
+    - 'lib/yardi/parameter/property.rb'
+    - 'lib/yardi/parameter/prospect.rb'
+    - 'lib/yardi/utils.rb'
+    - 'lib/yardi/utils/configuration_validator.rb'
+    - 'lib/yardi/utils/phone_parser.rb'
+    - 'lib/yardi/utils/snowflake_event_tracker.rb'
+    - 'lib/yardi/validator.rb'
+    - 'lib/yardi/validator/base.rb'
+    - 'lib/yardi/validator/prospect_eventing.rb'
+    - 'lib/yardi/validator/resident_eventing.rb'
+    - 'spec/spec_helper.rb'
+    - 'spec/yardi/request_section/authentication_spec.rb'
+    - 'spec/yardi/request_section/lead_management_spec.rb'
+    - 'spec/yardi/request_section/prospect_spec.rb'
+    - 'spec/yardi/request_section/residents_spec.rb'
+    - 'spec/yardi/utils/configuration_validator_spec.rb'
+    - 'spec/yardi/utils/request_fetcher_spec.rb'
+    - 'spec/yardi/utils/request_generator_spec.rb'
+    - 'spec/yardi/utils/snowflake_event_tracker_spec.rb'
+
+# Offense count: 73
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: always, always_true, never
+Style/FrozenStringLiteralComment:
+  Exclude:
+    - 'Gemfile'
+    - 'Rakefile'
+    - 'bin/console'
+    - 'config/multi_xml.rb'
+    - 'lib/yardi.rb'
+    - 'lib/yardi/document_parser.rb'
+    - 'lib/yardi/document_parser/base.rb'
+    - 'lib/yardi/document_parser/guest_card_import_response_object.rb'
+    - 'lib/yardi/document_parser/properties.rb'
+    - 'lib/yardi/document_parser/prospects.rb'
+    - 'lib/yardi/document_parser/residents.rb'
+    - 'lib/yardi/error/base.rb'
+    - 'lib/yardi/error/canceled_guest.rb'
+    - 'lib/yardi/error/connection_error.rb'
+    - 'lib/yardi/error/empty_response.rb'
+    - 'lib/yardi/error/error_response.rb'
+    - 'lib/yardi/error/fault_response.rb'
+    - 'lib/yardi/error/guests_not_found.rb'
+    - 'lib/yardi/error/invalid_configuration.rb'
+    - 'lib/yardi/error/missing_property.rb'
+    - 'lib/yardi/error/no_results.rb'
+    - 'lib/yardi/error/resource_not_found.rb'
+    - 'lib/yardi/error/service_unavailable.rb'
+    - 'lib/yardi/error/unparsable_response.rb'
+    - 'lib/yardi/model/event.rb'
+    - 'lib/yardi/model/guest_card_response.rb'
+    - 'lib/yardi/model/property.rb'
+    - 'lib/yardi/model/prospect.rb'
+    - 'lib/yardi/parameter/agent.rb'
+    - 'lib/yardi/parameter/contact_info.rb'
+    - 'lib/yardi/parameter/credential.rb'
+    - 'lib/yardi/parameter/property.rb'
+    - 'lib/yardi/parameter/prospect.rb'
+    - 'lib/yardi/parameter/user.rb'
+    - 'lib/yardi/request/base.rb'
+    - 'lib/yardi/request/get_property_configurations.rb'
+    - 'lib/yardi/request/get_residents.rb'
+    - 'lib/yardi/request/get_yardi_guest_activity.rb'
+    - 'lib/yardi/request/import_yardi_guest.rb'
+    - 'lib/yardi/request_section.rb'
+    - 'lib/yardi/request_section/authentication.rb'
+    - 'lib/yardi/request_section/lead_management.rb'
+    - 'lib/yardi/request_section/prospect.rb'
+    - 'lib/yardi/request_section/residents.rb'
+    - 'lib/yardi/utils.rb'
+    - 'lib/yardi/utils/configuration_validator.rb'
+    - 'lib/yardi/utils/phone_parser.rb'
+    - 'lib/yardi/utils/request_fetcher.rb'
+    - 'lib/yardi/utils/request_generator.rb'
+    - 'lib/yardi/utils/snowflake_event_tracker.rb'
+    - 'lib/yardi/validator.rb'
+    - 'lib/yardi/validator/base.rb'
+    - 'lib/yardi/validator/empty_response.rb'
+    - 'lib/yardi/validator/error_response.rb'
+    - 'lib/yardi/validator/fault_response.rb'
+    - 'lib/yardi/validator/missing_property.rb'
+    - 'lib/yardi/validator/prospect_eventing.rb'
+    - 'lib/yardi/validator/resident_eventing.rb'
+    - 'spec/behaviors/get_property_configurations_spec.rb'
+    - 'spec/behaviors/get_residents_spec.rb'
+    - 'spec/behaviors/get_yardi_guest_activity_spec.rb'
+    - 'spec/behaviors/import_yardi_guest_spec.rb'
+    - 'spec/spec_helper.rb'
+    - 'spec/yardi/models/resident_spec.rb'
+    - 'spec/yardi/request_section/authentication_spec.rb'
+    - 'spec/yardi/request_section/lead_management_spec.rb'
+    - 'spec/yardi/request_section/prospect_spec.rb'
+    - 'spec/yardi/request_section/residents_spec.rb'
+    - 'spec/yardi/utils/configuration_validator_spec.rb'
+    - 'spec/yardi/utils/request_fetcher_spec.rb'
+    - 'spec/yardi/utils/request_generator_spec.rb'
+    - 'spec/yardi/utils/snowflake_event_tracker_spec.rb'
+    - 'spec/yardi_spec.rb'
+
+# Offense count: 3
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: literals, strict
+Style/MutableConstant:
+  Exclude:
+    - 'lib/yardi/utils/snowflake_event_tracker.rb'
+    - 'lib/yardi/validator/missing_property.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: Mode.
+Style/StringConcatenation:
+  Exclude:
+    - 'lib/yardi/model/property.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
+# URISchemes: http, https
+Layout/LineLength:
+  Max: 631

data/Gemfile

@@ -2,3 +2,14 @@ source 'https://rubygems.org'
 
 # Specify your gem's dependencies in yardi.gemspec
 gemspec
+
+gem 'event_tracker', git: 'https://github.com/apartmentlist/eventing.git', glob: 'clients/ruby/event_tracker.gemspec',
+                     tag: 'rb1.28.0'
+
+gem 'google-cloud-storage'
+
+gem 'rubocop', '~> 1.23', group: :development
+
+gem 'rubocop-rspec', '~> 2.6', group: :development
+
+gem 'rubocop-rails', '~> 2.12', group: :development

data/README.md

@@ -1,6 +1,7 @@
 [![CircleCI](https://circleci.com/gh/apartmentlist/yardi.svg?style=svg&circle-token=f257321b5c0e4a15a49eda74aa869a09d6db2f19)](https://circleci.com/gh/apartmentlist/yardi)
 
 # yardi
+
 A Ruby client for v4 of Yardi's Guestcard (and soon ILS) API
 
 ## Installation
@@ -31,6 +32,8 @@ Yardi.configure do |config|
   config.license_key = ENV['LICENSE_KEY']
   config.entity = 'Apartment List'
   config.platform = 'SQL Server'
+  config.enable_event_tracking = true
+  config.gcs_bucket = ENV['_GCS_BUCKET']
 end
 ```
 
@@ -63,32 +66,36 @@ To request an action, instantiate the appropriate class (see below) and invoke
 `#perform` on it. The API response will be parsed and returned as a ruby object.
 
 #### Yardi::Action::ImportYardiGuest_Login
+
 Insert a guest card into Yardi's system.
 
 ##### Initialization parameters
 
-* `agent [Yardi::Parameter::Agent]`
-* `credential [Yardi::Parameter::Credential]`
-information needed to authenticate with Yardi
-* `lead_source [String]` what Yardi calls TransactionSource
-* `reason [String]` what Yardi calls Event Reasons. This is the reason for
-   the event, e.g. price inquiry, tour, etc.
-* `property [Yardi::Parameter::Property]` the property to associate the guest
-    card with
-* `user [Yardi::Parameter::User]` the user to associate the guest card with
+- `agent [Yardi::Parameter::Agent]`
+- `credential [Yardi::Parameter::Credential]`
+  information needed to authenticate with Yardi
+- `lead_source [String]` what Yardi calls TransactionSource
+- `reason [String]` what Yardi calls Event Reasons. This is the reason for
+  the event, e.g. price inquiry, tour, etc.
+- `property [Yardi::Parameter::Property]` the property to associate the guest
+  card with
+- `user [Yardi::Parameter::User]` the user to associate the guest card with
 
 #### Yardi::Request::GetResidents
+
 Get all the residents for a given property ID.
 
 ##### Initialization parameters
 
-* `credential [Yardi::Parameter::Credential]` information needed to authenticate with Yardi
-* `property_id [String]` the remote `YardiPropertyId`
+- `credential [Yardi::Parameter::Credential]` information needed to authenticate with Yardi
+- `property_id [String]` the remote `YardiPropertyId`
 
 ##### Response
+
 An array of `Yardi::Model::Resident`s
 
 ###### Example
+
 ```ruby
 Yardi::Request::GetResidents.new(
   credential: credential, params: { property_id: 'p263656'}
@@ -140,20 +147,22 @@ Get a list of `Yardi::Model::Prospect`s for a given Prospect at the specified pr
 
 ##### Initialization parameters
 
-* `credential [Yardi::Parameter::Credential]` information needed to authenticate with Yardi
-* `params [Hash]`
-  * `property_id [String]`
-  * `prospect [Yardi::Parameter::Prospect]`
+- `credential [Yardi::Parameter::Credential]` information needed to authenticate with Yardi
+- `params [Hash]`
+  - `property_id [String]`
+  - `prospect [Yardi::Parameter::Prospect]`
+  - `with_or [Yardi::Parameter::With_or]`
 
 ##### Response
 
 An array of `Yardi::Model::Prospect`s
 
 ###### Example
+
 ```ruby
 Yardi::Request::GetYardiGuestActivity.new(
   credential: credential,
-  params: { property_id: 'p263656', prospect: prospect }
+  params: { property_id: 'p263656', prospect: prospect, with_or: with_or }
 ).perform
 # => [#<Yardi::Model::Prospect>, #<Yardi::Model::Prospect>]
 ```
@@ -162,21 +171,18 @@ Yardi::Request::GetYardiGuestActivity.new(
 
 ##### Attributes
 
-* `first_name` The `Prospect`'s first name according to Yardi's database
-* `last_name` The `Prospect`'s last name according to Yardi's database
-* `email` The `Prospect`'s email address according to Yardi's database
-* `phones` An Array of the `Prospect`'s phone numbers, or `nil` if there are none
-* `events` An Array of `Yardi::Model::Event` objects
-* `prospect_id` The `Prospect` id from Yardi's database e.g. `"p00003693"`
-* `tenant_id` The tenant id from Yardi's database e.g. `"t000456"`
+- `first_name` The `Prospect`'s first name according to Yardi's database
+- `last_name` The `Prospect`'s last name according to Yardi's database
+- `email` The `Prospect`'s email address according to Yardi's database
+- `phones` An Array of the `Prospect`'s phone numbers, or `nil` if there are none
+- `events` An Array of `Yardi::Model::Event` objects
+- `prospect_id` The `Prospect` id from Yardi's database e.g. `"p00003693"`
+- `tenant_id` The tenant id from Yardi's database e.g. `"t000456"`
 
 ## Development
 
 To install this gem onto your local machine, run `bundle exec rake install`.
-To release a new version, update the version number in `version.rb`, and then
-run `bundle exec rake release` to create a git tag for the version, push git
-commits and tags, and push the `.gem` file to
-[rubygems.org](https://rubygems.org).
+To release a new version, follow the instructions [here](https://github.com/apartmentlist/albacore#releasing).
 
 ## Contributing
 
@@ -184,8 +190,24 @@ If you are interested in contributing to this project, please review the
 [contribution guidelines](docs/contributing.md).
 
 ## Versions
+
+- 4.10.3 Patch for NilClass when building prospect
+- 4.10.2 Patch for send_prospect_events in validator
+- 4.10.1 Patch for send_prospect_events default value
+- 4.10.0 GetYardiGuestActivity uses send_prospect_events parameter
+- 4.9.1 Bug fix for request using GetYardiGuestActivity_SearchWithOR which does not need prospect eventing
+- 4.9.0 Fix to change get_soap_action to action and add phones to prospect params
+- 4.8.4 GetYardiGuestActivity uses a with_or parameter
+- 4.8.2 Update EmptyResponse validator to look for Envelope in Xml
+- 4.8.1 Update document parser to look for Envelope in Xml
+- 4.8.0 Add GetPropertyConfigurations request
+- 4.6.10 Update pms_resident and pms_prospect: add unit_name, resident_id and move_in_report_type
+- 4.6.0 Add Snowflake eventing for residents and prospects
+- 4.2.0 Add ability to build xml to reactivate and update guestcards
+- 4.1.1 Fix to change param name of action to guestcard_action
+- 4.1.0 Add guestcard action to build xml for active or inactive guestcard
 - 4.0.0 Add handling for 404 errors and move ConnectionError to be a subclass of
-Yardi::Error::Base
+  Yardi::Error::Base
 - 3.1.2 Fix Prospect parsing to properly handle missing `Event` nodes
 - 3.1.1 Fix roommate parsing to properly extract roommate data from GetResidents response
 - 3.1.0 Add roommates to Resident Model and Parser

data/lib/yardi/document_parser/base.rb

@@ -25,6 +25,11 @@ module Yardi
       ].freeze
       private_constant :DEFAULT_VALIDATOR_CLASSES
 
+      def initialize(params)
+        @params = params
+        after_initialize(params)
+      end
+
       # @param xml [String] the XML response from the request
       # @return [Object] the parsed object(s) from the rsesponse
       # @raise [Yardi::Error::Base] if the response is invalid
@@ -35,17 +40,27 @@ module Yardi
           raise unparsable_xml_error(xml)
         end
 
+        return [] if test_data_not_found?(parsed)
+
         # This is a temporary code to be able to see what Yardi response
         # looks like when envelope is empty.
-        if !parsed.empty? && parsed['soap:Envelope'].nil?
-          raise Yardi::Error::UnparsableResponse.new(xml)
+        if !parsed.empty? && parsed['soap:Envelope'].nil? && parsed['Envelope'].nil?
+          if ((parsed['html'] || {})['head'] || {})['title']
+            raise Yardi::Error::ErrorResponse, parsed['html']['head']['title']
+          else
+            raise Yardi::Error::UnparsableResponse, xml
+          end
         end
 
         [*DEFAULT_VALIDATOR_CLASSES, *validator_classes].each do |klass|
-          klass.new(action: action, parsed_response: parsed).validate!
+          klass.new(action: action, parsed_response: parsed, params: @params).validate!
         end
 
-        parse_body(parsed['soap:Envelope']['soap:Body'])
+        if parsed['soap:Envelope']
+          parse_body(parsed['soap:Envelope']['soap:Body'])
+        else
+          parse_body(parsed['Envelope']['Body'])
+        end
       end
 
       private
@@ -58,11 +73,16 @@ module Yardi
       #   into a Hash
       # @return [Object] the parsed object(s) from the rsesponse
       # @raise [Yardi::Error::Base] if the response is invalid
-      def parse_body(body)
+      def parse_body(_body)
         raise NotImplementedError,
               "#{self.class.name} must implement #{__method__}"
       end
 
+      # implement this method if you need a callback in subclass after it is initialized
+      def after_initialize(_params)
+        nil
+      end
+
       def action
         self.class::SOAP_ACTION
       end
@@ -80,6 +100,16 @@ module Yardi
           Yardi::Error::UnparsableResponse.new(response)
         end
       end
+
+      # If the requested test data file from Google Cloud Storage does not exist,
+      # the parsed response would be {}. In this case, we return an empty list.
+      def test_data_not_found?(parsed)
+        parsed.empty? && ( parser_name == 'Residents' || parser_name == 'Prospects' )
+      end
+
+      def parser_name
+        self.class.name.split('::').last
+      end
     end
   end
 end

data/lib/yardi/document_parser/guest_card_import_response_object.rb

@@ -64,7 +64,7 @@ module Yardi
           id_regex =
             /(Inserted|Updated) Prospect CustomerID: (?<remote_id>p\d+)/
           id_match = id_message['__content__'].match(id_regex)
-          !id_match.nil? ? id_match[:remote_id] : nil
+          id_match.nil? ? nil : id_match[:remote_id]
         end
       end
     end

data/lib/yardi/document_parser/properties.rb

@@ -0,0 +1,39 @@
+require_relative 'base'
+
+module Yardi
+  module DocumentParser
+    class Properties < Base
+      SOAP_ACTION = 'GetPropertyConfigurations'.freeze
+
+      private
+
+      attr_reader :body
+
+      # @param body [Hash<String, Object>] the body of the XML response parsed
+      #   into a Hash
+      # @return [Array<Yardi::Model::Property>]
+      # @raise [Yardi::Error::Base] if the response is invalid
+      def parse_body(body)
+        @body = body
+        properties
+      end
+
+      def properties
+        path = %w[Properties Property]
+        results = [result_node.dig(*path)].flatten.compact
+
+        if results.empty?
+          raise Error::NoResults,
+                'Failed to get property configurations'
+        end
+
+        results.map { |r| create_property_configuration(r) }
+      end
+
+      # Creates a Property object
+      def create_property_configuration(property)
+        Model::Property.new(property)
+      end
+    end
+  end
+end

data/lib/yardi/document_parser/prospects.rb

@@ -1,13 +1,14 @@
 require_relative 'base'
+require 'active_support'
+require 'active_support/core_ext'
 require 'yardi/model/prospect'
 require 'yardi/utils/phone_parser'
+require 'yardi/validator/prospect_eventing'
 
 module Yardi
   module DocumentParser
     # Build Prospect objects from prospect search response body.
     class Prospects < Base
-      SOAP_ACTION = 'GetYardiGuestActivity_Search'.freeze
-
       private
 
       attr_reader :body
@@ -33,8 +34,8 @@ module Yardi
         events = prospect.dig('Events', 'Event') || []
 
         Model::Prospect.new(
-          first_name: customer['Name']['FirstName'],
-          last_name: customer['Name']['LastName'],
+          first_name: customer['Name']&.[]('FirstName'),
+          last_name: customer['Name']&.[]('LastName'),
           email: customer['Email'],
           phones: Utils::PhoneParser.parse(customer['Phone']),
           events: build_events(events),
@@ -59,7 +60,7 @@ module Yardi
       end
 
       def transaction_source(event_nodes)
-        transaction_node = event_nodes.detect{ |e| e['TransactionSource'].present? }
+        transaction_node = event_nodes.detect { |e| e['TransactionSource'].present? }
         if transaction_node.nil?
           'None Given From Yardi'
         else
@@ -74,6 +75,23 @@ module Yardi
 
         desired_id_node['IDValue']
       end
+
+      def validator_classes
+        # since leadsender also goes through this flow we want to make this generic/extendable by checking send_prospect_events
+        if @params[:send_prospect_events]
+          [Validator::ProspectEventing]
+        else
+          []
+        end
+      end
+
+      def action
+        if @params[:with_or]
+          'GetYardiGuestActivity_SearchWithOR'.freeze
+        else
+          'GetYardiGuestActivity_Search'.freeze
+        end
+      end
     end
   end
 end