yaoc 0.0.13 → 0.0.14

data/spec/unit/lib/yaoc/mapping_to_class_spec.rb

@@ -1,7 +1,7 @@
-require "spec_helper"
+require 'spec_helper'
 
 describe Yaoc::MappingToClass do
-  subject{
+  subject do
     Struct.new(:target_source) do
       include Yaoc::MappingToClass
 
@@ -10,19 +10,19 @@ describe Yaoc::MappingToClass do
       }
 
     end.new(expected_class)
-  }
+  end
 
-  let(:expected_class){
+  let(:expected_class)do
     Struct.new(:id)
-  }
+  end
 
-  describe "#call" do
-    subject{
+  describe '#call' do
+    subject do
       Struct.new(:target_source) do
         include Yaoc::MappingToClass
 
         self.mapping_strategy = ->(obj){
-          {:name => :new_name}
+          { name: :new_name }
         }
 
         def to_convert
@@ -30,22 +30,21 @@ describe Yaoc::MappingToClass do
         end
 
       end.new(expected_class)
-    }
+    end
 
-    it "creates on object of the wanted kind" do
+    it 'creates on object of the wanted kind' do
       expect(subject.call).to be_kind_of expected_class
     end
 
-    it "can use a lambda for creation" do
-      creator = ->(*args){}
+    it 'can use a lambda for creation' do
+      creator = ->(*args) {}
       expect(creator).to receive :call
       subject.target_source = creator
       subject.call
     end
 
-
-    it "splattes args when conversion result is an array" do
-      creator = ->(*args){}
+    it 'splattes args when conversion result is an array' do
+      creator = ->(*args) {}
       subject.class.mapping_strategy = ->(obj){
         [1, 2]
       }
@@ -57,7 +56,7 @@ describe Yaoc::MappingToClass do
       subject.call
     end
 
-    it "fills an existing object instead of create a new one" do
+    it 'fills an existing object instead of create a new one' do
       obj = Struct.new(:id, :name).new(:my_id)
       created_obj = subject.call(obj)
 
@@ -66,17 +65,16 @@ describe Yaoc::MappingToClass do
       expect(obj.id).to eq :my_id
     end
 
-    it "returns nil when nothing to convert" do
+    it 'returns nil when nothing to convert' do
       subject.stub(to_convert: nil)
       expect(subject.call).to be_nil
     end
   end
 
-  describe "#to_a" do
-    it "satisfies Array(*) when included into structs" do
+  describe '#to_a' do
+    it 'satisfies Array(*) when included into structs' do
       expect(subject.to_a).to eq ([subject])
     end
   end
 
-
-end
+end

data/spec/unit/lib/yaoc/object_mapper_spec.rb

@@ -1,30 +1,30 @@
-require "spec_helper"
+require 'spec_helper'
 
 describe Yaoc::ObjectMapper do
-  subject{
-    Yaoc::ObjectMapper.new(Struct.new(:id, :name)).tap{|mapper|
+  subject do
+    Yaoc::ObjectMapper.new(Struct.new(:id, :name)).tap do|mapper|
       mapper.stub(:converter_builder).and_return(converter_builder)
       mapper.stub(:reverse_converter_builder).and_return(reverse_converter_builder)
-    }
-  }
+    end
+  end
 
-  let(:converter_builder){
-    double("converter_builder", rule: nil, apply_commands!: nil, converter: converter)
-  }
+  let(:converter_builder)do
+    double('converter_builder', rule: nil, apply_commands!: nil, converter: converter)
+  end
 
-  let(:reverse_converter_builder){
-    double("reverse_converter_builder", rule: nil, apply_commands!: nil, converter: reverse_converter)
-  }
+  let(:reverse_converter_builder)do
+    double('reverse_converter_builder', rule: nil, apply_commands!: nil, converter: reverse_converter)
+  end
 
-  let(:converter){
-    double("converter", call: nil)
-  }
+  let(:converter)do
+    double('converter', call: nil)
+  end
 
-  let(:reverse_converter){
-    double("reverse_converter", call: nil)
-  }
+  let(:reverse_converter)do
+    double('reverse_converter', call: nil)
+  end
 
-  let(:expected_default_params){
+  let(:expected_default_params)do
     {
         to: :id,
         from: :id,
@@ -33,11 +33,11 @@ describe Yaoc::ObjectMapper do
         is_collection: nil,
         lazy_loading: nil,
     }
-  }
+  end
 
-  describe "#add_mapping" do
+  describe '#add_mapping' do
 
-    it "creates a converter" do
+    it 'creates a converter' do
       expected_params = expected_default_params
 
       expect(converter_builder).to receive(:rule).with(expected_params)
@@ -48,7 +48,7 @@ describe Yaoc::ObjectMapper do
 
     end
 
-    it "creates a revers converter" do
+    it 'creates a revers converter' do
       expected_params = expected_default_params
 
       expect(reverse_converter_builder).to receive(:rule).with(expected_params)
@@ -61,10 +61,10 @@ describe Yaoc::ObjectMapper do
 
   end
 
-  describe "#rule" do
+  describe '#rule' do
 
-    it "allows to use another converter as converter" do
-      converter_double = double("converter")
+    it 'allows to use another converter as converter' do
+      converter_double = double('converter')
 
       expected_params = expected_default_params.merge(
           object_converter: [converter_double],
@@ -74,22 +74,20 @@ describe Yaoc::ObjectMapper do
           object_converter: [converter_double]
       )
 
-
       expect(converter_builder).to receive(:rule).with(expected_params)
       expect(reverse_converter_builder).to receive(:rule).with(expected_params_reverse)
 
       expect(converter_double).to receive(:converter).and_return(converter_double)
       expect(converter_double).to receive(:reverse_converter).and_return(converter_double)
 
-
       subject.add_mapping do
         rule to: :id,
              object_converter: converter_double
       end
     end
 
-    it "allows to use another converter as reverse converter" do
-      reverse_converter_double = double("reverse converter")
+    it 'allows to use another converter as reverse converter' do
+      reverse_converter_double = double('reverse converter')
 
       expected_params = expected_default_params.merge(
           object_converter: [],
@@ -99,7 +97,6 @@ describe Yaoc::ObjectMapper do
           object_converter: [reverse_converter_double]
       )
 
-
       expect(converter_builder).to receive(:rule).with(expected_params)
       expect(reverse_converter_builder).to receive(:rule).with(expected_params_reverse)
 
@@ -111,7 +108,7 @@ describe Yaoc::ObjectMapper do
       end
     end
 
-    it "accepts a reverse mapping for from and to" do
+    it 'accepts a reverse mapping for from and to' do
       expected_params = expected_default_params.merge(
           to: :id_r,
           from: :id_r,
@@ -124,7 +121,7 @@ describe Yaoc::ObjectMapper do
       end
     end
 
-    it "allows to set a fetcher" do
+    it 'allows to set a fetcher' do
       expect(converter_builder).to receive(:fetcher=).with(:public_send)
 
       subject.add_mapping do
@@ -134,7 +131,7 @@ describe Yaoc::ObjectMapper do
 
     end
 
-    it "allows to set a reverse_fetcher" do
+    it 'allows to set a reverse_fetcher' do
       expect(reverse_converter_builder).to receive(:fetcher=).with(:fetch)
 
       subject.add_mapping do
@@ -143,7 +140,7 @@ describe Yaoc::ObjectMapper do
       end
     end
 
-    it "allows to change the strategy" do
+    it 'allows to change the strategy' do
       expect(converter_builder).to receive(:strategy=).with(:to_array_mapping)
 
       subject.add_mapping do
@@ -152,7 +149,7 @@ describe Yaoc::ObjectMapper do
       end
     end
 
-    it "allows to change the reverse strategy" do
+    it 'allows to change the reverse strategy' do
       expect(reverse_converter_builder).to receive(:strategy=).with(:to_array_mapping)
 
       subject.add_mapping do
@@ -161,7 +158,7 @@ describe Yaoc::ObjectMapper do
       end
     end
 
-    it "allows to set lazy_loading" do
+    it 'allows to set lazy_loading' do
       expected_params = expected_default_params.merge(
           lazy_loading: true,
       )
@@ -175,7 +172,7 @@ describe Yaoc::ObjectMapper do
       end
     end
 
-    it "allows to set reverse lazy_loading" do
+    it 'allows to set reverse lazy_loading' do
       expected_params = expected_default_params.merge(
           lazy_loading: nil,
       )
@@ -194,7 +191,7 @@ describe Yaoc::ObjectMapper do
     end
 
     it 'allows to register the mapper globally' do
-      registry_double=double('registry')
+      registry_double = double('registry')
       subject.registry = registry_double
 
       expect(registry_double).to receive(:add).with(:mapper_name, subject)
@@ -205,17 +202,16 @@ describe Yaoc::ObjectMapper do
 
     end
 
-
   end
 
-  describe "#load" do
-    it "creates an object of result class kind" do
+  describe '#load' do
+    it 'creates an object of result class kind' do
       expect(converter).to receive(:call)
 
       subject.load({})
     end
 
-    it "uses an existing object for the result" do
+    it 'uses an existing object for the result' do
       preloaded_obj = Object.new
 
       expect(converter).to receive(:call).with(preloaded_obj)
@@ -224,15 +220,15 @@ describe Yaoc::ObjectMapper do
     end
   end
 
-  describe "#dump" do
+  describe '#dump' do
 
-    it "dump the object as an wanted object" do
+    it 'dump the object as an wanted object' do
       expect(reverse_converter).to receive(:call)
 
       subject.dump({})
     end
 
-    it "uses an existing object for the result" do
+    it 'uses an existing object for the result' do
       preloaded_obj = Object.new
 
       expect(reverse_converter).to receive(:call).with(preloaded_obj)
@@ -242,8 +238,8 @@ describe Yaoc::ObjectMapper do
 
   end
 
-  describe "#noop" do
-    it "returns the input" do
+  describe '#noop' do
+    it 'returns the input' do
       expect(subject.noop.call(:some_thing, :expected_value)).to eq :expected_value
     end
   end
@@ -252,8 +248,8 @@ describe Yaoc::ObjectMapper do
     it 'returns a readable representation' do
       subject.dump_result_source = Object
       subject.load_result_source = nil
-      expect(subject.to_s).to eq "Object <=> "
+      expect(subject.to_s).to eq 'Object <=> '
     end
   end
 
-end
+end

data/spec/unit/lib/yaoc/one_to_many_mapper_chain_spec.rb

@@ -2,11 +2,11 @@ require 'spec_helper'
 
 describe Yaoc::OneToManyMapperChain do
 
-  subject{
+  subject do
     Yaoc::OneToManyMapperChain.new(first_mapper, second_mapper)
-  }
+  end
 
-  let(:first_mapper){
+  let(:first_mapper)do
     Yaoc::ObjectMapper.new(new_user_class, old_user_class).tap do |mapper|
       mapper.add_mapping do
         fetcher :public_send
@@ -14,9 +14,9 @@ describe Yaoc::OneToManyMapperChain do
              from: :o_id
       end
     end
-  }
+  end
 
-  let(:second_mapper){
+  let(:second_mapper)do
     Yaoc::ObjectMapper.new(new_user_class, old_user_class).tap do |mapper|
       mapper.add_mapping do
         fetcher :public_send
@@ -24,34 +24,34 @@ describe Yaoc::OneToManyMapperChain do
              from: :o_names
       end
     end
-  }
+  end
 
-  let(:new_user_class){
+  let(:new_user_class)do
     Yaoc::Helper::StructHE(:id, :names)
-  }
+  end
 
-  let(:old_user_class){
+  let(:old_user_class)do
     Yaoc::Helper::StructHE(:o_id, :o_names)
-  }
+  end
 
-  let(:existing_old_user){
+  let(:existing_old_user)do
     old_user_class.new(
         o_id: 'existing_user_2',
         o_names: ['first_name', 'second_name']
     )
-  }
+  end
 
-  let(:existing_user){
+  let(:existing_user)do
     new_user_class.new(
         id: 'existing_user_2',
         names: ['first_name', 'second_name']
     )
-  }
+  end
 
   describe '.new' do
-    subject{
+    subject do
       Yaoc::ManyToOneMapperChain
-    }
+    end
 
     it 'converts symbols into converter' do
       registry = double('registry')
@@ -88,7 +88,6 @@ describe Yaoc::OneToManyMapperChain do
     end
   end
 
-
   describe '#dump_all' do
     it 'converts one input object into multiple result object' do
       converted_users = subject.dump_all(existing_user)
@@ -110,4 +109,4 @@ describe Yaoc::OneToManyMapperChain do
     end
   end
 
-end
+end

data/spec/unit/lib/yaoc/strategies/to_array_mapping_spec.rb

@@ -1,38 +1,37 @@
-require "spec_helper"
+require 'spec_helper'
 
 describe Yaoc::Strategies::ToArrayMapping do
-  subject{
+  subject do
     Struct.new(:to_convert) do
       include Yaoc::MappingBase
       self.mapping_strategy = Yaoc::Strategies::ToArrayMapping
     end
-  }
+  end
 
-  let(:mapper){
+  let(:mapper)do
     subject.new(source_object)
-  }
+  end
 
-  let(:source_object){
-    {id: 1, name: "paul"}
-  }
+  let(:source_object)do
+    { id: 1, name: 'paul' }
+  end
 
-  let(:expected_array){
-    [1, "paul"]
-  }
+  let(:expected_array)do
+    [1, 'paul']
+  end
 
-  describe ".call" do
+  describe '.call' do
 
-    it "creates a hash from a object" do
+    it 'creates a hash from a object' do
       subject.map(to: 0, from: :id)
       subject.map(to: 1, from: :name)
 
       expect(mapper.call).to eq(expected_array)
     end
 
-
-    it "uses my converter proc" do
+    it 'uses my converter proc' do
       subject.map(to: 0, from: :id)
-      subject.map(to: 3, from: :fullname, converter: ->(source, result){ Yaoc::TransformationCommand.fill_result_with_value(result, 3, "#{source.fetch(:name)} Hello World") })
+      subject.map(to: 3, from: :fullname, converter: ->(source, result) { Yaoc::TransformationCommand.fill_result_with_value(result, 3, "#{source.fetch(:name)} Hello World") })
 
       ext_expectation = expected_array.clone
       ext_expectation[3] = "#{ext_expectation[1]} Hello World"
@@ -42,12 +41,12 @@ describe Yaoc::Strategies::ToArrayMapping do
       expect(mapper.call).to eq(ext_expectation)
     end
 
-    context "changed fetcher method" do
-      let(:source_object){
-        Struct.new(:id, :name).new(1, "paul")
-      }
+    context 'changed fetcher method' do
+      let(:source_object)do
+        Struct.new(:id, :name).new(1, 'paul')
+      end
 
-      it "uses custom fetcher methods" do
+      it 'uses custom fetcher methods' do
         subject.map(to: 0, from: :id)
         subject.map(to: 1, from: :name)
 
@@ -58,7 +57,7 @@ describe Yaoc::Strategies::ToArrayMapping do
         expect(mapper.call).to eq(expected_array)
       end
 
-      it "works with arrays" do
+      it 'works with arrays' do
         subject.map(to: 1, from: 0)
         subject.map(to: 0, from: 1)
 
@@ -66,7 +65,7 @@ describe Yaoc::Strategies::ToArrayMapping do
           :[]
         end
 
-        mapper.to_convert = [1, "paul"]
+        mapper.to_convert = [1, 'paul']
 
         expect(mapper.call).to eq(expected_array.reverse)
       end
@@ -74,4 +73,4 @@ describe Yaoc::Strategies::ToArrayMapping do
 
   end
 
-end
+end