yandex360 1.1.2 → 1.1.4

data/.gitignore

@@ -11,6 +11,7 @@
 
 ## Specific to RubyMotion:
 .dat*
+.c**
 .repl_history
 build/
 
@@ -37,4 +38,5 @@ build/
 .DS_Store
 dev
 
-.rspec_status
+.rspec_status
+TODO

data/.rubocop.yml

@@ -38,7 +38,6 @@ Style/OptionHash:
     - options
     - opts
     - args
-    - paramsgit sttus
     - parameters
 
 # Mixing the styles looks just silly.
@@ -139,4 +138,17 @@ Lint/Debugger:
 
 # Style preference
 Style/MethodDefParentheses:
-  Enabled: false
+  Enabled: false
+
+# Allow longer blocks in specs and configuration files
+Metrics/BlockLength:
+  Exclude:
+    - 'spec/**/*'
+    - 'test/**/*'
+    - 'Rakefile'
+    - '**/*.rake'
+
+# Allow longer modules in test support files due to mock data
+Metrics/ModuleLength:
+  Exclude:
+    - 'spec/support/**/*'

data/CHANGELOG.md

@@ -0,0 +1,76 @@
+## 🧹 Maintenance
+
+- build(deps): update faraday requirement from ~> 1.7 to >= 1.7, < 3.0 by @dependabot[bot] in #8
+- build(deps-dev): update simplecov-lcov requirement from ~> 0.7.0 to ~> 0.8.0 by @dependabot[bot] in #5
+- build(deps-dev): bump rspec from 3.11.0 to 3.12.0 by @dependabot[bot] in #6
+- build(deps-dev): update rake requirement from ~> 12.3.3 to ~> 13.0.6 by @dependabot[bot] in #3
+- build(deps): bump coverallsapp/github-action from 1.1.3 to 2.1.0 by @dependabot[bot] in #7
+- build(deps): bump coverallsapp/github-action from 2.1.0 to 2.1.2 by @dependabot[bot] in #12
+- build(deps): bump faraday from 2.7.4 to 2.7.5 by @dependabot[bot] in #13
+- build(deps): bump coverallsapp/github-action from 2.1.2 to 2.2.0 by @dependabot[bot] in #15
+- build(deps): bump faraday from 2.7.5 to 2.7.7 by @dependabot[bot] in #16
+- build(deps): bump faraday from 2.7.7 to 2.7.10 by @dependabot[bot] in #19
+- build(deps): bump coverallsapp/github-action from 2.2.0 to 2.2.1 by @dependabot[bot] in #20
+- build(deps): bump coverallsapp/github-action from 2.2.1 to 2.2.3 by @dependabot[bot] in #25
+- build(deps): bump faraday from 2.7.10 to 2.7.11 by @dependabot[bot] in #26
+- build(deps): bump actions/checkout from 3 to 4 by @dependabot[bot] in #24
+- build(deps-dev): bump webmock from 3.18.1 to 3.19.1 by @dependabot[bot] in #22
+- build(deps-dev): update rake requirement from ~> 13.0.6 to ~> 13.1.0 by @dependabot[bot] in #27
+- build(deps): bump faraday from 2.7.11 to 2.7.12 by @dependabot[bot] in #28
+- build(deps-dev): bump simplecov from 0.21.2 to 0.22.0 by @dependabot[bot] in #4
+- build(deps): bump faraday from 2.7.12 to 2.8.1 by @dependabot[bot] in #30
+- build(deps): bump ruby/setup-ruby from 1.165.1 to 1.175.1 by @dependabot[bot] in #42
+- build(deps): bump ruby/setup-ruby from 1.175.1 to 1.176.0 by @dependabot[bot] in #43
+- build(deps-dev): bump rspec from 3.12.0 to 3.13.0 by @dependabot[bot] in #34
+- build(deps-dev): bump webmock from 3.19.1 to 3.23.0 by @dependabot[bot] in #38
+- build(deps): bump coverallsapp/github-action from 2.2.3 to 2.3.0 by @dependabot[bot] in #45
+- build(deps-dev): bump rexml from 3.2.6 to 3.2.8 by @dependabot[bot] in #46
+- build(deps-dev): update rake requirement from ~> 13.1.0 to ~> 13.2.1 by @dependabot[bot] in #47
+- build(deps): bump ruby/setup-ruby from 1.176.0 to 1.177.0 by @dependabot[bot] in #48
+- build(deps-dev): bump webmock from 3.23.0 to 3.23.1 by @dependabot[bot] in #49
+- build(deps): bump ruby/setup-ruby from 1.177.0 to 1.177.1 by @dependabot[bot] in #50
+- build(deps): bump ruby/setup-ruby from 1.177.1 to 1.179.0 by @dependabot[bot] in #51
+- build(deps): bump ruby/setup-ruby from 1.179.0 to 1.180.1 by @dependabot[bot] in #53
+- build(deps): bump ruby/setup-ruby from 1.180.1 to 1.185.0 by @dependabot[bot] in #55
+- build(deps): bump ruby/setup-ruby from 1.185.0 to 1.187.0 by @dependabot[bot] in #56
+- build(deps): bump ruby/setup-ruby from 1.187.0 to 1.188.0 by @dependabot[bot] in #57
+- build(deps-dev): bump rexml from 3.2.8 to 3.3.2 by @dependabot[bot] in #58
+- build(deps): bump ruby/setup-ruby from 1.188.0 to 1.190.0 by @dependabot[bot] in #59
+- build(deps-dev): bump rexml from 3.3.2 to 3.3.6 by @dependabot[bot] in #60
+- build(deps): bump ruby/setup-ruby from 1.190.0 to 1.191.0 by @dependabot[bot] in #61
+- build(deps): bump ruby/setup-ruby from 1.191.0 to 1.192.0 by @dependabot[bot] in #62
+- build(deps): bump ruby/setup-ruby from 1.192.0 to 1.193.0 by @dependabot[bot] in #63
+- build(deps): bump ruby/setup-ruby from 1.193.0 to 1.194.0 by @dependabot[bot] in #64
+- build(deps): bump ruby/setup-ruby from 1.194.0 to 1.196.0 by @dependabot[bot] in #65
+- build(deps): bump ruby/setup-ruby from 1.196.0 to 1.199.0 by @dependabot[bot] in #72
+- build(deps-dev): bump webmock from 3.23.1 to 3.24.0 by @dependabot[bot] in #71
+- build(deps-dev): bump rexml from 3.3.6 to 3.3.9 by @dependabot[bot] in #69
+- build(deps): bump coverallsapp/github-action from 2.3.0 to 2.3.4 by @dependabot[bot] in #70
+- build(deps): bump ruby/setup-ruby from 1.199.0 to 1.202.0 by @dependabot[bot] in #73
+- build(deps): bump ruby/setup-ruby from 1.202.0 to 1.203.0 by @dependabot[bot] in #74
+- build(deps): bump ruby/setup-ruby from 1.203.0 to 1.204.0 by @dependabot[bot] in #75
+- build(deps): bump ruby/setup-ruby from 1.204.0 to 1.205.0 by @dependabot[bot] in #76
+- build(deps): bump ruby/setup-ruby from 1.205.0 to 1.206.0 by @dependabot[bot] in #77
+- build(deps): bump ruby/setup-ruby from 1.206.0 to 1.207.0 by @dependabot[bot] in #78
+- build(deps): bump ruby/setup-ruby from 1.207.0 to 1.213.0 by @dependabot[bot] in #79
+- build(deps): bump coverallsapp/github-action from 2.3.4 to 2.3.6 by @dependabot[bot] in #81
+- build(deps): bump ruby/setup-ruby from 1.213.0 to 1.214.0 by @dependabot[bot] in #80
+- build(deps): bump ruby/setup-ruby from 1.214.0 to 1.215.0 by @dependabot[bot] in #82
+- build(deps): bump ruby/setup-ruby from 1.215.0 to 1.218.0 by @dependabot[bot] in #83
+- build(deps): bump ruby/setup-ruby from 1.218.0 to 1.221.0 by @dependabot[bot] in #84
+- build(deps): bump ruby/setup-ruby from 1.221.0 to 1.222.0 by @dependabot[bot] in #85
+- build(deps): bump ruby/setup-ruby from 1.222.0 to 1.226.0 by @dependabot[bot] in #86
+- build(deps): bump ruby/setup-ruby from 1.226.0 to 1.227.0 by @dependabot[bot] in #87
+- build(deps): bump ruby/setup-ruby from 1.227.0 to 1.229.0 by @dependabot[bot] in #88
+- build(deps): bump ruby/setup-ruby from 1.229.0 to 1.237.0 by @dependabot[bot] in #92
+- build(deps): bump ruby/setup-ruby from 1.237.0 to 1.242.0 by @dependabot[bot] in #94
+- build(deps): bump ruby/setup-ruby from 1.242.0 to 1.245.0 by @dependabot[bot] in #96
+- build(deps): bump ruby/setup-ruby from 1.245.0 to 1.247.0 by @dependabot[bot] in #97
+- build(deps): bump actions/checkout from 4 to 5 by @dependabot[bot] in #99
+- build(deps): bump ruby/setup-ruby from 1.247.0 to 1.256.0 by @dependabot[bot] in #101
+- build(deps): bump ruby/setup-ruby from 1.256.0 to 1.257.0 by @dependabot[bot] in #102
+- build(deps-dev): update rake requirement from ~> 13.2.1 to ~> 13.3.0 by @dependabot[bot] in #107
+- build(deps-dev): bump webmock from 3.24.0 to 3.25.1 by @dependabot[bot] in #106
+- build(deps-dev): bump rspec from 3.13.0 to 3.13.1 by @dependabot[bot] in #105
+- build(deps-dev): update simplecov-lcov requirement from ~> 0.8.0 to ~> 0.9.0 by @dependabot[bot] in #104
+

data/Gemfile.lock

@@ -1,85 +1,93 @@
 PATH
   remote: .
   specs:
-    yandex360 (1.1.2)
-      faraday (~> 1.7)
+    yandex360 (1.1.4)
+      faraday (>= 1.7, < 3.0)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    addressable (2.8.1)
-      public_suffix (>= 2.0.2, < 6.0)
-    crack (0.4.5)
-      rexml
-    diff-lcs (1.5.0)
+    ast (2.4.3)
+    base64 (0.2.0)
+    diff-lcs (1.6.2)
     docile (1.4.0)
-    faraday (1.10.2)
-      faraday-em_http (~> 1.0)
-      faraday-em_synchrony (~> 1.0)
-      faraday-excon (~> 1.1)
-      faraday-httpclient (~> 1.0)
-      faraday-multipart (~> 1.0)
-      faraday-net_http (~> 1.0)
-      faraday-net_http_persistent (~> 1.0)
-      faraday-patron (~> 1.0)
-      faraday-rack (~> 1.0)
-      faraday-retry (~> 1.0)
+    faraday (2.8.1)
+      base64
+      faraday-net_http (>= 2.0, < 3.1)
       ruby2_keywords (>= 0.0.4)
-    faraday-em_http (1.0.0)
-    faraday-em_synchrony (1.0.0)
-    faraday-excon (1.1.0)
-    faraday-httpclient (1.0.1)
-    faraday-multipart (1.0.4)
-      multipart-post (~> 2)
-    faraday-net_http (1.0.1)
-    faraday-net_http_persistent (1.2.0)
-    faraday-patron (1.0.0)
-    faraday-rack (1.0.0)
-    faraday-retry (1.0.3)
-    hashdiff (1.0.1)
-    multipart-post (2.2.3)
-    public_suffix (5.0.0)
-    rake (12.3.3)
-    rexml (3.2.5)
-    rspec (3.11.0)
-      rspec-core (~> 3.11.0)
-      rspec-expectations (~> 3.11.0)
-      rspec-mocks (~> 3.11.0)
-    rspec-core (3.11.0)
-      rspec-support (~> 3.11.0)
-    rspec-expectations (3.11.1)
+    faraday-net_http (3.0.2)
+    fiddle (1.1.6)
+    json (2.14.1)
+    language_server-protocol (3.17.0.5)
+    lint_roller (1.1.0)
+    logger (1.6.4)
+    ostruct (0.6.1)
+    parallel (1.27.0)
+    parser (3.3.9.0)
+      ast (~> 2.4.1)
+      racc
+    prism (1.5.1)
+    racc (1.8.1)
+    rainbow (3.1.1)
+    rake (13.3.0)
+    regexp_parser (2.11.3)
+    rspec (3.13.1)
+      rspec-core (~> 3.13.0)
+      rspec-expectations (~> 3.13.0)
+      rspec-mocks (~> 3.13.0)
+    rspec-core (3.13.5)
+      rspec-support (~> 3.13.0)
+    rspec-expectations (3.13.5)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.11.0)
-    rspec-mocks (3.11.1)
+      rspec-support (~> 3.13.0)
+    rspec-mocks (3.13.5)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.11.0)
-    rspec-support (3.11.1)
+      rspec-support (~> 3.13.0)
+    rspec-support (3.13.6)
+    rubocop (1.80.2)
+      json (~> 2.3)
+      language_server-protocol (~> 3.17.0.2)
+      lint_roller (~> 1.1.0)
+      parallel (~> 1.10)
+      parser (>= 3.3.0.2)
+      rainbow (>= 2.2.2, < 4.0)
+      regexp_parser (>= 2.9.3, < 3.0)
+      rubocop-ast (>= 1.46.0, < 2.0)
+      ruby-progressbar (~> 1.7)
+      unicode-display_width (>= 2.4.0, < 4.0)
+    rubocop-ast (1.46.0)
+      parser (>= 3.3.7.2)
+      prism (~> 1.4)
+    ruby-progressbar (1.13.0)
     ruby2_keywords (0.0.5)
-    simplecov (0.21.2)
+    simplecov (0.22.0)
       docile (~> 1.1)
       simplecov-html (~> 0.11)
       simplecov_json_formatter (~> 0.1)
     simplecov-html (0.12.3)
-    simplecov-lcov (0.7.0)
+    simplecov-lcov (0.9.0)
     simplecov_json_formatter (0.1.4)
-    vcr (6.1.0)
-    webmock (3.18.1)
-      addressable (>= 2.8.0)
-      crack (>= 0.3.2)
-      hashdiff (>= 0.4.0, < 2.0.0)
+    unicode-display_width (3.2.0)
+      unicode-emoji (~> 4.1)
+    unicode-emoji (4.1.0)
 
 PLATFORMS
+  arm64-darwin-23
+  x64-mingw-ucrt
   x86_64-darwin-17
+  x86_64-linux
 
 DEPENDENCIES
   bundler
-  rake (~> 12.3.3)
+  fiddle (~> 1.0)
+  logger (~> 1.4)
+  ostruct (~> 0.5)
+  rake (~> 13.3.0)
   rspec (~> 3.0)
+  rubocop (~> 1.60)
   simplecov (~> 0.9)
-  simplecov-lcov (~> 0.7.0)
-  vcr (~> 6.1)
-  webmock (~> 3.18, >= 3.18.1)
+  simplecov-lcov (~> 0.9.0)
   yandex360!
 
 BUNDLED WITH
-   2.3.22
+   2.6.9

data/README.md

@@ -11,7 +11,7 @@
 ### Gemfile
 
 ```gemfile
-gem 'yandex360', '~> 1.1', '>= 1.1.1'
+gem 'yandex360', '~> 1.1', '>= 1.1.4'
 ```
 
 ### Install
@@ -25,14 +25,59 @@ gem install yandex360
 ```ruby
     require "yandex360"
 
-    yandex360 = Yandex360::Client.new(token: "paste your access_token here")
+    client = Yandex360::Client.new(token: "paste your access_token here")
 
-    users = yandex360.users.list(org_id: 1234567)
+    # List organizations
+    organizations = client.organizations.list
+
+    # List users in an organization
+    users = client.users.list(org_id: 1234567)
+
+    # Get organization domains
+    domains = client.domains.list(org_id: 1234567)
+
+    # Check 2FA status for a user
+    two_fa_status = client.two_fa.status(org_id: 1234567, user_id: 987654321)
 ```
 
 ## Available methods
 
 ```ruby
+# Organizations
+organizations.list()
+organizations.info(org_id:)
+
+# Domains
+domains.list(org_id:)
+domains.add(org_id:, name:, **params)
+domains.info(org_id:, domain:)
+domains.delete(org_id:, domain:)
+domains.verify(org_id:, domain:)
+
+# DNS
+dns.list(org_id:, domain:)
+dns.create(org_id:, domain:, **params)
+dns.update(org_id:, domain:, record_id:, **params)
+dns.delete(org_id:, domain:, record_id:)
+
+# Two-Factor Authentication
+two_fa.enable(org_id:, user_id:)
+two_fa.disable(org_id:, user_id:)
+two_fa.status(org_id:, user_id:)
+two_fa.domain_status(org_id:)
+two_fa.configure_domain(org_id:, enabled:)
+
+# Audit
+audit.list(org_id:, page: 1, per_page: 100, **params)
+audit.export(org_id:, **params)
+
+# Post Settings
+post_settings.list(org_id:, user_id:)
+post_settings.update(org_id:, user_id:, **params)
+post_settings.forwarding_list(org_id:, user_id:)
+post_settings.add_forwarding(org_id:, user_id:, address:)
+post_settings.delete_forwarding(org_id:, user_id:, address:)
+
 # Antispam
 antispam.list(org_id:)
 antispam.create(org_id, *strings)
@@ -47,6 +92,7 @@ users.list(org_id:, page: 1, per_page: 10)
 users.get2FA(org_id:, user_id:)
 users.has2FA?(org_id:, user_id:)
 users.delete_alias(org_id:, user_id:, user_alias:)
+users.delete(org_id:, user_id:)
 
 # Departments
 departments.add_alias(org_id:, dep_id:, name:)

data/Rakefile

@@ -1,15 +1,12 @@
 # frozen_string_literal: true
 
 require "bundler/gem_tasks"
-require "rake/testtask"
+require "rspec/core/rake_task"
 
-Rake::TestTask.new(:test) do |t|
-  t.libs << "test"
-  t.libs << "lib"
-  t.test_files = FileList["test/**/*_test.rb"]
-end
+RSpec::Core::RakeTask.new(:spec)
 
-task default: :test
+task default: :spec
+task test: :spec
 
 task :console do
   exec "irb -I lib -r yandex360.rb"

data/lib/yandex360/client.rb

@@ -6,11 +6,12 @@ module Yandex360
 
     attr_reader :token, :adapter
 
-    # new client
     def initialize(token:, adapter: Faraday.default_adapter, stubs: nil)
+      raise ArgumentError, "Token cannot be nil or empty" if token.nil? || token.to_s.strip.empty?
+
       @token = token
       @adapter = adapter
-      @stubs = stubs # Test stubs for requests
+      @stubs = stubs
     end
 
     def antispam
@@ -29,8 +30,42 @@ module Yandex360
       UsersResource.new(self)
     end
 
+    def organizations
+      OrganizationsResource.new(self)
+    end
+
+    def domains
+      DomainsResource.new(self)
+    end
+
+    def dns
+      DnsResource.new(self)
+    end
+
+    def two_fa
+      TwoFaResource.new(self)
+    end
+
+    def audit
+      AuditResource.new(self)
+    end
+
+    def post_settings
+      PostSettingsResource.new(self)
+    end
+
     def connection
-      @connection ||= Faraday.new(BASE_URL) do |conn|
+      @connection ||= build_connection
+    end
+
+    def inspect
+      "#<#{self.class.name}:#{object_id} token=***>"
+    end
+
+    private
+
+    def build_connection
+      Faraday.new(BASE_URL) do |conn|
         conn.request :authorization, :OAuth, token
         conn.request :json
         conn.request :url_encoded

data/lib/yandex360/collection.rb

@@ -2,14 +2,16 @@
 
 module Yandex360
   class Collection
+    include Enumerable
+
     attr_reader :data, :items, :total
 
     def self.from_response(response, key:, type:)
       body = response.body
       new(
-        data: body[key].map {|attrs| type.new(attrs) },
-        items: body["items"],
-        total: body["total"]
+        data: body[key]&.map {|attrs| type.new(attrs) } || [],
+        items: body["items"] || 0,
+        total: body["total"] || 0
       )
     end
 
@@ -18,5 +20,31 @@ module Yandex360
       @items  = items
       @total  = total
     end
+
+    def each(&block)
+      data.each(&block)
+    end
+
+    def size
+      data.size
+    end
+    alias length size
+    alias count size
+
+    def empty?
+      data.empty?
+    end
+
+    def first(idx=nil)
+      n ? data.first(idx) : data.first
+    end
+
+    def last(idx=nil)
+      n ? data.last(idx) : data.last
+    end
+
+    def [](index)
+      data[index]
+    end
   end
 end

data/lib/yandex360/error.rb

@@ -3,4 +3,22 @@
 module Yandex360
   class Error < StandardError
   end
+
+  class AuthenticationError < Error
+  end
+
+  class AuthorizationError < Error
+  end
+
+  class NotFoundError < Error
+  end
+
+  class ValidationError < Error
+  end
+
+  class RateLimitError < Error
+  end
+
+  class ServerError < Error
+  end
 end

data/lib/yandex360/object.rb

@@ -12,11 +12,13 @@ module Yandex360
     def to_ostruct(obj)
       case obj
       when Hash
-        # rubocop:disable Style/HashTransformValues
-        OpenStruct.new(obj.map {|key, val| [key, to_ostruct(val)] }.to_h)
-        # rubocop:enable Style/HashTransformValues
+        return OpenStruct.new if obj.empty?
+
+        OpenStruct.new(obj.transform_values {|val| to_ostruct(val) })
       when Array
         obj.map {|o| to_ostruct(o) }
+      when nil
+        nil
       else
         obj
       end

data/lib/yandex360/objects/types.rb

@@ -17,4 +17,11 @@ module Yandex360
   class GroupList < Object; end
 
   class Alias < Object; end
+  class UserAlias < Object; end
+
+  # New services
+  class Organization < Object; end
+  class Domain < Object; end
+  class DnsRecord < Object; end
+  class AuditEvent < Object; end
 end

data/lib/yandex360/param_builder.rb

@@ -0,0 +1,13 @@
+# frozen_string_literal: true
+
+module Yandex360
+  module ParamBuilder
+    private
+
+    def build_params(base_params, additional_params)
+      params = base_params.dup
+      additional_params.each {|param, value| params[param] = value }
+      params
+    end
+  end
+end

data/lib/yandex360/resource.rb

@@ -10,6 +10,36 @@ module Yandex360
 
     private
 
+    def validate_required_params(params, required_keys)
+      missing_keys = required_keys.reject {|key| valid_param?(params, key) }
+      raise ArgumentError, "Missing required parameters: #{missing_keys.join(', ')}" unless missing_keys.empty?
+    end
+
+    def valid_param?(params, key)
+      return false unless params.key?(key)
+
+      value = params[key]
+      return false if value.nil?
+
+      valid_string?(value) || valid_array?(value) || valid_other_type?(value)
+    end
+
+    def valid_string?(value)
+      value.is_a?(String) && !value.strip.empty?
+    end
+
+    def valid_array?(value)
+      value.is_a?(Array) && !value.empty?
+    end
+
+    def valid_other_type?(value)
+      !value.is_a?(String) && !value.is_a?(Array)
+    end
+
+    def build_url(path_segments)
+      "/#{path_segments.compact.join('/')}"
+    end
+
     def get(url, params: {}, headers: {})
       handle_response client.connection.get(url, params, headers)
     end
@@ -31,29 +61,42 @@ module Yandex360
     end
     alias delete_request delete
 
-    # rubocop:disable Metrics/CyclomaticComplexity
-    # rubocop:disable Metrics/AbcSize
     def handle_response(response)
-      case response.status
+      return response if successful_response?(response)
+
+      error_message = extract_error_message(response)
+      raise_appropriate_error(response.status, error_message)
+    end
+
+    def successful_response?(response)
+      response.status.between?(200, 299)
+    end
+
+    def raise_appropriate_error(status, error_message)
+      case status
       when 400
-        raise Error, "Your request was malformed. #{response.body['error']}"
+        raise ValidationError, "Your request was malformed. #{error_message}"
       when 401
-        raise Error, "You did not supply valid authentication credentials. #{response.body['error']}"
+        raise AuthenticationError, "You did not supply valid authentication credentials. #{error_message}"
       when 403
-        raise Error, "You are not allowed to perform that action. #{response.body['error']}"
+        raise AuthorizationError, "You are not allowed to perform that action. #{error_message}"
       when 404
-        raise Error, "No results were found for your request. #{response.body['error']}"
-      when 429
-        raise Error, "Your request exceeded the API rate limit. #{response.body['error']}"
-      when 500
-        raise Error, "We were unable to perform the request due to server-side problems. #{response.body['error']}"
-      when 503
-        raise Error, "You have been rate limited for sending more  requests per second. #{response.body['error']}"
+        raise NotFoundError, "No results were found for your request. #{error_message}"
+      when 429, 503
+        raise RateLimitError, "Your request exceeded the API rate limit. #{error_message}"
+      when 500..599
+        raise ServerError, "We were unable to perform the request due to server-side problems. #{error_message}"
+      else
+        raise Error, "Unexpected response status: #{status}. #{error_message}"
       end
+    end
+
+    def extract_error_message(response)
+      return "" unless response.body.is_a?(Hash)
 
-      response
+      response.body["error"] || response.body["message"] || ""
+    rescue StandardError
+      ""
     end
-    # rubocop:enable Metrics/AbcSize
-    # rubocop:enable Metrics/CyclomaticComplexity
   end
 end

data/lib/yandex360/resources/antispam.rb

@@ -3,16 +3,25 @@
 module Yandex360
   class AntispamResource < Resource
     def list(org_id:)
+      validate_required_params({org_id: org_id}, [:org_id])
       AllowList.new get("/admin/v1/org/#{org_id}/mail/antispam/allowlist/ips").body
     end
 
     def create(org_id, *strings)
-      body = {allowList: strings}
-      AllowList.new post("admin/v1/org/#{org_id}/mail/antispam/allowlist/ips", body: body).body
+      validate_required_params({org_id: org_id}, [:org_id])
+      raise ArgumentError, "At least one IP address must be provided" if strings.empty?
+
+      # Filter out empty strings
+      valid_strings = strings.compact.reject {|s| s.to_s.strip.empty? }
+      raise ArgumentError, "At least one valid IP address must be provided" if valid_strings.empty?
+
+      body = {allowList: valid_strings}
+      AllowList.new post("/admin/v1/org/#{org_id}/mail/antispam/allowlist/ips", body: body).body
     end
 
     def delete(org_id:)
-      delete_request("admin/v1/org/#{org_id}/mail/antispam/allowlist/ips")
+      validate_required_params({org_id: org_id}, [:org_id])
+      delete_request("/admin/v1/org/#{org_id}/mail/antispam/allowlist/ips")
     end
   end
 end