yaml-validator 0.1.1 → 0.1.2

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    yaml-validator (0.1.1)
+    yaml-validator (0.1.2)
       colorize
       rake
       rspec

data/lib/helpers.rb

@@ -20,5 +20,13 @@ module Helpers
     array.each_with_index { |val, i| hash[i.to_s] = val }
     hash
   end
+
+  def self.pluralization?(object)
+    return false if object.nil?
+
+    keys = object.keys.map { |k| k.to_sym }
+
+    (keys.include? :one) and (keys.include? :other)
+  end
   
 end

data/lib/pluralization-validator.rb

@@ -0,0 +1,65 @@
+
+KEYS_BY_LANGUAGE = {
+  :be=>[:one, :few, :many, :other],
+  :bs=>[:one, :few, :many, :other],
+  :by=>[:one, :few, :many, :other],
+  :cs=>[:one, :few, :other],
+  :hr=>[:one, :few, :many, :other],
+  :iu=>[:one, :two, :other],
+  :kw=>[:one, :two, :other],
+  :mo=>[:one, :few, :other],
+  :naq=>[:one, :two, :other],
+  :ro=>[:one, :few, :other],
+  :ru=>[:one, :few, :many, :other],
+  :se=>[:one, :two, :other],
+  :sh=>[:one, :few, :many, :other],
+  :sk=>[:one, :few, :other],
+  :sma=>[:one, :two, :other],
+  :smi=>[:one, :two, :other],
+  :smj=>[:one, :two, :other],
+  :smn=>[:one, :two, :other],
+  :sms=>[:one, :two, :other],
+  :sr=>[:one, :few, :many, :other],
+  :uk=>[:one, :few, :many, :other]
+}
+
+class PluralizationValidator
+  def self.validate(language, yaml_object)
+    validate_object(language, '', yaml_object)
+  end
+
+  def self.validate_object(language, full_key, yaml_object)
+    return [] if yaml_object.nil?
+
+    if Helpers.pluralization? yaml_object
+      self.validate_pluralization(language, full_key, yaml_object)
+    else
+      errors = []
+      yaml_object.each do |key, value|
+        if value.is_a? Hash
+          full_subkey = (full_key.empty?) ? key : "#{full_key}.#{key}"
+          errors.concat validate_object(language, full_subkey, value)
+        end
+      end
+      errors
+    end
+  end
+
+  def self.validate_pluralization(language, full_key, yaml_object)
+    language = language.to_sym
+    if KEYS_BY_LANGUAGE.has_key? language
+      errors = []
+      KEYS_BY_LANGUAGE[language].each do |key|
+        unless (yaml_object.has_key? key) or
+          (yaml_object.has_key? key.to_s)
+
+          errors << "missing '#{key.to_s}' pluralization for '#{full_key}'"
+        end
+      end
+      errors
+    else
+      []
+    end
+
+  end
+end

data/lib/yaml-validator/version.rb

@@ -1,3 +1,3 @@
 class YamlValidator
-  VERSION = "0.1.1"
+  VERSION = "0.1.2"
 end

data/lib/yaml-validator.rb

@@ -1,6 +1,7 @@
 require 'yaml'
 require 'yaml-validator/version'
 require_relative './helpers'
+require_relative './pluralization-validator'
 
 class YamlValidator
   
@@ -54,6 +55,7 @@ class YamlValidator
     errors += validate_yaml_object('', yaml_object)
     if @options[:show_missing]
       errors.concat find_missing_translations(yaml_object)
+      errors.concat find_missing_pluralizations(filename, yaml_object)
     end
     
     errors.map { |err| "#{filename}: #{err}" }
@@ -73,11 +75,12 @@ class YamlValidator
   def validate_yaml_object(full_key, yaml_object)
     return [] if yaml_object.nil?
     errors = []
+    is_pluralization = Helpers.pluralization? yaml_object
     
     yaml_object.each do |key, value|
       full_subkey = (full_key.empty?) ? key : "#{full_key}.#{key}"
       if value.is_a? String
-        errors.concat validate_item(full_subkey, value)
+        errors.concat validate_item(full_subkey, value, is_pluralization)
       else
         errors.concat validate_yaml_object(full_subkey, value)
       end
@@ -105,6 +108,11 @@ class YamlValidator
     end
     errors
   end
+
+  def find_missing_pluralizations(filename, yaml_object)
+    language = File.basename(filename, '.*')
+    PluralizationValidator.validate(language, yaml_object)
+  end
   
   def self.find_key_in_yaml_object(full_key, yaml_object)
     position = yaml_object
@@ -120,10 +128,14 @@ class YamlValidator
     end
   end
   
-  def validate_item(full_key, value)
+  def validate_item(full_key, value, is_pluralization = false)
     real_vars = get_key_en_vars(full_key)
     if real_vars.nil?
-      return ["#{full_key} doesn't exist in en.yml"]
+      if is_pluralization
+        return []
+      else
+        return ["#{full_key} doesn't exist in en.yml"]
+      end
     end
 
     used_vars = identify_variables(value)

data/scripts/get-rails-i18n-rules.rb

@@ -0,0 +1,38 @@
+#!/usr/bin/env ruby
+
+require 'pp'
+
+RAILS_I18N_PATH = File.expand_path("~/playground/rails-i18n")
+
+
+NORMAL_RULES = ['one_other', 'other', 'one_upto_two_other', 'one_with_zero_other']
+
+KEYS_BY_RULE = {
+  'west_slavic' => [:one, :few, :other],
+  'east_slavic' => [:one, :few, :many, :other],
+  'romanian' => [:one, :few, :other],
+  'one_two_other' => [:one, :two, :other]
+}
+
+PLURALS_PATH = File.join(RAILS_I18N_PATH, "rails/pluralization")
+
+def find_rule(pluralization_file)
+  rule = `grep require #{pluralization_file}`
+  if rule.length > 0
+    /^.*pluralizations\/(.*)'$/.match(rule)[1]
+  else
+    nil
+  end
+end
+
+all = {}
+Dir["#{PLURALS_PATH}/*.rb"].each do |file|
+  lang = File.basename(file, '.*')
+  rule = find_rule(file)
+  unless rule.nil? or NORMAL_RULES.include? rule
+    keys = KEYS_BY_RULE[rule]
+    all[lang.to_sym] = keys
+  end
+end
+
+pp all

data/spec/fixtures/weird_pluralizations/en.yml

@@ -0,0 +1,7 @@
+en:
+  dogs:
+    one: '1 dog'
+    other: '%{count} dogs'
+  cats:
+    one: '1 cat'
+    other: '%{count} cats'

data/spec/fixtures/weird_pluralizations/ru.yml

@@ -0,0 +1,9 @@
+ru:
+  dogs:
+    one: '1 dog'
+    other: '%{count} dogs'
+  cats:
+    one: '1 cat'
+    few: '%{count} cats'
+    many: '%{count} cats'
+    other: '%{count} cats'

data/spec/helpers_spec.rb

@@ -50,4 +50,16 @@ describe Helpers do
     end
   end
 
+  describe "#pluralization?" do
+    it "returns true when object has :one and :other" do
+      Helpers.pluralization?(:one => 'one', :other => 'other').should be_true
+    end
+    it "returns true when object has 'one' and 'other'" do
+      Helpers.pluralization?('one' => 'one', 'other' => 'other').should be_true
+    end
+    it "returns false for {}" do
+      Helpers.pluralization?({}).should be_false
+    end
+  end
+
 end

data/spec/yaml-validator_spec.rb

@@ -65,6 +65,17 @@ describe YamlValidator do
       end
     end
 
+    describe "weird pluralizations" do
+      it "returns missing pluralizations error" do
+        validator = YamlValidator.new('spec/fixtures/weird_pluralizations')
+        errors = validator.validate()
+        errors.should == [
+          "ru.yml: missing 'few' pluralization for 'dogs'",
+          "ru.yml: missing 'many' pluralization for 'dogs'",
+        ]
+      end
+    end
+
   end
   
   describe "#validate_yaml" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: yaml-validator
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-02-24 00:00:00.000000000 Z
+date: 2013-03-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -75,15 +75,19 @@ files:
 - Rakefile
 - bin/yaml-validator
 - lib/helpers.rb
+- lib/pluralization-validator.rb
 - lib/yaml-validator.rb
 - lib/yaml-validator/version.rb
 - pkg/yaml-validator-0.0.1.gem
+- scripts/get-rails-i18n-rules.rb
 - spec/fixtures/inconsistent_types/en.yml
 - spec/fixtures/inconsistent_types/he.yml
 - spec/fixtures/invalid_yml/en.yml
 - spec/fixtures/invalid_yml/invalid.yml
 - spec/fixtures/missing_translations/en.yml
 - spec/fixtures/missing_translations/he.yml
+- spec/fixtures/weird_pluralizations/en.yml
+- spec/fixtures/weird_pluralizations/ru.yml
 - spec/fixtures/wrong_root/en.yml
 - spec/fixtures/wrong_root/he.yml
 - spec/fixtures/wrong_variables/en.yml
@@ -105,7 +109,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 417878389105800096
+      hash: -1836755832709183753
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -114,7 +118,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 417878389105800096
+      hash: -1836755832709183753
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.24
@@ -128,6 +132,8 @@ test_files:
 - spec/fixtures/invalid_yml/invalid.yml
 - spec/fixtures/missing_translations/en.yml
 - spec/fixtures/missing_translations/he.yml
+- spec/fixtures/weird_pluralizations/en.yml
+- spec/fixtures/weird_pluralizations/ru.yml
 - spec/fixtures/wrong_root/en.yml
 - spec/fixtures/wrong_root/he.yml
 - spec/fixtures/wrong_variables/en.yml