yamine 0.8.0 → 0.8.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 04f00c2029bf4cda65d187225d251fc594bacf538092e6a56d9c5a03f9aa47fd
-  data.tar.gz: 963f1c74d64ddb94199d42325f6d8631a5dd2d618119554a4e1a72849394c5bc
+  metadata.gz: 52c2213e83a301befe5e048b7a83eec6e6c945f23475334928a298f81d9e8369
+  data.tar.gz: 39e2c51e536b6fa3d50a956bce2b20187899bf52a2c86a3b82ab110877a485fc
 SHA512:
-  metadata.gz: 2e02efba8d7c16767b0c4b8908d295f4c095f7c32f5ef90885e1ecf0a50aa68d61cb9e0c780d3729f703fcc14fc282eed46430d4efce631762dbb832ddecf408
-  data.tar.gz: 6d36c287b907fcfba07da2db3ecf1904ff4b396fb2bf8df277e0f9dfb23515e9245d574fb0bed85a034cd9f41fae14834842c722c3ac298e9f0fafedb1d30b45
+  metadata.gz: 543d3ba0a552e5cc2deef0784322d225c99a45ea19e35af090f6d5691d5cfc5b9637e8831755db5509e024a352fa33de70843aef2734353acf9bacfc867e805a
+  data.tar.gz: 57213387e578ba71b6d4140dd139d10fe2e7bf5168fe74ad85a3ba2b87089b69959284fc7f531f38034838dc67cb70b86b92f13b926aa638c1291a36bdbb1376

data/CHANGELOG.md

@@ -1,5 +1,36 @@
 # Changelog
 
+## [0.8.2] — 2026-09-10
+
+### Fixed
+
+- **The rest of the `--json` stdout leaks.** Two writers still reached
+  stdout during a machine-readable run, corrupting the stream a parser
+  reads: the `-> <url>` line from the sequential boot path, and
+  "Starting proxy..." — which is printed before the reporter is even
+  installed, so it would have been the FIRST line of a `--json` run.
+  Both now route through the same stderr-when-json rule as the rest of
+  the narration, and the contract is pinned by tests rather than assumed
+  (two separate leaks have now been caught here).
+
+
+## [0.8.1] — 2026-09-10
+
+### Fixed
+
+- **An already-correct `/etc/hosts` no longer reports a failure.**
+  `Hosts.sync` rewrote the file unconditionally, so on a normal machine
+  (where `/etc/hosts` is root-owned) it raised `Errno::EACCES`, returned
+  false, and made `yamine start` print "could not write /etc/hosts (try
+  sudo yamine hosts sync)" on every boot — pointing at an elevated write
+  for a file that already had exactly the right block. `synced?` existed
+  for precisely this guard but `sync` never consulted it. `sync` is now a
+  no-op returning true when the block already matches, and the setup step
+  reports "already lists N hostname(s)" instead of implying a failure.
+  Chrome/Firefox/Edge resolve `*.localhost` natively anyway; the file only
+  matters for Safari and custom TLDs.
+
+
 ## [0.8.0] — 2026-09-10
 
 ### Fixed

data/lib/yamine/cli/boot.rb

@@ -21,7 +21,7 @@ module Yamine
         # Ownership gate before any side effects: no proxy spawn, no
         # port allocation when we'd refuse anyway.
         check_worktree_ownership!(ctx, resolved, force: opts[:force])
-        ensure_proxy!(ctx)
+        ensure_proxy!(ctx, json: opts[:json])
         boot_all(ctx, resolved, opts)
       end
 
@@ -180,7 +180,7 @@ module Yamine
             rails_dev_host: item[:hostname], database_url: db_url)
           routes_registered << { hostnames: item[:hostnames], app: app }
 
-          puts "  -> #{item[:url]}"
+          say opts, "  -> #{item[:url]}"
         end
         children
       end
@@ -548,7 +548,11 @@ module Yamine
         Yamine::Resolver.resolve(Dir.pwd, variant: variant, tld: tld)
       end
 
-      def ensure_proxy!(ctx)
+      # json: keeps stdout free for the machine-readable stream — this runs
+      # BEFORE boot_all installs the reporter, so its progress line is the
+      # one piece of narration that could still land mid-JSON and break a
+      # parser on the first line of a --json run.
+      def ensure_proxy!(ctx, json: false)
         port = ctx.proxy_port
         tls = ctx.proxy_tls
         if ProxyControl.listening?(port)
@@ -570,7 +574,8 @@ module Yamine
           $stderr.puts "  Or start the proxy by hand: sudo yamine proxy start"
           exit 1
         end
-        puts "Starting proxy#{privileged ? " (sudo)" : ""}..."
+        starting = "Starting proxy#{privileged ? " (sudo)" : ""}..."
+        json ? $stderr.puts(starting) : puts(starting)
         begin
           Yamine::ProxyControl.spawn_daemon(store: ctx.store, port: port, tls: tls, sudo: privileged)
         rescue Yamine::ProxyNotRunningError => e

data/lib/yamine/cli/system.rb

@@ -220,6 +220,8 @@ module Yamine
         hostnames = ctx.store.load_routes.map { |r| r["hostname"] }
         if hostnames.empty?
           puts "    No routes registered yet — hosts sync will happen on the next boot."
+        elsif Yamine::Hosts.synced?(hostnames)
+          puts "    /etc/hosts already lists #{hostnames.length} hostname(s)."
         elsif Yamine::Hosts.sync(hostnames)
           puts "    Synced #{hostnames.length} hostname(s) to /etc/hosts."
         else
@@ -758,8 +760,12 @@ module Yamine
           end
         end
 
-        # 3. Hosts (best-effort: only needed for Safari; warn, don't fail)
-        unless Hosts.sync(ctx.store.load_routes.map { |r| r["hostname"] })
+        # 3. Hosts (best-effort: only needed for Safari and custom TLDs —
+        # Chrome/Firefox/Edge resolve *.localhost natively). Already-synced
+        # is the common case and must stay silent: warning there sent
+        # people to a sudo write for a file that needed nothing.
+        hostnames = ctx.store.load_routes.map { |r| r["hostname"] }
+        unless hostnames.empty? || Yamine::Hosts.synced?(hostnames) || Hosts.sync(hostnames)
           warn "Warning: could not write /etc/hosts (try sudo yamine hosts sync)."
         end
       end

data/lib/yamine/hosts.rb

@@ -41,7 +41,20 @@ module Yamine
       names
     end
 
+    # Bring the managed block to exactly these hostnames. Idempotent: when
+    # the block already matches, this is a no-op returning true.
+    #
+    # The short-circuit is load-bearing, not an optimization. /etc/hosts is
+    # root-owned on a normal machine, so a rewrite fails without sudo — and
+    # `setup` and every boot's workstation check run this. Without the
+    # guard, a machine whose hosts file was already correct got a
+    # "could not write /etc/hosts (try sudo yamine hosts sync)" warning on
+    # every run, sending people to an elevated write for a file that
+    # needed nothing. (Chrome/Firefox/Edge resolve *.localhost natively;
+    # /etc/hosts only matters for Safari and custom TLDs.)
     def sync(hostnames, path = PATH)
+      return true if synced?(hostnames, path)
+
       content = read(path)
       block = managed_block(hostnames)
       if content.include?(BEGIN_MARKER)

data/lib/yamine/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Yamine
-  VERSION = "0.8.0"
+  VERSION = "0.8.2"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: yamine
 version: !ruby/object:Gem::Version
-  version: 0.8.0
+  version: 0.8.2
 platform: ruby
 authors:
 - Kaka Ruto