yahoo_quote 0.0.4 → 0.0.5

data/README.markdown

@@ -32,7 +32,7 @@ puts quote.field_mappings.keys
 
 ## Configuration
 
-Use /tmp to keep a simple cache:
+Specify a directory to keep a simple file-based cache:
 
 ```ruby
 YahooQuote::Configuration.cache_dir = "/tmp"

data/lib/yahoo_quote/configuration.rb

@@ -2,12 +2,12 @@ module YahooQuote
   class Configuration
 
     def self.cache_dir=(path)
-      if !path
-        @@cache_dir = path
+      if !path || path.to_s.empty?
+        @@cache_dir = nil
       else
-        dir = path.to_s
-        Dir.mkdir(dir) unless dir.empty? || File.directory?(dir)
-        @@cache_dir = dir
+        path = Pathname.new(path) if path.is_a? String
+        path.mkdir unless path.directory?
+        @@cache_dir = path
       end
     end
 

data/lib/yahoo_quote/version.rb

@@ -1,3 +1,3 @@
 module YahooQuote
-  VERSION = "0.0.4"
+  VERSION = "0.0.5"
 end

data/lib/yahoo_quote.rb

@@ -46,8 +46,10 @@ module YahooQuote
     end
 
     def clear_cache
-      Dir.glob(File.join(YahooQuote::Configuration.cache_dir, '*.csv')).each {|f|
-        File.unlink f }
+      if cache_response?
+        Pathname.glob(YahooQuote::Configuration.cache_dir.join('*.csv')).each {|f|
+          f.unlink}
+      end
     end
 
     def quote_url

data/test/yahoo_quote_test.rb

@@ -1,5 +1,6 @@
 require 'yahoo_quote'
 require 'minitest/autorun'
+require 'pathname'
 require 'fakeweb'
 
 # TODO test 2 things: make intermediate dirs for cache and permissions
@@ -10,7 +11,13 @@ class TestYahooQuote < MiniTest::Unit::TestCase
     FakeWeb.allow_net_connect = false
     FakeWeb.register_uri(:get, @url_regexp, :response => File.read("test/fakeweb/aapl_good.csv"))
 
-    @cache_dir = File.join('test', 'cache')
+    @cache_dir = Pathname.new('test/cache')
+  end
+
+  def remove_dir(dir_path)
+    return unless dir_path.exist?
+    dir_path.each_child {|p| p.unlink}
+    dir_path.unlink
   end
 
   def test_empty_arguments
@@ -66,14 +73,39 @@ class TestYahooQuote < MiniTest::Unit::TestCase
     assert !cached_quote.cache_response?
   end
 
+  def test_create_cache_dir
+    remove_dir @cache_dir
+    assert !@cache_dir.exist?
+    YahooQuote::Configuration.cache_dir = @cache_dir
+    assert @cache_dir.exist?
+    YahooQuote::Configuration.cache_dir = nil
+  end
+
+  def test_clear_cache_when_no_cache
+    quote = YahooQuote::Quote.new('AAPL', ['Name'])
+    quote.clear_cache
+  end
+
+  def test_clear_cache_when_empty_string
+    YahooQuote::Configuration.cache_dir = ''
+    quote = YahooQuote::Quote.new('AAPL', ['Name'])
+    quote.clear_cache
+  end
+
   def test_clear_cache
     YahooQuote::Configuration.cache_dir = @cache_dir
     quote = YahooQuote::Quote.new('AAPL', ['Name'])
     assert Dir.glob(File.join(@cache_dir, '*.csv')).size > 0, 'No files stored in cache'
     quote.clear_cache
     assert_equal 0, Dir.glob(File.join(@cache_dir, '*.csv')).size
-    # We don't want to cache responses for other tests
     YahooQuote::Configuration.cache_dir = nil
-    assert !quote.cache_response?
+  end
+
+  def test_save_cache_dir_as_pathname
+    dir_string = @cache_dir.to_s
+    assert dir_string.is_a?(String)
+    YahooQuote::Configuration.cache_dir = dir_string
+    assert YahooQuote::Configuration.cache_dir.is_a?(Pathname)
+    YahooQuote::Configuration.cache_dir = nil
   end
 end

data/yahoo_quote.gemspec

@@ -12,6 +12,7 @@ Gem::Specification.new do |s|
   s.description = %q{Easy interaction with Yahoo Finance API}
 
   s.add_development_dependency "fakeweb"
+  s.add_development_dependency "ruby-debug19"
 
   s.rubyforge_project = "yahoo_quote"
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: yahoo_quote
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.5
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-02-21 00:00:00.000000000Z
+date: 2012-02-22 00:00:00.000000000Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: fakeweb
-  requirement: &2153217660 !ruby/object:Gem::Requirement
+  requirement: &2157617700 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,7 +21,18 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2153217660
+  version_requirements: *2157617700
+- !ruby/object:Gem::Dependency
+  name: ruby-debug19
+  requirement: &2157617280 !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: *2157617280
 description: Easy interaction with Yahoo Finance API
 email:
 - bcarreno@yahoo.com